diff mbox series

[25/32] net/dpaa2: replace memcpy with structure assignment

Message ID	20250208203142.242284-26-stephen@networkplumber.org (mailing list archive)
State	New
Delegated to:	Thomas Monjalon
Headers	From: Stephen Hemminger <stephen@networkplumber.org> To: dev@dpdk.org Cc: Stephen Hemminger <stephen@networkplumber.org>, Hemant Agrawal <hemant.agrawal@nxp.com>, Sachin Saxena <sachin.saxena@nxp.com> Subject: [PATCH 25/32] net/dpaa2: replace memcpy with structure assignment Date: Sat, 8 Feb 2025 12:22:17 -0800 Message-ID: <20250208203142.242284-26-stephen@networkplumber.org> In-Reply-To: <20250208203142.242284-1-stephen@networkplumber.org> References: <20250208203142.242284-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: dev-bounces@dpdk.org
Series	Use structure assignment instead of memcpy \| [00/32] Use structure assignment instead of memcpy [01/32] devtools/cocci: prefer structure assignment over memcpy [02/32] app/testpmd: replace memcpy with assignment [03/32] app/graph: replace memcpy with structure assignment [04/32] crypto/dpaa_sec: replace memcpy with assignment [05/32] dma/dpaa2: replace memcpy with assignment [06/32] eventdev: replace memcpy with assignment [07/32] event/dpaa2: replace memcpy with structure assignment [08/32] event/dsw: replace memcpy with assignment [09/32] ml/cnxk: replace memcpy with assignment [10/32] examples: replace memcpy with assignment [11/32] node: replace memcpy with assignment [12/32] pipeline: replace memcpy with assignment [13/32] sched: replace memcpy with structure assignment [14/32] table: replace memcpy with structure assignment [15/32] net/ntnic: replace memcpy with structure assignment [16/32] net/bnxt: replace memcpy with structure assignment [17/32] crypto/qat: replace memcpy with structure assignment [18/32] mempool/cnxk: replace memcpy with structure assignment [19/32] net/dpaa2: replace memcpy with assignment [20/32] net/enic: replace memcpy with assignment [21/32] net/intel/i40e: replace memcpy with structure assignment [22/32] net/nfp: replace memcpy with assignment [23/32] net/txgbe: replace memcpy with assignment [24/32] net/bnx2x: replace memcpy with structure assignment [25/32] net/dpaa2: replace memcpy with structure assignment [26/32] net/bonding: replace memcpy with structure assignment [27/32] net/cnxk: replace memcpy with structure assignment [28/32] net/enic: replace memcpy with structure assignment [29/32] net/iavf: replace memcpy with structure assignment [30/32] net/ice: replace memcpy with structure assignment [31/32] test: replace memcpy with structure assignment [32/32] test/cryptodev: replace memcpy with structure assignment

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Stephen Hemminger Feb. 8, 2025, 8:22 p.m. UTC

Prefer structure assignment over memcpy.
Found by struct-assign.cocci.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/dpaa2/dpaa2_ethdev.c | 5 ++---
 drivers/net/dpaa2/dpaa2_flow.c   | 9 +++------
 2 files changed, 5 insertions(+), 9 deletions(-)

Comments

Hemant Agrawal Feb. 10, 2025, 10:40 a.m. UTC | #1

Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

On 09-02-2025 01:52, Stephen Hemminger wrote:
> Prefer structure assignment over memcpy.
> Found by struct-assign.cocci.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>   drivers/net/dpaa2/dpaa2_ethdev.c | 5 ++---
>   drivers/net/dpaa2/dpaa2_flow.c   | 9 +++------
>   2 files changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c
> index a9bce854c3..452d58ae28 100644
> --- a/drivers/net/dpaa2/dpaa2_ethdev.c
> +++ b/drivers/net/dpaa2/dpaa2_ethdev.c
> @@ -2539,8 +2539,7 @@ populate_mac_addr(struct fsl_mc_io *dpni_dev,
>   					      ret);
>   				goto cleanup;
>   			}
> -			memcpy(&prime_mac, &phy_mac,
> -				sizeof(struct rte_ether_addr));
> +			prime_mac = phy_mac;
>   		}
>   	} else if (rte_is_zero_ether_addr(&prime_mac)) {
>   		/* In case phys and prime, both are zero, create random MAC */
> @@ -2555,7 +2554,7 @@ populate_mac_addr(struct fsl_mc_io *dpni_dev,
>   	}
>   
>   	/* prime_mac the final MAC address */
> -	memcpy(mac_entry, &prime_mac, sizeof(struct rte_ether_addr));
> +	*mac_entry = prime_mac;
>   	return 0;
>   
>   cleanup:
> diff --git a/drivers/net/dpaa2/dpaa2_flow.c b/drivers/net/dpaa2/dpaa2_flow.c
> index c94eb51ba5..299c50dcdf 100644
> --- a/drivers/net/dpaa2/dpaa2_flow.c
> +++ b/drivers/net/dpaa2/dpaa2_flow.c
> @@ -1008,8 +1008,7 @@ dpaa2_flow_faf_add_hdr(int faf_byte,
>   	if (pos != dpkg->num_extracts) {
>   		/* Not the last pos, must have IP address extract.*/
>   		for (i = dpkg->num_extracts - 1; i >= pos; i--) {
> -			memcpy(&extracts[i + 1],
> -				&extracts[i], sizeof(struct dpkg_extract));
> +			extracts[i + 1] = extracts[i];
>   		}
>   	}
>   
> @@ -1063,8 +1062,7 @@ dpaa2_flow_pr_add_hdr(uint32_t pr_offset,
>   	if (pos != dpkg->num_extracts) {
>   		/* Not the last pos, must have IP address extract.*/
>   		for (i = dpkg->num_extracts - 1; i >= pos; i--) {
> -			memcpy(&extracts[i + 1],
> -				&extracts[i], sizeof(struct dpkg_extract));
> +			extracts[i + 1] = extracts[i];
>   		}
>   	}
>   
> @@ -1118,8 +1116,7 @@ dpaa2_flow_extract_add_hdr(enum net_prot prot,
>   	if (pos != dpkg->num_extracts) {
>   		/* Not the last pos, must have IP address extract.*/
>   		for (i = dpkg->num_extracts - 1; i >= pos; i--) {
> -			memcpy(&extracts[i + 1],
> -				&extracts[i], sizeof(struct dpkg_extract));
> +			extracts[i + 1] = extracts[i];
>   		}
>   	}
>

diff mbox series

Patch

diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c
index a9bce854c3..452d58ae28 100644
--- a/drivers/net/dpaa2/dpaa2_ethdev.c
+++ b/drivers/net/dpaa2/dpaa2_ethdev.c
@@ -2539,8 +2539,7 @@  populate_mac_addr(struct fsl_mc_io *dpni_dev,
 					      ret);
 				goto cleanup;
 			}
-			memcpy(&prime_mac, &phy_mac,
-				sizeof(struct rte_ether_addr));
+			prime_mac = phy_mac;
 		}
 	} else if (rte_is_zero_ether_addr(&prime_mac)) {
 		/* In case phys and prime, both are zero, create random MAC */
@@ -2555,7 +2554,7 @@  populate_mac_addr(struct fsl_mc_io *dpni_dev,
 	}
 
 	/* prime_mac the final MAC address */
-	memcpy(mac_entry, &prime_mac, sizeof(struct rte_ether_addr));
+	*mac_entry = prime_mac;
 	return 0;
 
 cleanup:
diff --git a/drivers/net/dpaa2/dpaa2_flow.c b/drivers/net/dpaa2/dpaa2_flow.c
index c94eb51ba5..299c50dcdf 100644
--- a/drivers/net/dpaa2/dpaa2_flow.c
+++ b/drivers/net/dpaa2/dpaa2_flow.c
@@ -1008,8 +1008,7 @@  dpaa2_flow_faf_add_hdr(int faf_byte,
 	if (pos != dpkg->num_extracts) {
 		/* Not the last pos, must have IP address extract.*/
 		for (i = dpkg->num_extracts - 1; i >= pos; i--) {
-			memcpy(&extracts[i + 1],
-				&extracts[i], sizeof(struct dpkg_extract));
+			extracts[i + 1] = extracts[i];
 		}
 	}
 
@@ -1063,8 +1062,7 @@  dpaa2_flow_pr_add_hdr(uint32_t pr_offset,
 	if (pos != dpkg->num_extracts) {
 		/* Not the last pos, must have IP address extract.*/
 		for (i = dpkg->num_extracts - 1; i >= pos; i--) {
-			memcpy(&extracts[i + 1],
-				&extracts[i], sizeof(struct dpkg_extract));
+			extracts[i + 1] = extracts[i];
 		}
 	}
 
@@ -1118,8 +1116,7 @@  dpaa2_flow_extract_add_hdr(enum net_prot prot,
 	if (pos != dpkg->num_extracts) {
 		/* Not the last pos, must have IP address extract.*/
 		for (i = dpkg->num_extracts - 1; i >= pos; i--) {
-			memcpy(&extracts[i + 1],
-				&extracts[i], sizeof(struct dpkg_extract));
+			extracts[i + 1] = extracts[i];
 		}
 	}