ci: build with MSVC in GHA

Add a build target in Windows 2022 for MSVC.

Loading MSVC environment and having successive commands in a single
(cmd or pwsh) shell does not seem to correctly report if one of the
commands failed.
For now, load MSVC environment and run commands in separate shells.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 .github/workflows/build.yml | 38 +++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)
  

David Marchand <david.marchand@redhat.com> writes:

> Add a build target in Windows 2022 for MSVC.
>
> Loading MSVC environment and having successive commands in a single
> (cmd or pwsh) shell does not seem to correctly report if one of the
> commands failed.
> For now, load MSVC environment and run commands in separate shells.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---

LGTM.

Acked-by: Aaron Conole <aconole@redhat.com>

How far back will this work (ie: can we backport this to older branches?)

>  .github/workflows/build.yml | 38 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
>
> diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
> index dcafb4a8f5..aef692ca1f 100644
> --- a/.github/workflows/build.yml
> +++ b/.github/workflows/build.yml
> @@ -174,6 +174,44 @@ jobs:
>            build/meson-logs/meson-log.txt
>            build/meson-logs/testlog.txt
>  
> +  windows-vm-builds:
> +    name: ${{ join(matrix.config.*, '-') }}
> +    runs-on: ${{ matrix.config.os }}
> +    strategy:
> +      fail-fast: false
> +      matrix:
> +        config:
> +          - os: windows-2022
> +            compiler: msvc
> +
> +    steps:
> +    - name: Checkout sources
> +      uses: actions/checkout@v4
> +    - name: Set up Python
> +      uses: actions/setup-python@v5
> +      with:
> +        python-version: '3.x'
> +    - name: Install dependencies
> +      run: python -m pip install meson==1.6.1 ninja
> +    - name: Configure
> +      shell: cmd
> +      run: |
> +        call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\VsDevCmd.bat" -host_arch=amd64 -arch=amd64
> +        meson setup -Denable_stdatomic=true build
> +    - name: Build
> +      shell: cmd
> +      run: |
> +        call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\VsDevCmd.bat" -host_arch=amd64 -arch=amd64
> +        meson compile -C build
> +    - name: Upload logs on failure
> +      if: failure()
> +      uses: actions/upload-artifact@v4
> +      with:
> +        name: meson-logs-${{ join(matrix.config.*, '-') }}
> +        path: |
> +          build/.ninja_log
> +          build/meson-logs/meson-log.txt
> +
>    prepare-container-images:
>      name: ${{ join(matrix.config.*, '-') }}
>      runs-on: ubuntu-latest
  

On Tue, Feb 18, 2025 at 2:32 PM Aaron Conole <aconole@redhat.com> wrote:
>
> David Marchand <david.marchand@redhat.com> writes:
>
> > Add a build target in Windows 2022 for MSVC.
> >
> > Loading MSVC environment and having successive commands in a single
> > (cmd or pwsh) shell does not seem to correctly report if one of the
> > commands failed.
> > For now, load MSVC environment and run commands in separate shells.
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
>
> LGTM.
>
> Acked-by: Aaron Conole <aconole@redhat.com>
>
> How far back will this work (ie: can we backport this to older branches?)

MSVC was added in 23.11.
The patch applies cleanly and runs on 23.11 (where only lib/kvargs,
lib/log and lib/telemetry are compiled) and 24.11.

I can add Cc: stable if you think it is worth having it in LTS (UNH
provides some coverage in LTS releases).
  

On Tue, Feb 18, 2025 at 03:10:13PM +0100, David Marchand wrote:
> On Tue, Feb 18, 2025 at 2:32 PM Aaron Conole <aconole@redhat.com> wrote:
> >
> > David Marchand <david.marchand@redhat.com> writes:
> >
> > > Add a build target in Windows 2022 for MSVC.
> > >
> > > Loading MSVC environment and having successive commands in a single
> > > (cmd or pwsh) shell does not seem to correctly report if one of the
> > > commands failed.
> > > For now, load MSVC environment and run commands in separate shells.
> > >
> > > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > > ---
> >
> > LGTM.
> >
> > Acked-by: Aaron Conole <aconole@redhat.com>
> >
> > How far back will this work (ie: can we backport this to older branches?)
> 
> MSVC was added in 23.11.
> The patch applies cleanly and runs on 23.11 (where only lib/kvargs,
> lib/log and lib/telemetry are compiled) and 24.11.
> 
> I can add Cc: stable if you think it is worth having it in LTS (UNH
> provides some coverage in LTS releases).
> 
> 
> -- 
> David Marchand

LGTM.
--
Andre Muezerie
  

David Marchand <david.marchand@redhat.com> writes:

> On Tue, Feb 18, 2025 at 2:32 PM Aaron Conole <aconole@redhat.com> wrote:
>>
>> David Marchand <david.marchand@redhat.com> writes:
>>
>> > Add a build target in Windows 2022 for MSVC.
>> >
>> > Loading MSVC environment and having successive commands in a single
>> > (cmd or pwsh) shell does not seem to correctly report if one of the
>> > commands failed.
>> > For now, load MSVC environment and run commands in separate shells.
>> >
>> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>> > ---
>>
>> LGTM.
>>
>> Acked-by: Aaron Conole <aconole@redhat.com>
>>
>> How far back will this work (ie: can we backport this to older branches?)
>
> MSVC was added in 23.11.
> The patch applies cleanly and runs on 23.11 (where only lib/kvargs,
> lib/log and lib/telemetry are compiled) and 24.11.
>
> I can add Cc: stable if you think it is worth having it in LTS (UNH
> provides some coverage in LTS releases).

I usually prefer to back-port CI related changes because it helps us
catch issues / improve the stable release cycle.
  

On Tue, Feb 18, 2025 at 4:36 PM Andre Muezerie
<andremue@linux.microsoft.com> wrote:
> > > > Add a build target in Windows 2022 for MSVC.
> > > >
> > > > Loading MSVC environment and having successive commands in a single
> > > > (cmd or pwsh) shell does not seem to correctly report if one of the
> > > > commands failed.
> > > > For now, load MSVC environment and run commands in separate shells.

Cc: stable@dpdk.org

> > > > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > > Acked-by: Aaron Conole <aconole@redhat.com>
> LGTM.
> --
> Andre Muezerie

Applied, thanks.