diff mbox series

[1/4] raw/ifpga: remove unnecessary deref of function pointers

Message ID 20250311155300.13410-2-stephen@networkplumber.org (mailing list archive)
State New
Delegated to: Thomas Monjalon
Headers
Series more unnecessary function pointer |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Stephen Hemminger March 11, 2025, 3:51 p.m. UTC 
The expression *dev->ops->start and dev->ops->start are equivalent.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/raw/ifpga/afu_pmd_core.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

Comments

Bruce Richardson March 11, 2025, 4:03 p.m. UTC | #1 
On Tue, Mar 11, 2025 at 08:51:29AM -0700, Stephen Hemminger wrote:
> The expression *dev->ops->start and dev->ops->start are equivalent.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  drivers/raw/ifpga/afu_pmd_core.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Xu, Rosen March 12, 2025, 2:06 p.m. UTC | #2 
Hi,

> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Tuesday, March 11, 2025 11:51 PM
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; Xu, Rosen
> <rosen.xu@intel.com>
> Subject: [PATCH 1/4] raw/ifpga: remove unnecessary deref of function
> pointers
> 
> The expression *dev->ops->start and dev->ops->start are equivalent.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  drivers/raw/ifpga/afu_pmd_core.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/raw/ifpga/afu_pmd_core.c
> b/drivers/raw/ifpga/afu_pmd_core.c
> index 3ab1f47ac1..f650b76cfe 100644
> --- a/drivers/raw/ifpga/afu_pmd_core.c
> +++ b/drivers/raw/ifpga/afu_pmd_core.c
> @@ -39,7 +39,7 @@ static int afu_rawdev_configure(const struct
> rte_rawdev *rawdev,
>  		return -ENODEV;
> 
>  	if (dev->ops && dev->ops->config)
> -		ret = (*dev->ops->config)(dev, config, config_size);
> +		ret = dev->ops->config(dev, config, config_size);
> 
>  	return ret;
>  }
> @@ -62,7 +62,7 @@ static int afu_rawdev_start(struct rte_rawdev *rawdev)
>  	}
> 
>  	if (dev->ops && dev->ops->start)
> -		ret = (*dev->ops->start)(dev);
> +		ret = dev->ops->start(dev);
> 
>  	afu_rawdev_unlock(dev);
> 
> @@ -87,7 +87,7 @@ static void afu_rawdev_stop(struct rte_rawdev
> *rawdev)
>  	}
> 
>  	if (dev->ops && dev->ops->stop)
> -		ret = (*dev->ops->stop)(dev);
> +		ret = dev->ops->stop(dev);
> 
>  	afu_rawdev_unlock(dev);
>  }
> @@ -104,7 +104,7 @@ static int afu_rawdev_close(struct rte_rawdev
> *rawdev)
>  		return -ENODEV;
> 
>  	if (dev->ops && dev->ops->close)
> -		ret = (*dev->ops->close)(dev);
> +		ret = dev->ops->close(dev);
> 
>  	return ret;
>  }
> @@ -127,7 +127,7 @@ static int afu_rawdev_reset(struct rte_rawdev
> *rawdev)
>  	}
> 
>  	if (dev->ops && dev->ops->reset)
> -		ret = (*dev->ops->reset)(dev);
> +		ret = dev->ops->reset(dev);
> 
>  	afu_rawdev_unlock(dev);
> 
> @@ -155,7 +155,7 @@ static int afu_rawdev_selftest(uint16_t dev_id)
>  	}
> 
>  	if (dev->ops && dev->ops->test)
> -		ret = (*dev->ops->test)(dev);
> +		ret = dev->ops->test(dev);
> 
>  	afu_rawdev_unlock(dev);
> 
> @@ -174,7 +174,7 @@ static int afu_rawdev_dump(struct rte_rawdev
> *rawdev, FILE *f)
>  		return -ENODEV;
> 
>  	if (dev->ops && dev->ops->dump)
> -		ret = (*dev->ops->dump)(dev, f);
> +		ret = dev->ops->dump(dev, f);
> 
>  	return ret;
>  }
> @@ -326,7 +326,7 @@ static int afu_rawdev_create(struct rte_afu_device
> *afu_dev, int socket_id)
>  	}
> 
>  	if (dev->ops->init) {
> -		ret = (*dev->ops->init)(dev);
> +		ret = dev->ops->init(dev);
>  		if (ret) {
>  			IFPGA_RAWDEV_PMD_ERR("Failed to init %s",
> name);
>  			goto cleanup;
> --
> 2.47.2
Acked-by: Rosen Xu <rosen.xu@intel.com>
diff mbox series

Patch

diff --git a/drivers/raw/ifpga/afu_pmd_core.c b/drivers/raw/ifpga/afu_pmd_core.c
index 3ab1f47ac1..f650b76cfe 100644
--- a/drivers/raw/ifpga/afu_pmd_core.c
+++ b/drivers/raw/ifpga/afu_pmd_core.c
@@ -39,7 +39,7 @@  static int afu_rawdev_configure(const struct rte_rawdev *rawdev,
 		return -ENODEV;
 
 	if (dev->ops && dev->ops->config)
-		ret = (*dev->ops->config)(dev, config, config_size);
+		ret = dev->ops->config(dev, config, config_size);
 
 	return ret;
 }
@@ -62,7 +62,7 @@  static int afu_rawdev_start(struct rte_rawdev *rawdev)
 	}
 
 	if (dev->ops && dev->ops->start)
-		ret = (*dev->ops->start)(dev);
+		ret = dev->ops->start(dev);
 
 	afu_rawdev_unlock(dev);
 
@@ -87,7 +87,7 @@  static void afu_rawdev_stop(struct rte_rawdev *rawdev)
 	}
 
 	if (dev->ops && dev->ops->stop)
-		ret = (*dev->ops->stop)(dev);
+		ret = dev->ops->stop(dev);
 
 	afu_rawdev_unlock(dev);
 }
@@ -104,7 +104,7 @@  static int afu_rawdev_close(struct rte_rawdev *rawdev)
 		return -ENODEV;
 
 	if (dev->ops && dev->ops->close)
-		ret = (*dev->ops->close)(dev);
+		ret = dev->ops->close(dev);
 
 	return ret;
 }
@@ -127,7 +127,7 @@  static int afu_rawdev_reset(struct rte_rawdev *rawdev)
 	}
 
 	if (dev->ops && dev->ops->reset)
-		ret = (*dev->ops->reset)(dev);
+		ret = dev->ops->reset(dev);
 
 	afu_rawdev_unlock(dev);
 
@@ -155,7 +155,7 @@  static int afu_rawdev_selftest(uint16_t dev_id)
 	}
 
 	if (dev->ops && dev->ops->test)
-		ret = (*dev->ops->test)(dev);
+		ret = dev->ops->test(dev);
 
 	afu_rawdev_unlock(dev);
 
@@ -174,7 +174,7 @@  static int afu_rawdev_dump(struct rte_rawdev *rawdev, FILE *f)
 		return -ENODEV;
 
 	if (dev->ops && dev->ops->dump)
-		ret = (*dev->ops->dump)(dev, f);
+		ret = dev->ops->dump(dev, f);
 
 	return ret;
 }
@@ -326,7 +326,7 @@  static int afu_rawdev_create(struct rte_afu_device *afu_dev, int socket_id)
 	}
 
 	if (dev->ops->init) {
-		ret = (*dev->ops->init)(dev);
+		ret = dev->ops->init(dev);
 		if (ret) {
 			IFPGA_RAWDEV_PMD_ERR("Failed to init %s", name);
 			goto cleanup;