net/ixgbe: fix missing checks for E610 VFs

Message ID 20250321171211.386594-1-bruce.richardson@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Bruce Richardson
Headers
Series net/ixgbe: fix missing checks for E610 VFs |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-marvell-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/github-robot: build success github build: passed
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-mellanox-Functional success Functional Testing PASS

Commit Message

Bruce Richardson March 21, 2025, 5:12 p.m. UTC
A number of places in the ixgbe code check for a virtual function, but
these checks were missing the identifier for the E610 VF. Add them into
the conditionals.

Fixes: f678f3dea8fd ("net/ixgbe: fix missing VF PCI ID")
Cc: stable@dpdk.org

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/net/intel/ixgbe/ixgbe_rxtx.c | 4 ++++
 1 file changed, 4 insertions(+)
  

Comments

Medvedkin, Vladimir March 21, 2025, 5:15 p.m. UTC | #1
Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>

On 21/03/2025 17:12, Bruce Richardson wrote:
> A number of places in the ixgbe code check for a virtual function, but
> these checks were missing the identifier for the E610 VF. Add them into
> the conditionals.
>
> Fixes: f678f3dea8fd ("net/ixgbe: fix missing VF PCI ID")
> Cc: stable@dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>   drivers/net/intel/ixgbe/ixgbe_rxtx.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/intel/ixgbe/ixgbe_rxtx.c b/drivers/net/intel/ixgbe/ixgbe_rxtx.c
> index 3b7a6a6f0e..0c8a9ec763 100644
> --- a/drivers/net/intel/ixgbe/ixgbe_rxtx.c
> +++ b/drivers/net/intel/ixgbe/ixgbe_rxtx.c
> @@ -2767,6 +2767,7 @@ ixgbe_dev_tx_queue_setup(struct rte_eth_dev *dev,
>   	 * Modification to set VFTDT for virtual function if vf is detected
>   	 */
>   	if (hw->mac.type == ixgbe_mac_82599_vf ||
> +	    hw->mac.type == ixgbe_mac_E610_vf ||
>   	    hw->mac.type == ixgbe_mac_X540_vf ||
>   	    hw->mac.type == ixgbe_mac_X550_vf ||
>   	    hw->mac.type == ixgbe_mac_X550EM_x_vf ||
> @@ -2987,6 +2988,7 @@ ixgbe_is_vf(struct rte_eth_dev *dev)
>   	case ixgbe_mac_X550_vf:
>   	case ixgbe_mac_X550EM_x_vf:
>   	case ixgbe_mac_X550EM_a_vf:
> +	case ixgbe_mac_E610_vf:
>   		return 1;
>   	default:
>   		return 0;
> @@ -3153,6 +3155,7 @@ ixgbe_dev_rx_queue_setup(struct rte_eth_dev *dev,
>   	 * Modified to setup VFRDT for Virtual Function
>   	 */
>   	if (hw->mac.type == ixgbe_mac_82599_vf ||
> +	    hw->mac.type == ixgbe_mac_E610_vf ||
>   	    hw->mac.type == ixgbe_mac_X540_vf ||
>   	    hw->mac.type == ixgbe_mac_X550_vf ||
>   	    hw->mac.type == ixgbe_mac_X550EM_x_vf ||
> @@ -5835,6 +5838,7 @@ ixgbevf_dev_rx_init(struct rte_eth_dev *dev)
>   	case ixgbe_mac_X550_vf:
>   	case ixgbe_mac_X550EM_x_vf:
>   	case ixgbe_mac_X550EM_a_vf:
> +	case ixgbe_mac_E610_vf:
>   		switch (dev->data->dev_conf.rxmode.mq_mode) {
>   		case RTE_ETH_MQ_RX_RSS:
>   		case RTE_ETH_MQ_RX_DCB_RSS:
  
Thomas Monjalon March 23, 2025, 10:12 a.m. UTC | #2
21/03/2025 18:15, Medvedkin, Vladimir:
> Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> 
> On 21/03/2025 17:12, Bruce Richardson wrote:
> > A number of places in the ixgbe code check for a virtual function, but
> > these checks were missing the identifier for the E610 VF. Add them into
> > the conditionals.
> >
> > Fixes: f678f3dea8fd ("net/ixgbe: fix missing VF PCI ID")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks.
  

Patch

diff --git a/drivers/net/intel/ixgbe/ixgbe_rxtx.c b/drivers/net/intel/ixgbe/ixgbe_rxtx.c
index 3b7a6a6f0e..0c8a9ec763 100644
--- a/drivers/net/intel/ixgbe/ixgbe_rxtx.c
+++ b/drivers/net/intel/ixgbe/ixgbe_rxtx.c
@@ -2767,6 +2767,7 @@  ixgbe_dev_tx_queue_setup(struct rte_eth_dev *dev,
 	 * Modification to set VFTDT for virtual function if vf is detected
 	 */
 	if (hw->mac.type == ixgbe_mac_82599_vf ||
+	    hw->mac.type == ixgbe_mac_E610_vf ||
 	    hw->mac.type == ixgbe_mac_X540_vf ||
 	    hw->mac.type == ixgbe_mac_X550_vf ||
 	    hw->mac.type == ixgbe_mac_X550EM_x_vf ||
@@ -2987,6 +2988,7 @@  ixgbe_is_vf(struct rte_eth_dev *dev)
 	case ixgbe_mac_X550_vf:
 	case ixgbe_mac_X550EM_x_vf:
 	case ixgbe_mac_X550EM_a_vf:
+	case ixgbe_mac_E610_vf:
 		return 1;
 	default:
 		return 0;
@@ -3153,6 +3155,7 @@  ixgbe_dev_rx_queue_setup(struct rte_eth_dev *dev,
 	 * Modified to setup VFRDT for Virtual Function
 	 */
 	if (hw->mac.type == ixgbe_mac_82599_vf ||
+	    hw->mac.type == ixgbe_mac_E610_vf ||
 	    hw->mac.type == ixgbe_mac_X540_vf ||
 	    hw->mac.type == ixgbe_mac_X550_vf ||
 	    hw->mac.type == ixgbe_mac_X550EM_x_vf ||
@@ -5835,6 +5838,7 @@  ixgbevf_dev_rx_init(struct rte_eth_dev *dev)
 	case ixgbe_mac_X550_vf:
 	case ixgbe_mac_X550EM_x_vf:
 	case ixgbe_mac_X550EM_a_vf:
+	case ixgbe_mac_E610_vf:
 		switch (dev->data->dev_conf.rxmode.mq_mode) {
 		case RTE_ETH_MQ_RX_RSS:
 		case RTE_ETH_MQ_RX_DCB_RSS: