From patchwork Wed Apr 24 13:21:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anatoly Burakov X-Patchwork-Id: 139646 X-Patchwork-Delegate: bruce.richardson@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C5E643EAD; Wed, 24 Apr 2024 15:22:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2F1D343480; Wed, 24 Apr 2024 15:22:16 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by mails.dpdk.org (Postfix) with ESMTP id 313E640273; Wed, 24 Apr 2024 15:22:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713964935; x=1745500935; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=pH5TlTdGXAg9O85La1eq6EPtkLVnpxXM+bYQy6K+eRI=; b=Kl8MRG5lN4gBYQqpAYjRG4ikp/GVg0XD6r5xYPho86Hg8UhtpKQtpJt2 fJSW7UrFi+J6pZla/W/ycCA1dD5MrpcifZxBqPFmjn/Ihy8ePjx+7lCAn FpZKOz0Mllj8zW++AewFWn6s7aqQHbADoe6Ucg8NEl0aJQbMlOfn4YMm8 zeZZ+NhtAukmHz7d0/5MMCJ9A/55VXbPs3WJ48nTkdIbsivwWs3WEg4DW NDtHxSix0tOVIGbFC+Wc45INrMJHgOks+78Ymi+ZMjAO3JRvXZFJwnWDS R17kmkZ/Nk34dTuQ+dLNr8AMbO62eUSS7GVxZ+a4S6lAqR3gWaNnR6BTL Q==; X-CSE-ConnectionGUID: sc5YhMqYRESSBYtJ1XFRfQ== X-CSE-MsgGUID: N60uDQuAROOK/tChSqi7dw== X-IronPort-AV: E=McAfee;i="6600,9927,11054"; a="20289235" X-IronPort-AV: E=Sophos;i="6.07,226,1708416000"; d="scan'208";a="20289235" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2024 06:22:14 -0700 X-CSE-ConnectionGUID: UkVyEm4RTI6m0sgBW4J9Ew== X-CSE-MsgGUID: ZiDlHWmZSByoEJFJ8pErpA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,226,1708416000"; d="scan'208";a="24749274" Received: from silpixa00401119.ir.intel.com ([10.55.129.167]) by fmviesa006.fm.intel.com with ESMTP; 24 Apr 2024 06:22:11 -0700 From: Anatoly Burakov To: dev@dpdk.org Cc: Piotr Pietruszewski , vladimir.medvedkin@intel.com, bruce.richardson@intel.com, stable@dpdk.org, Skajewski@dpdk.org, PiotrX , Marek Mical , Kirsher@dpdk.org, Jeffrey T , Michael@dpdk.org, Alice Subject: [PATCH v1 01/22] net/ixgbe/base: revert remove default advertising for x550 2.5G/5G Date: Wed, 24 Apr 2024 14:21:35 +0100 Message-ID: <2accdfc6a96ea61acb30ef431e17c380dc538eba.1713964708.git.anatoly.burakov@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Piotr Pietruszewski This reverts the following commit: 13de2444449e ("net/ixgbe/base: remove default advertising for x550 2.5G/5G") The commit removing advertising 2.5G and 5G speeds from ixgbe_get_copper_speeds_supported() was supposed to disable 2.5G and 5G during the autonegotiation with default settings. However, that change prevented OS-specific part of the driver from forcing these speeds at user request. This change reverts the commit and adds 2.5G and 5G as speeds supported by the X550. Cc: stable@dpdk.org Signed-off-by: Piotr Pietruszewski Reviewed-by: Skajewski, PiotrX Reviewed-by: Marek Mical Reviewed-by: Kirsher, Jeffrey T Reviewed-by: Michael, Alice --- drivers/net/ixgbe/base/ixgbe_phy.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ixgbe/base/ixgbe_phy.c b/drivers/net/ixgbe/base/ixgbe_phy.c index 74c5db16fa..3a8e603472 100644 --- a/drivers/net/ixgbe/base/ixgbe_phy.c +++ b/drivers/net/ixgbe/base/ixgbe_phy.c @@ -915,6 +915,10 @@ static s32 ixgbe_get_copper_speeds_supported(struct ixgbe_hw *hw) hw->phy.speeds_supported |= IXGBE_LINK_SPEED_100_FULL; switch (hw->mac.type) { + case ixgbe_mac_X550: + hw->phy.speeds_supported |= IXGBE_LINK_SPEED_2_5GB_FULL; + hw->phy.speeds_supported |= IXGBE_LINK_SPEED_5GB_FULL; + break; case ixgbe_mac_X550EM_x: case ixgbe_mac_X550EM_a: hw->phy.speeds_supported &= ~IXGBE_LINK_SPEED_100_FULL;