diff mbox

[dpdk-dev] cmdline: add cmdline_token_portlist_ops to version map

Message ID 2f7ec12dfcf988fe41e2f8bd947a8c820eba095b.1423033634.git.pmatilai@redhat.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Panu Matilainen Feb. 4, 2015, 7:07 a.m. UTC 
  cmdline_token_portlist_ops fell through cracks in the initial symbol
versioning patch, breaking pktgen build.

Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
---
 lib/librte_cmdline/rte_cmdline_version.map | 1 +
 1 file changed, 1 insertion(+)

Comments

Olivier Matz Feb. 4, 2015, 8:58 a.m. UTC | #1 
On 02/04/2015 08:07 AM, Panu Matilainen wrote:
> cmdline_token_portlist_ops fell through cracks in the initial symbol
> versioning patch, breaking pktgen build.
>
> Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
> ---
>   lib/librte_cmdline/rte_cmdline_version.map | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/lib/librte_cmdline/rte_cmdline_version.map b/lib/librte_cmdline/rte_cmdline_version.map
> index 3e7b86b..6193462 100644
> --- a/lib/librte_cmdline/rte_cmdline_version.map
> +++ b/lib/librte_cmdline/rte_cmdline_version.map
> @@ -48,6 +48,7 @@ DPDK_2.0 {
>   	cmdline_token_etheraddr_ops;
>   	cmdline_token_ipaddr_ops;
>   	cmdline_token_num_ops;
> +	cmdline_token_portlist_ops;
>   	cmdline_token_string_ops;
>   	cmdline_token_string_ops;
>   	cmdline_write_char;
>

Acked-by: Olivier Matz <olivier.matz@6wind.com>
Neil Horman Feb. 4, 2015, 11:42 a.m. UTC | #2 
On Wed, Feb 04, 2015 at 09:07:14AM +0200, Panu Matilainen wrote:
> cmdline_token_portlist_ops fell through cracks in the initial symbol
> versioning patch, breaking pktgen build.
> 
> Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
> ---
>  lib/librte_cmdline/rte_cmdline_version.map | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/librte_cmdline/rte_cmdline_version.map b/lib/librte_cmdline/rte_cmdline_version.map
> index 3e7b86b..6193462 100644
> --- a/lib/librte_cmdline/rte_cmdline_version.map
> +++ b/lib/librte_cmdline/rte_cmdline_version.map
> @@ -48,6 +48,7 @@ DPDK_2.0 {
>  	cmdline_token_etheraddr_ops;
>  	cmdline_token_ipaddr_ops;
>  	cmdline_token_num_ops;
> +	cmdline_token_portlist_ops;
>  	cmdline_token_string_ops;
>  	cmdline_token_string_ops;
>  	cmdline_write_char;
> -- 
> 2.1.0
> 
> 

Acked-by: Neil Horman <nhorman@tuxdriver.com>
Thomas Monjalon Feb. 4, 2015, 10:35 p.m. UTC | #3 
2015-02-04 06:42, Neil Horman:
> On Wed, Feb 04, 2015 at 09:07:14AM +0200, Panu Matilainen wrote:
> > cmdline_token_portlist_ops fell through cracks in the initial symbol
> > versioning patch, breaking pktgen build.
> > 
> > Signed-off-by: Panu Matilainen <pmatilai@redhat.com>

> > +	cmdline_token_portlist_ops;

> Acked-by: Neil Horman <nhorman@tuxdriver.com>

Applied, thanks
diff mbox

Patch

diff --git a/lib/librte_cmdline/rte_cmdline_version.map b/lib/librte_cmdline/rte_cmdline_version.map
index 3e7b86b..6193462 100644
--- a/lib/librte_cmdline/rte_cmdline_version.map
+++ b/lib/librte_cmdline/rte_cmdline_version.map
@@ -48,6 +48,7 @@  DPDK_2.0 {
 	cmdline_token_etheraddr_ops;
 	cmdline_token_ipaddr_ops;
 	cmdline_token_num_ops;
+	cmdline_token_portlist_ops;
 	cmdline_token_string_ops;
 	cmdline_token_string_ops;
 	cmdline_write_char;