From patchwork Thu Oct 12 12:19:36 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adrien Mazarguil X-Patchwork-Id: 30272 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D9B1F1B2E9; Thu, 12 Oct 2017 14:20:51 +0200 (CEST) Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 5D4951B27F for ; Thu, 12 Oct 2017 14:20:36 +0200 (CEST) Received: by mail-wm0-f54.google.com with SMTP id t69so12678033wmt.2 for ; Thu, 12 Oct 2017 05:20:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=geWiWWtVkTe/lFkN5m+RwaMSKT3O7zWxQRz0DpwRk08=; b=pgmDTCSwHw7jftf39VbP6XkbOqX3Dvpb5L9b3eORwI7/JxU2oUb1ovhl7la6fwkBZy 0+iN657CuUDgCmY+0WsBrEwoJVthlTGHq2Jft6HxElAATsbt58lFFc/TZcK86hg+FOPC BHUwzqh4GjIeBu5G8rcSeEgXLCUQT79ZRgX5lGqxK+XCOMSU2msCa8Maj+PxI4Ueu80X bKhDhfEdioFwrfnAzzXU5TzpY6OqMuR1AbJOVvjJbpEtljvQm5D7yHX2av0YJr9ktJIu aapijJeC01AJXSpyeoRgOdNWEQOeGvI+jI818XQkmNLkn4g/PxksUAc3FPBE72Tad1qC txtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=geWiWWtVkTe/lFkN5m+RwaMSKT3O7zWxQRz0DpwRk08=; b=boFZSRw2deUTc8vdfqOKBay2TyT1l5WizPKdjtEPO9BMxAx4Osqhicaos7sk6XYGFY O31ybqSWjwfjrHtOy4eRwm7ajpxrFRYqYMxEiMezIuPaA6sXblz9HKbwo4cKTikOPrIJ MROdqRqv4zoefS+2JeQcuY1cphYZU5JYkfxPo4gEVP1d+/4XTm823ps3A593zNgGVF1h aTKQxdBV9FL/MuwQ54bAoNs7XoRnXhiAEBuwCFSiXPkM1T93wizAU3nlVaQMXdZOYfHd LbywiTUZt4v+rPUX1EOngFAPw7+qUaS9u33jEo1t7X9i3ZLRiZqz8cmqa3K1slWOQu2w 5JJg== X-Gm-Message-State: AMCzsaWuRfFLL/5dAoZ8hXb6AcZKXfdLP9RwQbQvjujk/9o4JeNttvWZ V9K31Hm6EuhPForgKVTBeWBTLQ== X-Google-Smtp-Source: AOwi7QCi0bC3uXOr2gE+2MZklj+4eV4qLAdRRA935ntrsg3yhdnA4yn78BDrRAF/kDKB9ZcmYrqSUQ== X-Received: by 10.223.171.92 with SMTP id r28mr2165064wrc.62.1507810836204; Thu, 12 Oct 2017 05:20:36 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id y29sm9157189wrd.3.2017.10.12.05.20.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Oct 2017 05:20:34 -0700 (PDT) From: Adrien Mazarguil To: Ferruh Yigit Cc: Nelio Laranjeiro , dev@dpdk.org Date: Thu, 12 Oct 2017 14:19:36 +0200 Message-Id: <44637d57aa92dc8ac82999e3ba3f8d6a5530f1ce.1507809961.git.adrien.mazarguil@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: References: Subject: [dpdk-dev] [PATCH v2 22/29] net/mlx4: fix invalid errno value sign X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Tx queue elements allocation function sets rte_errno properly and returns its negative version. Reassigning this value to rte_errno is thus both invalid and unnecessary. Fixes: c3e1f93cdf88 ("net/mlx4: standardize on negative errno values") Signed-off-by: Adrien Mazarguil Acked-by: Nelio Laranjeiro --- drivers/net/mlx4/mlx4_txq.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/mlx4/mlx4_txq.c b/drivers/net/mlx4/mlx4_txq.c index c1fdbaf..3cece3e 100644 --- a/drivers/net/mlx4/mlx4_txq.c +++ b/drivers/net/mlx4/mlx4_txq.c @@ -340,7 +340,6 @@ mlx4_txq_setup(struct rte_eth_dev *dev, struct txq *txq, uint16_t desc, } ret = mlx4_txq_alloc_elts(&tmpl, desc); if (ret) { - rte_errno = ret; ERROR("%p: TXQ allocation failed: %s", (void *)dev, strerror(rte_errno)); goto error;