diff mbox

[dpdk-dev,1/2] ethdev: fix C11 extensions in exported header

Message ID 55d8f7ef02866b9ab921656e9e9e4a43d09f3c50.1501847638.git.adrien.mazarguil@6wind.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Adrien Mazarguil Aug. 4, 2017, 11:56 a.m. UTC 
  Fix issues reported by check-includes.sh:

 rte_tm.h:473:2: error: anonymous unions are a C11 extension
     [-Werror,-Wc11-extensions]
 rte_tm.h:696:2: error: anonymous unions are a C11 extension
     [-Werror,-Wc11-extensions]
 rte_tm.h:904:2: error: anonymous unions are a C11 extension
     [-Werror,-Wc11-extensions]

Fixes: 5d109deffa87 ("ethdev: add traffic management API")
Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
---
 lib/librte_ether/rte_tm.h | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Cristian Dumitrescu Aug. 4, 2017, 1:37 p.m. UTC | #1 
> -----Original Message-----
> From: Adrien Mazarguil [mailto:adrien.mazarguil@6wind.com]
> Sent: Friday, August 4, 2017 12:56 PM
> To: Thomas Monjalon <thomas@monjalon.net>
> Cc: dev@dpdk.org; Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Subject: [PATCH 1/2] ethdev: fix C11 extensions in exported header
> 
> Fix issues reported by check-includes.sh:
> 
>  rte_tm.h:473:2: error: anonymous unions are a C11 extension
>      [-Werror,-Wc11-extensions]
>  rte_tm.h:696:2: error: anonymous unions are a C11 extension
>      [-Werror,-Wc11-extensions]
>  rte_tm.h:904:2: error: anonymous unions are a C11 extension
>      [-Werror,-Wc11-extensions]
> 
> Fixes: 5d109deffa87 ("ethdev: add traffic management API")
> Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> 
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> ---

Acked-by: Cristian Dumitrescu <Cristian.Dumitrescu@intel.com>
Thomas Monjalon Aug. 4, 2017, 11:16 p.m. UTC | #2 
> > Fix issues reported by check-includes.sh:
> > 
> >  rte_tm.h:473:2: error: anonymous unions are a C11 extension
> >      [-Werror,-Wc11-extensions]
> >  rte_tm.h:696:2: error: anonymous unions are a C11 extension
> >      [-Werror,-Wc11-extensions]
> >  rte_tm.h:904:2: error: anonymous unions are a C11 extension
> >      [-Werror,-Wc11-extensions]
> > 
> > Fixes: 5d109deffa87 ("ethdev: add traffic management API")
> > Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > 
> > Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> 
> Acked-by: Cristian Dumitrescu <Cristian.Dumitrescu@intel.com>

Series applied, thanks
diff mbox

Patch

diff --git a/lib/librte_ether/rte_tm.h b/lib/librte_ether/rte_tm.h
index a632b5c..ebbfa1e 100644
--- a/lib/librte_ether/rte_tm.h
+++ b/lib/librte_ether/rte_tm.h
@@ -50,6 +50,8 @@ 
 
 #include <stdint.h>
 
+#include <rte_common.h>
+
 #ifdef __cplusplus
 extern "C" {
 #endif
@@ -470,6 +472,7 @@  struct rte_tm_level_capabilities {
 	 */
 	int leaf_nodes_identical;
 
+	RTE_STD_C11
 	union {
 		/** Items valid only for the non-leaf nodes on this level. */
 		struct {
@@ -693,6 +696,7 @@  struct rte_tm_node_capabilities {
 	 */
 	uint32_t shaper_shared_n_max;
 
+	RTE_STD_C11
 	union {
 		/** Items valid only for non-leaf nodes. */
 		struct {
@@ -901,6 +905,7 @@  struct rte_tm_node_params {
 	/** Number of shared shaper IDs in the *shared_shaper_id* array. */
 	uint32_t n_shared_shapers;
 
+	RTE_STD_C11
 	union {
 		/** Parameters only valid for non-leaf nodes. */
 		struct {