From patchwork Wed Apr 24 13:21:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anatoly Burakov X-Patchwork-Id: 139653 X-Patchwork-Delegate: bruce.richardson@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09C5243EAD; Wed, 24 Apr 2024 15:23:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3A343434AA; Wed, 24 Apr 2024 15:22:35 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by mails.dpdk.org (Postfix) with ESMTP id A18EC434A6 for ; Wed, 24 Apr 2024 15:22:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713964954; x=1745500954; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=l9+PUKAsDi2uqwCxaMcNclP+NWYYilGNGmA3IVK50O0=; b=X5Wz5UFaLALxFTGvSvag9wQ4bPKgogA94zKHh2jgxWB0pgQAL9OJjo3x z33nnqHJaHMpKpTEpD3Jm+mlEf25R0vIdEROiqxTVPA7yx/Q4vILFM9/B dxh9Kb3Nf2im+xXN3uYE1kAMC6BFiSmx6qY9gJW2pk6q/6juzy1AifbNP GFCZftcUHo1CJkUDvYN6RI+uYsQIH3/SM2DSM8GRgn4OnCSUmwRgs/R+y 72WloWA7w1ySkBZmv8IknIiMmWd7A6wmAJxEAfHoGUh7rmCL1wZGkpdQR X9dQSt0elJpnJlv+mSt/Acg+UcsE8xayzM2XXknp9fMtmcSvRd5usi9jZ A==; X-CSE-ConnectionGUID: dN5nfcHgRxe0gE2K+WS+Hg== X-CSE-MsgGUID: 0DB4yhKHSwOXK35thEozpQ== X-IronPort-AV: E=McAfee;i="6600,9927,11054"; a="20289261" X-IronPort-AV: E=Sophos;i="6.07,226,1708416000"; d="scan'208";a="20289261" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2024 06:22:33 -0700 X-CSE-ConnectionGUID: 64nJ7+rzRNWFkKqgU1zsvQ== X-CSE-MsgGUID: aXCbgSAAQCGItgsW2J7xJw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,226,1708416000"; d="scan'208";a="24749375" Received: from silpixa00401119.ir.intel.com ([10.55.129.167]) by fmviesa006.fm.intel.com with ESMTP; 24 Apr 2024 06:22:31 -0700 From: Anatoly Burakov To: dev@dpdk.org Cc: Slawomir Mrozowicz , vladimir.medvedkin@intel.com, bruce.richardson@intel.com, Tyl@dpdk.org, RadoslawX , Skajewski@dpdk.org, PiotrX , nosbuild , Michael@dpdk.org, Alice Subject: [PATCH v1 08/22] net/ixgbe/base: fix crash while loading driver Date: Wed, 24 Apr 2024 14:21:42 +0100 Message-ID: <577c1cb1250710da2839079d85a8e9e83fa34c7e.1713964708.git.anatoly.burakov@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Slawomir Mrozowicz Issue observed: system crash While loading the driver when debug macros were defined. The solution removes the debug macro call from ixgbe_set_mac_type() function which causes the crash. So far, the ixgbe_set_mac_type() function has called in the ixgbe driver ixgbe_probe() function before the struct ixgbe_hw is properly defined. In this case, the field back of the structure that must contain pointer to an adapter has not yet been defined and should not be used to obtain driver information which is needed in debug macros. Moreover bearing in mind the recommendations to not print out excessive amount of information it was decided to remove the debug information. Signed-off-by: Slawomir Mrozowicz Reviewed-by: Tyl, RadoslawX Reviewed-by: Skajewski, PiotrX Tested-by: nosbuild Reviewed-by: Michael, Alice --- Notes: This fix seems to be kernel-specific, so Cc:stable was intentionally omitted. drivers/net/ixgbe/base/ixgbe_api.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ixgbe/base/ixgbe_api.c b/drivers/net/ixgbe/base/ixgbe_api.c index b322c181b4..89e1650d63 100644 --- a/drivers/net/ixgbe/base/ixgbe_api.c +++ b/drivers/net/ixgbe/base/ixgbe_api.c @@ -216,8 +216,6 @@ s32 ixgbe_set_mac_type(struct ixgbe_hw *hw) break; } - DEBUGOUT2("ixgbe_set_mac_type found mac: %d, returns: %d\n", - hw->mac.type, ret_val); return ret_val; }