[dpdk-dev,2/2] cryptodev: fix C11 extensions in exported header

Message ID 61d6d83aca3273eb3ed0b6b204cf0c6fb131d635.1501847638.git.adrien.mazarguil@6wind.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Adrien Mazarguil Aug. 4, 2017, 11:56 a.m. UTC
  Fix issues reported by check-includes.sh:

 rte_crypto_sym.h:586:3: error: anonymous structs are a C11 extension
     [-Werror,-Wc11-extensions]
 rte_crypto_sym.h:510:2: error: anonymous unions are a C11 extension
     [-Werror,-Wc11-extensions]

Fixes: b59502a5e3d0 ("cryptodev: add AEAD parameters in crypto operation")
Cc: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
---
 lib/librte_cryptodev/rte_crypto_sym.h | 1 +
 1 file changed, 1 insertion(+)
  

Comments

De Lara Guarch, Pablo Aug. 4, 2017, 12:41 p.m. UTC | #1
> -----Original Message-----
> From: Adrien Mazarguil [mailto:adrien.mazarguil@6wind.com]
> Sent: Friday, August 4, 2017 12:56 PM
> To: Thomas Monjalon <thomas@monjalon.net>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> Subject: [PATCH 2/2] cryptodev: fix C11 extensions in exported header
> 
> Fix issues reported by check-includes.sh:
> 
>  rte_crypto_sym.h:586:3: error: anonymous structs are a C11 extension
>      [-Werror,-Wc11-extensions]
>  rte_crypto_sym.h:510:2: error: anonymous unions are a C11 extension
>      [-Werror,-Wc11-extensions]
> 
> Fixes: b59502a5e3d0 ("cryptodev: add AEAD parameters in crypto
> operation")
> Cc: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> 
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

Patch looks good, although check-git-log.sh complains about it:

Wrong tag:
        Fix issues reported by check-includes.sh:

Apart from this.

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
  

Patch

diff --git a/lib/librte_cryptodev/rte_crypto_sym.h b/lib/librte_cryptodev/rte_crypto_sym.h
index 58a33b8..0ceaa91 100644
--- a/lib/librte_cryptodev/rte_crypto_sym.h
+++ b/lib/librte_cryptodev/rte_crypto_sym.h
@@ -507,6 +507,7 @@  struct rte_crypto_sym_op {
 		/**< Session-less API crypto operation parameters */
 	};
 
+	RTE_STD_C11
 	union {
 		struct {
 			struct {