From patchwork Wed Apr 24 13:21:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anatoly Burakov X-Patchwork-Id: 139664 X-Patchwork-Delegate: bruce.richardson@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 941E643EAD; Wed, 24 Apr 2024 15:24:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0EFED434E8; Wed, 24 Apr 2024 15:22:59 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by mails.dpdk.org (Postfix) with ESMTP id 4533143478 for ; Wed, 24 Apr 2024 15:22:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713964977; x=1745500977; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=mZl2m7YUtXSxvkJUd0oPtka1e4NgTjBDvKH+O8GquyY=; b=ZFeoHRZptIC6eZNGoFqwlJ0pJ8ISMGLHTYb6+vtRPeqDcc5l3K9NRJzq 357NEslP2uhJKs1F24mpbWZSj84lP87GDomjwMJ68iTfIEFEbKXd2yP// cosEWq13Pt/Jj3Mmc6oGPkMwoV69GWoYvEie9uj67+qIFwzYknXlsB/0i t3gW52vceVFxK2G7PFYOoWVCwd79u9DOvjl0iKljTmhWkqY1lG0xJAnjh tiVv3oeFKaD0/6pkQ5lfv67+WK1wfYnFVb88+IzEqCjAhcEerS47B2vSe SbgfK5rYJyp3MzjyVnvY9T7Pxv2J1uWfLbYF6vXcZsZKGZpSvjTyjFj5e A==; X-CSE-ConnectionGUID: A0gz6FHQQoiMcnETcBBtzA== X-CSE-MsgGUID: U/i73VxtSeuD8jIffUE3uA== X-IronPort-AV: E=McAfee;i="6600,9927,11054"; a="20289292" X-IronPort-AV: E=Sophos;i="6.07,226,1708416000"; d="scan'208";a="20289292" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2024 06:22:56 -0700 X-CSE-ConnectionGUID: 721FCzWYTWKz3SsA8Aie7Q== X-CSE-MsgGUID: 8ssdqBW5Q/+sW0YNwWTASA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,226,1708416000"; d="scan'208";a="24749499" Received: from silpixa00401119.ir.intel.com ([10.55.129.167]) by fmviesa006.fm.intel.com with ESMTP; 24 Apr 2024 06:22:55 -0700 From: Anatoly Burakov To: dev@dpdk.org Cc: Dawid Zielinski , vladimir.medvedkin@intel.com, bruce.richardson@intel.com Subject: [PATCH v1 19/22] net/ixgbe/base: prevent untrusted loop bound Date: Wed, 24 Apr 2024 14:21:53 +0100 Message-ID: <666102a18ae39c8e1f0beb08640224aaff0169fc.1713964708.git.anatoly.burakov@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Dawid Zielinski Added length check against EEPROM size in words to prevent untrusted loop bound reported by static code analysis. Signed-off-by: Dawid Zielinski --- drivers/net/ixgbe/base/ixgbe_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c index a19f4d715c..73b5935d88 100644 --- a/drivers/net/ixgbe/base/ixgbe_common.c +++ b/drivers/net/ixgbe/base/ixgbe_common.c @@ -675,7 +675,7 @@ s32 ixgbe_read_pba_string_generic(struct ixgbe_hw *hw, u8 *pba_num, return ret_val; } - if (length == 0xFFFF || length == 0) { + if (length == 0xFFFF || length == 0 || length > hw->eeprom.word_size) { DEBUGOUT("NVM PBA number section invalid length\n"); return IXGBE_ERR_PBA_SECTION; }