From patchwork Fri May 3 13:57:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Burakov, Anatoly" X-Patchwork-Id: 139847 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5717043F76; Fri, 3 May 2024 16:00:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E77940ECF; Fri, 3 May 2024 15:58:59 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by mails.dpdk.org (Postfix) with ESMTP id F294C40E72 for ; Fri, 3 May 2024 15:58:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714744738; x=1746280738; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=mZl2m7YUtXSxvkJUd0oPtka1e4NgTjBDvKH+O8GquyY=; b=gSHp+jL88fKyCNK5BP4fbwohMEch/W4HWYK+j7K33oqX2PJ+6GvidAKU HEyZxAYPxa7P6YyUCpXF9HDz25JluqO+qEaApmKqjV3B534tbU/Ge2EIR +XvAsDlCSTWvtmL7VC9HBaBztyU4bi6HtV3TcR8lvj9W2pD7oZTiptXyu rFa2w882lcbM8mNaqfSDVeQX6p0aszDBQjf/GXGewttvxjcXjw2rqMePx 9TL06Acy49p2YsvD2Xitb4OFrqOC9cXLMg9jyTkTMXtN4NAqBgqfbf8MO n2/XIZgTb5Qlu3zTJsQGxmt9IqjEAuD+1+rBJBCjssKlxPHk/wcwA/92K w==; X-CSE-ConnectionGUID: kRcmyVh2QbaJQmJF2gPwyQ== X-CSE-MsgGUID: okj57tOuRvKLf59PKAWnEw== X-IronPort-AV: E=McAfee;i="6600,9927,11063"; a="10714965" X-IronPort-AV: E=Sophos;i="6.07,251,1708416000"; d="scan'208";a="10714965" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 May 2024 06:58:57 -0700 X-CSE-ConnectionGUID: V3/7DIOHQIG9+31CK9tRyQ== X-CSE-MsgGUID: Nd1SBwwMSjiG3o3rg9nlWg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,251,1708416000"; d="scan'208";a="50642040" Received: from silpixa00401119.ir.intel.com ([10.55.129.167]) by fmviesa002.fm.intel.com with ESMTP; 03 May 2024 06:58:56 -0700 From: Anatoly Burakov To: dev@dpdk.org Cc: Dawid Zielinski , bruce.richardson@intel.com, vladimir.medvedkin@intel.com Subject: [PATCH v2 19/27] net/ixgbe/base: prevent untrusted loop bound Date: Fri, 3 May 2024 14:57:50 +0100 Message-ID: <66a1bc91af68d5b58c8a7e352869a43ed80dd6f8.1714744628.git.anatoly.burakov@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Dawid Zielinski Added length check against EEPROM size in words to prevent untrusted loop bound reported by static code analysis. Signed-off-by: Dawid Zielinski --- drivers/net/ixgbe/base/ixgbe_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c index a19f4d715c..73b5935d88 100644 --- a/drivers/net/ixgbe/base/ixgbe_common.c +++ b/drivers/net/ixgbe/base/ixgbe_common.c @@ -675,7 +675,7 @@ s32 ixgbe_read_pba_string_generic(struct ixgbe_hw *hw, u8 *pba_num, return ret_val; } - if (length == 0xFFFF || length == 0) { + if (length == 0xFFFF || length == 0 || length > hw->eeprom.word_size) { DEBUGOUT("NVM PBA number section invalid length\n"); return IXGBE_ERR_PBA_SECTION; }