From patchwork Tue Aug 1 16:54:35 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adrien Mazarguil X-Patchwork-Id: 27360 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id E94FAA345; Tue, 1 Aug 2017 18:56:40 +0200 (CEST) Received: from mail-wr0-f169.google.com (mail-wr0-f169.google.com [209.85.128.169]) by dpdk.org (Postfix) with ESMTP id A158AA206 for ; Tue, 1 Aug 2017 18:55:59 +0200 (CEST) Received: by mail-wr0-f169.google.com with SMTP id f21so9183795wrf.5 for ; Tue, 01 Aug 2017 09:55:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references; bh=0FHtr7oPGHmR8iAbstfPAr4RJK18LVwGmBQka09k2dk=; b=vpumWMjZXvxtqsVppXOl6h1lQaiCrkb8+zssQvrAZuYIVPLEsPOCsapG99Ov+IHh7U WNjKGr3UTt19YZF5CCryD+SIXABOhBbqeAsS6gXJHksiqKEwAX8RZsqAkSRzDzBQCs1n DKT4xWLcSSmCdOT0fxSxbvv86ty9icyVt4yqNpZk2jkK9xEjo6LA4jM8PrrErR5db906 cHw03Dn8lJ3lUwia2AltS3fS6vLrJvDILgt0XNaK/oBB9kIPsgdbcKFrf1Sk7CBO2Hq/ zXewM5JV/tXVpbCdYBhVdvSyX8z7YmgLPmNDifXzgI1dEPod6xLabJ3dOIYIK2b9srQQ Nj5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=0FHtr7oPGHmR8iAbstfPAr4RJK18LVwGmBQka09k2dk=; b=rnXENLCBuvkm1TT8Btw5y+wkglrhJSzQMkbeVvar86i6trQg+khXrUd2hT8hsbK6DB /QZips2g4oZSI0YI4Qmasq3c4X59aplbIDugYdXkuNyaxrIvooxYvJZ80GF8ogznNDUt 0uxVhKYLhit1+LfkbMJGnU5G6rHSCQ41Nsfds5xhHqMs0UdShq5zKhH2zxbS50Czd5nv uWoFfrB47xvRK7o9NossHAnGPyLJcWrTJEsWP7WEEIIfgdkM9UkhgeEo6TlZiXXcdPXz h5Sd1D522lrqdtVDjM29f+FidvM3lgniYsGr07ZkF9vDUSazZxCXazZaID2+jyf1sCxB GuWw== X-Gm-Message-State: AIVw1134Hk7ztakOJoHulmS3HakKGf5VHZW0wMkG7kRg6vw2RhZ7fGnS iGFTqIsw4lTlM2WLH9o= X-Received: by 10.223.139.23 with SMTP id n23mr7845165wra.249.1501606559083; Tue, 01 Aug 2017 09:55:59 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id g93sm19449324wrd.11.2017.08.01.09.55.57 for (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 01 Aug 2017 09:55:58 -0700 (PDT) From: Adrien Mazarguil To: dev@dpdk.org Date: Tue, 1 Aug 2017 18:54:35 +0200 Message-Id: <7007c1ef2927315fe7fc768167f93fdea551b96e.1501598384.git.adrien.mazarguil@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: References: Subject: [dpdk-dev] [PATCH v1 48/48] net/mlx4: clean up includes and comments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add missing includes and sort them, then update/remove comments around them for consistency. Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 40 ++++++++++++++++++++++++--------------- drivers/net/mlx4/mlx4.h | 3 +-- drivers/net/mlx4/mlx4_flow.c | 5 +++++ drivers/net/mlx4/mlx4_flow.h | 3 +-- 4 files changed, 32 insertions(+), 19 deletions(-) diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c index c16803e..8573e14 100644 --- a/drivers/net/mlx4/mlx4.c +++ b/drivers/net/mlx4/mlx4.c @@ -31,29 +31,41 @@ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ -/* System headers. */ +/** + * @file + * mlx4 driver initialization. + */ + +#include +#include +#include #include +#include #include #include -#include -#include #include -#include #include -#include -#include -#include -#include +/* Verbs headers do not support -pedantic. */ +#ifdef PEDANTIC +#pragma GCC diagnostic ignored "-Wpedantic" +#endif +#include +#ifdef PEDANTIC +#pragma GCC diagnostic error "-Wpedantic" +#endif + +#include #include -#include #include -#include -#include +#include +#include +#include #include -#include +#include +#include +#include -/* PMD headers. */ #include "mlx4.h" #include "mlx4_flow.h" #include "mlx4_rxtx.h" @@ -73,8 +85,6 @@ const char *pmd_mlx4_init_params[] = { NULL, }; -/* Device configuration. */ - /** * DPDK callback for Ethernet device configuration. * diff --git a/drivers/net/mlx4/mlx4.h b/drivers/net/mlx4/mlx4.h index 94b5f1e..1cd4db3 100644 --- a/drivers/net/mlx4/mlx4.h +++ b/drivers/net/mlx4/mlx4.h @@ -37,8 +37,7 @@ #include #include -/* Verbs header. */ -/* ISO C doesn't support unnamed structs/unions, disabling -pedantic. */ +/* Verbs headers do not support -pedantic. */ #ifdef PEDANTIC #pragma GCC diagnostic ignored "-Wpedantic" #endif diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c index 5616b83..e2798f6 100644 --- a/drivers/net/mlx4/mlx4_flow.c +++ b/drivers/net/mlx4/mlx4_flow.c @@ -31,6 +31,11 @@ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +/** + * @file + * Flow API operations for mlx4 driver. + */ + #include #include #include diff --git a/drivers/net/mlx4/mlx4_flow.h b/drivers/net/mlx4/mlx4_flow.h index a24ae31..fbb775d 100644 --- a/drivers/net/mlx4/mlx4_flow.h +++ b/drivers/net/mlx4/mlx4_flow.h @@ -37,8 +37,7 @@ #include #include -/* Verbs header. */ -/* ISO C doesn't support unnamed structs/unions, disabling -pedantic. */ +/* Verbs headers do not support -pedantic. */ #ifdef PEDANTIC #pragma GCC diagnostic ignored "-Wpedantic" #endif