From patchwork Wed Oct 11 14:35:24 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adrien Mazarguil X-Patchwork-Id: 30144 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E83411B2A7; Wed, 11 Oct 2017 16:36:57 +0200 (CEST) Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 7AF0B1B24F for ; Wed, 11 Oct 2017 16:36:45 +0200 (CEST) Received: by mail-wm0-f43.google.com with SMTP id l68so5402361wmd.5 for ; Wed, 11 Oct 2017 07:36:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=geWiWWtVkTe/lFkN5m+RwaMSKT3O7zWxQRz0DpwRk08=; b=rpfuG0LoYdC7rPfhP3f0/th9/N24QZY5qtCsjc+fRjvDAeEpBxsZ5H+s8BbBao1Tca NiCM/RLTZAJS9FoGqMEoGsGNB405JbFkRk86lbeiQRUYHy8RP4om4wQDNGnfOp76IwaD 4zzGDb4d1VWF5CaPCycnq1s8yhoaNv8iIYQMazKatxN75W2B9fP6UrsPdfOac5Xh8amH YWlRmwHzCB7wcvQ3otwMtN2nIy69qKvPfKcQ61THV2iuxCbfXyM900nuQee6zgoMg7Vm 19MSvmOrHpDOCr3jbrty5rN5VOIs4S4MvR3ddUoT5NbQaWIHRC/Dc+bRgyhvSEVX3BLF nN0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=geWiWWtVkTe/lFkN5m+RwaMSKT3O7zWxQRz0DpwRk08=; b=UJHzWVRW/emh/j/BaV2q9PXqaTOuhM9wObs80AY0fcqYRLt0z7ITRTrnzNBrIKdFFW ge/GuP8aQSt54zrcjYsI+hKdYRRoHo9Eu0/Qu1Bf7y9AgiWI9qGhS9TeeiFD4S4VyliP CN6+TDXzYjdDQzkX12jwHVC0hdMxm8tpilkD3Iv3ZlJNYvWwdkClKKp6k60+kU0MUMw7 QPUWsRgLHJnCUSLdu9tbWnEWRbYJEQB35V5HlVeAFfNlaXpI6Z+Jej6q3SvVAigGIkh8 XzTGT53S9ub4qDlwmXipU68VLWkrsu5fMSeIixYurh5uqJiyeC+3V9ftjJGl0FCjvJL1 t0YA== X-Gm-Message-State: AMCzsaUvYTpDTM24lBBvOY3P6B+cm8+W7Uk6SpzaoX/OoplAGNziLzUS 9mQ9upCmdD+cJCDplMmDEG25C63y X-Google-Smtp-Source: AOwi7QBygtvYoOzPlhhcxKgRCitILt/U15qSXXHr9ByWh+M7QrXqQ3k7Vo+pGrjeRdsgHhuTvZdjYA== X-Received: by 10.28.137.193 with SMTP id l184mr13082867wmd.24.1507732605280; Wed, 11 Oct 2017 07:36:45 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id c37sm31747994wra.73.2017.10.11.07.36.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Oct 2017 07:36:44 -0700 (PDT) From: Adrien Mazarguil To: Ferruh Yigit Cc: dev@dpdk.org Date: Wed, 11 Oct 2017 16:35:24 +0200 Message-Id: <753b9f245816affe06a3a4db26cb12c40fe39779.1507730496.git.adrien.mazarguil@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: References: Subject: [dpdk-dev] [PATCH v1 22/29] net/mlx4: fix invalid errno value sign X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Tx queue elements allocation function sets rte_errno properly and returns its negative version. Reassigning this value to rte_errno is thus both invalid and unnecessary. Fixes: c3e1f93cdf88 ("net/mlx4: standardize on negative errno values") Signed-off-by: Adrien Mazarguil Acked-by: Nelio Laranjeiro --- drivers/net/mlx4/mlx4_txq.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/mlx4/mlx4_txq.c b/drivers/net/mlx4/mlx4_txq.c index c1fdbaf..3cece3e 100644 --- a/drivers/net/mlx4/mlx4_txq.c +++ b/drivers/net/mlx4/mlx4_txq.c @@ -340,7 +340,6 @@ mlx4_txq_setup(struct rte_eth_dev *dev, struct txq *txq, uint16_t desc, } ret = mlx4_txq_alloc_elts(&tmpl, desc); if (ret) { - rte_errno = ret; ERROR("%p: TXQ allocation failed: %s", (void *)dev, strerror(rte_errno)); goto error;