From patchwork Tue Sep 30 11:13:08 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hiroshi Shimamoto X-Patchwork-Id: 677 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id D2556678B; Tue, 30 Sep 2014 13:10:28 +0200 (CEST) Received: from tyo202.gate.nec.co.jp (TYO202.gate.nec.co.jp [210.143.35.52]) by dpdk.org (Postfix) with ESMTP id 4501A5902 for ; Tue, 30 Sep 2014 13:10:27 +0200 (CEST) Received: from mailgate3.nec.co.jp ([10.7.69.160]) by tyo202.gate.nec.co.jp (8.13.8/8.13.4) with ESMTP id s8UBH6oQ024876 for ; Tue, 30 Sep 2014 20:17:06 +0900 (JST) Received: from mailsv.nec.co.jp (imss62.nec.co.jp [10.7.69.157]) by mailgate3.nec.co.jp (8.11.7/3.7W-MAILGATE-NEC) with ESMTP id s8UBH6200987 for ; Tue, 30 Sep 2014 20:17:06 +0900 (JST) Received: from mail02.kamome.nec.co.jp (mail02.kamome.nec.co.jp [10.25.43.5]) by mailsv.nec.co.jp (8.13.8/8.13.4) with ESMTP id s8UBH6A6024645 for ; Tue, 30 Sep 2014 20:17:06 +0900 (JST) Received: from bpxc99gp.gisp.nec.co.jp ([10.38.151.141] [10.38.151.141]) by mail01b.kamome.nec.co.jp with ESMTP id BT-MMP-2225109; Tue, 30 Sep 2014 20:13:09 +0900 Received: from BPXM14GP.gisp.nec.co.jp ([169.254.1.136]) by BPXC13GP.gisp.nec.co.jp ([10.38.151.141]) with mapi id 14.03.0174.002; Tue, 30 Sep 2014 20:13:08 +0900 From: Hiroshi Shimamoto To: "dev@dpdk.org" Thread-Topic: [memnic PATCH v2 3/7] pmd: use helper macros Thread-Index: Ac/cn3n2FqYy9gPKQp6qx2mbmpjsAw== Date: Tue, 30 Sep 2014 11:13:08 +0000 Message-ID: <7F861DC0615E0C47A872E6F3C5FCDDBD02AE2665@BPXM14GP.gisp.nec.co.jp> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.205.5.123] MIME-Version: 1.0 Cc: Hayato Momma Subject: [dpdk-dev] [memnic PATCH v2 3/7] pmd: use helper macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Hiroshi Shimamoto Do not touch pktmbuf directly. Intead of direct access, use rte_pktmbuf_pkt_len() and rte_pktmbuf_data_len() to access the property. Signed-off-by: Hiroshi Shimamoto Reviewed-by: Hayato Momma --- pmd/pmd_memnic.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pmd/pmd_memnic.c b/pmd/pmd_memnic.c index bbb5380..872f3c4 100644 --- a/pmd/pmd_memnic.c +++ b/pmd/pmd_memnic.c @@ -308,8 +308,8 @@ static uint16_t memnic_recv_pkts(void *rx_queue, rte_memcpy(rte_pktmbuf_mtod(mb, void *), p->data, p->len); mb->pkt.in_port = q->port_id; - mb->pkt.pkt_len = p->len; - mb->pkt.data_len = p->len; + rte_pktmbuf_pkt_len(mb) = p->len; + rte_pktmbuf_data_len(mb) = p->len; rx_pkts[nr] = mb; pkts++; @@ -394,7 +394,7 @@ retry: ptr = p->data; for (sg = tx_pkts[nr]; sg; sg = sg->pkt.next) { void *src = rte_pktmbuf_mtod(sg, void *); - int data_len = sg->pkt.data_len; + int data_len = rte_pktmbuf_data_len(sg); rte_memcpy(ptr, src, data_len); ptr += data_len;