[dpdk-dev,v4,2/2] net/mlx5: fix TSO MLNX OFED 3.3 verification

Message ID 81890cca60b5f6a2921a314f29e6661588910977.1505643166.git.shacharbe@mellanox.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Shachar Beiser Sept. 17, 2017, 10:42 a.m. UTC
  Fixes: 3cf87e68d97b ("net/mlx5: remove old MLNX OFED 3.3 verification")
Cc: stable@dpdk.org

Signed-off-by: Shachar Beiser <shacharbe@mellanox.com>
---
I have rebased last patch [PATCH v3 2/2] net/mlx5: fix TSO MLNX OFED 3.3 verification
---
 drivers/net/mlx5/mlx5_prm.h | 3 ---
 1 file changed, 3 deletions(-)
  

Comments

Yongseok Koh Sept. 18, 2017, 5:52 p.m. UTC | #1
> On Sep 17, 2017, at 3:42 AM, Shachar Beiser <shacharbe@mellanox.com> wrote:
> 
> Fixes: 3cf87e68d97b ("net/mlx5: remove old MLNX OFED 3.3 verification")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Shachar Beiser <shacharbe@mellanox.com>
> ---
> I have rebased last patch [PATCH v3 2/2] net/mlx5: fix TSO MLNX OFED 3.3 verification
> ---
I think this patch had been acked by Nelio since v2.  Then you can keep
'Acked-by' tag through updated versions unless there's any change in the patch.

Acked-by: Yongseok Koh <yskoh@mellanox.com>

Thanks
Yongseok
  
Ferruh Yigit Sept. 22, 2017, 6:02 p.m. UTC | #2
On 9/18/2017 6:52 PM, Yongseok Koh wrote:
> 
>> On Sep 17, 2017, at 3:42 AM, Shachar Beiser <shacharbe@mellanox.com> wrote:
>>
>> Fixes: 3cf87e68d97b ("net/mlx5: remove old MLNX OFED 3.3 verification")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Shachar Beiser <shacharbe@mellanox.com>
>> ---
>> I have rebased last patch [PATCH v3 2/2] net/mlx5: fix TSO MLNX OFED 3.3 verification
>> ---
> I think this patch had been acked by Nelio since v2.  Then you can keep
> 'Acked-by' tag through updated versions unless there's any change in the patch.
> 
> Acked-by: Yongseok Koh <yskoh@mellanox.com>

This commit is fixing one that is within this release, so this commit
squashed into relevant one.

> 
> Thanks
> Yongseok
>
  

Patch

diff --git a/drivers/net/mlx5/mlx5_prm.h b/drivers/net/mlx5/mlx5_prm.h
index c61e4d8..e00be81 100644
--- a/drivers/net/mlx5/mlx5_prm.h
+++ b/drivers/net/mlx5/mlx5_prm.h
@@ -89,9 +89,6 @@ 
 /* Default max packet length to be inlined. */
 #define MLX5_EMPW_MAX_INLINE_LEN (4U * MLX5_WQE_SIZE)
 
-#ifndef HAVE_VERBS_MLX5_OPCODE_TSO
-#define MLX5_OPCODE_TSO MLX5_OPCODE_LSO_MPW /* Compat with OFED 3.3. */
-#endif
 
 #define MLX5_OPC_MOD_ENHANCED_MPSW 0
 #define MLX5_OPCODE_ENHANCED_MPSW 0x29