gpu: add support for rtx 6000 variant

Message ID BYAPR12MB359134D71AB0F853DCB1E9F8ABFC9@BYAPR12MB3591.namprd12.prod.outlook.com (mailing list archive)
State New
Delegated to: Thomas Monjalon
Headers
Series gpu: add support for rtx 6000 variant |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/iol-testing warning apply patch failure
ci/Intel-compilation warning apply issues

Commit Message

Cliff Burdick April 29, 2022, 4:52 p.m. UTC
  gpu: added second RTX 6000 device ID variant

Added second GPU PCI device ID for RTX 6000


Signed-off-by: Cliff Burdick <cburdick@nvidia.com<mailto:cburdick@nvidia.com>>
---
drivers/gpu/cuda/cuda.c    | 6 +++++-
drivers/gpu/cuda/devices.h | 3 ++-
2 files changed, 7 insertions(+), 2 deletions(-)

--
2.17.1
  

Comments

David Marchand Sept. 29, 2023, 2:55 p.m. UTC | #1
Hello,

On Fri, Apr 29, 2022 at 6:53 PM Cliff Burdick <cburdick@nvidia.com> wrote:
>
> Added second GPU PCI device ID for RTX 6000
>
> Signed-off-by: Cliff Burdick <cburdick@nvidia.com>
> ---
> drivers/gpu/cuda/cuda.c    | 6 +++++-
> drivers/gpu/cuda/devices.h | 3 ++-
> 2 files changed, 7 insertions(+), 2 deletions(-)

Is this patch still wanted?
It seems it fell through the cracks.

Cc: maintainers.
  
Elena Agostini Oct. 5, 2023, 12:50 p.m. UTC | #2
This patch makes sense to me and actually we should update the drivers/gpu/cuda/devices.h with all the new GPU devices ID
I don’t have an RTX 6000 GPU in my setup so I trust Cliff on the correctness of the ID

Thanks
EA

From: David Marchand <david.marchand@redhat.com>
Date: Friday, 29 September 2023 at 16:56
To: Cliff Burdick <cburdick@nvidia.com>
Cc: dev@dpdk.org <dev@dpdk.org>, Elena Agostini <eagostini@nvidia.com>, NBU-Contact-Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>
Subject: Re: [PATCH] gpu: add support for rtx 6000 variant
External email: Use caution opening links or attachments


Hello,

On Fri, Apr 29, 2022 at 6:53 PM Cliff Burdick <cburdick@nvidia.com> wrote:
>
> Added second GPU PCI device ID for RTX 6000
>
> Signed-off-by: Cliff Burdick <cburdick@nvidia.com>
> ---
> drivers/gpu/cuda/cuda.c    | 6 +++++-
> drivers/gpu/cuda/devices.h | 3 ++-
> 2 files changed, 7 insertions(+), 2 deletions(-)

Is this patch still wanted?
It seems it fell through the cracks.

Cc: maintainers.


--
David Marchand
  
David Marchand Oct. 6, 2023, 7:53 a.m. UTC | #3
On Thu, Oct 5, 2023 at 2:50 PM Elena Agostini <eagostini@nvidia.com> wrote:
>
> This patch makes sense to me and actually we should update the drivers/gpu/cuda/devices.h with all the new GPU devices ID
>
> I don’t have an RTX 6000 GPU in my setup so I trust Cliff on the correctness of the ID

Elena, please work with Cliff on a v2 with a release notes update and
ping me or Thomas once the patch is reviewed and ready for merge.

Thanks.
  

Patch

diff --git a/drivers/gpu/cuda/cuda.c b/drivers/gpu/cuda/cuda.c
index 5b8476ac20..d33e8e5116 100644
--- a/drivers/gpu/cuda/cuda.c
+++ b/drivers/gpu/cuda/cuda.c
@@ -197,8 +197,12 @@  static const struct rte_pci_id pci_id_cuda_map[] = {
        },
        {
                RTE_PCI_DEVICE(NVIDIA_GPU_VENDOR_ID,
-                               NVIDIA_GPU_QUADRO_RTX_6000)
+                               NVIDIA_GPU_QUADRO_RTX_6000_1)
        },
+       {
+               RTE_PCI_DEVICE(NVIDIA_GPU_VENDOR_ID,
+                               NVIDIA_GPU_QUADRO_RTX_6000_2)
+       },
        {
                RTE_PCI_DEVICE(NVIDIA_GPU_VENDOR_ID,
                                NVIDIA_GPU_QUADRO_RTX_8000)
diff --git a/drivers/gpu/cuda/devices.h b/drivers/gpu/cuda/devices.h
index e6502910f3..59933f0e49 100644
--- a/drivers/gpu/cuda/devices.h
+++ b/drivers/gpu/cuda/devices.h
@@ -52,7 +52,8 @@ 
#define NVIDIA_GPU_GV100_QUADRO_DEVICE_ID (0x1dba)
#define NVIDIA_GPU_QUADRO_RTX_4000 (0x1eb1)
#define NVIDIA_GPU_QUADRO_RTX_5000 (0x1eb0)
-#define NVIDIA_GPU_QUADRO_RTX_6000 (0x13d9)
+#define NVIDIA_GPU_QUADRO_RTX_6000_1 (0x13d9)
+#define NVIDIA_GPU_QUADRO_RTX_6000_2 (0x1e30)
#define NVIDIA_GPU_QUADRO_RTX_8000 (0x13d8)
#define NVIDIA_GPU_QUADRO_RTX_A4000 (0x24b0)
#define NVIDIA_GPU_QUADRO_RTX_A6000 (0x2230)