From patchwork Sat Aug 6 11:19:41 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matt X-Patchwork-Id: 15151 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id E42DE2BB3; Sat, 6 Aug 2016 13:20:03 +0200 (CEST) Received: from mail-it0-f65.google.com (mail-it0-f65.google.com [209.85.214.65]) by dpdk.org (Postfix) with ESMTP id 9A6069E7 for ; Sat, 6 Aug 2016 13:20:02 +0200 (CEST) Received: by mail-it0-f65.google.com with SMTP id f6so3255822ith.2 for ; Sat, 06 Aug 2016 04:20:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to:cc; bh=goNbshO8t6K89u/T/YviQURTYe7mKgK52Oy7szW0jSo=; b=MA7G6/bl+F7exrIPBryuOAkkQ8jKl/g4taDxiaXZcSt+OrCM6zXZczkujSMYKziVY/ x009qDmBYGziDdIiHIi0NpPSrJ8NgEEC6EG9rufLcg7RAj9iaWxCYQVFDzucxwjYEGkm 2ZWHfYIbmgi3kk8mFZJpSCVtaRwq81HUpcpoQ6Sg2UurxpfMMS2i8deCG7I2Hos/fKzV KKnAtD7f60lm9Gq+bwH0hFtY4C8OeLlUiosCqRc03kZ/9c8crWGDUknZI7uIfASO+FCQ OeSd8b8TFFhAu+sZ096Kgw55SK1zH/eDHgUJ+nSvHGre83RTOr8oy+ejueWVKNfdTEUG hpNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=goNbshO8t6K89u/T/YviQURTYe7mKgK52Oy7szW0jSo=; b=mo/5dVspwapWU8WUp0ta8QRhPFzxGgwQNPEZMpGoJH7iK6djNbaY8Lz6HawYrfx7dR FX4m2LNa5jX+r6N7clpJqZzSEavy9IkPYn8+HPPee8tLAiECWoEnKnPka/H9osXzCn4S ukGOMG3ROqhoX7si3NGRQ+KZMKOmWG80mXat0qSpd+rmXB03IP2E3vgMxc8KLFEm2e+P kz4wx4G6qe9rHFJnH3veUe0mmPWjHsKprPiY4GlqG2Mo9FuQg0VvFub4nveAfnFF6KWA ZCdZR4r8of8Rmpo0SUDzY/RaSyrxt3LryaVaEX1TDFoo9H1bF6Doy9hBxenlGgmyn5zY 0GMw== X-Gm-Message-State: AEkoouvqLAcHYpeHerX3iaXIO6FJeZZiwXm62YcwCgNZmveCMhJqS2/GShH9QudT7S5bzDS1yUJofHu23qJnBQ== X-Received: by 10.36.74.5 with SMTP id k5mr9244867itb.68.1470482402039; Sat, 06 Aug 2016 04:20:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.47.66 with HTTP; Sat, 6 Aug 2016 04:19:41 -0700 (PDT) From: =?UTF-8?B?5ZGo5p2o6LaF?= Date: Sat, 6 Aug 2016 19:19:41 +0800 Message-ID: To: dev@dpdk.org Cc: ferruh.yigit@intel.com Subject: [dpdk-dev] [PATCH] kni: error release device list head could cause a kernel crash. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From 3edca1e3194959ba26a6c36143f8423009661b11 Mon Sep 17 00:00:00 2001 From: zhouyangchao Date: Sat, 6 Aug 2016 19:14:51 +0800 Subject: [PATCH] kni: error release device list head could cause a kernel crash. Signed-off-by: zhouyangchao --- lib/librte_eal/linuxapp/kni/kni_misc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- diff --git a/lib/librte_eal/linuxapp/kni/kni_misc.c b/lib/librte_eal/linuxapp/kni/kni_misc.c index ae8133f..a49924b 100644 --- a/lib/librte_eal/linuxapp/kni/kni_misc.c +++ b/lib/librte_eal/linuxapp/kni/kni_misc.c @@ -276,8 +276,8 @@ kni_release(struct inode *inode, struct file *file) #ifdef RTE_KNI_VHOST kni_vhost_backend_release(dev); #endif - kni_dev_remove(dev); list_del(&dev->list); + kni_dev_remove(dev); } up_write(&knet->kni_list_lock); @@ -613,8 +613,8 @@ kni_ioctl_release(struct net *net, #ifdef RTE_KNI_VHOST kni_vhost_backend_release(dev); #endif - kni_dev_remove(dev); list_del(&dev->list); + kni_dev_remove(dev); ret = 0; break; }