From patchwork Thu Oct 5 15:19:04 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "De Lara Guarch, Pablo" X-Patchwork-Id: 29761 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 91D7E1B200; Thu, 5 Oct 2017 17:19:12 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 7AB032935 for ; Thu, 5 Oct 2017 17:19:10 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Oct 2017 08:19:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,481,1500966000"; d="scan'208";a="143112580" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga002.jf.intel.com with ESMTP; 05 Oct 2017 08:19:06 -0700 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 5 Oct 2017 16:19:05 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by irsmsx111.ger.corp.intel.com ([169.254.2.30]) with mapi id 14.03.0319.002; Thu, 5 Oct 2017 16:19:05 +0100 From: "De Lara Guarch, Pablo" To: Jan Blunck CC: "dev@dpdk.org" , "Doherty, Declan" Thread-Topic: [PATCH v2 3/4] cryptodev: rework PMD init to not require rte_vdev.h Thread-Index: AQHS+0lWkeSHr/Qkd06ZsxvLnGo6xKJUu5UQgFBi1zCAMK13gIAAFsEg Date: Thu, 5 Oct 2017 15:19:04 +0000 Message-ID: References: <20170712075940.58559-1-jblunck@infradead.org> <20170712195846.65286-1-jblunck@infradead.org> <20170712195846.65286-4-jblunck@infradead.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTcwZTQyZjMtMGZiZS00MTNiLTkyY2UtZGI1M2U3MTAzYTNmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlBSeGJNNHE0OHFWbWNQeFwvQ2pKSXh1elJQbkVuV25zaDBnRHlPaUV1RitBPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 3/4] cryptodev: rework PMD init to not require rte_vdev.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: jblunck@gmail.com [mailto:jblunck@gmail.com] On Behalf Of Jan > Blunck > Sent: Thursday, October 5, 2017 3:53 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Doherty, Declan > Subject: Re: [PATCH v2 3/4] cryptodev: rework PMD init to not require > rte_vdev.h > > On Mon, Sep 4, 2017 at 4:32 PM, De Lara Guarch, Pablo > wrote: > > Hi Jan, > > > >> -----Original Message----- > >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of De Lara Guarch, > >> Pablo > >> Sent: Saturday, July 15, 2017 12:05 PM > >> To: Jan Blunck ; dev@dpdk.org > >> Cc: Doherty, Declan > >> Subject: Re: [dpdk-dev] [PATCH v2 3/4] cryptodev: rework PMD init to > >> not require rte_vdev.h > >> > >> Hi > >> > >> > -----Original Message----- > >> > From: Jan Blunck [mailto:jblunck@gmail.com] On Behalf Of Jan Blunck > >> > Sent: Wednesday, July 12, 2017 8:59 PM > >> > To: dev@dpdk.org > >> > Cc: Doherty, Declan ; De Lara Guarch, > >> > Pablo > >> > Subject: [PATCH v2 3/4] cryptodev: rework PMD init to not require > >> > rte_vdev.h > >> > > >> > The rte_cryptodev_vdev_pmd_init() is a helper for vdev-based drivers. > >> > By moving the helper to the header we don't require rte_vdev.h at > >> > build- time of the librte_cryptodev library. This is a preparation > >> > to move the vdev bus into a standalone library. > >> > > >> > Signed-off-by: Jan Blunck > >> > >> I am seeing some clang errors when applying this patch: > >> > >> lib/librte_cryptodev/rte_cryptodev_vdev.h:88:14: error: implicit > >> declaration of function 'rte_cryptodev_pmd_allocate' is invalid in > >> C99 [- Werror,-Wimplicit-function-declaration] > >> cryptodev = rte_cryptodev_pmd_allocate(name, socket_id); > >> ^ > >> lib/librte_cryptodev/rte_cryptodev_vdev.h:88:12: error: incompatible > >> integer to pointer conversion assigning to 'struct rte_cryptodev *' from > 'int' > >> [-Werror,-Wint-conversion] > >> cryptodev = rte_cryptodev_pmd_allocate(name, socket_id); > >> > > Pablo, > > I can not reproduce this. There is already an include for > rte_cryptodev_pmd_allocate() in rte_cryptodev_vdev.h. Yes, but you are adding that header file in patch 4, so patch 3 fails. You should add it in patch 3: > > >> Also, looks like git commit title is not correct, according to check-git- > log.sh: > >> > >> Wrong headline format: > >> cryptodev: rework PMD init to not require rte_vdev.h > > > > This script complains about underscores ... Yes, could you reword it a bit? Instead of rte_vdev, use vdev header? > > Tell me what you think, > Jan Thanks, Pablo --- a/lib/librte_cryptodev/rte_cryptodev_vdev.h +++ b/lib/librte_cryptodev/rte_cryptodev_vdev.h @@ -36,6 +36,7 @@ #include #include +#include "rte_cryptodev_pmd.h" #include "rte_cryptodev.h" #define RTE_CRYPTODEV_VDEV_DEFAULT_MAX_NB_QUEUE_PAIRS 8