From patchwork Mon Aug 7 06:18:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Hascoet X-Patchwork-Id: 129931 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9590242FF6; Mon, 7 Aug 2023 08:18:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4AE9B410D3; Mon, 7 Aug 2023 08:18:47 +0200 (CEST) Received: from smtpout30.security-mail.net (smtpout30.security-mail.net [85.31.212.37]) by mails.dpdk.org (Postfix) with ESMTP id 8D16440A8B for ; Mon, 7 Aug 2023 08:18:45 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by fx301.security-mail.net (Postfix) with ESMTP id 6C858A84C59 for ; Mon, 7 Aug 2023 08:18:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kalrayinc.com; s=sec-sig-email; t=1691389125; bh=zeTQSzPnojzD/5CbjvJhPyegcrgJQ+8bBP+nhn/Qd1k=; h=From:To:Subject:Date; b=Ik1mu4z/mfX5hrDHHjmT9MliAUt+z8rfHT2M3tNvobb0VFrQKuwkCuqdvyfJ4DI1y L/DNs5CceYUVroagMQJIEpV+gKFvugNnhgR5CsYjF0Ds0nWPFXSkrJKQHZkZiaZ5Fd kvbtn/YN0eRIo1DRbniz/9OHyryTTiQl9IvizwQ4= Received: from fx301 (localhost [127.0.0.1]) by fx301.security-mail.net (Postfix) with ESMTP id 4EF58A8519A for ; Mon, 7 Aug 2023 08:18:45 +0200 (CEST) Received: from FRA01-MR2-obe.outbound.protection.outlook.com (mail-mr2fra01lp0105.outbound.protection.outlook.com [104.47.25.105]) by fx301.security-mail.net (Postfix) with ESMTPS id CE1C0A85035 for ; Mon, 7 Aug 2023 08:18:44 +0200 (CEST) Received: from MR1P264MB1729.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:5::17) by MR1P264MB2387.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:34::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Mon, 7 Aug 2023 06:18:43 +0000 Received: from MR1P264MB1729.FRAP264.PROD.OUTLOOK.COM ([fe80::77f5:4fc5:a7f9:f855]) by MR1P264MB1729.FRAP264.PROD.OUTLOOK.COM ([fe80::77f5:4fc5:a7f9:f855%7]) with mapi id 15.20.6652.026; Mon, 7 Aug 2023 06:18:43 +0000 X-Virus-Scanned: E-securemail Secumail-id: ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oEIchv2I5DsMtcJ8Ih6UNWLFms72+AxqBqBWP3aEArfpXVc5+OV18uYlE6GQqDQntYDT6coa+mh6ew3L1d+Q+5/ernV30sTU5lPqAl4wmXv3xFB0jeyzfNvK8phJyebGIUFcDZ+hpWwoW+659J1dAnZ6OUIddaHfiPVEe6Smu2NY3jcgqpGUTiVH2FkUAunPgYKPhfq+xr1tlNbY2orYoZ4JbYUwL5DG61ZSqf55SqqC1sunIjrY25MIe+5DxpoPedClO4o4IzUahWp0hNPDkwtR+j84f6JZH1v7TRhmlL85rLC3Tz7A5ULbBlyB+dzOpiP6WRoCJz3OKtwL1Amr4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VvCLtcdxRtyJajICt+quDaJELE/WyqhHK11RbsFPR/w=; b=h9WYxxGi1dkUr+b3WVBem4jKQLssBIcNYIcmRFL3kMyHm1k9DZDkh+4Cfwxj3ICIeHsIG3w/n7kF8ckZ4N7OCS15YCoj3F1BSPkfUEIbnid7tnhI4UlqHzFY4aa5/sEIv64Dybj5TL+AZ57ajKxCZfoj0UEzV28Z0Pil+rNwPXG5pxP7qX0CxJ9bYxeUA1IQsfj88ky4tw/rtb8dGlTvM/e/dZ9F9kkvzarlQZ9BunNq7DWyIPU9qP4UYcVh/1hWY8BHmnJf2n1c8+L4emef+C/XIrycRgW70cSClugjvCnGSITNkeDZqfKdbMR2fUCN3QlNv9QeY52NVhv+Jit5OQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=kalrayinc.com; dmarc=pass action=none header.from=kalrayinc.com; dkim=pass header.d=kalrayinc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kalrayinc.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VvCLtcdxRtyJajICt+quDaJELE/WyqhHK11RbsFPR/w=; b=Aja4FRcvVDkP4cbllPxMjLBcRXrUxb7zB3U51ladWKzF+jvwnXse5kQkJfxNzFMv8P7ajh+YHoMK/EzT7d8bjIlBPBjgwTp/YR3pm9GgAPTOxjEtxdTSnQAdrhf2RWPO3BsiRCVjXURX/3xSme3DF8BJWGcEFgAJgKWbS1vi6zrbIRYpcfRgKcvyavYDwnWwKFdxkzFiVDHGVn2/lHgfsKjJ40sA4c82OOkr035hzemu3dqriGYjWMhroRWNjIO+b4e7GLEq+vV2jPs+z2Mw1nIN7FTOUBUtnPRiLyr8QkBPMlc4jOvPa+MFnvzp3jO67w5bQSONIkqYNh1TEYLEyg== From: Julien Hascoet To: dev@dpdk.org Subject: [TEST] dpdk/app/test/test_mbuf.c test_refcnt_mbuf instability + fix proposal Thread-Topic: [TEST] dpdk/app/test/test_mbuf.c test_refcnt_mbuf instability + fix proposal Thread-Index: AQHZyPXqJYRcwSX/10G/C+IoeOYWlg== Date: Mon, 7 Aug 2023 06:18:43 +0000 Message-ID: Accept-Language: fr-FR, en-GB, en-US Content-Language: fr-fr X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=kalrayinc.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MR1P264MB1729:EE_|MR1P264MB2387:EE_ x-ms-office365-filtering-correlation-id: 47605b6e-365c-496c-2720-08db970e2661 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cZmSMSldCvwHaCZrJhN8DE4dYY6dSHE2HUZCzFFJVyVYULKmQFR39iXbCekZXX/TJvauHfsS0F+eOELeQgl2K6ott9CLTV3Rd16aMftK7G+SAynkacrzzPLR9mKptiRfvxSbu6iJQZ+6q7aXlsYhYGv6sucjUs4gQUblj1K21kd+gLSBD3p3IOWbxRhSt/4619YDGEt3nSeaaid2GcKUK4J2/N0qVcPeyUqapMaT43SVaAFd8M28CE8OrmwtNTA90R7nbwRUtfsSOXE608gvvheqzfmzfFBEjhIuoNjk5vLWDXriB1HwpBf9e+J1CJ7k5TggQ/gCmN0AH/RoV1WwvYGREQpx6heOUBDL5/4OSwe0gGbfePoJS2/wBGJuf5Ym5X9fqL9hQc2GC3dp9J3c0DecJ2dpPd61NvnP5fggfIHDP0yfSwcJB/MWOM4jwd/PXE0eiGuXqz/sOctCsLX4KmInwfjOT/cyvEIAUnHORNd7tIydksEQVWmsrSxIqCtunCEPi4kpMnJSef2gsw+QlsEMpbjtgJQrulW59ZRazHtUdwbx+au5GkO6+1brlJDMs1l/aaw9/BqTfdv5J1Yzjjc3UVD9x41MeVm15oOUDbYhfYMaXcNsrkp/zmMiIAmv x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MR1P264MB1729.FRAP264.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(136003)(396003)(346002)(376002)(366004)(451199021)(186006)(1800799003)(55016003)(19627405001)(9686003)(316002)(6916009)(86362001)(122000001)(478600001)(38100700002)(76116006)(71200400001)(66946007)(91956017)(64756008)(66556008)(66476007)(66446008)(33656002)(7696005)(6506007)(41300700001)(26005)(52536014)(38070700005)(8676002)(8936002)(4744005)(2906002)(83380400001)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: VGdX8gvsxVCKZY2ZgtUWPy6bhjP8YacnuPgNOS60shMd1jBISsPK1jeNcQ9H8o2pUb0/ey/q76ftKK4oSh/hrWR3Wb7dsXB5xJHEjYYWh97rhsyYtsqQvILQcEE2gwYPnFukpTUfGQgDpzK0jeqBl+Dx2Z3DcVvG4u2Tl/E2TaC0dv8NL+i2+wBFr4Pe2v+wVVakNco6S3272UVk4fvVixsXnWy1g/pFDU+Z9SHoFM504NsvCotHLpmfMIVBvjyBO9pEDlFT/CAAhix+ipF7ToayHDDUPa2pcqfUqvo9RRLDJ0whenXK3bYa6tBoGusTp/p0YkDzVLiGTuO/FY2vd7ICKEkuCk6OtlWbJb8pHDN2iQW0X8rB8z/TNdrs4gLihow3+oM+8Uh4UyI/yBxCWUBY1Ee7uRYcnQmxEyRp9GKgFvAGlw1csZz8ujLeOIAwDGGDK8pEwcY/WeV3Kl79IesvbxLPCn9vmIJUpsRRoFTS6/QgrJfScjL2AlaULyr/NRn50U10cEUG5wCj1tcPHU6Werw8jhuHEHizR+RdDpsMDR2lMccDl2Qya19nZ7SXDtez3Xvb7wCiK+Cyw6XUo8Y4DnIWiSVdYcJecAzBRs6FL49GiR/pXNPFFoGyy8qUovqGISBeqOso+sPvM7bl0+3YERKPCttrStTlyHM6xUYjbtm+WWQ8JMrZYvpAEF3ST7/IwwiNpRZEfN9UO1yAJFmT3ddG1gcnSYlwU2Ogda6435XmyXclXbTQeL8ux0d8Hc7wOQoIN1AQTYrUubPd8hm0sao3z8GdZHOTqT1aBbgaMfGFwbMxpTYObn5iJ4n5IYYlGWnagA49hxggaKGXovmWjBjtKWMykL8tbegc9V9Q0AHNLyYleS4JY3yg53uSmQAhBZhUIs76tMR/h5PcJrlbLTpMNL96qCtorePW9qE4HBAvLpgT7HUTa2oVWRtn t+hQ4U2ELnHX/fwJG2ipx4doBVA1Z6NJNxdw4YRN00RxrLK2oAMM5+ZGuJWwikcT4Cz6uFdmoLz2ttkSzHDEmyOfZCVBKILEGtN6lQ/KF+aOv2AYq035FpZFPtDTTLxKXX1rBLiOTOUwke8tZ1OYldge85mfnN45mJJTDvI/pwPFvdrBpLxixr5l4rggd8cfqyE8Ym8+mvHDB6ZJxqQHbLlf6EuPaRljn5bYmFzF2beaK4LQkJDOrXCBgi87kAPbFtM9M7tJdJvi9+r4RuiiX6JVyctETKSNKKnsw7j1F4M0XZPidZvW1e7txr9xtkPbyNusNj0y1G251UNTMC8aIc+hCDOfkGQrWiPX7FxnZvZ/Lag9aAe3ktA+ZuijiS1abNLtvgTnqVRBArfPY0lj8pbARBeMv5sONYpRW3QXFY3/9/pkWFyJ7a07rQnRw0UqQZ14GzUwF5KJaiBh+m+zxTyyqi567pxGC0K5Z0jOaRA+hvjk1cSnKbBIL6JfLQI7CEuBUD5Fvn+ZAxjyTz70rLjYEm6GnEbVf3Ze4Yuq4VTynlzmn1g9SFghgMZfHttwDtbSD0X1QL9sreNGaDbFe3f7NCJkGIKjNCudASAhvVokNPjrCRLF++H9DfM/ej6D MIME-Version: 1.0 X-OriginatorOrg: kalrayinc.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MR1P264MB1729.FRAP264.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 47605b6e-365c-496c-2720-08db970e2661 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Aug 2023 06:18:43.1920 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 8931925d-7620-4a64-b7fe-20afd86363d3 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fmeQ7v3muCe2BKIzH0ZBlAZTmsUhPS3TEYMp+2OCLPiBiMlMzBDGiWt3ef5zZUviGA1HRQdivwHM1KJV+6OH0g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MR1P264MB2387 X-ALTERMIMEV2_out: done X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello, from my understanding after debugging, in test_refcnt_iter the return value of rte_ring_enqueue is not checked; leading to lack of expected mbufs at the end checks. Here is some fix proposal that seems to work after running endurance tests for several days: Can you confirm ? Thank, Julien Hascoet diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c index b4f436b5e2..8a5d26e4f6 100644 --- a/app/test/test_mbuf.c +++ b/app/test/test_mbuf.c @@ -1033,12 +1033,17 @@ test_refcnt_iter(unsigned int lcore, unsigned int iter, tref += ref; if ((ref & 1) != 0) { rte_pktmbuf_refcnt_update(m, ref); - while (ref-- != 0) - rte_ring_enqueue(refcnt_mbuf_ring, m); + while (ref-- != 0) { + /* retry in case of failure */ + while (rte_ring_enqueue(refcnt_mbuf_ring, m) != 0) + ; + } } else { while (ref-- != 0) { rte_pktmbuf_refcnt_update(m, 1); - rte_ring_enqueue(refcnt_mbuf_ring, m); + /* retry in case of failure */ + while (rte_ring_enqueue(refcnt_mbuf_ring, m) != 0) + ; } } rte_pktmbuf_free(m);