diff mbox series

[Bug,1087,Bug] tcp data len is incorrectly calculated in gro_tcp4_reassemble function

Message ID bug-1087-3@http.bugs.dpdk.org/ (mailing list archive)
State Not Applicable, archived
Delegated to: Thomas Monjalon
Headers
Series [Bug,1087,Bug] tcp data len is incorrectly calculated in gro_tcp4_reassemble function |

Checks

Context Check Description
ci/Intel-compilation warning apply issues

Commit Message

bugzilla@dpdk.org Sept. 29, 2022, 1:40 a.m. UTC 
  https://bugs.dpdk.org/show_bug.cgi?id=1087

            Bug ID: 1087
           Summary: [Bug] tcp data len is incorrectly calculated in
                    gro_tcp4_reassemble function
           Product: DPDK
           Version: unspecified
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: other
          Assignee: dev@dpdk.org
          Reporter: 853048484@qq.com
  Target Milestone: ---

Hello:
In gro_tcp4_reassemble function, tcp data len is calculated:
tcp_dl = pkt->pkt_len - hdr_len;
https://github.com/DPDK/dpdk/blob/v22.07/lib/gro/gro_tcp4.c#L232

if packets < 60 bytes, pkt_len will contain padding bytes, tcp_dl is
incorrectly calculated. this will result the wrong data length after gro.

Comments

bugzilla@dpdk.org Nov. 10, 2022, 1:45 a.m. UTC | #1 
https://bugs.dpdk.org/show_bug.cgi?id=1087

jinag (853048484@qq.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from jinag (853048484@qq.com) ---
fixed by: 
https://github.com/DPDK/dpdk/commit/b8a55871d5af6f5b8694b1cb5eacbc629734e403
https://github.com/DPDK/dpdk/commit/72f51b097a71fb9bdea13bdd254ff620b34c852e
diff mbox series

Patch

diff --git a/lib/gro/gro_tcp4.c b/lib/gro/gro_tcp4.c index
7498c66141..cbba9fed5e 100644
--- a/lib/gro/gro_tcp4.c
+++ b/lib/gro/gro_tcp4.c
@@ -229,7 +229,7 @@  gro_tcp4_reassemble(struct rte_mbuf *pkt,
         * Don't process the packet whose payload length is less than or
         * equal to 0.
         */
-       tcp_dl = pkt->pkt_len - hdr_len;
+       tcp_dl = rte_be_to_cpu_16(ipv4_hdr->total_length) - hdr_len;
        if (tcp_dl <= 0)
                return -1;