diff mbox

[dpdk-dev] net/mlx5: removal already initialised mbuf fields

Message ID cb8b5bcefe50a79dc57f12f636ed8992fa831f7d.1496051062.git.nelio.laranjeiro@6wind.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Nélio Laranjeiro May 29, 2017, 9:45 a.m. UTC 
  Since commit 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool"), some
fields are already initialised and do not need to be modified by the PMD
anymore.

Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Acked-by: Shahaf Shuler <shahafs@mellanox.com>
---
 drivers/net/mlx5/mlx5_rxtx.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Adrien Mazarguil May 29, 2017, 1:30 p.m. UTC | #1 
On Mon, May 29, 2017 at 11:45:09AM +0200, Nelio Laranjeiro wrote:
> Since commit 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool"), some
> fields are already initialised and do not need to be modified by the PMD
> anymore.
> 
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> Acked-by: Shahaf Shuler <shahafs@mellanox.com>

Except for the title ("removal" => "remove"?),

Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Ferruh Yigit May 30, 2017, 12:39 p.m. UTC | #2 
On 5/29/2017 2:30 PM, Adrien Mazarguil wrote:
> On Mon, May 29, 2017 at 11:45:09AM +0200, Nelio Laranjeiro wrote:
>> Since commit 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool"), some
>> fields are already initialised and do not need to be modified by the PMD
>> anymore.
>>
>> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
>> Acked-by: Shahaf Shuler <shahafs@mellanox.com>
> 
> Except for the title ("removal" => "remove"?),
> 
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

Applied to dpdk-next-net/master, thanks.

(fixed title)
diff mbox

Patch

diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
index de6e0fa..d4ab7a8 100644
--- a/drivers/net/mlx5/mlx5_rxtx.c
+++ b/drivers/net/mlx5/mlx5_rxtx.c
@@ -2054,9 +2054,7 @@  mlx5_rx_burst(void *dpdk_rxq, struct rte_mbuf **pkts, uint16_t pkts_n)
 		DATA_LEN(rep) = DATA_LEN(seg);
 		PKT_LEN(rep) = PKT_LEN(seg);
 		SET_DATA_OFF(rep, DATA_OFF(seg));
-		NB_SEGS(rep) = NB_SEGS(seg);
 		PORT(rep) = PORT(seg);
-		NEXT(rep) = NULL;
 		(*rxq->elts)[idx] = rep;
 		/*
 		 * Fill NIC descriptor with the new buffer.  The lkey and size