From patchwork Fri May 3 13:57:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Burakov, Anatoly" X-Patchwork-Id: 139829 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 245A543F76; Fri, 3 May 2024 15:58:20 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E8FB2402E5; Fri, 3 May 2024 15:58:15 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by mails.dpdk.org (Postfix) with ESMTP id BE1DD402E1; Fri, 3 May 2024 15:58:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714744695; x=1746280695; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=pH5TlTdGXAg9O85La1eq6EPtkLVnpxXM+bYQy6K+eRI=; b=CkoUXPuCP8gLJJg9pYsst2ivFHZZmiuwvTePTamfwX3P3W4dxky0S1Ty dLTi59Kze40GXjo8L2hgZ102zQXygT+QTH0Q3lQwDaQEjGfCO1Svz5RYL c2GQqYSoAJePGMVXdg7MCvzD6eCISFu9l+XG6pjQPUIdD6oVBnEgXVDBT jgCL47jK77WjSXNbhnCHsRT+6pkSOdrse5u+z/aRUjPe0vz5JzYc4BuO7 L487R4N3WE/CsJ7xpp1BvPOXY1PAoSigA5RFxTsD47wcWkpjsZ8ge8Hwh uMRsQ/6VTci3rirJiUnbvduSgPTEF8cAoZF8NYOi2ylSRnploN9mxdAxg g==; X-CSE-ConnectionGUID: 6a8kqXtpQx+feBpD7BMpEA== X-CSE-MsgGUID: /OQteAP+Ql6TYhC/CTVWFg== X-IronPort-AV: E=McAfee;i="6600,9927,11063"; a="10714884" X-IronPort-AV: E=Sophos;i="6.07,251,1708416000"; d="scan'208";a="10714884" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 May 2024 06:58:14 -0700 X-CSE-ConnectionGUID: PPCNPlr9SQSplp0NtbVi5g== X-CSE-MsgGUID: sK2i2FZtTgWFo+ME1pOtcg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,251,1708416000"; d="scan'208";a="50641885" Received: from silpixa00401119.ir.intel.com ([10.55.129.167]) by fmviesa002.fm.intel.com with ESMTP; 03 May 2024 06:58:12 -0700 From: Anatoly Burakov To: dev@dpdk.org Cc: Piotr Pietruszewski , bruce.richardson@intel.com, vladimir.medvedkin@intel.com, stable@dpdk.org, Skajewski@dpdk.org, PiotrX , Marek Mical , Kirsher@dpdk.org, Jeffrey T , Michael@dpdk.org, Alice Subject: [PATCH v2 01/27] net/ixgbe/base: revert remove default advertising for x550 2.5G/5G Date: Fri, 3 May 2024 14:57:32 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Piotr Pietruszewski This reverts the following commit: 13de2444449e ("net/ixgbe/base: remove default advertising for x550 2.5G/5G") The commit removing advertising 2.5G and 5G speeds from ixgbe_get_copper_speeds_supported() was supposed to disable 2.5G and 5G during the autonegotiation with default settings. However, that change prevented OS-specific part of the driver from forcing these speeds at user request. This change reverts the commit and adds 2.5G and 5G as speeds supported by the X550. Cc: stable@dpdk.org Signed-off-by: Piotr Pietruszewski Reviewed-by: Skajewski, PiotrX Reviewed-by: Marek Mical Reviewed-by: Kirsher, Jeffrey T Reviewed-by: Michael, Alice --- drivers/net/ixgbe/base/ixgbe_phy.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ixgbe/base/ixgbe_phy.c b/drivers/net/ixgbe/base/ixgbe_phy.c index 74c5db16fa..3a8e603472 100644 --- a/drivers/net/ixgbe/base/ixgbe_phy.c +++ b/drivers/net/ixgbe/base/ixgbe_phy.c @@ -915,6 +915,10 @@ static s32 ixgbe_get_copper_speeds_supported(struct ixgbe_hw *hw) hw->phy.speeds_supported |= IXGBE_LINK_SPEED_100_FULL; switch (hw->mac.type) { + case ixgbe_mac_X550: + hw->phy.speeds_supported |= IXGBE_LINK_SPEED_2_5GB_FULL; + hw->phy.speeds_supported |= IXGBE_LINK_SPEED_5GB_FULL; + break; case ixgbe_mac_X550EM_x: case ixgbe_mac_X550EM_a: hw->phy.speeds_supported &= ~IXGBE_LINK_SPEED_100_FULL;