Checks
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | warning | coding style issues |
Commit Message
Anatoly Burakov
June 12, 2024, 3 p.m. UTC
From: Ian Stokes <ian.stokes@intel.com> Use proper bitmask to verify primary/secondary mode instead of whole 'mode' field, which also includes other information. In the result, for Mode 2a for example, 'secondary' mode was always reported which was misleading. Signed-off-by: Prathisna Padmasanan <prathisna.padmasanan@intel.com> Signed-off-by: Ian Stokes <ian.stokes@intel.com> --- drivers/net/ice/base/ice_common.c | 4 ++++ 1 file changed, 4 insertions(+)
Comments
On Wed, Jun 12, 2024 at 04:00:41PM +0100, Anatoly Burakov wrote: > From: Ian Stokes <ian.stokes@intel.com> > > Use proper bitmask to verify primary/secondary mode instead of whole 'mode' > field, which also includes other information. In the result, for Mode 2a for > example, 'secondary' mode was always reported which was misleading. > Commit log is not accurate for this, I think. Commit title alone is probably sufficient for such a simple change, or at most a one-line description of it. /Bruce > Signed-off-by: Prathisna Padmasanan <prathisna.padmasanan@intel.com> > Signed-off-by: Ian Stokes <ian.stokes@intel.com> > --- > drivers/net/ice/base/ice_common.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c > index 45fea193da..62c68b6d73 100644 > --- a/drivers/net/ice/base/ice_common.c > +++ b/drivers/net/ice/base/ice_common.c > @@ -2886,6 +2886,10 @@ ice_parse_nac_topo_dev_caps(struct ice_hw *hw, struct ice_hw_dev_caps *dev_p, > dev_p->nac_topo.mode = LE32_TO_CPU(cap->number); > dev_p->nac_topo.id = LE32_TO_CPU(cap->phys_id) & ICE_NAC_TOPO_ID_M; > > + ice_info(hw, "PF is configured in %s mode with IP instance ID %d\n", > + (dev_p->nac_topo.mode & ICE_NAC_TOPO_PRIMARY_M) ? > + "primary" : "secondary", dev_p->nac_topo.id); > + > ice_debug(hw, ICE_DBG_INIT, "dev caps: nac topology is_primary = %d\n", > !!(dev_p->nac_topo.mode & ICE_NAC_TOPO_PRIMARY_M)); > ice_debug(hw, ICE_DBG_INIT, "dev caps: nac topology is_dual = %d\n", > -- > 2.43.0 >
diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c index 45fea193da..62c68b6d73 100644 --- a/drivers/net/ice/base/ice_common.c +++ b/drivers/net/ice/base/ice_common.c @@ -2886,6 +2886,10 @@ ice_parse_nac_topo_dev_caps(struct ice_hw *hw, struct ice_hw_dev_caps *dev_p, dev_p->nac_topo.mode = LE32_TO_CPU(cap->number); dev_p->nac_topo.id = LE32_TO_CPU(cap->phys_id) & ICE_NAC_TOPO_ID_M; + ice_info(hw, "PF is configured in %s mode with IP instance ID %d\n", + (dev_p->nac_topo.mode & ICE_NAC_TOPO_PRIMARY_M) ? + "primary" : "secondary", dev_p->nac_topo.id); + ice_debug(hw, ICE_DBG_INIT, "dev caps: nac topology is_primary = %d\n", !!(dev_p->nac_topo.mode & ICE_NAC_TOPO_PRIMARY_M)); ice_debug(hw, ICE_DBG_INIT, "dev caps: nac topology is_dual = %d\n",