diff mbox series

[v1,1/1] iavf: document limitation on MTU

Message ID f5310a19f7d9aeb08aa5bf31f19fe59dafadbdd7.1710344183.git.anatoly.burakov@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Bruce Richardson
Headers
Series [v1,1/1] iavf: document limitation on MTU |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/github-robot: build success github build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS

Commit Message

Anatoly Burakov March 13, 2024, 3:43 p.m. UTC 
  When configuring a port, the configured MTU will
not include VLAN tag size, but the physical
function driver will add it automatically if the
port has VLAN filtering configured, which may
result in seemingly valid MTU to be rejected by
the PF.

Document the limitation.

Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
 doc/guides/nics/intel_vf.rst | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Bruce Richardson March 19, 2024, 12:14 p.m. UTC | #1 
On Wed, Mar 13, 2024 at 03:43:35PM +0000, Anatoly Burakov wrote:
> When configuring a port, the configured MTU will
> not include VLAN tag size, but the physical
> function driver will add it automatically if the
> port has VLAN filtering configured, which may
> result in seemingly valid MTU to be rejected by
> the PF.
> 
> Document the limitation.
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Bruce Richardson March 19, 2024, 3:15 p.m. UTC | #2 
On Tue, Mar 19, 2024 at 12:14:53PM +0000, Bruce Richardson wrote:
> On Wed, Mar 13, 2024 at 03:43:35PM +0000, Anatoly Burakov wrote:
> > When configuring a port, the configured MTU will
> > not include VLAN tag size, but the physical
> > function driver will add it automatically if the
> > port has VLAN filtering configured, which may
> > result in seemingly valid MTU to be rejected by
> > the PF.
> > 
> > Document the limitation.
> > 
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied to dpdk-next-net-intel

Thanks,
/Bruce
diff mbox series

Patch

diff --git a/doc/guides/nics/intel_vf.rst b/doc/guides/nics/intel_vf.rst
index ce2bd88cbe..78fd25bad4 100644
--- a/doc/guides/nics/intel_vf.rst
+++ b/doc/guides/nics/intel_vf.rst
@@ -730,3 +730,13 @@  and has this issue.
 
 Set the parameter `--force-max-simd-bitwidth` as 64/128/256
 to avoid selecting AVX-512 Tx path.
+
+ice: VLAN tag length not included in MTU
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+When configuring MTU for a VF, MTU must not include VLAN tag length. In
+practice, when kernel driver configures VLAN filtering for a VF, the VLAN
+header tag length will be automatically added to MTU when configuring queues.
+As a consequence, when attempting to configure a VF port with MTU that, together
+with a VLAN tag header, exceeds maximum supported MTU, port configuration will
+fail if kernel driver has configured VLAN filtering on that VF.