gpu/cuda: Add missing stdlib include
Checks
Commit Message
From: John Romein <romein@astron.nl>
getenv needs stdlib.h to be included.
Bugzilla ID: 1133
Fixes: 24c77594e08f ("gpu/cuda: map GPU memory with GDRCopy")
Signed-off-by: John Romein <romein@astron.nl>
---
NOTE: this is a post of https://github.com/DPDK/dpdk/pull/69 to the
mailing list.
drivers/gpu/cuda/gdrcopy.c | 2 ++
1 file changed, 2 insertions(+)
---
2.40.1
Comments
On Tue, Sep 26, 2023 at 8:24 PM Aaron Conole <aconole@redhat.com> wrote:
>
>
> From: John Romein <romein@astron.nl>
>
> getenv needs stdlib.h to be included.
>
> Bugzilla ID: 1133
>
> Fixes: 24c77594e08f ("gpu/cuda: map GPU memory with GDRCopy")
> Signed-off-by: John Romein <romein@astron.nl>
Thanks for the patch, it seems to be a duplicate of the prior patch
sent by Levend:
https://patchwork.dpdk.org/project/dpdk/patch/20230803162512.41396-1-levendsayar@gmail.com/
Ack
Thanks
EA
From: David Marchand <david.marchand@redhat.com>
Date: Friday, 29 September 2023 at 16:58
To: Aaron Conole <aconole@redhat.com>, John Romein <romein@astron.nl>
Cc: dev@dpdk.org <dev@dpdk.org>, Elena Agostini <eagostini@nvidia.com>, levendsayar@gmail.com <levendsayar@gmail.com>
Subject: Re: [PATCH] gpu/cuda: Add missing stdlib include
External email: Use caution opening links or attachments
On Tue, Sep 26, 2023 at 8:24 PM Aaron Conole <aconole@redhat.com> wrote:
>
>
> From: John Romein <romein@astron.nl>
>
> getenv needs stdlib.h to be included.
>
> Bugzilla ID: 1133
>
> Fixes: 24c77594e08f ("gpu/cuda: map GPU memory with GDRCopy")
> Signed-off-by: John Romein <romein@astron.nl>
Thanks for the patch, it seems to be a duplicate of the prior patch
sent by Levend:
https://patchwork.dpdk.org/project/dpdk/patch/20230803162512.41396-1-levendsayar@gmail.com/
--
David Marchand
Hello,
On Thu, Oct 5, 2023 at 2:44 PM Elena Agostini <eagostini@nvidia.com> wrote:
>
> Ack
Please, don't top post.
>
>
>
> Thanks
>
> EA
>
>
>
> From: David Marchand <david.marchand@redhat.com>
> Date: Friday, 29 September 2023 at 16:58
> To: Aaron Conole <aconole@redhat.com>, John Romein <romein@astron.nl>
> Cc: dev@dpdk.org <dev@dpdk.org>, Elena Agostini <eagostini@nvidia.com>, levendsayar@gmail.com <levendsayar@gmail.com>
> Subject: Re: [PATCH] gpu/cuda: Add missing stdlib include
>
> External email: Use caution opening links or attachments
>
>
> On Tue, Sep 26, 2023 at 8:24 PM Aaron Conole <aconole@redhat.com> wrote:
> >
> >
> > From: John Romein <romein@astron.nl>
> >
> > getenv needs stdlib.h to be included.
> >
> > Bugzilla ID: 1133
> >
> > Fixes: 24c77594e08f ("gpu/cuda: map GPU memory with GDRCopy")
> > Signed-off-by: John Romein <romein@astron.nl>
>
> Thanks for the patch, it seems to be a duplicate of the prior patch
> sent by Levend:
> https://patchwork.dpdk.org/project/dpdk/patch/20230803162512.41396-1-levendsayar@gmail.com/
As I mentionned, this is a duplicate and you just acked the other patch.
Please pay attention.
@@ -2,6 +2,8 @@
* Copyright (c) 2022 NVIDIA Corporation & Affiliates
*/
+#include <stdlib.h>
+
#include "common.h"
#ifdef DRIVERS_GPU_CUDA_GDRCOPY_H