From patchwork Tue Aug 1 16:54:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adrien Mazarguil X-Patchwork-Id: 27342 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id C604BA1F4; Tue, 1 Aug 2017 18:55:57 +0200 (CEST) Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 5F1DCA130 for ; Tue, 1 Aug 2017 18:55:28 +0200 (CEST) Received: by mail-wm0-f52.google.com with SMTP id t201so20257509wmt.1 for ; Tue, 01 Aug 2017 09:55:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references; bh=wdWESGN2zy7fWWa+HZmuje+KTmBqal4pLjQO/MKIM2s=; b=y89DrnHBN5/gzI7/7o5nBALbmty5Gen1ng2yRWTUvT9mVgwNd18U0RWxocUL5pK3bs yogcTQ3K2PJFIM9lSkLIEm48eMNLQ29V/45ky+rY4xVMgIC9+b71+s5+zz3z9LWLdB5W Vi0DQfTGpBm1ZToHEiHtk+zh2aqw4WJTl5jCcKY1dvw2k3P5Vh1JKDAKAPULzYaa4/aB 24Jen6lv4JsH4bo7Vzb4NmzjPP2AY1EdNBHDdVr6ruDSjMzKHcN3KeCXABJW4FwcBm0U JLJIHfotq6PM+ZkLzxbQAW/x1bWSiXj8PNp7cLKe2JskzTjvPA4Fan1ociXln0Sxouu0 BOQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=wdWESGN2zy7fWWa+HZmuje+KTmBqal4pLjQO/MKIM2s=; b=I/3VQuQ+z+LQKauoRccNWezbllaW+KrWvqU1rlYekhgOy8F3mA9Ewe6bnT74Qrc2hg rl6XrVkAOye6N/UVsGKvRqipNVLdfZhYKf9pU7qvKRQsaJfOsYddZXNb9U6OkO9Fst7L HuDk1enQPLDz9M0bmjR36uix13qfrXC9JLF6D0Nt8yqn8md+i/FwRm0hXUr0e2IQbFKj aRcMEf0rsQK5/f46WtFC1zU+Xd6Ti12Ze4BGun2wlJvJ0QkW9FCueD8baJls3tbQ61Ji UtKc4Zev2JZoC9gv+pMsQr2wrT0SqvrJHUXVH+HsuSMggabbpp0fVW8at5M4X78MrHvN XxsQ== X-Gm-Message-State: AIVw111qRng6PGEoiNyKmcfdIFlxKKB6Tl2NbHPKP1XPx67AuuK7LgBX Nbbr2X95bCaHv27yjoM= X-Received: by 10.28.43.6 with SMTP id r6mr1954723wmr.78.1501606527742; Tue, 01 Aug 2017 09:55:27 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 39sm39449008wrc.84.2017.08.01.09.55.26 for (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 01 Aug 2017 09:55:26 -0700 (PDT) From: Adrien Mazarguil To: dev@dpdk.org Date: Tue, 1 Aug 2017 18:54:13 +0200 Message-Id: X-Mailer: git-send-email 2.1.4 In-Reply-To: References: Subject: [dpdk-dev] [PATCH v1 26/48] net/mlx4: simplify link update function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Returning a different value when the current link status differs from the previous one was probably useful at some point in the past but is now meaningless; this value is ignored both internally (mlx4 PMD) and externally (ethdev wrapper). Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c index 5b7238e..7312482 100644 --- a/drivers/net/mlx4/mlx4.c +++ b/drivers/net/mlx4/mlx4.c @@ -2543,13 +2543,8 @@ mlx4_link_update(struct rte_eth_dev *dev, int wait_to_complete) ETH_LINK_HALF_DUPLEX : ETH_LINK_FULL_DUPLEX); dev_link.link_autoneg = !(dev->data->dev_conf.link_speeds & ETH_LINK_SPEED_FIXED); - if (memcmp(&dev_link, &dev->data->dev_link, sizeof(dev_link))) { - /* Link status changed. */ - dev->data->dev_link = dev_link; - return 0; - } - /* Link status is still the same. */ - return -1; + dev->data->dev_link = dev_link; + return 0; } /**