diff mbox series

examples/l2fwd-event: fix function args of worker cleanup

Message ID fdc89e404bfe8e67144fb2ca1073e029e0a44200.1670859887.git.sthotton@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series examples/l2fwd-event: fix function args of worker cleanup |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-testing fail Testing issues
ci/iol-x86_64-unit-testing fail Testing issues
ci/iol-aarch64-compile-testing success Testing PASS

Commit Message

Shijith Thotton Dec. 12, 2022, 3:48 p.m. UTC 
  Fixed function call arguments of l2fwd worker cleanup. Number of events
enqueued and dequeued are set the opposite.

Fixes: 622ebb6b4a7d ("examples/l2fwd-event: clean up worker state before exit")

Signed-off-by: Shijith Thotton <sthotton@marvell.com>
---
 examples/l2fwd-event/l2fwd_event.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Pavan Nikhilesh Bhagavatula Dec. 13, 2022, 3:13 p.m. UTC | #1 
> -----Original Message-----
> From: Shijith Thotton <sthotton@marvell.com>
> Sent: Monday, December 12, 2022 9:19 PM
> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> Cc: Shijith Thotton <sthotton@marvell.com>; dev@dpdk.org; Pavan
> Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
> Subject: [PATCH] examples/l2fwd-event: fix function args of worker cleanup
> 
> Fixed function call arguments of l2fwd worker cleanup. Number of events
> enqueued and dequeued are set the opposite.
> 
> Fixes: 622ebb6b4a7d ("examples/l2fwd-event: clean up worker state before
> exit")
Cc: stable@dpdk.org
> 
> Signed-off-by: Shijith Thotton <sthotton@marvell.com>
Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
>  examples/l2fwd-event/l2fwd_event.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/examples/l2fwd-event/l2fwd_event.c b/examples/l2fwd-
> event/l2fwd_event.c
> index 63450537fe..4b5a032e35 100644
> --- a/examples/l2fwd-event/l2fwd_event.c
> +++ b/examples/l2fwd-event/l2fwd_event.c
> @@ -284,7 +284,7 @@ l2fwd_event_loop_burst(struct l2fwd_resources
> *rsrc,
>  		}
>  	}
> 
> -	l2fwd_event_worker_cleanup(event_d_id, port_id, ev, nb_rx,
> nb_tx, 0);
> +	l2fwd_event_worker_cleanup(event_d_id, port_id, ev, nb_tx,
> nb_rx, 0);
>  }
> 
>  static __rte_always_inline void
> @@ -468,7 +468,7 @@ l2fwd_event_loop_vector(struct l2fwd_resources
> *rsrc, const uint32_t flags)
>  		}
>  	}
> 
> -	l2fwd_event_worker_cleanup(event_d_id, port_id, ev, nb_rx,
> nb_tx, 1);
> +	l2fwd_event_worker_cleanup(event_d_id, port_id, ev, nb_tx,
> nb_rx, 1);
>  }
> 
>  static void __rte_noinline
> --
> 2.25.1
Jerin Jacob Jan. 18, 2023, 10:30 a.m. UTC | #2 
On Tue, Dec 13, 2022 at 8:43 PM Pavan Nikhilesh Bhagavatula
<pbhagavatula@marvell.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Shijith Thotton <sthotton@marvell.com>
> > Sent: Monday, December 12, 2022 9:19 PM
> > To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> > Cc: Shijith Thotton <sthotton@marvell.com>; dev@dpdk.org; Pavan
> > Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
> > Subject: [PATCH] examples/l2fwd-event: fix function args of worker cleanup
> >
> > Fixed function call arguments of l2fwd worker cleanup. Number of events
> > enqueued and dequeued are set the opposite.
> >
> > Fixes: 622ebb6b4a7d ("examples/l2fwd-event: clean up worker state before
> > exit")
> Cc: stable@dpdk.org
> >
> > Signed-off-by: Shijith Thotton <sthotton@marvell.com>
> Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>

Applied to dpdk-next-net-eventdev/for-main. Thanks




> > ---
> >  examples/l2fwd-event/l2fwd_event.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/examples/l2fwd-event/l2fwd_event.c b/examples/l2fwd-
> > event/l2fwd_event.c
> > index 63450537fe..4b5a032e35 100644
> > --- a/examples/l2fwd-event/l2fwd_event.c
> > +++ b/examples/l2fwd-event/l2fwd_event.c
> > @@ -284,7 +284,7 @@ l2fwd_event_loop_burst(struct l2fwd_resources
> > *rsrc,
> >               }
> >       }
> >
> > -     l2fwd_event_worker_cleanup(event_d_id, port_id, ev, nb_rx,
> > nb_tx, 0);
> > +     l2fwd_event_worker_cleanup(event_d_id, port_id, ev, nb_tx,
> > nb_rx, 0);
> >  }
> >
> >  static __rte_always_inline void
> > @@ -468,7 +468,7 @@ l2fwd_event_loop_vector(struct l2fwd_resources
> > *rsrc, const uint32_t flags)
> >               }
> >       }
> >
> > -     l2fwd_event_worker_cleanup(event_d_id, port_id, ev, nb_rx,
> > nb_tx, 1);
> > +     l2fwd_event_worker_cleanup(event_d_id, port_id, ev, nb_tx,
> > nb_rx, 1);
> >  }
> >
> >  static void __rte_noinline
> > --
> > 2.25.1
>
diff mbox series

Patch

diff --git a/examples/l2fwd-event/l2fwd_event.c b/examples/l2fwd-event/l2fwd_event.c
index 63450537fe..4b5a032e35 100644
--- a/examples/l2fwd-event/l2fwd_event.c
+++ b/examples/l2fwd-event/l2fwd_event.c
@@ -284,7 +284,7 @@  l2fwd_event_loop_burst(struct l2fwd_resources *rsrc,
 		}
 	}
 
-	l2fwd_event_worker_cleanup(event_d_id, port_id, ev, nb_rx, nb_tx, 0);
+	l2fwd_event_worker_cleanup(event_d_id, port_id, ev, nb_tx, nb_rx, 0);
 }
 
 static __rte_always_inline void
@@ -468,7 +468,7 @@  l2fwd_event_loop_vector(struct l2fwd_resources *rsrc, const uint32_t flags)
 		}
 	}
 
-	l2fwd_event_worker_cleanup(event_d_id, port_id, ev, nb_rx, nb_tx, 1);
+	l2fwd_event_worker_cleanup(event_d_id, port_id, ev, nb_tx, nb_rx, 1);
 }
 
 static void __rte_noinline