[v2,1/6] bus/dpaa: fix the curly braces mismatch problem

Message ID tencent_426C785E4E2922F07558BE4346C445946309@qq.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [v2,1/6] bus/dpaa: fix the curly braces mismatch problem |

Checks

Context Check Description
ci/checkpatch warning coding style issues

Commit Message

Weiguo Li Feb. 7, 2022, 12:36 p.m. UTC
  Supplement the missing half of braces for the extern "C" block,
or remove the incomplete guard in internal header.

Fixes: 6d6b4f49a155 ("bus/dpaa: add FMAN hardware operations")
Fixes: 919eeaccb2ba ("bus/dpaa: introduce NXP DPAA bus driver skeleton")
Cc: shreyansh.jain@nxp.com

Signed-off-by: Weiguo Li <liwg06@foxmail.com>
---
 drivers/bus/dpaa/include/fsl_fman.h | 4 ----
 drivers/bus/dpaa/rte_dpaa_bus.h     | 4 ++++
 2 files changed, 4 insertions(+), 4 deletions(-)
  

Comments

Thomas Monjalon Feb. 8, 2022, 4:24 p.m. UTC | #1
07/02/2022 13:36, Weiguo Li:
> Supplement the missing half of braces for the extern "C" block,
> or remove the incomplete guard in internal header.
> 
> Fixes: 6d6b4f49a155 ("bus/dpaa: add FMAN hardware operations")
> Fixes: 919eeaccb2ba ("bus/dpaa: introduce NXP DPAA bus driver skeleton")
> Cc: shreyansh.jain@nxp.com
> 
> Signed-off-by: Weiguo Li <liwg06@foxmail.com>

Series applied, thanks.

It seems there are more useless C++ include guard in drivers and examples.
  

Patch

diff --git a/drivers/bus/dpaa/include/fsl_fman.h b/drivers/bus/dpaa/include/fsl_fman.h
index acb344584f..20690f8329 100644
--- a/drivers/bus/dpaa/include/fsl_fman.h
+++ b/drivers/bus/dpaa/include/fsl_fman.h
@@ -9,10 +9,6 @@ 
 
 #include <rte_compat.h>
 
-#ifdef __cplusplus
-extern "C" {
-#endif
-
 /* Status field in FD is updated on Rx side by FMAN with following information.
  * Refer to field description in FM BG.
  */
diff --git a/drivers/bus/dpaa/rte_dpaa_bus.h b/drivers/bus/dpaa/rte_dpaa_bus.h
index 31a5ea3fca..54bb1436fd 100644
--- a/drivers/bus/dpaa/rte_dpaa_bus.h
+++ b/drivers/bus/dpaa/rte_dpaa_bus.h
@@ -17,6 +17,10 @@ 
 #include <fsl_bman.h>
 #include <netcfg.h>
 
+#ifdef __cplusplus
+extern "C" {
+#endif
+
 /* This sequence number field is used to store event entry index for
  * driver specific usage. For parallel mode queues, invalid
  * index will be set and for atomic mode queues, valid value