From patchwork Fri Jan 28 09:43:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Weiguo Li X-Patchwork-Id: 106657 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B3ABA034D; Fri, 28 Jan 2022 10:43:52 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 435DB4284B; Fri, 28 Jan 2022 10:43:52 +0100 (CET) Received: from out162-62-57-252.mail.qq.com (out162-62-57-252.mail.qq.com [162.62.57.252]) by mails.dpdk.org (Postfix) with ESMTP id 25B2140141 for ; Fri, 28 Jan 2022 10:43:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1643363027; bh=Y+SaQWhgYMeCYVhjQHCGEzFWEMiWFzdnNp0GpXlJKqU=; h=From:To:Cc:Subject:Date; b=cE21wU4QZsu66xn3GB4SpHtHUK70eOpnHPoKjl42caTux0KV4D1aHJDimcuSUK8Yv cncW6F/CqKgdhZ616CV2XpZbmdlR3Q3vvUsEKszOpqwF1c1sJ+AuWb6Px5ptbgsRpz oIyF2vSOaqd/wg5ZtnA/JD+dzAJH9FjNx6fFLEdE= Received: from localhost.localdomain ([111.193.130.237]) by newxmesmtplogicsvrszc11.qq.com (NewEsmtp) with SMTP id ACFB76E0; Fri, 28 Jan 2022 17:43:15 +0800 X-QQ-mid: xmsmtpt1643362995txsdpsflc Message-ID: X-QQ-XMAILINFO: NhWS0W1hioO8B05VDQoG5zJCE4jZQndpPCgYZk/b/zbHICwTyDkIm69S66e+lf kq6jCZ8JqXzKovFxf5FSJgBJygGpwJ6EotcGnxVSJcC38fBjNoqasdH1fgf7STWMxnFA+6Bjs6dP LvloWCVIgvIOUrBsFBPYfhUJcmgGVIsBl3NLAip4Jr+aTIDq4f8kcEzdIkKo2TtOlciwW+WJ0yBC CwBxsBDsOLXXIcFu7eWdxyWW1J0avGhLNIes6kd1MRezfLz4ErAiN/tLo/eiyJ8epMwVL9DoqOfo 9m2LFOFT+6mTb2kgkE4Wmh6BSNUjW2eW35qDHNymKeFzKx8T+ZLPUytztsZXcSYK7bflb4dTeuCZ jmy0t11eN4hziP5Pscv+A4bDak/EgQFP/P3DNiMyRXifU8SB3UIS99uKaazGevNOyfnFCNe1fPu7 kdW/XQMyFxKC2XvBpEqnAJQDMIBevqdoulZlqIjCPqGWdk25HZeHCt0mu62KFXKWqmlj2xxfgOW4 CrbEuNxjBBztnyN80ft729zIOt1plliRzjOhwXtbvhrPn4wpdduPvAS9i9FGdG1mggUOqKh2V/+f SBgDD/UXnhgLwdUGfkZ+y8g+UHxscfx0uiut/VVMIAgMLM+YuCFHQE7Q2z6MOXKN1CQJPHW9A9IW AXELXFdtIzJgrPT4oSR1zbjZ4xjvpFEUCGKFkuWXFgA5aKolJVntT7O/Mk4MNvrDAE7vngtgRrzc fL0rSOpzfuuv1JHBOrGcxu5s/3eZQDcKsxOs0XU8Ro2ev+ZMYWYcrO7Zs7BIsjU4gqhozxUwsCoP xFu1TfjxdzNyugZGRs1vQMG4INt3R23/ehe2jG06HfSsgK2q37Tb4hSE0CFaTeSD7A8/agxoPidA == From: Weiguo Li To: jingjing.wu@intel.com Cc: radu.nicolau@intel.com, dev@dpdk.org Subject: [PATCH v2] net/iavf: fix null pointer dereference Date: Fri, 28 Jan 2022 17:43:15 +0800 X-OQ-MSGID: <20220128094315.48646-1-liwg06@foxmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Check for memory allocation failure is added to avoid null pointer dereference. Fixes: 6bc987ecb860 ("net/iavf: support IPsec inline crypto") Signed-off-by: Weiguo Li Acked-by: Radu Nicolau --- v2: * Update to keep coding style consistent --- drivers/net/iavf/iavf_ipsec_crypto.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/iavf/iavf_ipsec_crypto.c b/drivers/net/iavf/iavf_ipsec_crypto.c index adf101ab8a..6ac1b213db 100644 --- a/drivers/net/iavf/iavf_ipsec_crypto.c +++ b/drivers/net/iavf/iavf_ipsec_crypto.c @@ -1352,6 +1352,8 @@ iavf_ipsec_crypto_set_security_capabililites(struct iavf_security_ctx capabilities = rte_zmalloc("crypto_cap", sizeof(struct rte_cryptodev_capabilities) * (number_of_capabilities + 1), 0); + if (!capabilities) + return -ENOMEM; capabilities[number_of_capabilities].op = RTE_CRYPTO_OP_TYPE_UNDEFINED; /**