diff mbox series

[08/20] net/cnxk: free 'node' memory when node add fail

Message ID	tencent_A4F9A97D84BB4ED0B7C648B048680C0B0F06@qq.com (mailing list archive)
State	Changes Requested, archived
Delegated to:	David Marchand
Headers	Message-ID: <tencent_A4F9A97D84BB4ED0B7C648B048680C0B0F06@qq.com> From: Weiguo Li <liwg06@foxmail.com> To: dev@dpdk.org Cc: adypodoman@gmail.com, xiaoyun.li@intel.com, tianfei.zhang@intel.com, bruce.richardson@intel.com, ivan.malov@oktetlabs.ru, jgrajcia@cisco.com, hkalra@marvell.com, ying.a.wang@intel.com, ting.xu@intel.com, simei.su@intel.com, qiming.yang@intel.com, motih@mellanox.com, shreyansh.jain@nxp.com, skoteshwar@marvell.com, stephen@networkplumber.org, kalesh-anakkur.purayil@broadcom.com, somnath.kotur@broadcom.com, declan.doherty@intel.com, gakhil@marvell.com, nicolas.chautru@intel.com Subject: [PATCH 08/20] net/cnxk: free 'node' memory when node add fail Date: Wed, 23 Feb 2022 02:18:06 +0800 In-Reply-To: <cover.1645551559.git.liwg06@foxmail.com> References: <cover.1645551559.git.liwg06@foxmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: dev-bounces@dpdk.org
Series	fix memory leaks in error handling \| [00/20] fix memory leaks in error handling [01/20] baseband/acc100: fix a memory leak in acc100 queue setup [02/20] common/dpaax: fix a memory leak in iterate dir [03/20] crypto/dpaa2_sec: fix memory leaks in error handlings [04/20] crypto/qat: fix a memory leak when set encrypt key fail [05/20] net/bnxt: fix a memory leak in error handling [06/20] net/bnxt: fix 'ctx' memory leak when new malloc fail [07/20] net/bnx2x: add clean up for 'rxq' to avoid a memory leak [08/20] net/cnxk: free 'node' memory when node add fail [09/20] net/dpaa: fix a memory leak when validation fail [10/20] net/failsafe: fix a memory leak in error handling [11/20] net/iavf: fix a memory leak in error handling [12/20] net/ice: goto clean up lable to avoid memory leak [13/20] net/ice: fix memory leaks in error handlings [14/20] net/ice: avoid fix memory leaks in register parser [15/20] net/memif: fix some memory leaks in error handlings [16/20] net/sfc: fix a memory leak in error handling [17/20] net/vmxnet3: fix memory leaks in error handlings [18/20] raw/ifpga/base: fix memory leaks in error handlings [19/20] raw/ntb: fix some memory leaks in error handlings [20/20] regex/mlx5: fix a memory leak in error handling

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Weiguo Li Feb. 22, 2022, 6:18 p.m. UTC

  When node_add failed and function return, then the memory of 'node'
is leaked.

Fixes: 4435371b8fb1c0 ("net/cnxk: add TM shaper and node operations")

Signed-off-by: Weiguo Li <liwg06@foxmail.com>
---
 drivers/net/cnxk/cnxk_tm.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Nithin Dabilpuram April 7, 2022, 9:02 a.m. UTC | #1

Acked-by: Nithin Dabilpuram <ndabilpuram@marvell.com>

On 2/22/22 11:48 PM, Weiguo Li wrote:
> When node_add failed and function return, then the memory of 'node'
> is leaked.
> 
> Fixes: 4435371b8fb1c0 ("net/cnxk: add TM shaper and node operations")
> 
> Signed-off-by: Weiguo Li <liwg06@foxmail.com>
> ---
>   drivers/net/cnxk/cnxk_tm.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/cnxk/cnxk_tm.c b/drivers/net/cnxk/cnxk_tm.c
> index 9015a452f8..81afafd5b7 100644
> --- a/drivers/net/cnxk/cnxk_tm.c
> +++ b/drivers/net/cnxk/cnxk_tm.c
> @@ -389,6 +389,7 @@ cnxk_nix_tm_node_add(struct rte_eth_dev *eth_dev, uint32_t node_id,
>   	if (rc < 0) {
>   		error->type = roc_nix_tm_err_to_rte_err(rc);
>   		error->message = roc_error_msg_get(rc);
> +		rte_free(node);
>   		return rc;
>   	}
>   	error->type = RTE_TM_ERROR_TYPE_NONE;

diff mbox series

Patch

diff --git a/drivers/net/cnxk/cnxk_tm.c b/drivers/net/cnxk/cnxk_tm.c
index 9015a452f8..81afafd5b7 100644
--- a/drivers/net/cnxk/cnxk_tm.c
+++ b/drivers/net/cnxk/cnxk_tm.c
@@ -389,6 +389,7 @@  cnxk_nix_tm_node_add(struct rte_eth_dev *eth_dev, uint32_t node_id,
 	if (rc < 0) {
 		error->type = roc_nix_tm_err_to_rte_err(rc);
 		error->message = roc_error_msg_get(rc);
+		rte_free(node);
 		return rc;
 	}
 	error->type = RTE_TM_ERROR_TYPE_NONE;