From patchwork Tue Feb 22 18:18:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Weiguo Li X-Patchwork-Id: 108032 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9865AA034E; Tue, 22 Feb 2022 19:18:46 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 718B341151; Tue, 22 Feb 2022 19:18:42 +0100 (CET) Received: from out203-205-221-210.mail.qq.com (out203-205-221-210.mail.qq.com [203.205.221.210]) by mails.dpdk.org (Postfix) with ESMTP id CFFC741151 for ; Tue, 22 Feb 2022 19:18:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1645553916; bh=DwAvKDADkVs7IE7mcF2IcClCGLFw4Vxp4OYIJLQm0ok=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ETjQZWaJHAOAi+9b16GK8D4jEWSiofEHVZ1S5t6S+Ca3qI47G9OY0jh2ELo4IJ9rt OsgGX3+yZN/aLLtc4gIy5x0uASZ3gM6YuHcnd1iy3j4FpaC1USTj/GEkNBvxAPDKvL GQZSvCtgSoZuRMMYGs1jjNRN1eTsd34ON+yGOUDE= Received: from localhost.localdomain ([111.193.130.237]) by newxmesmtplogicsvrszc6.qq.com (NewEsmtp) with SMTP id 49223207; Wed, 23 Feb 2022 02:18:18 +0800 X-QQ-mid: xmsmtpt1645553911t0ea8ce31 Message-ID: X-QQ-XMAILINFO: N0opbxSOYLeWeBduHNMesvvziNPlPlQrGZXPoJHEFVsV5z5qKmUgf7FxBx8Xek zFC58AgK/moYF5cAE/5FXwyMWmbwUx9sGKycxJLBrZvXHjPdTT9z6nMXxJt94SsnUy7KEXWpr0UR PM0RozGvAs7ZXhfbjS8TlHJsLY93nvPKgyYk1gawnLnvcFyzx4D/6smGA6g+Bj+MMS88mc9E8tim DLjbEgNq77VvFzod9any9AULF3ZZw1ls4QsLGkq2uu/uI4L/VuK1nVunFXj+M2paCPW20Q8IHfwp +zq7ciiPl6IybDlc0qviTRSu2NYbSPlJBs/4FlDjmF7FFDrsE1sOf0ZkcVep3Olqdy2kNtq1E71V F3FqjH9+aIUZsoCbUa4AyWPd1ejaMhVgJYYpByEuXoYmX4ukRvb16d2BdASZGA7p6ik9xsvNkdzc yuNb/jRQ3fP/8qgjNNqAj1XUfMjzW+SM3gEp4/zQmzJIgWuPGT1QHedrehIMTNPrWOOkHiZY4J3o XCMhy66hgj4JPl3657b36ZfoONYZw3sEGKUirRe2f7OOqi78K+2e3lvvVW2GauWZ+jw55wmxacBt vklpDd/UoaLVdnKislZd9Bj+1hOqq1ZVfRikKty3ehxxwUnljsPKcwkLn0ygglbGUM0c7f4mYHpm YI/D06ro+hvhnzC2+5XRO0HggXxyMdrOQdObn6WFwsZRjvniFJRqR5I6HjfyvfOQLPkP5uYVqcUv SbLD4mvmHK34BPlxTbY7DKB1BUN9Ubq3Lc8vFC8yus0beYH92XninFNyCTmMEsmGDI+nGYOiXbVp Dv3VREW5CFPwpbEaa/UhTGV0TviEgZ86lefrH3TbwngDyFqGaAYY56Le0y/HZVgLR+1aux/fQg+Q == From: Weiguo Li To: dev@dpdk.org Cc: adypodoman@gmail.com, xiaoyun.li@intel.com, tianfei.zhang@intel.com, bruce.richardson@intel.com, ivan.malov@oktetlabs.ru, jgrajcia@cisco.com, hkalra@marvell.com, ying.a.wang@intel.com, ting.xu@intel.com, simei.su@intel.com, qiming.yang@intel.com, motih@mellanox.com, shreyansh.jain@nxp.com, skoteshwar@marvell.com, stephen@networkplumber.org, kalesh-anakkur.purayil@broadcom.com, somnath.kotur@broadcom.com, declan.doherty@intel.com, gakhil@marvell.com, nicolas.chautru@intel.com Subject: [PATCH 02/20] common/dpaax: fix a memory leak in iterate dir Date: Wed, 23 Feb 2022 02:18:00 +0800 X-OQ-MSGID: <8a17d8a3d16cf860a62a48782da19cb78fc27853.1645551559.git.liwg06@foxmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When process_dir() fails, the memory to 'subdir' was not freed which caused a memory leak. Fixes: 2183c6f69d7e ("bus/dpaa: add OF parser for device scanning") Signed-off-by: Weiguo Li --- drivers/common/dpaax/dpaa_of.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/common/dpaax/dpaa_of.c b/drivers/common/dpaax/dpaa_of.c index bb2c8fc66b..a827b42efa 100644 --- a/drivers/common/dpaax/dpaa_of.c +++ b/drivers/common/dpaax/dpaa_of.c @@ -126,8 +126,10 @@ iterate_dir(struct dirent **d, int num, struct dt_dir *dt) d[loop]->d_name); subdir->parent = dt; ret = process_dir(subdir->node.node.full_name, subdir); - if (ret) + if (ret) { + free(subdir); return ret; + } list_add_tail(&subdir->node.list, &dt->subdirs); break; default: