diff mbox series

[V1] tests/telemetry: adapt meson build

Message ID 1616479476-9464-1-git-send-email-junx.w.zhou@intel.com (mailing list archive)
State Changes Requested
Headers
Series [V1] tests/telemetry: adapt meson build |

Commit Message

Zhou, JunX W March 23, 2021, 6:04 a.m. UTC 
  adapt meson build, need modify compile parameter and recompile
 for test

Signed-off-by: Zhou Jun <junx.w.zhou@intel.com>
---
 tests/TestSuite_telemetry.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Zhou, JunX W March 23, 2021, 6:11 a.m. UTC | #1 
>-----Original Message-----
>From: Zhou, JunX W 
>Sent: Tuesday, March 23, 2021 2:05 PM
>To: dts@dpdk.org
>Cc: Zhou, JunX W <junx.w.zhou@intel.com>
>Subject: [dts][PATCH V1] tests/telemetry: adapt meson build
>
>adapt meson build, need modify compile parameter and recompile  for test
>
>Signed-off-by: Zhou Jun <junx.w.zhou@intel.com>

Tested-by: Zhou, Jun <junx.w.zhou@intel.com>
Zhao, HaiyangX March 23, 2021, 9:53 a.m. UTC | #2 
> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Zhou, JunX W
> Sent: Tuesday, March 23, 2021 14:11
> To: dts@dpdk.org
> Subject: Re: [dts] [PATCH V1] tests/telemetry: adapt meson build
> 
> >-----Original Message-----
> >From: Zhou, JunX W
> >Sent: Tuesday, March 23, 2021 2:05 PM
> >To: dts@dpdk.org
> >Cc: Zhou, JunX W <junx.w.zhou@intel.com>
> >Subject: [dts][PATCH V1] tests/telemetry: adapt meson build
> >
> >adapt meson build, need modify compile parameter and recompile  for test
> >
> >Signed-off-by: Zhou Jun <junx.w.zhou@intel.com>
> 
> Tested-by: Zhou, Jun <junx.w.zhou@intel.com>

Acked-by: Haiyang Zhao <haiyangx.zhao@intel.com>
Tu, Lijuan March 25, 2021, 5:55 a.m. UTC | #3 
> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Zhou Jun
> Sent: 2021年3月23日 14:05
> To: dts@dpdk.org
> Cc: Zhou, JunX W <junx.w.zhou@intel.com>
> Subject: [dts] [PATCH V1] tests/telemetry: adapt meson build
> 
> adapt meson build, need modify compile parameter and recompile  for test
> 
> Signed-off-by: Zhou Jun <junx.w.zhou@intel.com>
> ---
>  tests/TestSuite_telemetry.py | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_telemetry.py b/tests/TestSuite_telemetry.py index
> 7e474bc..8de8fb6 100644
> --- a/tests/TestSuite_telemetry.py
> +++ b/tests/TestSuite_telemetry.py
> @@ -49,6 +49,7 @@ class TestTelemetry(TestCase):
> 
> "'s/CONFIG_RTE_LIBRTE_TELEMETRY=n/CONFIG_RTE_LIBRTE_TELEMETRY=y/g
> '"
>              " {}/config/common_base").format(self.target_dir)
>          self.d_a_console(cmd)
> +        self.dut.set_build_options({'RTE_LIBRTE_TELEMETRY': 'y'})

Duplicated with your old method, please remove it, thanks

> 
>      def create_query_script(self):
>          '''
> @@ -588,7 +589,8 @@ class TestTelemetry(TestCase):
>          """
>          Run after each test suite.
>          """
> -        pass
> +        self.dut.set_build_options({'RTE_LIBRTE_TELEMETRY': 'n'})
> +        self.dut.build_install_dpdk(self.target)
> 
>      def test_basic_connection(self):
>          '''
> --
> 1.8.3.1
diff mbox series

Patch

diff --git a/tests/TestSuite_telemetry.py b/tests/TestSuite_telemetry.py
index 7e474bc..8de8fb6 100644
--- a/tests/TestSuite_telemetry.py
+++ b/tests/TestSuite_telemetry.py
@@ -49,6 +49,7 @@  class TestTelemetry(TestCase):
             "'s/CONFIG_RTE_LIBRTE_TELEMETRY=n/CONFIG_RTE_LIBRTE_TELEMETRY=y/g'"
             " {}/config/common_base").format(self.target_dir)
         self.d_a_console(cmd)
+        self.dut.set_build_options({'RTE_LIBRTE_TELEMETRY': 'y'})
 
     def create_query_script(self):
         '''
@@ -588,7 +589,8 @@  class TestTelemetry(TestCase):
         """
         Run after each test suite.
         """
-        pass
+        self.dut.set_build_options({'RTE_LIBRTE_TELEMETRY': 'n'})
+        self.dut.build_install_dpdk(self.target)
 
     def test_basic_connection(self):
         '''