[V1] tests/checksum_offload: Bugfix for bug 529
Commit Message
added missing quote in template for scapy packets.
Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
---
tests/TestSuite_checksum_offload.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
Hi, owen
Can you send a tested-by of this patch base on self-test and the result is pass,
It is best to upload the test log at same time.
Regards,
Ma,lihong
> -----Original Message-----
> From: Owen Hilyard <ohilyard@iol.unh.edu>
> Sent: Friday, September 4, 2020 3:13 PM
> To: dts@dpdk.org; Ma, LihongX <lihongx.ma@intel.com>
> Cc: Zhang, XiX <xix.zhang@intel.com>; Zhang, XuemingX
> <xuemingx.zhang@intel.com>; ohilyard@iol.unh.edu
> Subject: [dts][PATCH V1] tests/checksum_offload: Bugfix for bug 529
>
> added missing quote in template for scapy packets.
>
> Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
> ---
> tests/TestSuite_checksum_offload.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/TestSuite_checksum_offload.py
> b/tests/TestSuite_checksum_offload.py
> index c4a877d..ef7a9de 100644
> --- a/tests/TestSuite_checksum_offload.py
> +++ b/tests/TestSuite_checksum_offload.py
> @@ -374,7 +374,7 @@ class TestChecksumOffload(TestCase):
> def replay_pcap_file_on_tester(self, iface, packet_file_path):
> self.tester.send_expect("scapy", ">>>")
> self.scapy_exec(f"packets = rdpcap('{packet_file_path}')")
> - self.scapy_exec(f"sendp(packets, iface={iface})")
> + self.scapy_exec(f"sendp(packets, iface='{iface}')")
> self.tester.send_expect("quit()", "# ")
>
> def validate_packet_list_checksums(self, packets):
> @@ -703,7 +703,7 @@ class TestChecksumOffload(TestCase):
> for l4 in l4_protos:
> for chksum in "", "chksum=0xf":
> vf =
> self.send_pkt_expect_good_bad_from_flag_catch_failure(
> - f"eth/IP({chksum})/{l4}()/(X'*50)",
> + f"eth/IP({chksum})/{l4}()/('X'*50)",
> "PKT_RX_IP_CKSUM_", f"{l4}",
> should_pass=(chksum == ""))
> if vf is not None:
> --
> 2.25.1
@@ -374,7 +374,7 @@ class TestChecksumOffload(TestCase):
def replay_pcap_file_on_tester(self, iface, packet_file_path):
self.tester.send_expect("scapy", ">>>")
self.scapy_exec(f"packets = rdpcap('{packet_file_path}')")
- self.scapy_exec(f"sendp(packets, iface={iface})")
+ self.scapy_exec(f"sendp(packets, iface='{iface}')")
self.tester.send_expect("quit()", "# ")
def validate_packet_list_checksums(self, packets):
@@ -703,7 +703,7 @@ class TestChecksumOffload(TestCase):
for l4 in l4_protos:
for chksum in "", "chksum=0xf":
vf = self.send_pkt_expect_good_bad_from_flag_catch_failure(
- f"eth/IP({chksum})/{l4}()/(X'*50)",
+ f"eth/IP({chksum})/{l4}()/('X'*50)",
"PKT_RX_IP_CKSUM_", f"{l4}",
should_pass=(chksum == ""))
if vf is not None: