[V2] framework/pmd_output:start_testpmd interface support expected params

Message ID 20210202142340.3877630-1-weix.ling@intel.com (mailing list archive)
State Accepted
Headers
Series [V2] framework/pmd_output:start_testpmd interface support expected params |

Commit Message

Ling, WeiX Feb. 2, 2021, 2:23 p.m. UTC
  v1:
In DPDK 9af79db20f4cf,when launch virtio-user testpmd as server mode,
 virtio-user server side testpmd expected character will be 
'wait for client side started...', after client side started, 
it change to 'testpmd>'.

v2:
Modify patch comments style issues.

Signed-off-by: Ling Wei <weix.ling@intel.com>
---
 framework/pmd_output.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
  

Comments

Ling, WeiX Feb. 2, 2021, 6:34 a.m. UTC | #1
Tested-by: Wei Ling <weix.ling@intel.com>

Regards,
Ling Wei

> -----Original Message-----
> From: Ling Wei <weix.ling@intel.com>
> Sent: Tuesday, February 2, 2021 10:24 PM
> To: dts@dpdk.org
> Cc: Ling, WeiX <weix.ling@intel.com>
> Subject: [dts][PATCH V2] framework/pmd_output:start_testpmd interface
> support expected params
  
Wang, Yinan Feb. 2, 2021, 1:48 p.m. UTC | #2
Acked-by: Wang, Yinan <yinan.wang@intel.com>

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Ling, WeiX
> Sent: 2021?2?2? 14:35
> To: Ling, WeiX <weix.ling@intel.com>; dts@dpdk.org
> Subject: Re: [dts] [PATCH V2] framework/pmd_output:start_testpmd interface
> support expected params
> 
> Tested-by: Wei Ling <weix.ling@intel.com>
> 
> Regards,
> Ling Wei
> 
> > -----Original Message-----
> > From: Ling Wei <weix.ling@intel.com>
> > Sent: Tuesday, February 2, 2021 10:24 PM
> > To: dts@dpdk.org
> > Cc: Ling, WeiX <weix.ling@intel.com>
> > Subject: [dts][PATCH V2] framework/pmd_output:start_testpmd interface
> > support expected params
  
Tu, Lijuan Feb. 3, 2021, 6:21 a.m. UTC | #3
> v1:
> In DPDK 9af79db20f4cf,when launch virtio-user testpmd as server mode,  virtio-
> user server side testpmd expected character will be 'wait for client side
> started...', after client side started, it change to 'testpmd>'.
> 
> v2:
> Modify patch comments style issues.
> 
> Signed-off-by: Ling Wei <weix.ling@intel.com>

Applied, thanks
  

Patch

diff --git a/framework/pmd_output.py b/framework/pmd_output.py
index 3daa86b..1ad4ce7 100644
--- a/framework/pmd_output.py
+++ b/framework/pmd_output.py
@@ -103,7 +103,7 @@  class PmdOutput():
     def get_pmd_cmd(self):
         return self.command
 
-    def start_testpmd(self, cores='default', param='', eal_param='', socket=0, fixed_prefix=False, **config):
+    def start_testpmd(self, cores='default', param='', eal_param='', socket=0, fixed_prefix=False, expected='testpmd> ', **config):
         """
         start testpmd with input parameters.
         :param cores: eg:
@@ -148,7 +148,7 @@  class PmdOutput():
         command = command.replace('  ', ' ')
         if self.session != self.dut:
             self.session.send_expect("cd %s" % self.dut.base_dir, "# ")
-        out = self.session.send_expect(command, "testpmd> ", 120)
+        out = self.session.send_expect(command, expected, 120)
         self.command = command
         # wait 10s to ensure links getting up before test start.
         sleep(10)