[V3,2/2] tests/checksum_offload: checksum suite script and testplan optimization

Message ID 20220923055321.23361-2-weiyuanx.li@intel.com (mailing list archive)
State Accepted
Headers
Series [V3,1/2] test_plans/checksum_offload: checksum suite script and testplan optimization |

Checks

Context Check Description
ci/Intel-dts-format-test success Testing OK
ci/Intel-dts-pylama-test success Testing OK
ci/Intel-dts-doc-test success Testing OK
ci/Intel-dts-suite-test success Testing OK

Commit Message

Weiyuan Li Sept. 23, 2022, 5:53 a.m. UTC
  Optimize the test case name to match test plan, add test case in test
plan to map test suite and delete the cmd "tx_checksum set 0x0 0" using "csum set".

Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
---
Tested-by: Lingli Chen <linglix.chen@intel.com>
Acked-by: Fu, Qi <qi.fu@intel.com>

v2:
-modify test plan delete IXIA description.
v3:
-delete case "Validate checksum on the receive packet".
-optimize the case in the test plan enable csum to used "csum set
ip|tcp|udp|sctp hw 0.
-optimzie the test steps of cases in the test plan change from IXIA to
scapy.

 tests/TestSuite_checksum_offload.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
  

Comments

Tu, Lijuan Oct. 10, 2022, 3:21 a.m. UTC | #1
On Fri, 23 Sep 2022 13:53:21 +0800, Weiyuan Li <weiyuanx.li@intel.com> wrote:
> Optimize the test case name to match test plan, add test case in test
> plan to map test suite and delete the cmd "tx_checksum set 0x0 0" using "csum set".
> 
> Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>

Acked-by: Lijuan Tu <lijuan.tu@intel.com>
Series applied, thanks
  

Patch

diff --git a/tests/TestSuite_checksum_offload.py b/tests/TestSuite_checksum_offload.py
index 1ccc884c..b181bf37 100644
--- a/tests/TestSuite_checksum_offload.py
+++ b/tests/TestSuite_checksum_offload.py
@@ -605,7 +605,7 @@  class TestChecksumOffload(TestCase):
         # send the packet checksum value different from the expected value
         self.checksum_valid_flags(pkts_bad, 0)
 
-    def test_checksum_offload_enable(self):
+    def test_insert_checksum_on_the_transmit_packet(self):
         """
         Insert IPv4/IPv6 UDP/TCP/SCTP checksum on the transmit packet.
         Enable Checksum offload.
@@ -654,7 +654,7 @@  class TestChecksumOffload(TestCase):
 
         self.verify(len(result) == 0, ",".join(list(result.values())))
 
-    def test_checksum_offload_disable(self):
+    def test_do_not_insert_checksum_on_the_transmit_packet(self):
         """
         Do not insert IPv4/IPv6 UDP/TCP checksum on the transmit packet.
         Disable Checksum offload.