[V2] test_plans/ieee1588: according to dts script compile ieee1588 update testplan

Message ID 20221019010615.49882-1-linglix.chen@intel.com (mailing list archive)
State Accepted
Headers
Series [V2] test_plans/ieee1588: according to dts script compile ieee1588 update testplan |

Checks

Context Check Description
ci/Intel-dts-pylama-test success Testing OK
ci/Intel-dts-doc-test success Testing OK
ci/Intel-dts-suite-test warning SKIPPED
ci/Intel-dts-format-test success Testing OK

Commit Message

Lingli Chen Oct. 19, 2022, 1:06 a.m. UTC
  Modify build extra options, start testpmd parameters sync with script.

Signed-off-by: Lingli Chen <linglix.chen@intel.com>
---
V2:add some description about '--tx-offloads=0x00008000'

 test_plans/ieee1588_test_plan.rst | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
  

Comments

Huang, ZhiminX Oct. 21, 2022, 1:53 a.m. UTC | #1
> -----Original Message-----
> From: Chen, LingliX <linglix.chen@intel.com>
> Sent: Wednesday, October 19, 2022 9:06 AM
> To: dts@dpdk.org
> Cc: Huang, ZhiminX <zhiminx.huang@intel.com>; Chen, LingliX
> <linglix.chen@intel.com>
> Subject: [dts][PATCH V2] test_plans/ieee1588: according to dts script compile
> ieee1588 update testplan
> 
> Modify build extra options, start testpmd parameters sync with script.
> 
> Signed-off-by: Lingli Chen <linglix.chen@intel.com>
> ---
> V2:add some description about '--tx-offloads=0x00008000'
> 
Acked-by: Zhimin Huang <zhiminx.huang@intel.com >
  
Tu, Lijuan Nov. 18, 2022, 8:08 a.m. UTC | #2
On Tue, 18 Oct 2022 21:06:15 -0400, Lingli Chen <linglix.chen@intel.com> wrote:
> Modify build extra options, start testpmd parameters sync with script.
> 
> Signed-off-by: Lingli Chen <linglix.chen@intel.com>


Applied, thanks
  

Patch

diff --git a/test_plans/ieee1588_test_plan.rst b/test_plans/ieee1588_test_plan.rst
index 94c56edf..285ca306 100644
--- a/test_plans/ieee1588_test_plan.rst
+++ b/test_plans/ieee1588_test_plan.rst
@@ -52,7 +52,9 @@  to the device under test::
    usertools/dpdk-devbind.py --bind=vfio-pci device_bus_id
 
 The support of the IEEE1588 Precise Time Protocol in Poll Mode Drivers must
-be configured at compile-time with the ``CONFIG_RTE_LIBRTE_IEEE1588`` option.
+be configured at compile-time with the ``DRTE_LIBRTE_IEEE1588`` option::
+
+   CC=gcc meson -Denable_kmods=True -Dlibdir=lib -Dc_args=-DRTE_LIBRTE_IEEE1588 --default-library=static x86_64-native-linuxapp-gcc
 
 Configure the packet format for the traffic generator to be IEEE1588 PTP
 Ethernet type ``0x88F7`` and containing PTP ``SYNC`` (version 2 at offset 1,
@@ -60,10 +62,11 @@  and message ID 0 at offset 0).
 
 Start the ``testpmd`` application with the following parameters::
 
-   -cffffff -n 3 -- -i --rxpt=0 --rxht=0 --rxwt=0 \
-   --txpt=39 --txht=0 --txwt=0
+   -cffffff -n 3 -- -i --tx-offloads=0x00008000
 
 The -n command is used to select the number of memory channels. It should match the number of memory channels on that setup.
+--tx-offloads: for IEEE1588, the full-feature tx path needs to be enabled. Enabling any tx offload will force DPDK utilize full tx path.
+Enabling multiple segment offload is more reasonable for user cases.
 
 Test Case: Enable IEEE1588 PTP packet reception and generation
 ==============================================================