diff mbox series

[V1] tests/ice_iavf_fdir: optimize scripts

Message ID 20221215140011.14633-1-hongbox.li@intel.com (mailing list archive)
State Accepted
Headers
Series [V1] tests/ice_iavf_fdir: optimize scripts |

Checks

Context Check Description
ci/Intel-dts-format-test success Testing OK
ci/Intel-dts-pylama-test success Testing OK
ci/Intel-dts-suite-test warning SKIPPED

Commit Message

Li, HongboX Dec. 15, 2022, 2 p.m. UTC 
  If testcase of throws an exception, and multiple testpmds have been started, the vf cannot be cleaned, and cause other cases to fail.
Therefore, by adjusting the cleaning environment order, make sure to exit all sessions before cleaning vf.

Signed-off-by: Hongbo Li <hongbox.li@intel.com>
---
 tests/TestSuite_ice_iavf_fdir.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Jiale, SongX Dec. 21, 2022, 9:22 a.m. UTC | #1 
> -----Original Message-----
> From: Hongbo Li <hongbox.li@intel.com>
> Sent: Thursday, December 15, 2022 10:00 PM
> To: dts@dpdk.org
> Cc: Li, HongboX <hongbox.li@intel.com>
> Subject: [dts][PATCH V1] tests/ice_iavf_fdir: optimize scripts
> 
> If testcase of throws an exception, and multiple testpmds have been started,
> the vf cannot be cleaned, and cause other cases to fail.
> Therefore, by adjusting the cleaning environment order, make sure to exit all
> sessions before cleaning vf.
> 
> Signed-off-by: Hongbo Li <hongbox.li@intel.com>
> ---
Tested-by: Song Jiale <songx.jiale@intel.com>
Tu, Lijuan Dec. 22, 2022, 8:46 a.m. UTC | #2 
On Thu, 15 Dec 2022 22:00:11 +0800, Hongbo Li <hongbox.li@intel.com> wrote:
> If testcase of throws an exception, and multiple testpmds have been started, the vf cannot be cleaned, and cause other cases to fail.
> Therefore, by adjusting the cleaning environment order, make sure to exit all sessions before cleaning vf.
> 
> Signed-off-by: Hongbo Li <hongbox.li@intel.com>

Acked-by: Lijuan Tu <lijuan.tu@intel.com>
Applied, thanks
diff mbox series

Patch

diff --git a/tests/TestSuite_ice_iavf_fdir.py b/tests/TestSuite_ice_iavf_fdir.py
index d6ca832a..b7954784 100644
--- a/tests/TestSuite_ice_iavf_fdir.py
+++ b/tests/TestSuite_ice_iavf_fdir.py
@@ -11932,12 +11932,12 @@  class TestICEIAVFFdir(TestCase):
             "test_mac_ipv6_multicast_protocol",
         ]:
             self.pmd_output.execute_cmd("mcast_addr remove 0 11:22:33:44:55:66")
-        self.destroy_env()
-        self.dut.kill_all()
         if getattr(self, "session_secondary", None):
             self.dut.close_session(self.session_secondary)
         if getattr(self, "session_third", None):
             self.dut.close_session(self.session_third)
+        self.destroy_env()
+        self.dut.kill_all()
 
         if self.running_case in [
             "test_pfcp_vlan_strip_off_sw_checksum",