[V1] tests/vf_offload: fix wrong value assigned for VxLAN packet under DCF.

Message ID 20230315092843.85005-1-ke1.xu@intel.com (mailing list archive)
State Accepted
Headers
Series [V1] tests/vf_offload: fix wrong value assigned for VxLAN packet under DCF. |

Checks

Context Check Description
ci/Intel-dts-pylama-test success Testing OK
ci/Intel-dts-format-test success Testing OK
ci/Intel-dts-suite-test success Testing OK

Commit Message

Ke Xu March 15, 2023, 9:28 a.m. UTC
  There are several mis-placed parameters in vf_offload updating and not covered
 due to an known issue blocking dcf enabling of this case. These mistakes may cause
 unexpected verifying result. This patch fixes these errors.

Signed-off-by: Ke Xu <ke1.xu@intel.com>
---
 tests/TestSuite_vf_offload.py | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
  

Comments

Tu, Lijuan March 28, 2023, 12:56 a.m. UTC | #1
On Wed, 15 Mar 2023 17:28:43 +0800, Ke Xu <ke1.xu@intel.com> wrote:
> There are several mis-placed parameters in vf_offload updating and not covered
>  due to an known issue blocking dcf enabling of this case. These mistakes may cause
>  unexpected verifying result. This patch fixes these errors.
> 
> Signed-off-by: Ke Xu <ke1.xu@intel.com>


Applied, thanks
  

Patch

diff --git a/tests/TestSuite_vf_offload.py b/tests/TestSuite_vf_offload.py
index 9475ef22..9d7ed9c2 100644
--- a/tests/TestSuite_vf_offload.py
+++ b/tests/TestSuite_vf_offload.py
@@ -545,7 +545,7 @@  class TestVfOffload(TestCase):
         if self.dcf_mode == "enable":
             pkts_outer.update(
                 {
-                    "IP/UDP/VXLAN/ETH": f'IP(src = "{sndIP}") / UDP(sport = 4789, dport = 4789, chksum = 0xff) / VXLAN() / Ether()',
+                    "IP/UDP/VXLAN/ETH": f'IP(src = "{sndIP}", chksum = 0xff) / UDP(sport = 4789, dport = 4789, chksum = 0xff) / VXLAN() / Ether()',
                     "IPv6/UDP/VXLAN/ETH": f'IPv6(src = "{sndIPv6}") / UDP(sport = 4789, dport = 4789, chksum = 0xff) / VXLAN() / Ether()',
                 }
             )
@@ -584,9 +584,9 @@  class TestVfOffload(TestCase):
         }
 
         if self.dcf_mode == "enable":
-            pkts_outer.update(
+            pkts_outer_ref.update(
                 {
-                    "IP/UDP/VXLAN/ETH": f'IP(src = "{sndIP}", chksum = 0xff) / UDP(sport = 4789, dport = 4789) / VXLAN() / Ether()',
+                    "IP/UDP/VXLAN/ETH": f'IP(src = "{sndIP}") / UDP(sport = 4789, dport = 4789) / VXLAN() / Ether()',
                     "IPv6/UDP/VXLAN/ETH": f'IPv6(src = "{sndIPv6}") / UDP(sport = 4789, dport = 4789) / VXLAN() / Ether()',
                 }
             )
@@ -735,9 +735,9 @@  class TestVfOffload(TestCase):
         }
 
         if self.dcf_mode == "enable":
-            pkts_outer.update(
+            pkts_outer_ref.update(
                 {
-                    "VLAN/IP/UDP/VXLAN/ETH": f'Dot1Q(vlan=100) / IP(src = "{sndIP}", chksum = 0xff) / UDP(sport = 4789, dport = 4789) / VXLAN() / Ether()',
+                    "VLAN/IP/UDP/VXLAN/ETH": f'Dot1Q(vlan=100) / IP(src = "{sndIP}") / UDP(sport = 4789, dport = 4789) / VXLAN() / Ether()',
                     "VLAN/IPv6/UDP/VXLAN/ETH": f'Dot1Q(vlan=100) / IPv6(src = "{sndIPv6}") / UDP(sport = 4789, dport = 4789) / VXLAN() / Ether()',
                 }
             )