From patchwork Tue May 26 19:10:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 70588 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 262C9A04A4; Tue, 26 May 2020 21:10:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EDD6B1D6E9; Tue, 26 May 2020 21:10:51 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 93C3C1D6E5 for ; Tue, 26 May 2020 21:10:50 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200526191049euoutp02f510e8618b57b18ab28edffb2b6bec9a~Sqb14rzv71970319703euoutp02I for ; Tue, 26 May 2020 19:10:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200526191049euoutp02f510e8618b57b18ab28edffb2b6bec9a~Sqb14rzv71970319703euoutp02I DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1590520249; bh=qh9JCtxcjKOea/2bzK40RVNX0VCSjD1DsMJBarBtp44=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=Dl6a519Da1K4WQXDdFKht7aQV0U/ewrG8UGsJbfgGI0HMpZdU0poZbwr9gm+Z43xz y+9Z/oKEIRRPEhiE6Ip3JhAU80vbhP3xMYF5ptZ2bRUyj+6gn+X8jDevelb2k+Gbqo SAQW58aJo1j9+2k7yRNFeUnTCVkH40e6yxh0GKWE= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200526191049eucas1p1c6a61c19590c7a9bca668ad734f014d9~Sqb1SI-yh2444924449eucas1p1I; Tue, 26 May 2020 19:10:49 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 0D.A7.60698.8B96DCE5; Tue, 26 May 2020 20:10:48 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200526191048eucas1p2970aa70da22d080be6cc2554d5a7083b~Sqb0zXTVz2632026320eucas1p2e; Tue, 26 May 2020 19:10:48 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200526191048eusmtrp2a30fdbae2d2b5e40bc8def80afa4a578~Sqb0yuh-70921709217eusmtrp21; Tue, 26 May 2020 19:10:48 +0000 (GMT) X-AuditID: cbfec7f5-a0fff7000001ed1a-da-5ecd69b846db Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 20.F4.08375.8B96DCE5; Tue, 26 May 2020 20:10:48 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200526191047eusmtip1dca52d93d7c30d2a544caa37490d77f7~Sqb0BhsKK1925319253eusmtip1s; Tue, 26 May 2020 19:10:47 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com Date: Tue, 26 May 2020 22:10:04 +0300 Message-Id: <20200526191033.16459-2-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200526191033.16459-1-i.dyukov@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA01SfSyUcRzf73nu7nnYnT2OzRct61atskhqPVojzR+Pzao/9I8teeKJy2t3 Tl20RJlYZjflrUVeRhR2zrswfxCHyobTKH94iZDkQl7qzqPlv8/L9/v5fr/bl8SlzUIHUh4V yymi2AiZyFJQ37U+cLxR3h94wlBzmp7IGhfR6UsPMbqhPE1ELy43YPTYWz1B5w0mEfTM5hxO ZzU1Inp54p2A1o/WEvRr40ecruvbQufFzO/CUiFT3DqLMV2jzwjme9uQiMnQVSCmcnJNdFkU YHkuhIuQx3EKV88gy7DeLx3CmGm4M1M7LkxERps0ZEECdQqyZw3CNGRJSqlyBKVT8yKerCBY aM0lePLT5HyYNBFip0XD8nIZgtqqIgFPjAi6l0cF5lgRdQT0qS8ws2FLZWHwICUXNxs2FA3F 26VCMxZQh8D4ZszUQJISygNWNff4lZygsqZjp9yCOgvzK2U7mVJqP4wUrGBmLKGsoSd3ckfH TfXJdfm4eRZQwwQMP5kW8EE+UDKoEfLYBua6dQSP98GfpgKMx/Gwqh0h+OZUBJ+LHu0WeYHu 2wBhXg6njkJ1s6sZAuUNhnVnHlqBYcGaX8EKNPXZOC9LIDVFymfIoKNncFcG2NoQ8zIDSb/S 8Ux0IG/PLXl7bsn7P7UQ4RXIjlMpI0M5pXsUd9tFyUYqVVGhLsHRkVpk+ij9drexEbVtXu9E FIlkYknQRl+gVMjGKdWRnQhIXGYrudCvD5RKQlj1XU4RfU2hiuCUnciRFMjsJO5Fs1elVCgb y4VzXAyn+OdipIVDIlL5csk2vckWCe2r2oChBl1Ool/FjXip3F79nm3R4km3qu5P+WnOeNJp 9eqQw3NzAT41HmLGW7z2tSIlxS2nOv9VQ1jJ0yFteLOrl/PNSy8z1W2Z9stYhmPpjwncKauk N+MkE+xlOHhlUdzu750svvj8se/qJ0bnnOPPtqiWEmQCZRjrdgxXKNm/Vkf0pE0DAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrPIsWRmVeSWpSXmKPExsVy+t/xu7o7Ms/GGex7IG7xYMpdNovuDy1M FttXdLFZvPu0ncnizt7T7BazLjWxWzz/84rZYsrOHYwWnx6cYLE4fXMzu8WarxeZLbae+cvo wOPxa8FSVo/Fe14yeRy7OY3d4/2+q2wefVtWMXqsfvKDLYAtSs+mKL+0JFUhI7+4xFYp2tDC SM/Q0kLPyMRSz9DYPNbKyFRJ384mJTUnsyy1SN8uQS/j1P0DrAXPJCqeb77L2sD4VbiLkZ1D QsBEYlJiFyMXh5DAUkaJSdfWsHQxcgCFJSReP2HuYuQEMoUl/lzrYoOo+cwosa3lLxNIgk1A Q+J0xzwmkISIwBImib2rzjGCJIQFLCQW/1vKCmKzCKhKfF17B2wor4ClxPdJtRBD5SVWbzgA toBTwErizZflLCC2kECmxPo789kgbDmJ6/O/gO3iFRCUODnzCdgYZgF1ifXzhEDCzEBjmrfO Zp7AKDgLSdUshKpZSKoWMDKvYhRJLS3OTc8tNtQrTswtLs1L10vOz93ECIy8bcd+bt7BeGlj 8CFGAQ5GJR7ehN9n4oRYE8uKK3MPMUpwMCuJ8DqdPR0nxJuSWFmVWpQfX1Sak1p8iNEU6MuJ zFKiyfnApJBXEm9oamhuYWlobmxubGahJM7bIXAwRkggPbEkNTs1tSC1CKaPiYNTqoExhG1t 2AkpseafmoGhtSF/d6n71xQunm0cMOGWju3K3VVzF3NHrJ/bdaQiVlTcMeVDWeQvj84rCfuW ZNQ0VGodcp0w8+6RDY0TXS6wtXqtWn5EySSoSfOwmmR28duG//J9zdVx9Tqvr4Qt1NkpEKQ+ O1gu5+9nB+Gjx45oWkrMfcQury5Xu1qJpTgj0VCLuag4EQDDvjWT0gIAAA== X-CMS-MailID: 20200526191048eucas1p2970aa70da22d080be6cc2554d5a7083b X-Msg-Generator: CA X-RootMTR: 20200526191048eucas1p2970aa70da22d080be6cc2554d5a7083b X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200526191048eucas1p2970aa70da22d080be6cc2554d5a7083b References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200526191033.16459-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v2 1/7] ethdev: allow unknown link speed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Thomas Monjalon When querying the link information, the link status is a mandatory major information. Other boolean values are supposed to be accurate: - duplex mode (half/full) - negotiation (auto/fixed) This API update is making explicit that the link speed information is optional. The value ETH_SPEED_NUM_NONE (0) was already part of the API. The value ETH_SPEED_NUM_UNKNOWN (infinite) is added to cover two different cases: - speed is not known by the driver - device is virtual Suggested-by: Morten Brørup Suggested-by: Benoit Ganne Signed-off-by: Thomas Monjalon --- lib/librte_ethdev/rte_ethdev.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index a49242bcd..2090af501 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -303,6 +303,7 @@ struct rte_eth_stats { #define ETH_SPEED_NUM_56G 56000 /**< 56 Gbps */ #define ETH_SPEED_NUM_100G 100000 /**< 100 Gbps */ #define ETH_SPEED_NUM_200G 200000 /**< 200 Gbps */ +#define ETH_SPEED_NUM_UNKNOWN UINT32_MAX /**< Unknown */ /** * A structure used to retrieve link-level information of an Ethernet port. @@ -2262,15 +2263,16 @@ int rte_eth_allmulticast_disable(uint16_t port_id); int rte_eth_allmulticast_get(uint16_t port_id); /** - * Retrieve the status (ON/OFF), the speed (in Mbps) and the mode (HALF-DUPLEX - * or FULL-DUPLEX) of the physical link of an Ethernet device. It might need - * to wait up to 9 seconds in it. + * Retrieve the link status (up/down), the duplex mode (half/full), + * the negotiation (auto/fixed), and if available, the speed (Mbps). + * + * It might need to wait up to 9 seconds. + * @see rte_eth_link_get_nowait. * * @param port_id * The port identifier of the Ethernet device. * @param link - * A pointer to an *rte_eth_link* structure to be filled with - * the status, the speed and the mode of the Ethernet device link. + * Link information written back. * @return * - (0) if successful. * - (-ENOTSUP) if the function is not supported in PMD driver. @@ -2279,15 +2281,13 @@ int rte_eth_allmulticast_get(uint16_t port_id); int rte_eth_link_get(uint16_t port_id, struct rte_eth_link *link); /** - * Retrieve the status (ON/OFF), the speed (in Mbps) and the mode (HALF-DUPLEX - * or FULL-DUPLEX) of the physical link of an Ethernet device. It is a no-wait - * version of rte_eth_link_get(). + * Retrieve the link status (up/down), the duplex mode (half/full), + * the negotiation (auto/fixed), and if available, the speed (Mbps). * * @param port_id * The port identifier of the Ethernet device. * @param link - * A pointer to an *rte_eth_link* structure to be filled with - * the status, the speed and the mode of the Ethernet device link. + * Link information written back. * @return * - (0) if successful. * - (-ENOTSUP) if the function is not supported in PMD driver. From patchwork Tue May 26 19:10:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 70589 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4DACFA04A4; Tue, 26 May 2020 21:11:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B65D51D6F6; Tue, 26 May 2020 21:10:54 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 0D4611D6F3 for ; Tue, 26 May 2020 21:10:53 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200526191052euoutp01e3695ccd1a71c5a131970845ba5c2d20~Sqb4RmA1O3216332163euoutp01d for ; Tue, 26 May 2020 19:10:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200526191052euoutp01e3695ccd1a71c5a131970845ba5c2d20~Sqb4RmA1O3216332163euoutp01d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1590520252; bh=r/Zgdgw3cI5ClABDcivjVEPBf0kVTXTPMgQM9bIHrGk=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=APDHQ8QAzK3x6KRsuk6GrgjZUkN2oqGphSKZz29oXHgWWuvfEW3I7cvsqIbaU2ihY Nq1StWVmjF6kxanHhQVlElJrbozJJN+agBzo5JhiHgUHb2OBs3WbIcswmEnshiq7KU 9kiGNizxYY9bkIz+skCMzjdEtJK+xJBO7D6qjXMw= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200526191051eucas1p17bfca30df0ee8b93d7b6d2391e726f53~Sqb3nJkOA2430024300eucas1p1I; Tue, 26 May 2020 19:10:51 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id DD.A7.60698.BB96DCE5; Tue, 26 May 2020 20:10:51 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200526191050eucas1p16311d491af2d7640553aced2e55ac83a~Sqb2wdJtR2416724167eucas1p1G; Tue, 26 May 2020 19:10:50 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200526191050eusmtrp2299cec4ea77ba851cb39d7c94e5ae1f1~Sqb2v8txz0898208982eusmtrp2_; Tue, 26 May 2020 19:10:50 +0000 (GMT) X-AuditID: cbfec7f5-a29ff7000001ed1a-dd-5ecd69bbc34b Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id F0.F4.08375.AB96DCE5; Tue, 26 May 2020 20:10:50 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200526191049eusmtip1e91038a56c93867429e81a599fd0f120~Sqb2B2I8b1119611196eusmtip1-; Tue, 26 May 2020 19:10:49 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com Date: Tue, 26 May 2020 22:10:05 +0300 Message-Id: <20200526191033.16459-3-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200526191033.16459-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSe0hTYRjG/Xa2c47DyXEavlkoDCSL0kyDo1lZGIyE7B8hitSVBxWdyo5a GoR3dEZqzHt5xQual9TmXURDjTktw8xLIVnIvBXmLG+Z80z67/c+z/Ne+PhITFwksCFDwqMY RbgsTIIL+erBzbEzXSFav7PpiTb0nOozTmf8TObRbTVKnF5da+PRsz0agi4cTyTohZ1FjFZ1 tCN6bW6YT2umWgj6pf49Rr8e2UWeZtKt0kqBtKJbx5MOTuUS0h+9E7j0aWstktZ9+4PfxG8L PQKZsJAYRuF0KUAYrCufJyLzbB/2ZuSgeJR9VIlMSaBcYXjhK1+JhKSYqkGQtZ6Ec8U6gtG+ KmPxC8Gb6RrssKXxeTvGGdUIugeWCK7QI1htTeIbUjjlAJq0Yp7BsKJUPEhILThot6SuQfL0 hMDAfMoenkxlEQYWUW4wtr2McyvsoK6p7yBvSrnD8nr1wVAxZQuTJesHQ4GqIqB/RW+8yQsm mpQEx5awONRq5OOw11HC4/gR/G6eJLjmNARfylOMocvQujS6zySJUSehsdOJk6/ATEGDwCAD ZQ6fViwMMraPz9R5GCeLIC1VzKUl0Pd23CgD7G6bcbIUtG0tiHufHgSZiaP8LGRX+H9XKUK1 yJqJZuVBDOsSzjxwZGVyNjo8yPF+hLwZ7X8Zzd8hfTvq3bnXjygSScxEAdsjfmKBLIaNlfcj IDGJleiqVuMnFgXKYuMYRYS/IjqMYfvRMZIvsRa5lOvuiqkgWRQTyjCRjOLQ5ZGmNvFIzkqW Sm/k6+JiM+qVyeK1+t4jZYKU02zchzK2y3suYdPHq7pC3558R2Uz8z3dbelEMb5abzX/2KRh z1M4W+Q/36xSbQye2ypIHL3lnp1r8lGmPe+wcV39wvddZU72BfXFTh9Xe62Hb45Oa54pGPDw xszzhWrn0Fcu2d0W28uREj4bLHM+hSlY2T+yRKXELgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrDLMWRmVeSWpSXmKPExsVy+t/xu7q7Ms/GGWxaqGjxYMpdNovuDy1M FttXdLFZvPu0ncnizt7T7BazLjWxWzz/84rZYsrOHYwWnx6cYLE4fXMzu8WarxeZLbae+cvo wOPxa8FSVo/Fe14yeRy7OY3d4/2+q2wefVtWMXqsfvKDLYAtSs+mKL+0JFUhI7+4xFYp2tDC SM/Q0kLPyMRSz9DYPNbKyFRJ384mJTUnsyy1SN8uQS/j5aLH7AXT5Sr2dU9lbGCcKNnFyMkh IWAisX7ODuYuRi4OIYGljBK3Fm9h6WLkAEpISLx+wgxRIyzx51oXG0TNZ0aJnxMPsIEk2AQ0 JE53zGMCSYgILGGS2LvqHCNIQljAVaLl1lVWEJtFQFWi5+YEdhCbV8BS4vzvN2wQU+UlVm84 ALaBU8BK4s2X5SwgtpBApsT6O/PZIGw5ievzvzBNYORbwMiwilEktbQ4Nz232FCvODG3uDQv XS85P3cTIzDktx37uXkH46WNwYcYBTgYlXh4E36fiRNiTSwrrsw9xCjBwawkwut09nScEG9K YmVValF+fFFpTmrxIUZToAMnMkuJJucD4zGvJN7Q1NDcwtLQ3Njc2MxCSZy3Q+BgjJBAemJJ anZqakFqEUwfEwenVAOjVe25U2pSXSf0lrfXvHxzWrv+/tM3+Y/uOF4RZDDfMoF1WW6X+UVj 0cctDXd61fKmKnA+C2SQlwqNdltyO9v+5a+LHWV+Htt3i4jb35j0ooxtmnVjv9cduRZJ4T63 D+pNO72U/miHlUWFiTt8tZweNN1hV0Efq9P2Obpf17yfd/bM35fLTrkosRRnJBpqMRcVJwIA 1LKsko8CAAA= X-CMS-MailID: 20200526191050eucas1p16311d491af2d7640553aced2e55ac83a X-Msg-Generator: CA X-RootMTR: 20200526191050eucas1p16311d491af2d7640553aced2e55ac83a X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200526191050eucas1p16311d491af2d7640553aced2e55ac83a References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200526191033.16459-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v2 2/7] ethdev: add a link status text representation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This commit add function which treat link status structure and format it to text representation. Signed-off-by: Ivan Dyukov --- lib/librte_ethdev/rte_ethdev.c | 39 ++++++++++++++++++++++++++++++++++ lib/librte_ethdev/rte_ethdev.h | 31 +++++++++++++++++++++++++++ 2 files changed, 70 insertions(+) diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c index 8e10a6fc3..8d75c2440 100644 --- a/lib/librte_ethdev/rte_ethdev.c +++ b/lib/librte_ethdev/rte_ethdev.c @@ -2385,6 +2385,45 @@ rte_eth_link_get_nowait(uint16_t port_id, struct rte_eth_link *eth_link) return 0; } +void +rte_eth_link_prepare_text(struct rte_eth_link *eth_link, uint32_t speed_unit, + struct rte_eth_link_text *link_text) +{ + uint32_t link_speed = 0; + /* prepare link speed */ + if (eth_link->link_speed == ETH_SPEED_NUM_UNKNOWN) + memcpy(link_text->link_speed, "unknown", sizeof("unknown")); + else { + if (speed_unit == ETH_SPEED_UNIT_GBPS) + link_speed = eth_link->link_speed / 1000; + else + link_speed = eth_link->link_speed; + snprintf(link_text->link_speed, sizeof(link_text->link_speed), + "%u", link_speed); + } + /* prepare link duplex */ + if (eth_link->link_duplex == ETH_LINK_FULL_DUPLEX) + memcpy(link_text->link_duplex, "full-duplex", + sizeof("full-duplex")); + else + memcpy(link_text->link_duplex, "half-duplex", + sizeof("half-duplex")); + /* prepare autoneg */ + if (eth_link->link_autoneg == ETH_LINK_AUTONEG) + memcpy(link_text->link_autoneg, "autoneg", + sizeof("autoneg")); + else + memcpy(link_text->link_autoneg, "fixed", + sizeof("fixed")); + /* prepare status */ + if (eth_link->link_status == ETH_LINK_DOWN) + memcpy(link_text->link_status, "down", + sizeof("down")); + else + memcpy(link_text->link_status, "up", + sizeof("up")); +} + int rte_eth_stats_get(uint16_t port_id, struct rte_eth_stats *stats) { diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index 2090af501..53d2f0c78 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -316,6 +316,19 @@ struct rte_eth_link { uint16_t link_status : 1; /**< ETH_LINK_[DOWN/UP] */ } __rte_aligned(8); /**< aligned for atomic64 read/write */ +/** + * Link speed units + */ +#define ETH_SPEED_UNIT_GBPS 0 +#define ETH_SPEED_UNIT_MBPS 1 + + +struct rte_eth_link_text { + char link_speed[14]; /** link speed */ + char link_duplex[12]; /** full-duplex or half-duplex */ + char link_autoneg[8]; /** autoneg or fixed */ + char link_status[5]; /** down or up */ +}; /* Utility constants */ #define ETH_LINK_HALF_DUPLEX 0 /**< Half-duplex connection (see link_duplex). */ #define ETH_LINK_FULL_DUPLEX 1 /**< Full-duplex connection (see link_duplex). */ @@ -2295,6 +2308,24 @@ int rte_eth_link_get(uint16_t port_id, struct rte_eth_link *link); */ int rte_eth_link_get_nowait(uint16_t port_id, struct rte_eth_link *link); +/** + * Format link status to textual representation. speed_unit is used to convert + * link_speed to specified unit. Also this function threats a special + * ETH_SPEED_NUM_UNKNOWN value of link_speed and return 'UNKNOWN' speed + * in this case. + * + * @param link + * Link status provided by rte_eth_link_get function + * @param speed_unit + * Target units for the speed. Following values are available: + * - ETH_SPEED_UNIT_GBPS + * - ETH_SPEED_UNIT_MBPS + * @param link_text + * A pointer to an *rte_eth_link_text* structure to be filled with + * textual representation of device status + */ +void rte_eth_link_prepare_text(struct rte_eth_link *link, uint32_t speed_unit, + struct rte_eth_link_text *link_text); /** * Retrieve the general I/O statistics of an Ethernet device. * From patchwork Tue May 26 19:10:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 70590 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E1EEA04A4; Tue, 26 May 2020 21:11:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9F6D71D70F; Tue, 26 May 2020 21:10:57 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 080A11D6F4 for ; Tue, 26 May 2020 21:10:54 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200526191053euoutp01e8fc75f9d75b6d1e4874aa8c58fbe00b~Sqb5mKbfB0044500445euoutp01L for ; Tue, 26 May 2020 19:10:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200526191053euoutp01e8fc75f9d75b6d1e4874aa8c58fbe00b~Sqb5mKbfB0044500445euoutp01L DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1590520253; bh=GknZngFdpOIDKYIYJ7vyk3o8XkbRCfaGhuuZlaIUVOA=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=LwqGFZebre/Xm3NUe9xnjZlw1fQZmY56eFP5USW5E/kMa2H+tXcfyl8z7YMkD7o4u NsCJHUON/+EDtXC9BxdNZ94LSZuIgQtRnOoK4Nq/9KyRZG9jVit64yqHDfJlbbMLHS VYZ08QtRAZbxwPPydNWv1ISJRZ/gMWjD/zKLkhjY= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200526191053eucas1p194958ea29d5ffe2c5fe992dbbdc5960e~Sqb5JiMEk2409924099eucas1p1O; Tue, 26 May 2020 19:10:53 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id AE.A7.60698.DB96DCE5; Tue, 26 May 2020 20:10:53 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200526191052eucas1p2c53ca292499647dce2360fbe328c4521~Sqb4uFs-L0108001080eucas1p2r; Tue, 26 May 2020 19:10:52 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200526191052eusmtrp2b32efa152c4396564c4d838a17cc4deb~Sqb4tHWRB0921709217eusmtrp22; Tue, 26 May 2020 19:10:52 +0000 (GMT) X-AuditID: cbfec7f5-a0fff7000001ed1a-e0-5ecd69bdd8ca Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id C1.F4.08375.CB96DCE5; Tue, 26 May 2020 20:10:52 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200526191051eusmtip1fda29d76733778478fc6816cee86a422~Sqb35KHK-1925619256eusmtip1z; Tue, 26 May 2020 19:10:51 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com Date: Tue, 26 May 2020 22:10:06 +0300 Message-Id: <20200526191033.16459-4-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200526191033.16459-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprFKsWRmVeSWpSXmKPExsWy7djP87p7M8/GGWyfzGbxYMpdNovuDy1M FttXdLFZvPu0ncnizt7T7BazLjWxWzz/84rZYsrOHYwWnx6cYLE4fXMzu8WarxeZLbae+cvo wOPxa8FSVo/Fe14yeRy7OY3d4/2+q2wefVtWMXqsfvKDLYAtissmJTUnsyy1SN8ugSvj/Osn jAV3zSom7b3B1MC4RqeLkZNDQsBEou3gIfYuRi4OIYEVjBJt7zcygiSEBL4wSry6UguR+Mwo seHFQ2aYjr+/zrFBJJYzSvRsegHV/pVRYveSJ2BVbAIaEqc75jGBJEQEpjBJNLbNBEsIC9hI 7Ny1FGwHi4CqxJLVN8FsXgFLiWW9E6FWyEus3nAAzOYUsJJ482U5C8RNchLX538BGyohMI9d 4vOCz4wQDS4Sx1q2QzULS7w6voUdwpaR+L9zPhOEXS3xfdN1dojmDkaJe4taoYrsJba8Pgdk c3AwC2hKrN+lDxF2lJh5/TZYWEKAT+LGW0GQMDOQOWnbdGaIMK9ER5sQRLWSxIGTl6DCEhJ/ f/NAhD0kpu55zQoJn72MEu3rZrBNYJSfhbBrASPjKkbx1NLi3PTUYuO81HK94sTc4tK8dL3k /NxNjMAUc/rf8a87GPf9STrEKMDBqMTDm/D7TJwQa2JZcWXuIUYJDmYlEV6ns6fjhHhTEiur Uovy44tKc1KLDzFKc7AoifMaL3oZKySQnliSmp2aWpBaBJNl4uCUamBkeO32KFatZ/6mwwn8 a7w/uYpsc5676J8Ov9QHPg3JFIv9afOfVh86LfdIU9WFZ07ttYQzl+Nivk076OutrGuYw3fx ofePncejHT5aN61bZvM7wuWdWAVfbFbH+vlqhjEXv7H/jXuqftLgXf6HtHaN6YpJL9vcb++f JlxXlakjMatzjnbvrB4lluKMREMt5qLiRAAn7o1yLQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrDLMWRmVeSWpSXmKPExsVy+t/xu7p7Ms/GGexYqmzxYMpdNovuDy1M FttXdLFZvPu0ncnizt7T7BazLjWxWzz/84rZYsrOHYwWnx6cYLE4fXMzu8WarxeZLbae+cvo wOPxa8FSVo/Fe14yeRy7OY3d4/2+q2wefVtWMXqsfvKDLYAtSs+mKL+0JFUhI7+4xFYp2tDC SM/Q0kLPyMRSz9DYPNbKyFRJ384mJTUnsyy1SN8uQS/j/OsnjAV3zSom7b3B1MC4RqeLkZND QsBE4u+vc2xdjFwcQgJLGSWOXNrJ2MXIAZSQkHj9hBmiRljiz7UuqJrPjBKT3v9iBEmwCWhI nO6YxwSSEBFYwiSxd9U5sISwgI3Ezl1LwWwWAVWJJatvgtm8ApYSy3onQk2Vl1i94QCYzSlg JfHmy3IWEFtIIFNi/Z35bBC2nMT1+V+YJjDyLWBkWMUoklpanJueW2yoV5yYW1yal66XnJ+7 iREY8tuO/dy8g/HSxuBDjAIcjEo8vAm/z8QJsSaWFVfmHmKU4GBWEuF1Ons6Tog3JbGyKrUo P76oNCe1+BCjKdCBE5mlRJPzgfGYVxJvaGpobmFpaG5sbmxmoSTO2yFwMEZIID2xJDU7NbUg tQimj4mDU6qB0fZ29sklyaJ2jFofCz9/uCJqtUSZ38dJXTVrdVfG3GULN9r+bDz9bfL3e0w1 LvOe/beb6mPFf7fsocBMqZK3ksGhkVHOd778K378wMS9JGGBaZt1zm7dupyJazier7zwKPqy +29Hi4J4j6BIQR6Oonnu9u+FtvE+zvv+vziqIzwmt53tUupTJZbijERDLeai4kQAyt0VA48C AAA= X-CMS-MailID: 20200526191052eucas1p2c53ca292499647dce2360fbe328c4521 X-Msg-Generator: CA X-RootMTR: 20200526191052eucas1p2c53ca292499647dce2360fbe328c4521 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200526191052eucas1p2c53ca292499647dce2360fbe328c4521 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200526191033.16459-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v2 3/7] app: UNKNOWN link speed print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_prepare_text function to example applications Signed-off-by: Ivan Dyukov --- app/proc-info/main.c | 15 +++++++++------ app/test-pipeline/init.c | 11 ++++++----- app/test-pmd/config.c | 20 ++++++++++++-------- app/test-pmd/testpmd.c | 10 ++++++---- app/test/test_pmd_perf.c | 10 ++++++---- 5 files changed, 39 insertions(+), 27 deletions(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index abeca4aab..d8506cbb2 100644 --- a/app/proc-info/main.c +++ b/app/proc-info/main.c @@ -669,6 +669,7 @@ show_port(void) RTE_ETH_FOREACH_DEV(i) { uint16_t mtu = 0; struct rte_eth_link link; + struct rte_eth_link_text link_text; struct rte_eth_dev_info dev_info; struct rte_eth_rxq_info queue_info; struct rte_eth_rss_conf rss_conf; @@ -685,12 +686,14 @@ show_port(void) printf("Link get failed (port %u): %s\n", i, rte_strerror(-ret)); } else { - printf("\t -- link speed %d duplex %d," - " auto neg %d status %d\n", - link.link_speed, - link.link_duplex, - link.link_autoneg, - link.link_status); + rte_eth_link_prepare_text(&link, + ETH_SPEED_UNIT_MBPS, &link_text); + printf("\t -- link speed: %s, duplex: %s," + " auto neg: %s, status: %s\n", + link_text.link_speed, + link_text.link_duplex, + link_text.link_autoneg, + link_text.link_status); } printf("\t -- promiscuous (%d)\n", rte_eth_promiscuous_get(i)); diff --git a/app/test-pipeline/init.c b/app/test-pipeline/init.c index 67d54ae05..920023825 100644 --- a/app/test-pipeline/init.c +++ b/app/test-pipeline/init.c @@ -160,6 +160,7 @@ app_ports_check_link(void) for (i = 0; i < app.n_ports; i++) { struct rte_eth_link link; + struct rte_eth_link_text link_text; uint16_t port; int ret; @@ -173,12 +174,12 @@ app_ports_check_link(void) all_ports_up = 0; continue; } - - RTE_LOG(INFO, USER1, "Port %u (%u Gbps) %s\n", + rte_eth_link_prepare_text(&link, + ETH_SPEED_UNIT_GBPS, &link_text); + RTE_LOG(INFO, USER1, "Port %u (%s Gbps) %s\n", port, - link.link_speed / 1000, - link.link_status ? "UP" : "DOWN"); - + link_text.link_speed, + link_text.link_status); if (link.link_status == ETH_LINK_DOWN) all_ports_up = 0; } diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 5381207cc..722f57c12 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -552,6 +552,7 @@ port_infos_display(portid_t port_id) struct rte_port *port; struct rte_ether_addr mac_addr; struct rte_eth_link link; + struct rte_eth_link_text link_text; struct rte_eth_dev_info dev_info; int vlan_offload; struct rte_mempool * mp; @@ -600,10 +601,10 @@ port_infos_display(portid_t port_id) } else printf("\nmemory allocation on the socket: %u",port->socket_id); - printf("\nLink status: %s\n", (link.link_status) ? ("up") : ("down")); - printf("Link speed: %u Mbps\n", (unsigned) link.link_speed); - printf("Link duplex: %s\n", (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); + rte_eth_link_prepare_text(&link, ETH_SPEED_UNIT_MBPS, &link_text); + printf("\nLink status: %s\n", link_text.link_status); + printf("Link speed: %s Mbps\n", link_text.link_speed); + printf("Link duplex: %s\n", link_text.link_duplex); if (!rte_eth_dev_get_mtu(port_id, &mtu)) printf("MTU: %u\n", mtu); @@ -724,6 +725,7 @@ port_summary_display(portid_t port_id) { struct rte_ether_addr mac_addr; struct rte_eth_link link; + struct rte_eth_link_text link_text; struct rte_eth_dev_info dev_info; char name[RTE_ETH_NAME_MAX_LEN]; int ret; @@ -746,12 +748,14 @@ port_summary_display(portid_t port_id) if (ret != 0) return; - printf("%-4d %02X:%02X:%02X:%02X:%02X:%02X %-12s %-14s %-8s %uMbps\n", + rte_eth_link_prepare_text(&link, ETH_SPEED_UNIT_GBPS, + &link_text); + printf("%-4d %02X:%02X:%02X:%02X:%02X:%02X %-12s %-14s %-8s %sMbps\n", port_id, mac_addr.addr_bytes[0], mac_addr.addr_bytes[1], mac_addr.addr_bytes[2], mac_addr.addr_bytes[3], mac_addr.addr_bytes[4], mac_addr.addr_bytes[5], name, - dev_info.driver_name, (link.link_status) ? ("up") : ("down"), - (unsigned int) link.link_speed); + dev_info.driver_name, link_text.link_status, + link_text.link_speed); } void @@ -3897,7 +3901,7 @@ set_queue_rate_limit(portid_t port_id, uint16_t queue_idx, uint16_t rate) ret = eth_link_get_nowait_print_err(port_id, &link); if (ret < 0) return 1; - if (rate > link.link_speed) { + if (link.link_speed != UINT32_MAX && rate > link.link_speed) { printf("Invalid rate value:%u bigger than link speed: %u\n", rate, link.link_speed); return 1; diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 9cbe6e9f6..fd78e1cea 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2987,6 +2987,7 @@ check_all_ports_link_status(uint32_t port_mask) portid_t portid; uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; + struct rte_eth_link_text link_text; int ret; printf("Checking link statuses...\n"); @@ -3007,12 +3008,13 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { + rte_eth_link_prepare_text(&link, + ETH_SPEED_UNIT_MBPS, &link_text); if (link.link_status) printf( - "Port%d Link Up. speed %u Mbps- %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); + "Port%d Link Up. speed %s Mbps- %s\n", + portid, link_text.link_speed, + link_text.link_duplex); else printf("Port %d Link Down\n", portid); continue; diff --git a/app/test/test_pmd_perf.c b/app/test/test_pmd_perf.c index 352cd4715..9a275287b 100644 --- a/app/test/test_pmd_perf.c +++ b/app/test/test_pmd_perf.c @@ -125,6 +125,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) uint16_t portid; uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; + struct rte_eth_link_text link_text; int ret; printf("Checking link statuses...\n"); @@ -147,11 +148,12 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) /* print link status if flag set */ if (print_flag == 1) { if (link.link_status) { + rte_eth_link_prepare_text(&link, + ETH_SPEED_UNIT_MBPS, &link_text); printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); + "Port%d Link Up. Speed %s Mbps - %s\n", + portid, link_text.link_speed, + link_text.link_duplex); if (link_mbps == 0) link_mbps = link.link_speed; } else From patchwork Tue May 26 19:10:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 70591 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64CF8A04A4; Tue, 26 May 2020 21:11:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0D07C1D8FC; Tue, 26 May 2020 21:10:59 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 45F241D670 for ; Tue, 26 May 2020 21:10:56 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200526191056euoutp029828936fc24622e5b6ef707a22b52e4f~Sqb8EfC6R1916119161euoutp02T for ; Tue, 26 May 2020 19:10:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200526191056euoutp029828936fc24622e5b6ef707a22b52e4f~Sqb8EfC6R1916119161euoutp02T DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1590520256; bh=ZipdGY2cAx7vDrJLPB9oB2xWunr5C/DPzf/7eMfNA2U=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=GZ/tfuomG6EUMrl1xvjDIj1UFhWJTnYwGEjfLZVyMO1J5OMnCDca1m03gPTUCSoJ3 q347+WHKQkSpi+y599QwgALWfBSPyL1PIZcRQRQh3HG+zj80nmDyQQimrmeLh4n7yl KTBMg3B27IA0OSMs4N6YfqLAOP/MY5TNnKkILASA= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200526191055eucas1p2698fc4d6d511850d3d5734c02a523b98~Sqb7ToukU0385303853eucas1p2O; Tue, 26 May 2020 19:10:55 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 05.B3.61286.FB96DCE5; Tue, 26 May 2020 20:10:55 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200526191054eucas1p27defd4f1d656f07f1d9d5a95be369de9~Sqb6e_6Ln0765607656eucas1p2R; Tue, 26 May 2020 19:10:54 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200526191054eusmtrp2fb13d6402f12112aeac9bb5c43db305a~Sqb6eYzPk0898208982eusmtrp2-; Tue, 26 May 2020 19:10:54 +0000 (GMT) X-AuditID: cbfec7f2-f0bff7000001ef66-e1-5ecd69bf28b1 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 92.F4.08375.EB96DCE5; Tue, 26 May 2020 20:10:54 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200526191053eusmtip120e26ab967e137c5d3825dc9492a1f7a~Sqb5r_1Cz1925319253eusmtip1t; Tue, 26 May 2020 19:10:53 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com Date: Tue, 26 May 2020 22:10:07 +0300 Message-Id: <20200526191033.16459-5-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200526191033.16459-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBKsWRmVeSWpSXmKPExsWy7djPc7r7M8/GGcx/L2nxYMpdNovuDy1M FttXdLFZvPu0ncnizt7T7BazLjWxWzz/84rZYsrOHYwWnx6cYLE4fXMzu8WarxeZLbae+cvo wOPxa8FSVo/Fe14yeRy7OY3d4/2+q2wefVtWMXqsfvKDLYAtissmJTUnsyy1SN8ugSujddMK xoL1PBUnXx9mb2Dcw9nFyMEhIWAisf5+VhcjF4eQwApGia3be1khnC+MEp8ubWLqYuQEcj4z Sjyd6QBigzS8XPUaqmg5o8SSRQ+ZIJyvjBId+w8xg1SxCWhInO6YB5YQEZjCJNHYNhMsISzg KPH+J4TNIqAq8aDhFBuIzStgKXFv7k92iBXyEqs3HACr4RSwknjzZTkLxBlyEtfnfwEbKiGw iF1i/YJrUA0uEs9/f2GCsIUlXh3fAhWXkfi/cz5UvFri+6br7BDNHYwS9xa1QhXZS2x5fY4d FBrMApoS63fpQ4QdJd7sbGSHBBKfxI23giBhZiBz0rbpzBBhXomONiGIaiWJAycvQYUlJP7+ 5oEIe0hcnnSKEeL6vYwSf38GTWCUn4WwagEj4ypG8dTS4tz01GLDvNRyveLE3OLSvHS95Pzc TYzA9HL63/FPOxi/Xko6xCjAwajEw8vx80ycEGtiWXFl7iFGCQ5mJRFep7On44R4UxIrq1KL 8uOLSnNSiw8xSnOwKInzGi96GSskkJ5YkpqdmlqQWgSTZeLglGpg3Ds99wb7Q7/YDbbhIXZ7 Am/mJbrdXeur83vtpzqVozNnd/0Lrj524qKY44sCLoPZ9t7fT70/sc743vpC9y38RZL/xJ/u lG/7OJspQ74wYNZib/PTjp55cUnXVrnd3BrIt2hxQsyv37yiasvvC/RNDTU6OZ/z0/Rw/e/b 30l9k9/QcdbPiE3TWYmlOCPRUIu5qDgRAA5Jua8rAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrDLMWRmVeSWpSXmKPExsVy+t/xu7r7Ms/GGWyZLWfxYMpdNovuDy1M FttXdLFZvPu0ncnizt7T7BazLjWxWzz/84rZYsrOHYwWnx6cYLE4fXMzu8WarxeZLbae+cvo wOPxa8FSVo/Fe14yeRy7OY3d4/2+q2wefVtWMXqsfvKDLYAtSs+mKL+0JFUhI7+4xFYp2tDC SM/Q0kLPyMRSz9DYPNbKyFRJ384mJTUnsyy1SN8uQS+jddMKxoL1PBUnXx9mb2Dcw9nFyMkh IWAi8XLVa9YuRi4OIYGljBLz3v1i7mLkAEpISLx+wgxRIyzx51oXG0TNZ0aJ1iPdTCAJNgEN idMd85hAEiICS5gk9q46xwiSEBZwlHj/cyZYN4uAqsSDhlNsIDavgKXEvbk/2SGmykus3nAA rIZTwErizZflLCC2kECmxPo789kgbDmJ6/O/ME1g5FvAyLCKUSS1tDg3PbfYUK84Mbe4NC9d Lzk/dxMjMOS3Hfu5eQfjpY3BhxgFOBiVeHgTfp+JE2JNLCuuzD3EKMHBrCTC63T2dJwQb0pi ZVVqUX58UWlOavEhRlOgAycyS4km5wPjMa8k3tDU0NzC0tDc2NzYzEJJnLdD4GCMkEB6Yklq dmpqQWoRTB8TB6dUA6NixqX9vVuucssf1e7lcjtrenCfms9OW/my/80x0kH88ikXZ9wouMwS Z6yyNbjG46vChc2fY5ibD30506GirJMhw+R7w9c/6uGUnY9K59zYO4OJIVFVYL0bt9/fkuQe y2nX5+2RYbr9P7Xh02y3jUbFJ1ZZ8c19xr0nXmatg/KfTrf/AdOSgpVYijMSDbWYi4oTAWFS /a6PAgAA X-CMS-MailID: 20200526191054eucas1p27defd4f1d656f07f1d9d5a95be369de9 X-Msg-Generator: CA X-RootMTR: 20200526191054eucas1p27defd4f1d656f07f1d9d5a95be369de9 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200526191054eucas1p27defd4f1d656f07f1d9d5a95be369de9 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200526191033.16459-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v2 4/7] doc: update sample app with unknown speed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_prepare_text function to example applications Signed-off-by: Ivan Dyukov --- doc/guides/sample_app_ug/link_status_intr.rst | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/doc/guides/sample_app_ug/link_status_intr.rst b/doc/guides/sample_app_ug/link_status_intr.rst index 04c40f285..bdefcd17b 100644 --- a/doc/guides/sample_app_ug/link_status_intr.rst +++ b/doc/guides/sample_app_ug/link_status_intr.rst @@ -157,6 +157,7 @@ An example callback function that has been written as indicated below. lsi_event_callback(uint16_t port_id, enum rte_eth_event_type type, void *param) { struct rte_eth_link link; + struct rte_eth_link_text link_text; int ret; RTE_SET_USED(param); @@ -170,8 +171,9 @@ An example callback function that has been written as indicated below. printf("Failed to get port %d link status: %s\n\n", port_id, rte_strerror(-ret)); } else if (link.link_status) { - printf("Port %d Link Up - speed %u Mbps - %s\n\n", port_id, (unsigned)link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? ("full-duplex") : ("half-duplex")); + rte_eth_link_prepare_text(&link), ETH_SPEED_UNIT_MBPS, &link_text); + printf("Port %d Link Up - speed %s Mbps - %s\n\n", port_id, link_text.link_speed, + link_text.link_duplex); } else printf("Port %d Link Down\n\n", port_id); } From patchwork Tue May 26 19:10:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 70592 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 37575A04A4; Tue, 26 May 2020 21:11:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9434E1D71A; Tue, 26 May 2020 21:11:00 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id BDA281D717 for ; Tue, 26 May 2020 21:10:57 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200526191057euoutp0132eb46a07ac5dbe6d5d11fa79426e5f9~Sqb9RUA0s0044500445euoutp01N for ; Tue, 26 May 2020 19:10:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200526191057euoutp0132eb46a07ac5dbe6d5d11fa79426e5f9~Sqb9RUA0s0044500445euoutp01N DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1590520257; bh=xT5j1nj1DdFTRPLN/UuV43EkTsRJYECBQbvaE2okZEk=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=SE7w/evrzm9x2NVMDzqD7rpD2xMPZYj2//yikM0pZY6iy3/IdKOdIzbvv/m8FLGdi NVaP5XsYP3Y6SdLB0Qdd+6u2CZVq6C2+ckWBGkZoZZ6M98JcBElpjI0Fkuj7GjmBJ7 5tWkfR2KmmaE8aQBONVxUoRWqNZ5za0W8fOzve8o= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200526191056eucas1p232f2d98130ee4e0fe9b63908cb332155~Sqb8bNMAH0108001080eucas1p2s; Tue, 26 May 2020 19:10:56 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 26.B3.61286.0C96DCE5; Tue, 26 May 2020 20:10:56 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200526191056eucas1p2985e531db4a95745ca70e0bc4e9d6cdb~Sqb8BboSI0110401104eucas1p2h; Tue, 26 May 2020 19:10:56 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200526191056eusmtrp1a2886372bef83a4e021ee9ce98936b77~Sqb8Avndn0430304303eusmtrp1P; Tue, 26 May 2020 19:10:56 +0000 (GMT) X-AuditID: cbfec7f2-ef1ff7000001ef66-e4-5ecd69c08215 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 33.F0.07950.0C96DCE5; Tue, 26 May 2020 20:10:56 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200526191055eusmtip1270843f8583cc3f2cac5a0b9e4bb5253~Sqb7Nv-Pl1925619256eusmtip10; Tue, 26 May 2020 19:10:55 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com Date: Tue, 26 May 2020 22:10:08 +0300 Message-Id: <20200526191033.16459-6-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200526191033.16459-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSfyyUcRzHfe+5e57HzdnTsXyi0q5pspxumj39lvXH80db5q9qI1eejrhj d0fUH2hct9NEXYwN18WYY/mVo1HHjNqRnDWEUrOKqIYLFct5VP+99v7x+Xz++JCYuEjgSyao tKxaJU+S4EJ+a+/qYLAtYSDmYGXhPnrKOInTed9zeLS1xoDTXxesPHqi007QpY6bBP3p9yxG G9vbEL0w9ZxP28eaCbrOOYTRj/vXULgH89NUJWAedszwmN6xIoL59vQ1zuS31CLGMr2CR+IX hMfi2KSENFYdciJWGF9oGMJSyoj0ssb0LJSPG5A7CdQhqJq2EgYkJMVUDYJ30/OEyxBTSwjM 696csYggb274X6Mka0zAGdUI7E1rWw0ngpVBmYtxKhDs+nKeK+RNGXmQrSvBXIYXdQo+N6zx XcynAsDWZRG4WEQdhuJKHY/b4A+WBttm3p06AnNL1XxuwW4YqVjaHApUOQFFba0YVzgNPQ8G t8peMNvXQnC8E+z3bvM5vgHLTSMEV9YjeGvO3QqdhJYvLzeYJDFqPzx6EuJC2Dj0R8VVDj1h dH6bK4xt4N3WYoyTRaDXibkZErC9cGzJAGu/PDiZgfI8B84d34lgqXFXAfIv/b/JhFAt8mFT NUoFq5Gp2GtSjVypSVUppJeTlU1o41vs630LbcjpuNSNKBJJPETkan+MWCBP02QouxGQmMRb FDFgjxGL4uQZ11l18kV1ahKr6UZ+JF/iIwo1z0SLKYVcyyaybAqr/uvySHffLOSZG963N6Tn mXP4vTFwe/NouMWqWC5446f1OUqNJ96/hUaCXi23H6gVG331FWketZlXguIYA5UDIxPZlRLP 6EmRqSi0SysNq4uNcBue/eg2/CHpTs/x5Pgzoe7SyKioHXv0kvLxTC8ZK6x31Mfozsm0Zzvy w8ymgIXzNiZ4UcLXxMtlQZhaI/8DCSrlpykDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrNLMWRmVeSWpSXmKPExsVy+t/xu7oHMs/GGWxaw2XxYMpdNovuDy1M FttXdLFZvPu0ncnizt7T7BazLjWxWzz/84rZYsrOHYwWnx6cYLE4fXMzu8WarxeZLbae+cvo wOPxa8FSVo/Fe14yeRy7OY3d4/2+q2wefVtWMXqsfvKDLYAtSs+mKL+0JFUhI7+4xFYp2tDC SM/Q0kLPyMRSz9DYPNbKyFRJ384mJTUnsyy1SN8uQS9jYtdF5oK57BVzN1Y0MPaxdTFyckgI mEjMbLjJ2sXIxSEksJRR4v/GRUAJDqCEhMTrJ8wQNcISf651sUHUfGaUmLJlNSNIgk1AQ+J0 xzwmkISIwBImib2rzoElhAUcJV5s+MsCYrMIqEocOLiaFcTmFbCUmL6kjQliqrzE6g0HwDZw ClhJvPmyHKxeSCBTYv2d+WwQtpzE9flfmCYw8i1gZFjFKJJaWpybnltspFecmFtcmpeul5yf u4kRGPDbjv3csoOx613wIUYBDkYlHt6E32fihFgTy4orcw8xSnAwK4nwOp09HSfEm5JYWZVa lB9fVJqTWnyI0RTowInMUqLJ+cBozCuJNzQ1NLewNDQ3Njc2s1AS5+0QOBgjJJCeWJKanZpa kFoE08fEwSnVwLhEU/Bo/5rMKzOcPGRtWe64eZZLdyWytgqvbVT5cft/0qpVfNanZRaY5c22 W1UdZtDtLua8ykOZb/XN2+fSLSoNPklelxKoD7/UtThWrPBjwcbia/eLF04/vHOtpufisyXx qrFRIafdxP9op02r9+RKrkhZ9YPB4tikkO07Sovv3Gft+/drlxJLcUaioRZzUXEiAE+cYGaO AgAA X-CMS-MailID: 20200526191056eucas1p2985e531db4a95745ca70e0bc4e9d6cdb X-Msg-Generator: CA X-RootMTR: 20200526191056eucas1p2985e531db4a95745ca70e0bc4e9d6cdb X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200526191056eucas1p2985e531db4a95745ca70e0bc4e9d6cdb References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200526191033.16459-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v2 5/7] net/ixgbe: return unknown speed in status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rte_ethdev has declared new NUM_UNKNOWN speed which could be used in case when no speed information is available Signed-off-by: Ivan Dyukov --- drivers/net/ixgbe/ixgbe_ethdev.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index a4e5c539d..5b9b13058 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -4311,11 +4311,7 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev, switch (link_speed) { default: case IXGBE_LINK_SPEED_UNKNOWN: - if (hw->device_id == IXGBE_DEV_ID_X550EM_A_1G_T || - hw->device_id == IXGBE_DEV_ID_X550EM_A_1G_T_L) - link.link_speed = ETH_SPEED_NUM_10M; - else - link.link_speed = ETH_SPEED_NUM_100M; + link.link_speed = ETH_SPEED_NUM_UNKNOWN; break; case IXGBE_LINK_SPEED_100_FULL: From patchwork Tue May 26 19:10:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 70593 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 10F7EA04A4; Tue, 26 May 2020 21:11:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 03F011D95F; Tue, 26 May 2020 21:11:02 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id E1E1B1D71A for ; Tue, 26 May 2020 21:10:58 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200526191058euoutp0234f4dad1b7a92c4f2d1e78e849df3207~Sqb_VJ20q1195811958euoutp02h for ; Tue, 26 May 2020 19:10:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200526191058euoutp0234f4dad1b7a92c4f2d1e78e849df3207~Sqb_VJ20q1195811958euoutp02h DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1590520258; bh=RnlYD+Sn70PZMzCtJxYR4w9oEJDvYzwy6GYddb6sZF8=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=iZjgtMsBjZ43px85u0pckL8PZzbPLTiE4K7zZbsfFBkZW1Y54I6s3xNfdvBa1mOTv 96YxJorktW89fNVaG11vYH3J+fakiYd1yQElbu+0bLSLzubsa5u/cp1P41OxDmcdDy gSTmWfQRI7eHZWIl7lk1bhz5ig4YVKqUd0dWwsEI= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200526191058eucas1p190d3452905bb37299eb5ac47062515a6~Sqb_IRwm22594725947eucas1p1J; Tue, 26 May 2020 19:10:58 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id BF.A7.60698.2C96DCE5; Tue, 26 May 2020 20:10:58 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200526191058eucas1p11a8a5007144ba3b0e66ab1286a85c84b~Sqb9sk4Wt2444924449eucas1p1O; Tue, 26 May 2020 19:10:58 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200526191058eusmtrp19af5a763df3af7a1d5f8e6cfaeef140d~Sqb9sBai70430304303eusmtrp1R; Tue, 26 May 2020 19:10:58 +0000 (GMT) X-AuditID: cbfec7f5-a29ff7000001ed1a-e7-5ecd69c263b5 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 24.F0.07950.1C96DCE5; Tue, 26 May 2020 20:10:57 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200526191057eusmtip15ec74b91514ab368071150da909f68e5~Sqb85E2tD1119611196eusmtip1A; Tue, 26 May 2020 19:10:57 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com Date: Tue, 26 May 2020 22:10:09 +0300 Message-Id: <20200526191033.16459-7-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200526191033.16459-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBKsWRmVeSWpSXmKPExsWy7djP87qHMs/GGSyfL2LxYMpdNovuDy1M FttXdLFZvPu0ncnizt7T7BazLjWxWzz/84rZYsrOHYwWnx6cYLE4fXMzu8WarxeZLbae+cvo wOPxa8FSVo/Fe14yeRy7OY3d4/2+q2wefVtWMXqsfvKDLYAtissmJTUnsyy1SN8ugSvj0WKj ghV8FXe/dDI3MP7i7mLk5JAQMJH4+7SJsYuRi0NIYAWjxK+je5khnC+MEpMXfGSHcD4zSlxa +pAVpuX3jCNQLcsZJbonX4aq+soosax/B1gVm4CGxOmOeUwgCRGBKUwSjW0zmUESwgIOEice XQLq4OBgEVCV6NkjCRLmFbCUePChjRFig7zE6g0HwMo5Bawk3nxZzgJiCwnISVyf/wVspoTA InaJp4s2skE0uEjcPvGdBcIWlnh1fAs7hC0jcXpyD1S8WuL7puvsEM0djBL3FrVCFdlLbHl9 DuwgZgFNifW79CHCjhL/z95jBglLCPBJ3HgrCBJmBjInbZsOFeaV6GgTgqhWkjhw8hJUWELi 728eCNND4mhnLSR09jJKtPw6yzKBUX4WwqoFjIyrGMVTS4tz01OLjfNSy/WKE3OLS/PS9ZLz czcxAtPL6X/Hv+5g3Pcn6RCjAAejEg9vwu8zcUKsiWXFlbmHGCU4mJVEeJ3Ono4T4k1JrKxK LcqPLyrNSS0+xCjNwaIkzmu86GWskEB6YklqdmpqQWoRTJaJg1OqgVF34QvPGvnNe2McDwhu Ucq+cPkS3/Fe3gkp/man+F8YqX78m53/2CB29dKmi9beV17adHXHpWp+n/5hcvFehaVzBT6u /luw1apv3dJm/o/Cjxdxh9/9+7R0DvMHfeOCkkbe25vWLXuss2hO6n3GOwpaU/bv3xYwK6wl Wi6t0aXw89FlQmzaFzWUWIozEg21mIuKEwGVlpe6KwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrFLMWRmVeSWpSXmKPExsVy+t/xu7oHM8/GGXy/aGHxYMpdNovuDy1M FttXdLFZvPu0ncnizt7T7BazLjWxWzz/84rZYsrOHYwWnx6cYLE4fXMzu8WarxeZLbae+cvo wOPxa8FSVo/Fe14yeRy7OY3d4/2+q2wefVtWMXqsfvKDLYAtSs+mKL+0JFUhI7+4xFYp2tDC SM/Q0kLPyMRSz9DYPNbKyFRJ384mJTUnsyy1SN8uQS/j0WKjghV8FXe/dDI3MP7i7mLk5JAQ MJH4PeMIYxcjF4eQwFJGid4b+4AcDqCEhMTrJ8wQNcISf651sUHUfGaUWPSymR0kwSagIXG6 Yx4TSEJEYAmTxN5V5xhBEsICDhInHl1iBxnEIqAq0bNHEiTMK2Ap8eBDGyPEUHmJ1RsOgC3g FLCSePNlOQuILSSQKbH+znw2CFtO4vr8L0wTGPkWMDKsYhRJLS3OTc8tNtIrTswtLs1L10vO z93ECAz3bcd+btnB2PUu+BCjAAejEg9vwu8zcUKsiWXFlbmHGCU4mJVEeJ3Ono4T4k1JrKxK LcqPLyrNSS0+xGgKdN9EZinR5HxgLOaVxBuaGppbWBqaG5sbm1koifN2CByMERJITyxJzU5N LUgtgulj4uCUamBUc4j0i05U9tuiafFrpckjEa+almua/x8bHvENkuj9HJoxYdZz36LnM0Ir jpyyVEmZW/npt6XKhf3TLupqnJrxaUaddGPc3eQW/g1MX1JKKla/SnjJ/WKzG+OTaW5Sr4s9 bwUZnKsqeOqV1favtJAl2azwFf+jWRtO6tr4KLZtX/i3rT/yVZsSS3FGoqEWc1FxIgDaXSgC jQIAAA== X-CMS-MailID: 20200526191058eucas1p11a8a5007144ba3b0e66ab1286a85c84b X-Msg-Generator: CA X-RootMTR: 20200526191058eucas1p11a8a5007144ba3b0e66ab1286a85c84b X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200526191058eucas1p11a8a5007144ba3b0e66ab1286a85c84b References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200526191033.16459-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v2 6/7] net/i40e: return unknown speed in status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rte_ethdev has declared new NUM_UNKNOWN speed which could be used in case when no speed information is available and link is up. NUM_NONE should be returned, if link is down. Signed-off-by: Ivan Dyukov --- drivers/net/i40e/i40e_ethdev.c | 5 ++++- drivers/net/i40e/i40e_ethdev_vf.c | 10 +++++----- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 749d85f54..d09b77674 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -2889,7 +2889,10 @@ update_link_aq(struct i40e_hw *hw, struct rte_eth_link *link, link->link_speed = ETH_SPEED_NUM_40G; break; default: - link->link_speed = ETH_SPEED_NUM_NONE; + if (link->link_status) + link->link_speed = ETH_SPEED_NUM_UNKNOWN; + else + link->link_speed = ETH_SPEED_NUM_NONE; break; } } diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index bb5d28a44..1da185485 100644 --- a/drivers/net/i40e/i40e_ethdev_vf.c +++ b/drivers/net/i40e/i40e_ethdev_vf.c @@ -2165,15 +2165,15 @@ i40evf_dev_link_update(struct rte_eth_dev *dev, new_link.link_speed = ETH_SPEED_NUM_40G; break; default: - new_link.link_speed = ETH_SPEED_NUM_NONE; + if (vf->link_up) + new_link.link_speed = ETH_SPEED_NUM_UNKNOWN; + else + new_link.link_speed = ETH_SPEED_NUM_NONE; break; } /* full duplex only */ new_link.link_duplex = ETH_LINK_FULL_DUPLEX; - new_link.link_status = vf->link_up && - new_link.link_speed != ETH_SPEED_NUM_NONE - ? ETH_LINK_UP - : ETH_LINK_DOWN; + new_link.link_status = vf->link_up ? ETH_LINK_UP : ETH_LINK_DOWN; new_link.link_autoneg = !(dev->data->dev_conf.link_speeds & ETH_LINK_SPEED_FIXED); From patchwork Tue May 26 19:10:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 70594 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B306A04A4; Tue, 26 May 2020 21:11:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AA4291DA1D; Tue, 26 May 2020 21:11:05 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 5DAF11D930 for ; Tue, 26 May 2020 21:11:01 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200526191100euoutp029255b7c14292a8430968510e55d070ed~SqcAS2Sgo1195811958euoutp02i for ; Tue, 26 May 2020 19:11:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200526191100euoutp029255b7c14292a8430968510e55d070ed~SqcAS2Sgo1195811958euoutp02i DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1590520260; bh=1IJRNFPapx2JgSG1rviP/sukMFI/zSzOoripxUwPpBs=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=gbM+681VjHmQU+h4o5/kOiELW36ITEILWfzPhWN/xuXjmXatH76aiZIeGpGu7DLsv Fc1xK0//mLttDxnCuCxOYzqn3vPRgkuIX7XkKye4gvTxlkDrTGWuaqd2scxmfZVMbQ gJwzJ/xq9etQKLbwCSr/cdKr8AM3L+asaNf48maU= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200526191100eucas1p192342a342739ccd7edc9b99bf119ff12~SqcADkdwB2444924449eucas1p1P; Tue, 26 May 2020 19:11:00 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 76.7E.60679.4C96DCE5; Tue, 26 May 2020 20:11:00 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200526191100eucas1p2505b82b041fdb64fd2ceceadd67749dc~Sqb-s42NE0385303853eucas1p2R; Tue, 26 May 2020 19:11:00 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200526191100eusmtrp2c19f76187e3efff85df218cbe415467a~Sqb-sUoUu0921709217eusmtrp25; Tue, 26 May 2020 19:11:00 +0000 (GMT) X-AuditID: cbfec7f4-0cbff7000001ed07-17-5ecd69c4243e Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 35.F4.08375.4C96DCE5; Tue, 26 May 2020 20:11:00 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200526191059eusmtip138c6f44820b07389bfdaccbf631ee8bc~Sqb_4acqz1119611196eusmtip1B; Tue, 26 May 2020 19:10:59 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com Date: Tue, 26 May 2020 22:10:10 +0300 Message-Id: <20200526191033.16459-8-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200526191033.16459-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSa0hTYRjHec/ZzjmKk+M09qCSsIhSSLNETlGZUToIyk9RitrMk4pObcdr gbm8NFRKxRSXeWsx0cKweSVFtLSammmiYoqQElqa2Cxvy9zOpG//5//8ntvLS+HicqEzFROf xCrj5XFSwlbQ0rcxdORNzGDYUa3GjZktmSaY/JVsjGmtyyOY5dVWjPnSaSAZzcg9kvm2vYgz Je1tiFmdfSdgDJOvSOb52iecaR4wobN2ss3qZ0LZ09cLmKxvspSU/ewaI2QP9PVI1jC3TgQR wbanItm4mBRW6XXmum30x+GvRKKGTJtYf4Rloh1hHrKhgPaB+RUNnodsKTFdh0DTW0TwgRHB aP4La+YXgpn7FfheSU9NHsYndAhK9SoBH6whmF/bsDQm6MNgUFdaKCe6BANVbrml3JH2g7L2 OQskoA+CbnJ0V1OUiD4BFa32/AQ3aHjZbcFt6JPww6gTmLWY3g/jVUaMZypJWH3rxevzYPpd gHjtCIv9epLXrrDTXmXl78CfpnHSvA/Q6t1zanOskB/ovw+R5h1w2h0aO6w9/eFx8QxutoG2 h4klB7ON78riljKrLQJ1rpinpdD9fsRqA5i27HhbBvqJLOsbdiJ4otNihchN839WNUL1SMIm c4ooljsWz6Z6cnIFlxwf5XkjQdGEdj+M4W+/sQ11bEf0IJpCUjsRtTEQJhbKU7h0RQ8CCpc6 ic4NGsLEokh5+m1WmRCuTI5juR7kQgmkEtHx2oVQMR0lT2JjWTaRVe5lMcrGORMFp5lCGq8V pDa73OLcPR7Gqq6G1DRkOBeX5mRMLG4ZwzNztMNtRR79Y4Fdps8SVfGai8Rbcel0gA+jndO6 Rgl3CnWqgANZ9jWhQXY101mR+2ILA+0lU2WHHIaFvejm4QsRaU0ffNUXL08tpS0zzJhvmW4z OiQy3D83teXulWy1VMBFy709cCUn/wf2axQ1LAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrNLMWRmVeSWpSXmKPExsVy+t/xu7pHMs/GGey4wWrxYMpdNovuDy1M FttXdLFZvPu0ncnizt7T7BazLjWxWzz/84rZYsrOHYwWnx6cYLE4fXMzu8WarxeZLbae+cvo wOPxa8FSVo/Fe14yeRy7OY3d4/2+q2wefVtWMXqsfvKDLYAtSs+mKL+0JFUhI7+4xFYp2tDC SM/Q0kLPyMRSz9DYPNbKyFRJ384mJTUnsyy1SN8uQS/j/IXHbAWz2Ctu/JjK1MD4n7WLkZND QsBE4tDCLqYuRi4OIYGljBLLV58EcjiAEhISr58wQ9QIS/y51sUGUfOZUeLSkp9gCTYBDYnT HfPAmkUEljBJ7F11jhEkISxgLzF95xOwDSwCqhLLb15mBRnKK2ApMWc7H8RQeYnVGw6AzeEU sJJ482U5C4gtJJApsf7OfDYIW07i+vwvTBMY+RYwMqxiFEktLc5Nzy021CtOzC0uzUvXS87P 3cQIDPhtx35u3sF4aWPwIUYBDkYlHt6E32fihFgTy4orcw8xSnAwK4nwOp09HSfEm5JYWZVa lB9fVJqTWnyI0RTovonMUqLJ+cBozCuJNzQ1NLewNDQ3Njc2s1AS5+0QOBgjJJCeWJKanZpa kFoE08fEwSnVwNjU/bNArOO66P0/h6rOMLzbofJD7fVaTbWqYktjq2fsF8L3+EQWO/QGmHhf 0dcoDlL/y87RYNjpqZWQUp9TZa5g38HsHervkq6TIfsn3tjk96VtV3Ys3225u6HV8MTffRk6 smV5cjHrjl2L+3xQtlm+edKXjtUa/49M5Dmed6OAf/+l8hvmSizFGYmGWsxFxYkA0OjeFI4C AAA= X-CMS-MailID: 20200526191100eucas1p2505b82b041fdb64fd2ceceadd67749dc X-Msg-Generator: CA X-RootMTR: 20200526191100eucas1p2505b82b041fdb64fd2ceceadd67749dc X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200526191100eucas1p2505b82b041fdb64fd2ceceadd67749dc References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200526191033.16459-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v2 7/7] net/ice: return unknown speed in status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rte_ethdev has declared new NUM_UNKNOWN speed which could be used in case when no speed information is available and link is up. NUM_NONE should be returned, if link is down. Signed-off-by: Ivan Dyukov --- drivers/net/ice/ice_ethdev.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index d5110c439..1c0c087ea 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -3112,8 +3112,11 @@ ice_link_update(struct rte_eth_dev *dev, int wait_to_complete) link.link_speed = ETH_SPEED_NUM_100G; break; case ICE_AQ_LINK_SPEED_UNKNOWN: - default: PMD_DRV_LOG(ERR, "Unknown link speed"); + link.link_speed = ETH_SPEED_NUM_UNKNOWN; + break; + default: + PMD_DRV_LOG(ERR, "None link speed"); link.link_speed = ETH_SPEED_NUM_NONE; break; }