From patchwork Fri Jul 10 14:28:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Kuhn X-Patchwork-Id: 73745 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B1B78A052A; Fri, 10 Jul 2020 16:29:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0FA3B1DB1B; Fri, 10 Jul 2020 16:29:09 +0200 (CEST) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id 05D9A1DB08 for ; Fri, 10 Jul 2020 16:29:07 +0200 (CEST) Received: by mail-wm1-f68.google.com with SMTP id o2so6126475wmh.2 for ; Fri, 10 Jul 2020 07:29:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=gdes89iMVxZMcmLuBhTMjj2meOWpJztr8mGvaMpoJNo=; b=mJpJ9y473x/TPUS1j2aQqQij+84Gm0gkMeb5fn43lYXg3GXw2rKw+o9RwsfCFmK5QS 5lDSJ5vxnIdD20UnSUrs7PfwgoF3ciYgIppns+FzCY6TGq66sZh2s0FfV96R+WMqiyNe VKb7Xp01u1L4H1RBT/NN0/XsdqtnqWVzfTZGotO3hAJweVIknQvf9yH+iRlpd2fB6xLT HKKzBQp/7p9dNbZnqFR3gL9+KH4m1ti4ILbpBeJfkuayeDF8Kvfh9qUHYZKtrvpApUm2 vtBBrhYjhi+3Z6sZFZOpo8ixJyU3J7QVkAENzLeIJBGd9QN4Ifp8KSo/SiqmZksDrsw+ mpUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=gdes89iMVxZMcmLuBhTMjj2meOWpJztr8mGvaMpoJNo=; b=pczcj20fssdatbPtGCr9Rhbmsppy3SfyWBeL4FXY1V755YF4NVndYCKyxVrdRhNJjc Ngf0peRkIv8wxZJUQZ1eZgHybDj93hUBsxTfgHv7DqFjng0nQBdSHTBmFnNWYI/xRBtf 3ZE3ZK5lKData2qLPzk7lPLG2sZmj5r6c4ryYNVX0ib7Ydyi/t6HWAPwqFJRP1G7Sf2/ yG6woIyO8813+e6LMSuQsaBquRNhBeipSFlZ0Av5INMML3N/6+vWBSkYUC7sNAhYqJbO Wp6ZVB2N16erRKlmNn8H/0pMiar5UZA7mozfjiKCm+RVHeNbdOUm/dAYBeNC80FgPV4p vaow== X-Gm-Message-State: AOAM531x9Bg96g93gznrzB6L93oh4j7ZChRg3T5nx2qd8n6G8mZWXaA0 frgbLwKY1vinsfihW8q53lGqXMOqII9tBMPQe6vnUzfT8O1yOo+MmrLFonqOiUisZX/M2MNJ0FB TA/BVBBt6VwqSoV43mue3PklOWl6nEmq1FuLAv3RkmaQfn7IxMyIbZR9cXWoxDw== X-Google-Smtp-Source: ABdhPJxAAYsekIlSJmFiMaM9uQS7C4wTcp28Y4TLZfo/WxzrcOWQEvf8joQzAlob3O4xoRt31kMeGg== X-Received: by 2002:a1c:2402:: with SMTP id k2mr5476204wmk.138.1594391346602; Fri, 10 Jul 2020 07:29:06 -0700 (PDT) Received: from localhost.localdomain (dsl-197-245-84-180.voxdsl.co.za. [197.245.84.180]) by smtp.gmail.com with ESMTPSA id 33sm11352132wri.16.2020.07.10.07.29.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2020 07:29:06 -0700 (PDT) From: Heinrich Kuhn To: dev@dpdk.org Cc: Heinrich Kuhn , stable@dpdk.org, Simon Horman Date: Fri, 10 Jul 2020 16:28:46 +0200 Message-Id: <20200710142846.14110-1-heinrich.kuhn@netronome.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] net/nfp: fix RSS hash configuration reporting X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Prior to this fix the NFP PMD implementation of the .rss_hash_conf_get callback did not propagate the current hardware state of rss_hf back up to the caller. Users of the hash_conf_get callback would receive an incorrect representation of what the RSS configuration currently is in hardware. Fixes: 934e4c60fbff ("nfp: add RSS") Cc: stable@dpdk.org Signed-off-by: Heinrich Kuhn Signed-off-by: Simon Horman --- drivers/net/nfp/nfp_net.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 88e3f01d6..f47200cc4 100644 --- a/drivers/net/nfp/nfp_net.c +++ b/drivers/net/nfp/nfp_net.c @@ -2626,6 +2626,9 @@ nfp_net_rss_hash_conf_get(struct rte_eth_dev *dev, if (cfg_rss_ctrl & NFP_NET_CFG_RSS_IPV6) rss_hf |= ETH_RSS_NONFRAG_IPV4_UDP | ETH_RSS_NONFRAG_IPV6_UDP; + /* Propagate current RSS hash functions to caller */ + rss_conf->rss_hf = rss_hf; + /* Reading the key size */ rss_conf->rss_key_len = nn_cfg_readl(hw, NFP_NET_CFG_RSS_KEY_SZ);