From patchwork Fri Jul 31 04:27:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Wang, Haiyue" X-Patchwork-Id: 75092 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8465A052B; Fri, 31 Jul 2020 06:36:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 831D01C012; Fri, 31 Jul 2020 06:36:38 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 2EB5E1C00E; Fri, 31 Jul 2020 06:36:35 +0200 (CEST) IronPort-SDR: O/Vb5KWMooQ/dcDtQF3WDphgZTd4+T5C0OBpgtS/8/WDe6LlCYHuFhy3h/gAb9sDhhWKP3hgEG aESOxN+k2ntg== X-IronPort-AV: E=McAfee;i="6000,8403,9698"; a="139714208" X-IronPort-AV: E=Sophos;i="5.75,417,1589266800"; d="scan'208";a="139714208" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jul 2020 21:36:34 -0700 IronPort-SDR: zHOYlawut7Rv4awOsugQb0CVQePgBwZvnBg92l3rDbce8LdB2rOxPcvVBdmOdQBf1aanOfDish Sllz2LtU7PWg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,417,1589266800"; d="scan'208";a="313683761" Received: from npg-dpdk-haiyue-3.sh.intel.com ([10.67.118.199]) by fmsmga004.fm.intel.com with ESMTP; 30 Jul 2020 21:36:32 -0700 From: Haiyue Wang To: dev@dpdk.org, qiming.yang@intel.com, qi.z.zhang@intel.com Cc: ting.xu@intel.com, chenmin.sun@intel.com, yinan.wang@intel.com, Haiyue Wang , stable@dpdk.org Date: Fri, 31 Jul 2020 12:27:13 +0800 Message-Id: <20200731042713.209949-1-haiyue.wang@intel.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v1] net/ice: fix burst Tx descriptor set issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The variables 'td_offset' and 'td_tag' should be reset to 0 for every burst packet, otherwise the fields of Tx Descriptor will be set wrong, this will cause the MDD event error, and Tx will hang. Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx") Cc: stable@dpdk.org Signed-off-by: Haiyue Wang Acked-by: Qi Zhang --- drivers/net/ice/ice_rxtx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c index bcb67ec25..b83c5c862 100644 --- a/drivers/net/ice/ice_rxtx.c +++ b/drivers/net/ice/ice_rxtx.c @@ -2431,6 +2431,8 @@ ice_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) tx_pkt = *tx_pkts++; td_cmd = 0; + td_tag = 0; + td_offset = 0; ol_flags = tx_pkt->ol_flags; tx_offload.l2_len = tx_pkt->l2_len; tx_offload.l3_len = tx_pkt->l3_len;