From patchwork Tue Sep 15 19:06:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77786 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2138A04C7; Tue, 15 Sep 2020 21:07:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2E7411C0D9; Tue, 15 Sep 2020 21:07:45 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 319C11C0CF for ; Tue, 15 Sep 2020 21:07:43 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200915190742euoutp02f38549436b642f3f23224b43089b17ba~1CpGFaLNm1701117011euoutp02O; Tue, 15 Sep 2020 19:07:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200915190742euoutp02f38549436b642f3f23224b43089b17ba~1CpGFaLNm1701117011euoutp02O DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1600196862; bh=BG13JEDguLywByJwOXQTWe6Zorck+0Dg5OriYR0Hx5A=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=HX0lRs8YxNRi7gfkG9gWnF+rtsuAThLHFy2GGCy/3KMulyRwsK4w1f4NTvwCEYO/P B0RYAuCPuHBz/nod+tMcq4RyIknzC3KFPKusjqp01GTJgNNj/xj/vS4P0Mp0Qzbkna YOReiSg7WkjbIMoiBcPeLsj/NLbqXhKZuxR5yeQY= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200915190742eucas1p1b9eb8cbe7533a52d38f9590dc51491a9~1CpF38i9E3106731067eucas1p1M; Tue, 15 Sep 2020 19:07:42 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 1B.CF.05997.EF0116F5; Tue, 15 Sep 2020 20:07:42 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200915190742eucas1p2a19ad1f8ee0a19b400652262fd036e67~1CpFhzPAw2574925749eucas1p2e; Tue, 15 Sep 2020 19:07:42 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200915190742eusmtrp19fb23f967264dfeb76ad13cc3686e0c7~1CpFhC-W12872428724eusmtrp1A; Tue, 15 Sep 2020 19:07:42 +0000 (GMT) X-AuditID: cbfec7f4-65dff7000000176d-29-5f6110feeede Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id C5.DB.06314.EF0116F5; Tue, 15 Sep 2020 20:07:42 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200915190740eusmtip22e3a06ec606c533a89f9c13c05b94566~1CpDxn2qW0503405034eusmtip2e; Tue, 15 Sep 2020 19:07:40 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 15 Sep 2020 22:06:56 +0300 Message-Id: <20200915190728.18143-2-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200915190728.18143-1-i.dyukov@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA01Sa0yTZxjN+91prPksOB6VYWgyb5mXgT8eh9GBZvt+aESzZMuCw6pf0IxW 0w9wLibWS5gpULmpoWhXYQas2xApbcHLtE6xq5VIYEh0UkkTb0MFauIFcJRPo//Oc855znmf 5BVonYebLmw15ctmkyFPz2kYz9WXHfPHREPOIv+Zadh43UGw/24djeGqfzksfrafwluu5XjO e5TFij4LhbaKQQq9DVYO/wvvZfDJkJfCO+eDPNo79/I45L/PY2lHDcH7I49orHYOE+xwtLD4 8lIbh09Hahm0veomeNB9jWB7ySCDVa0+gkVWEZ+drOex7k4yDoWvMRjsbebxt+c3aWy5Pkqw vL2RYKjoDftFivTKeYKV6s49pKTK4zdp6WrvYV4qCTgoqemJj5KeXujmJJvbRaS/+4tp6VTk BZel+U6zdLOct7VQNi9ctkGz5fdwBb/dPu3HPluIt5BfE6wkTgBxMdQPP2CtRCPoxAYCo64T bEzQiVECt3uJKgwTeNFxmX63ceVsF6MK9QR8UTenbjwnEPBmxzAnzoHgAQcVMyWITRx4R3qo mBAvpsM9TyuJYUb8BB5HLBNYKy6BoqYoozbMhFOnL060xYmfQ2drN68WJEPPL1FK9U+BQHVk wk+P+/e11NCxMhDfCLCnJzQeKowPK6HBslvNjIdH7W5exUkQrCxhVP/PBMo9zbw6lBHYVzPw 1rUc3I9v8LEgWpwLjW0LVToDIgOXWTV/MtwamKK+YTJUeI7QKq2FA0U61a2Hi4HOtzTA6OtJ Ki2Bv+EPpoyk2D84xv7BMfb3tU5Cu0iiXKAYc2Ul1STvWKAYjEqBKXfBpm3GM2T8NwfH2qM+ 0jay0U9EgegnaZ23N+ToWEOhstPoJyDQ+gRtZij4vU672bDzJ9m8LcdckCcrfjJDYPSJ2rTa h+t1Yq4hX/5BlrfL5ncqJcRNtxBn9l+LF5V+LEf9ifNslWnpH3nnOMbS7OFZl9YNdq3JuDvT V5wzO2vWitVZGWsJe7Q531h7SDgZLr3nKvwnqTQ168qfh5usPV+t5G8szQytcqfP7lvHf/Pl 1+KKeF3/1AeB1uSqlOCazKRvX5s+LeeyOyOpyqGu/CVzS6o3rd6x61hvmZ5Rthg+m0ebFcP/ LW2kTMkDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA02Sf0yMcRzH932e557nam57us58i/lxhNlcnn64T8jv2fMPM1ZrkfOsHtV0 nT3PlZhZYuEQ8mMcOxFDWKWuHyhp9MNJqxQmuVrT/Ap1jKTcdTP+e+/zeX3en/dn+yhJ9V1F oDI51SxKqUKKlvalHCP1XXNHWMEwr6iVhMInNgQ9XfkkOE++puHQl30EvChYAvfKzysg900m ATm5Xwkov2ah4aMzi4L+gXICOqscDFhbsxgYqO1j4EjzOQR9w+9JOJs3iKDZZlfAzwd3aPg8 fImCnKF2BEdLGxDUH/5KwcnKCgTZFha+XL/KQH7nZBhwNlDgeFnCwM1vLSTYn/xGcLy+EEFT 9qhi6TR+KO+Kgs+/947gT1xsIfm6l6cZ/nCjjeCL+ysI/nN1O83nlBYg/nHPIZK/0fuDXusb q1skmdLM4tQkk2yO1G7gIETHRYAuJCxCx4Xq4xaEhGuDFy9KEFOS00UpePFmXdItZy6zzRqQ 8SaniclElzUW5KPEbBh+dPcZ5dFq9grCVd9VFqR01zH+0Et6EX883GGhLcjXjQwiXPLh4RhP s7Ox44CN8DQ07Csat+3fM9bwZxfi7rJK5NEUG+Q2yhzTKjYCZxe7KK/rFHyjqGZsgw+7ALdW tjPeEMn4wv422qsn4+cXXIR31g83nu2lPOFIdhYutKk9ZdJts9d+jjyG/Kz/UdZ/lPU/Kg+R BUgjpsnGRKPM6WTBKKelJuriTcbbyP04ZXU/SypQa/H6WsQqkXacKu/VZoNaIaTLO4y1CCtJ rUa1vMmxSa1KEHbsFCWTQUpLEeVaFO4+8zgZOD7e5H7DVLOBC+f0EMHpQ/Wh80E7QXWAfbBR zSYKZnGrKG4Tpb9zhNInMBNNLdbY1068HzNa018jTVraNCN6cPn6GNXRail2XZ/NvqZzjn7F p6zmkelt0b/8YqNWBa2uztC/FVxciXizYXRGdHBMkH5lpM/A1oszXTtfR25Jz/7ulLqYoZrS qCLLqV3LXGcyXI8C4uOqNh20dDw9gZLjyipCtjsN87t3r9qdsCZXS8lJAjeHlGThD1fDtXZO AwAA X-CMS-MailID: 20200915190742eucas1p2a19ad1f8ee0a19b400652262fd036e67 X-Msg-Generator: CA X-RootMTR: 20200915190742eucas1p2a19ad1f8ee0a19b400652262fd036e67 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200915190742eucas1p2a19ad1f8ee0a19b400652262fd036e67 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200915190728.18143-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v11 01/24] ethdev: allow unknown link speed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Thomas Monjalon When querying the link information, the link status is a mandatory major information. Other boolean values are supposed to be accurate: - duplex mode (half/full) - negotiation (auto/fixed) This API update is making explicit that the link speed information is optional. The value ETH_SPEED_NUM_NONE (0) was already part of the API. The value ETH_SPEED_NUM_UNKNOWN (infinite) is added to cover two different cases: - speed is not known by the driver - device is virtual Suggested-by: Morten Brørup Suggested-by: Benoit Ganne Signed-off-by: Thomas Monjalon Reviewed-by: Ferruh Yigit --- lib/librte_ethdev/rte_ethdev.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index a49242bcd..2090af501 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -303,6 +303,7 @@ struct rte_eth_stats { #define ETH_SPEED_NUM_56G 56000 /**< 56 Gbps */ #define ETH_SPEED_NUM_100G 100000 /**< 100 Gbps */ #define ETH_SPEED_NUM_200G 200000 /**< 200 Gbps */ +#define ETH_SPEED_NUM_UNKNOWN UINT32_MAX /**< Unknown */ /** * A structure used to retrieve link-level information of an Ethernet port. @@ -2262,15 +2263,16 @@ int rte_eth_allmulticast_disable(uint16_t port_id); int rte_eth_allmulticast_get(uint16_t port_id); /** - * Retrieve the status (ON/OFF), the speed (in Mbps) and the mode (HALF-DUPLEX - * or FULL-DUPLEX) of the physical link of an Ethernet device. It might need - * to wait up to 9 seconds in it. + * Retrieve the link status (up/down), the duplex mode (half/full), + * the negotiation (auto/fixed), and if available, the speed (Mbps). + * + * It might need to wait up to 9 seconds. + * @see rte_eth_link_get_nowait. * * @param port_id * The port identifier of the Ethernet device. * @param link - * A pointer to an *rte_eth_link* structure to be filled with - * the status, the speed and the mode of the Ethernet device link. + * Link information written back. * @return * - (0) if successful. * - (-ENOTSUP) if the function is not supported in PMD driver. @@ -2279,15 +2281,13 @@ int rte_eth_allmulticast_get(uint16_t port_id); int rte_eth_link_get(uint16_t port_id, struct rte_eth_link *link); /** - * Retrieve the status (ON/OFF), the speed (in Mbps) and the mode (HALF-DUPLEX - * or FULL-DUPLEX) of the physical link of an Ethernet device. It is a no-wait - * version of rte_eth_link_get(). + * Retrieve the link status (up/down), the duplex mode (half/full), + * the negotiation (auto/fixed), and if available, the speed (Mbps). * * @param port_id * The port identifier of the Ethernet device. * @param link - * A pointer to an *rte_eth_link* structure to be filled with - * the status, the speed and the mode of the Ethernet device link. + * Link information written back. * @return * - (0) if successful. * - (-ENOTSUP) if the function is not supported in PMD driver. From patchwork Tue Sep 15 19:06:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77787 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 903FFA04C7; Tue, 15 Sep 2020 21:08:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8B2231C119; Tue, 15 Sep 2020 21:07:48 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 801801C10D for ; Tue, 15 Sep 2020 21:07:47 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200915190747euoutp0264a92e300717e5b5a34e74e4b8ba69bd~1CpKEcXXK0661606616euoutp02c; Tue, 15 Sep 2020 19:07:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200915190747euoutp0264a92e300717e5b5a34e74e4b8ba69bd~1CpKEcXXK0661606616euoutp02c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1600196867; bh=RQ3/kkDLle8kNv2ZAm9r/hPz4wWBq8W0Dvtw/mrDJa0=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=iT8BFjxlaO4kJVqjD64ouMSmh2LJsV59gqoR24SMDa6wD1yHi6XCtV9MZxmZrsg6F zoAsQN6SqSPhqcAzBF/TEePX0epVi7S6hBCW23DumKf+GH91difMdYqGC7nrOqXLGV A4YpyMbMLB0yOl3ybxd6n4C4b2sLtI7NkB2VlK7w= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200915190746eucas1p1f4e83098f40528fa6999c304098f8cce~1CpJsAELo3097030970eucas1p1T; Tue, 15 Sep 2020 19:07:46 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 35.46.06318.201116F5; Tue, 15 Sep 2020 20:07:46 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200915190746eucas1p2c80920f3eaff2844faf836eaea4c1d42~1CpJLp8n02574925749eucas1p2j; Tue, 15 Sep 2020 19:07:46 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200915190746eusmtrp10cda18771e6791514153607ab0a91a52~1CpJK6CiJ2872428724eusmtrp1G; Tue, 15 Sep 2020 19:07:45 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-53-5f611102ada5 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 38.DB.06314.101116F5; Tue, 15 Sep 2020 20:07:45 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200915190743eusmtip2e08a44b03f82f69e2adc48b30ec97f6a~1CpHP0t961759817598eusmtip2J; Tue, 15 Sep 2020 19:07:43 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 15 Sep 2020 22:06:57 +0300 Message-Id: <20200915190728.18143-3-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200915190728.18143-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSfUwTdxjH99xd747GmqOY+ZtTiU1MNjNejIt7QOMrLmeyRc32z5ZspZML mkLBlrK5uKSzpEpFxMJ0CqlVZCLdhiK0YJBok4muMLCTYLVoYzYNMhQK3QYWlXo1/vf5vvzy PHny42m1g13A7zSUSEaDrkDDKhnP1am+NCpZp80cL9dgc48T8P7dehrDNUMsHhgro/BW01rs 9NYp0HHPQmGlY5xCb6OdxX/Cexl8HPFSGLrk5/B4YC+HEd9DDg/21QI+jD2i8ZhrArDP2abA qSsXWXwSO8Vg5fQA4KHWa4DdFeMM1nS0A9rsAo6dPcNhfWgxRsLXGPQHL3D4c/QGjW09M4CH u5sBe23PFeuWiNOuBoVY3zlMidUnb9Di1eARTqy47qTE84/bKfFJ1wArVrY2gfj7/QO06P7r f3ar8nPl6jypYGepZMxYk6vc4fg3Qhdbc7/xnnzTAj9usUMST4T3yeivLWAHJa8WGoHMBM6x spgEcsfydyKZANLpH2ZePbGNNTJycAZIsCNIySIKpNbay8ZbrPAO8e93vgzmCedZ4o0Nzgqe TxFWk+jR7HiHEZaSrrJ7ijirhCzSYamh5AmpxH3uMh3nJCGbBDoGuDirhcVk8MRkotPPk3bP JzLnkMH/yjiZU8ij7tYELyT+6oqXmxJhH5DDngucLKqAWGtHE621pHXkDy6+HC28S5ovZsj2 elJ783uI20SYS26NJsdtehYdnqO0bKvIfptabmvI5euBhE3IzNM5MoqkM7JSvs4lILdbPEwV pB5/PcoF0ATzJbOpMF8yrTBIX6ebdIUmsyE/fXtRYQvM/lT/s+5oO3TFvvKBwINmjsp1J1er VuhKTbsLfUB4WjNPtaHX/6Valafb/a1kLNIazQWSyQdv84xmvmrFqeEv1EK+rkTSS1KxZHyV UnzSAguE9lg3r5nIyX5j491Yv76ntDxlqEx/ZDjV1rAraP2lSn/z7MJNmQa3jZ38OC1j5Ifi Enc0bF3221xX1rEPt7Fmz64HqrZPQysD0+l54UVM3e0tp5e73xN8/X9yaaHPppZ+d/rBW+Ww anuOGasdzpGhnxo/eNZn36jNKhrVX1FqMz/SMKYduuXLaKNJ9wJ0No/8pQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSbUhTcRTG+997dzdXi9vU+idkNQgqcG6aelxqIYG3TxViH3qbo25TdFvs zl4pbNqUaZYm2ZtrJpJZYWU5Vxa6wJnTRMMyTJNYVPamU/MFrVzStx88z3POgeeISOkYFSJK 15s4o16TKaPFlOe3eyAMLdGoFV+qFFDbbkPwYaCShMHSfhoKhnMJ6K3ZBI2OawIoeZ9NQFHJ CAGOaisN3wbNFPzwOQh499QjhCvdZiH4XJ+EcLbzKoJPM0MkXLaPIui0PRLAVPNjGn7O3KCg aLoHwbmHrQjchSMUlDobEFisDAzfuimEyneh4BtspcDztk4Id8a7SHjUPoug2F2LoMPyR7B5 NTttrxKwlY1fCPZCRRfJtry9KGQLX9gI9v6PBoL9+ayHZose1iC27UMByd72TtLbxbvkcUZD lolblWbgTfGy3UqIkCtjQR6xIVaujIzZq4qIkoUnxB3gMtMPc8bwhFR5WskvH3koJ/Woo2Jp Nrq0zYoCRJjZgC3D1ZQViUVSpgrh4ielpBWJ5gSMv3rJeU8gnnltpec9owgPvKyl/QLNrMWe fBvhF4KYPhq/yjtN+cOBTBweL1P5PRSzBj/LfS/ws4SJxc7sUmJ+6Ep8+17TvwUBjAp3O3uE fpYy6fh63it6nkPxm+tjxHm02I4W1KAgLovXaXW8Us5rdHyWXivfb9A9QHON17dM1TWg7vvJ LsSIkGyRxN6XqpYKNIf5YzoXwiJSFiRJ7PDsk0oOaI4d54wGtTErk+NdKGruwGIyJHi/Ye5/ 9Ca1MkoZA7HKmMiYyGiQLZPkM817pIxWY+IyOO4QZ/yfI0QBIdlIpyiLnqDrA30Fnyf6Tyxf IW7d8v1jb8bQkoVcZG1LsC/c7M1Iid+adGTKZZk0O9nnB3O8cb7RXtvs2fKUhOaLU+xsyZ2N xsKqzuYdivL8j2XDqurcU4u0vL0p9MzJNkgOK07qb+zzrruk0l5panDXrVXsiP5qOZgYzMX3 7lTdlVF8mka5njTymr8sCG57BwMAAA== X-CMS-MailID: 20200915190746eucas1p2c80920f3eaff2844faf836eaea4c1d42 X-Msg-Generator: CA X-RootMTR: 20200915190746eucas1p2c80920f3eaff2844faf836eaea4c1d42 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200915190746eucas1p2c80920f3eaff2844faf836eaea4c1d42 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200915190728.18143-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v11 02/24] ethdev: format a link status text X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" There is new link_speed value introduced. It's INT_MAX value which means that speed is unknown. To simplify processing of the value in application, new function is added which convert link_speed to string. Also dpdk examples have many duplicated code which format entire link status structure to text. This commit adds two functions: * rte_eth_link_speed_to_str - format link_speed to string * rte_eth_link_to_str - convert link status structure to string Signed-off-by: Ivan Dyukov Acked-by: Morten Brørup Reviewed-by: Ferruh Yigit --- MAINTAINERS | 1 + app/test/Makefile | 3 + app/test/meson.build | 2 + app/test/test_ethdev_link.c | 169 +++++++++++++++++++++++ lib/librte_ethdev/rte_ethdev.c | 37 +++++ lib/librte_ethdev/rte_ethdev.h | 32 +++++ lib/librte_ethdev/rte_ethdev_version.map | 4 + 7 files changed, 248 insertions(+) create mode 100644 app/test/test_ethdev_link.c diff --git a/MAINTAINERS b/MAINTAINERS index 5e706cd7e..f4fb31ea2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -393,6 +393,7 @@ T: git://dpdk.org/next/dpdk-next-net F: lib/librte_ethdev/ F: devtools/test-null.sh F: doc/guides/prog_guide/switch_representation.rst +F: app/test/test_ethdev* Flow API M: Ori Kam diff --git a/app/test/Makefile b/app/test/Makefile index e5440774b..9f43b8c3c 100644 --- a/app/test/Makefile +++ b/app/test/Makefile @@ -251,6 +251,9 @@ SRCS-$(CONFIG_RTE_LIBRTE_SECURITY) += test_security.c SRCS-$(CONFIG_RTE_LIBRTE_IPSEC) += test_ipsec.c test_ipsec_perf.c SRCS-$(CONFIG_RTE_LIBRTE_IPSEC) += test_ipsec_sad.c + +SRCS-$(CONFIG_RTE_LIBRTE_ETHER) += test_ethdev_link.c + ifeq ($(CONFIG_RTE_LIBRTE_IPSEC),y) LDLIBS += -lrte_ipsec endif diff --git a/app/test/meson.build b/app/test/meson.build index 56591db4e..1e6acf701 100644 --- a/app/test/meson.build +++ b/app/test/meson.build @@ -39,6 +39,7 @@ test_sources = files('commands.c', 'test_efd.c', 'test_efd_perf.c', 'test_errno.c', + 'test_ethdev_link.c', 'test_event_crypto_adapter.c', 'test_event_eth_rx_adapter.c', 'test_event_ring.c', @@ -199,6 +200,7 @@ fast_tests = [ ['eal_flags_misc_autotest', false], ['eal_fs_autotest', true], ['errno_autotest', true], + ['ethdev_link_status', true], ['event_ring_autotest', true], ['fib_autotest', true], ['fib6_autotest', true], diff --git a/app/test/test_ethdev_link.c b/app/test/test_ethdev_link.c new file mode 100644 index 000000000..ee11987ba --- /dev/null +++ b/app/test/test_ethdev_link.c @@ -0,0 +1,169 @@ +/* SPDX-License-Identifier: BSD-3-Clause + * Copyright (c) 2020 Samsung Electronics Co., Ltd All Rights Reserved + */ + +#include +#include + +#include +#include "test.h" + + +static int32_t +test_link_status_up_default(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_2_5G, + .link_status = ETH_LINK_UP, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_FULL_DUPLEX + }; + char text[RTE_ETH_LINK_MAX_STR_LEN]; + + ret = rte_eth_link_to_str(text, sizeof(text), &link_status); + RTE_TEST_ASSERT(ret > 0, "Failed to format default string\n"); + printf("Default link up #1: %s\n", text); + TEST_ASSERT_BUFFERS_ARE_EQUAL("Link up at 2.5 Gbps FDX Autoneg", + text, strlen(text), "Invalid default link status string"); + + link_status.link_duplex = ETH_LINK_HALF_DUPLEX; + link_status.link_autoneg = ETH_LINK_FIXED; + link_status.link_speed = ETH_SPEED_NUM_10M, + ret = rte_eth_link_to_str(text, sizeof(text), &link_status); + printf("Default link up #2: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "Failed to format default string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("Link up at 10 Mbps HDX Fixed", + text, strlen(text), "Invalid default link status " + "string with HDX"); + + link_status.link_speed = ETH_SPEED_NUM_UNKNOWN; + ret = rte_eth_link_to_str(text, sizeof(text), &link_status); + printf("Default link up #3: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "Failed to format default string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("Link up at Unknown HDX Fixed", + text, strlen(text), "Invalid default link status " + "string with HDX"); + + link_status.link_speed = ETH_SPEED_NUM_NONE; + ret = rte_eth_link_to_str(text, sizeof(text), &link_status); + printf("Default link up #3: %s\n", text); + RTE_TEST_ASSERT(ret > 0, "Failed to format default string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("Link up at None HDX Fixed", + text, strlen(text), "Invalid default link status " + "string with HDX"); + + /* test max str len */ + link_status.link_speed = ETH_SPEED_NUM_200G; + link_status.link_duplex = ETH_LINK_HALF_DUPLEX; + link_status.link_autoneg = ETH_LINK_AUTONEG; + ret = rte_eth_link_to_str(text, sizeof(text), &link_status); + printf("Default link up #4:len = %d, %s\n", ret, text); + RTE_TEST_ASSERT(ret < RTE_ETH_LINK_MAX_STR_LEN, + "String length exceeds max allowed value\n"); + return TEST_SUCCESS; +} + +static int32_t +test_link_status_down_default(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = ETH_SPEED_NUM_2_5G, + .link_status = ETH_LINK_DOWN, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_FULL_DUPLEX + }; + char text[RTE_ETH_LINK_MAX_STR_LEN]; + + ret = rte_eth_link_to_str(text, sizeof(text), &link_status); + RTE_TEST_ASSERT(ret > 0, "Failed to format default string\n"); + TEST_ASSERT_BUFFERS_ARE_EQUAL("Link down", + text, strlen(text), "Invalid default link status string"); + + return TEST_SUCCESS; +} + +static int32_t +test_link_status_invalid(void) +{ + int ret = 0; + struct rte_eth_link link_status = { + .link_speed = 55555, + .link_status = ETH_LINK_UP, + .link_autoneg = ETH_LINK_AUTONEG, + .link_duplex = ETH_LINK_FULL_DUPLEX + }; + char text[RTE_ETH_LINK_MAX_STR_LEN]; + + ret = rte_eth_link_to_str(text, sizeof(text), &link_status); + RTE_TEST_ASSERT(ret < RTE_ETH_LINK_MAX_STR_LEN, + "Failed to format invalid string\n"); + printf("invalid link up #1: len=%d %s\n", ret, text); + TEST_ASSERT_BUFFERS_ARE_EQUAL("Link up at Invalid FDX Autoneg", + text, strlen(text), "Incorrect invalid link status string"); + + return TEST_SUCCESS; +} + + +static int32_t +test_link_speed_all_values(void) +{ + const char *speed; + uint32_t i; + struct link_speed_t { + const char *value; + uint32_t link_speed; + } speed_str_map[] = { + { "None", ETH_SPEED_NUM_NONE }, + { "10 Mbps", ETH_SPEED_NUM_10M }, + { "100 Mbps", ETH_SPEED_NUM_100M }, + { "1 Gbps", ETH_SPEED_NUM_1G }, + { "2.5 Gbps", ETH_SPEED_NUM_2_5G }, + { "5 Gbps", ETH_SPEED_NUM_5G }, + { "10 Gbps", ETH_SPEED_NUM_10G }, + { "20 Gbps", ETH_SPEED_NUM_20G }, + { "25 Gbps", ETH_SPEED_NUM_25G }, + { "40 Gbps", ETH_SPEED_NUM_40G }, + { "50 Gbps", ETH_SPEED_NUM_50G }, + { "56 Gbps", ETH_SPEED_NUM_56G }, + { "100 Gbps", ETH_SPEED_NUM_100G }, + { "200 Gbps", ETH_SPEED_NUM_200G }, + { "Unknown", ETH_SPEED_NUM_UNKNOWN }, + { "Invalid", 50505 } + }; + + for (i = 0; i < sizeof(speed_str_map) / sizeof(struct link_speed_t); + i++) { + speed = rte_eth_link_speed_to_str(speed_str_map[i].link_speed); + TEST_ASSERT_BUFFERS_ARE_EQUAL(speed_str_map[i].value, + speed, strlen(speed_str_map[i].value), + "Invalid link speed string"); + } + return TEST_SUCCESS; +} + +static struct unit_test_suite link_status_testsuite = { + .suite_name = "link status formatting", + .setup = NULL, + .teardown = NULL, + .unit_test_cases = { + TEST_CASE(test_link_status_up_default), + TEST_CASE(test_link_status_down_default), + TEST_CASE(test_link_speed_all_values), + TEST_CASE(test_link_status_invalid), + TEST_CASES_END() /**< NULL terminate unit test array */ + } +}; + +static int +test_link_status(void) +{ + rte_log_set_global_level(RTE_LOG_DEBUG); + rte_log_set_level(RTE_LOGTYPE_EAL, RTE_LOG_DEBUG); + + return unit_test_suite_runner(&link_status_testsuite); +} + +REGISTER_TEST_COMMAND(ethdev_link_status, test_link_status); diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c index d06b7f9b1..438cece72 100644 --- a/lib/librte_ethdev/rte_ethdev.c +++ b/lib/librte_ethdev/rte_ethdev.c @@ -2383,6 +2383,43 @@ rte_eth_link_get_nowait(uint16_t port_id, struct rte_eth_link *eth_link) return 0; } +const char * +rte_eth_link_speed_to_str(uint32_t link_speed) +{ + switch (link_speed) { + case ETH_SPEED_NUM_NONE: return "None"; + case ETH_SPEED_NUM_10M: return "10 Mbps"; + case ETH_SPEED_NUM_100M: return "100 Mbps"; + case ETH_SPEED_NUM_1G: return "1 Gbps"; + case ETH_SPEED_NUM_2_5G: return "2.5 Gbps"; + case ETH_SPEED_NUM_5G: return "5 Gbps"; + case ETH_SPEED_NUM_10G: return "10 Gbps"; + case ETH_SPEED_NUM_20G: return "20 Gbps"; + case ETH_SPEED_NUM_25G: return "25 Gbps"; + case ETH_SPEED_NUM_40G: return "40 Gbps"; + case ETH_SPEED_NUM_50G: return "50 Gbps"; + case ETH_SPEED_NUM_56G: return "56 Gbps"; + case ETH_SPEED_NUM_100G: return "100 Gbps"; + case ETH_SPEED_NUM_200G: return "200 Gbps"; + case ETH_SPEED_NUM_UNKNOWN: return "Unknown"; + default: return "Invalid"; + } +} + +int +rte_eth_link_to_str(char *str, size_t len, const struct rte_eth_link *eth_link) +{ + if (eth_link->link_status == ETH_LINK_DOWN) + return snprintf(str, len, "Link down"); + else + return snprintf(str, len, "Link up at %s %s %s", + rte_eth_link_speed_to_str(eth_link->link_speed), + (eth_link->link_duplex == ETH_LINK_FULL_DUPLEX) ? + "FDX" : "HDX", + (eth_link->link_autoneg == ETH_LINK_AUTONEG) ? + "Autoneg" : "Fixed"); +} + int rte_eth_stats_get(uint16_t port_id, struct rte_eth_stats *stats) { diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index 2090af501..a86f8f916 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -323,6 +323,7 @@ struct rte_eth_link { #define ETH_LINK_UP 1 /**< Link is up (see link_status). */ #define ETH_LINK_FIXED 0 /**< No autonegotiation (see link_autoneg). */ #define ETH_LINK_AUTONEG 1 /**< Autonegotiated (see link_autoneg). */ +#define RTE_ETH_LINK_MAX_STR_LEN 40 /**< Max length of default link string. */ /** * A structure used to configure the ring threshold registers of an RX/TX @@ -2295,6 +2296,37 @@ int rte_eth_link_get(uint16_t port_id, struct rte_eth_link *link); */ int rte_eth_link_get_nowait(uint16_t port_id, struct rte_eth_link *link); +/** + * The function converts a link_speed to a string. It handles all special + * values like unknown or none speed. + * @param link_speed + * link_speed of rte_eth_link struct + * @return + * Link speed in textual format. It's pointer to immutable memory. + * No free is required. + */ +__rte_experimental +const char *rte_eth_link_speed_to_str(uint32_t speed_link); + +/** + * The function converts a rte_eth_link struct representing a link status to + * a string. + * @param str + * A pointer to a string to be filled with textual representation of + * device status. At least ETH_LINK_MAX_STR_LEN bytes should be allocated to + * store default link status text. + * @param len + * Length of available memory at 'str' string. + * @param eth_link + * Link status returned by rte_eth_link_get function + * @return + * - Number of bytes written to str array. + * + */ +__rte_experimental +int rte_eth_link_to_str(char *str, size_t len, + const struct rte_eth_link *eth_link); + /** * Retrieve the general I/O statistics of an Ethernet device. * diff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethdev/rte_ethdev_version.map index 715505604..69a763d4b 100644 --- a/lib/librte_ethdev/rte_ethdev_version.map +++ b/lib/librte_ethdev/rte_ethdev_version.map @@ -241,4 +241,8 @@ EXPERIMENTAL { __rte_ethdev_trace_rx_burst; __rte_ethdev_trace_tx_burst; rte_flow_get_aged_flows; + + # added in 20.11 + rte_eth_link_to_str; + rte_eth_link_speed_to_str; }; From patchwork Tue Sep 15 19:06:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77788 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C895A04C7; Tue, 15 Sep 2020 21:08:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C395F1C10F; Tue, 15 Sep 2020 21:07:51 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 20FF51C10E for ; Tue, 15 Sep 2020 21:07:50 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200915190749euoutp012c8dab6b7292f37a52ec1b80688a6a8a~1CpMdaFM10530105301euoutp01T; Tue, 15 Sep 2020 19:07:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200915190749euoutp012c8dab6b7292f37a52ec1b80688a6a8a~1CpMdaFM10530105301euoutp01T DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1600196869; bh=A2PTzi/6QAPdj31SukY6WaSzyjFhYitbEDWVAQoenkE=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=c/2kyi4XN4QnQvB+zlgCVcZTvlm/zwGI34kVWI7sVCMQfkC114D47nwJ1OJXbZp08 5Y1imXjANQ6mibRTfYcKtYVC9MUQNAUwL6HQz3hHirCOSVQCms5Z8xKLJmuxCz7BTY 7i8hCQW5Iw8y57uEDZtZO9jylTz/zb7/RexQ9SaQ= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200915190749eucas1p10acec7e593034d8cf8b33d2d74148a61~1CpMJCRt33097130971eucas1p1S; Tue, 15 Sep 2020 19:07:49 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id F7.46.06318.501116F5; Tue, 15 Sep 2020 20:07:49 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200915190748eucas1p171de0997902ef5c415bdd60e391ae631~1CpLxTG0r3097030970eucas1p1Y; Tue, 15 Sep 2020 19:07:48 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200915190748eusmtrp19aaa08952e5aa4e16f034ec1e56eadba~1CpLwUOdK3148631486eusmtrp1C; Tue, 15 Sep 2020 19:07:48 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-57-5f61110519e2 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 11.EB.06017.401116F5; Tue, 15 Sep 2020 20:07:48 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200915190746eusmtip253380944e2c80083e28f465370995825~1CpJ-yzwn1712017120eusmtip2F; Tue, 15 Sep 2020 19:07:46 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 15 Sep 2020 22:06:58 +0300 Message-Id: <20200915190728.18143-4-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200915190728.18143-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSf0yUdRzH+z6/uXHu8byNz7Agb7VlDSi1+CQN1LX52Jq6NjfXVnjFM6C4 w90jmLrVpYBwIOiJlODokpoEBhoHBw4dUuOgQxH0Bg5QJJ2hcPyWoPMHx3PO/97v1+f9/n62 z74CrSvhwoVU8x7ZYjamGTgN09A23xXFLjcmvp1XpMHaznKCw7cqaBwqHuQwfyKLwr6qBGx2 nWLRfttKYaF9kkJXpY3D0aGDDPqmXBQOXPTwWNpzkMep1vs8HukqI3jf/4DGk45pgl3l9SzO X77A4bj/NIOFC16CRc52gu6CSQaLmxoJ5thEnPjtDI8VAxE4NdTOoOdmHY9nZ7tprO98TPCY u5bglZyn7IZV0oLjV1aqaB6hpOM/d9NS280SXiroKKek875GShq/5OWkQmcVkf4ezqel6rv/ cds1n2o+SJLTUjNlS0z8Lk1KVs/v7O7iuG9qmltoK3FG20iIAOI6qO4/x9qIRtCJlQQapsc5 1cwQcJT6KNVMEzjx8A7zvDK1cJ1XB2cIdAzU0KqZJTDzKHspxYlvgCe3fKmuF89z4PL3UoHB CvFjuN1/iw9oRnwdrJ3/sgGtFd8H14+ngisiofpcCx3QIeJ66GnyLuV1YgT0/jSz9CiInQLk PSli1cKHcORPX7C8Ah64nbyqXwbP8QJGLRwmcKyhjlfNUQKHysaCqQRwPry6qAWBFldD7YUY FW+EYe8vdACDuAz6xpYHML0o7Q0/BLEWcnN0atoALR09QQzw+P9QFUtw5/u84LUuEqic/Ic5 SiJLX+xyEFJFwuQMxZQsK2vN8t5oxWhSMszJ0V+mm/4gi7/V88Q920gu+b9oJaJADKFaR/+u RB1rzFT2mVoJCLRBr910xfO5Tptk3LdftqQnWjLSZKWVrBQYQ5h27emRz3RisnGP/LUs75Yt z6eUEBJuJbErU2t2uMPzTs75qa45vbA9NDxs73uHej/5KzL2hC2OrI4wfzXfFq+fqC8zX336 Uc7l7+a2dbdcK0yIsltea747uuPRuhvfrtG4GwusI/0lBw40ZQ+mOHbqo4T0voj1mW/1+jSv 5O989aU609lRe9ZWr7It7l0Smz3WPhiTuyXp3uZ4A6OkGN95k7YoxmcAp7O2qQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSa0hTcRjG/Z9zds7ZaHFaSn8MugyCCjw1l+7VTKMPcYI+RNGHrnqo44Xc JjszMoKsRtmqlSZdba6GpetiF20WM9QPWm4rdFialywCu06bRWV2cVnffvC8z/u88LwsqflC xbN5JqtkMYn5WlpF+X+1DSRQ08TMxd/aE6A24ETwasBNwmB5Pw1HRmwEdHsywOetUEDZi2IC HGWfCPBW22n4MLifgnDES0Bfo5+Bc537GYi0DDFw7Ml5BEPj70g46xpF8MRZr4DvzfdpGB6/ RIFjrAvB8bqHCNqOfqKg/F4DgoN2DkZqrjDg7psFkcGHFPh77jBw7UsHCfWBnwhK22oRBA/+ ViyfK4y5qhSC2/eWEE5e7CCF1p5TjHD0kZMQboUbCGH4QRctOOo8SGh/dYQUrr7+Rq9RbeTT LOZCqzQn1yxbl2k36SCR16UAn7gkhdfpDVtSE5O0i9LTtkv5eTsly6L0LD7X1nldUVC+dNcN XxNZjOp4O1KymFuCI2Mhxo5UrIarQrj7kpO0I3ZCwPj9a3JyZjoef2qno6zhRhF+GTJFmebm Y3+Jk4h6Y7leGocO7aOiwnRuNX7RO8BEmeLm4eLAG0WU1VwK9p6poCaXzsZXbzb9DVByqbjz XhczGZCHKw+F/oXNws8qPxMn0FQXivGgWKlQNuYY5UReFo1yoSmH32Y23kYTld9t/V7XgOzh dS2IY5F2itrVm5WpUYg75SJjC8IsqY1Vrwj6t2rU28Wi3ZLFnGkpzJfkFpQ0cWApGR+3zTzx QCZrpi5JZ4AUnUFv0CeDdoa6hGverOFyRKu0Q5IKJMt/H8Eq44vR5YRSOegfN8KYz+EOU3ls j7LSJp2N25Ktr615PrM+++sU9WfWTd8Mq3wFnq+OtbYmb6S/OndZTEZy0Q+978oFZRr1OH20 e6SPH1q146k/9QAOxm/w59t/GkRu+GP2YVvjvvsL1guBx66SW5rW2A7jnovVvmMrf53eG6q5 nKWl5FxRt5C0yOIfxU0rKQgDAAA= X-CMS-MailID: 20200915190748eucas1p171de0997902ef5c415bdd60e391ae631 X-Msg-Generator: CA X-RootMTR: 20200915190748eucas1p171de0997902ef5c415bdd60e391ae631 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200915190748eucas1p171de0997902ef5c415bdd60e391ae631 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200915190728.18143-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v11 03/24] app: update apps&docs with new UNKNOWN link speed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications and docs Signed-off-by: Ivan Dyukov Reviewed-by: Ferruh Yigit --- app/proc-info/main.c | 11 +++++------ app/test-pipeline/init.c | 11 +++++------ app/test-pmd/config.c | 9 +++++---- app/test-pmd/testpmd.c | 12 ++++-------- app/test/test_pmd_perf.c | 17 +++++++---------- doc/guides/sample_app_ug/link_status_intr.rst | 10 +++++----- 6 files changed, 31 insertions(+), 39 deletions(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index abeca4aab..0b030d326 100644 --- a/app/proc-info/main.c +++ b/app/proc-info/main.c @@ -672,6 +672,7 @@ show_port(void) struct rte_eth_dev_info dev_info; struct rte_eth_rxq_info queue_info; struct rte_eth_rss_conf rss_conf; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; memset(&rss_conf, 0, sizeof(rss_conf)); @@ -685,12 +686,10 @@ show_port(void) printf("Link get failed (port %u): %s\n", i, rte_strerror(-ret)); } else { - printf("\t -- link speed %d duplex %d," - " auto neg %d status %d\n", - link.link_speed, - link.link_duplex, - link.link_autoneg, - link.link_status); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), + &link); + printf("\t%s\n", link_status_text); } printf("\t -- promiscuous (%d)\n", rte_eth_promiscuous_get(i)); diff --git a/app/test-pipeline/init.c b/app/test-pipeline/init.c index 67d54ae05..fe37d6373 100644 --- a/app/test-pipeline/init.c +++ b/app/test-pipeline/init.c @@ -155,7 +155,7 @@ static void app_ports_check_link(void) { uint32_t all_ports_up, i; - + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; all_ports_up = 1; for (i = 0; i < app.n_ports; i++) { @@ -173,12 +173,11 @@ app_ports_check_link(void) all_ports_up = 0; continue; } - - RTE_LOG(INFO, USER1, "Port %u (%u Gbps) %s\n", + rte_eth_link_to_str(link_status_text, sizeof(link_status_text), + &link); + RTE_LOG(INFO, USER1, "Port %u %s\n", port, - link.link_speed / 1000, - link.link_status ? "UP" : "DOWN"); - + link_status_text); if (link.link_status == ETH_LINK_DOWN) all_ports_up = 0; } diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index a7112c998..f814de29c 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -605,7 +605,7 @@ port_infos_display(portid_t port_id) printf("\nmemory allocation on the socket: %u",port->socket_id); printf("\nLink status: %s\n", (link.link_status) ? ("up") : ("down")); - printf("Link speed: %u Mbps\n", (unsigned) link.link_speed); + printf("Link speed: %s\n", rte_eth_link_speed_to_str(link.link_speed)); printf("Link duplex: %s\n", (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? ("full-duplex") : ("half-duplex")); @@ -750,12 +750,12 @@ port_summary_display(portid_t port_id) if (ret != 0) return; - printf("%-4d %02X:%02X:%02X:%02X:%02X:%02X %-12s %-14s %-8s %uMbps\n", + printf("%-4d %02X:%02X:%02X:%02X:%02X:%02X %-12s %-14s %-8s %s\n", port_id, mac_addr.addr_bytes[0], mac_addr.addr_bytes[1], mac_addr.addr_bytes[2], mac_addr.addr_bytes[3], mac_addr.addr_bytes[4], mac_addr.addr_bytes[5], name, dev_info.driver_name, (link.link_status) ? ("up") : ("down"), - (unsigned int) link.link_speed); + rte_eth_link_speed_to_str(link.link_speed)); } void @@ -3899,7 +3899,8 @@ set_queue_rate_limit(portid_t port_id, uint16_t queue_idx, uint16_t rate) ret = eth_link_get_nowait_print_err(port_id, &link); if (ret < 0) return 1; - if (rate > link.link_speed) { + if (link.link_speed != ETH_SPEED_NUM_UNKNOWN && + rate > link.link_speed) { printf("Invalid rate value:%u bigger than link speed: %u\n", rate, link.link_speed); return 1; diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 4989d22ca..e996e2b75 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2991,6 +2991,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status[RTE_ETH_LINK_MAX_STR_LEN]; printf("Checking link statuses...\n"); fflush(stdout); @@ -3010,14 +3011,9 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. speed %u Mbps- %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status, + sizeof(link_status), &link); + printf("Port %d %s\n", portid, link_status); continue; } /* clear all_ports_up flag if any link down */ diff --git a/app/test/test_pmd_perf.c b/app/test/test_pmd_perf.c index 352cd4715..d1240b76f 100644 --- a/app/test/test_pmd_perf.c +++ b/app/test/test_pmd_perf.c @@ -126,6 +126,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status[RTE_ETH_LINK_MAX_STR_LEN]; printf("Checking link statuses...\n"); fflush(stdout); @@ -146,16 +147,12 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) { - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - if (link_mbps == 0) - link_mbps = link.link_speed; - } else - printf("Port %d Link Down\n", portid); + if (link.link_status && link_mbps == 0) + link_mbps = link.link_speed; + + rte_eth_link_to_str(link_status, + sizeof(link_status), &link); + printf("Port %d %s\n", portid, link_status); continue; } /* clear all_ports_up flag if any link down */ diff --git a/doc/guides/sample_app_ug/link_status_intr.rst b/doc/guides/sample_app_ug/link_status_intr.rst index 04c40f285..1057c7584 100644 --- a/doc/guides/sample_app_ug/link_status_intr.rst +++ b/doc/guides/sample_app_ug/link_status_intr.rst @@ -158,6 +158,7 @@ An example callback function that has been written as indicated below. { struct rte_eth_link link; int ret; + char link_status[RTE_ETH_LINK_MAX_STR_LEN]; RTE_SET_USED(param); @@ -169,11 +170,10 @@ An example callback function that has been written as indicated below. if (ret < 0) { printf("Failed to get port %d link status: %s\n\n", port_id, rte_strerror(-ret)); - } else if (link.link_status) { - printf("Port %d Link Up - speed %u Mbps - %s\n\n", port_id, (unsigned)link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? ("full-duplex") : ("half-duplex")); - } else - printf("Port %d Link Down\n\n", port_id); + } else { + rte_eth_link_to_str(link_status, sizeof(link_status), &link); + printf("Port %d %s\n", port_id, link_status); + } } This function is called when a link status interrupt is present for the right port. From patchwork Tue Sep 15 19:06:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77789 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 822A5A04C7; Tue, 15 Sep 2020 21:08:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4B8521C12C; Tue, 15 Sep 2020 21:07:54 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 0959C1C120 for ; Tue, 15 Sep 2020 21:07:53 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200915190752euoutp01da2f53baf76b6e99e1c93112d32c0a9b~1CpPcRvB80517005170euoutp01Y; Tue, 15 Sep 2020 19:07:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200915190752euoutp01da2f53baf76b6e99e1c93112d32c0a9b~1CpPcRvB80517005170euoutp01Y DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1600196872; bh=1R9omrZ5fAPdKYuUkOS/6cuY8buXbZ+pEv8UB5bwG/w=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=YFlXCdO1gu7hPdePbRjYihu/MTrzKtY46GybIHw4JiSxGsIcHV7p1Hlr3BPBnwBjj aRJyhjhv8ghm9zSez53ApcJEt86bAoctaGORmib/XsFquQ7MVchMiiMTHbVqTDq0fZ iPtq4lPJbE9ihoXMo9PK8PNNIjoADD5fTlrgGuew= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200915190752eucas1p264abf8055cfc15fa70ebf52ffd13d305~1CpOuXx8g1274112741eucas1p2k; Tue, 15 Sep 2020 19:07:52 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 2E.CF.05997.701116F5; Tue, 15 Sep 2020 20:07:51 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200915190751eucas1p20c71494682efc4dbcda7836db5af1558~1CpOYv0Ot1274112741eucas1p2j; Tue, 15 Sep 2020 19:07:51 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200915190751eusmtrp17dbee6b93074451def2a93cf420a4da6~1CpOX97_23148631486eusmtrp1E; Tue, 15 Sep 2020 19:07:51 +0000 (GMT) X-AuditID: cbfec7f4-65dff7000000176d-39-5f6111070a05 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id FA.DB.06314.701116F5; Tue, 15 Sep 2020 20:07:51 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200915190749eusmtip28c1b978247d0d6e608627ae6322cc058~1CpMmJiyd1712017120eusmtip2G; Tue, 15 Sep 2020 19:07:49 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 15 Sep 2020 22:06:59 +0300 Message-Id: <20200915190728.18143-5-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200915190728.18143-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSf0zUdRjH93x/c/Po61enT1C6zrXI+btaT45hNba+rtVcW6VtCpd8BY1D uq+I1lZkdNKJiHCLiQ7xyJ1Cicpx/G6KjkNOfsjG0A6DEcuJ4AGCS8OU40vrv9f7/fz4fJ5n j8QqhUKUtDNtj2ZPs6ZaBBPna3nUuVKcb01Y4xx8kyqvlwAN/lHG0oDrtkCHxrIZulm+gRpr TvBU0J/FUF7BOEM1Z5wCjQwc4Oj+RA1DfU0BkYq7D4g00XxHpMOdx4HuTA+zdKz0AVBnSTVP jy7XCxSadnOU97gH6Ii3FcifO86Rq64WyOGUaeysR6SyviU0MdDKUeBWlUi/TN1gqfr6E6Cj /kqgdsdT/u2X1Melp3m1rPEuoxaeusGqLbd+EtXcayWMeuF+LaOGfusR1DxvOahtg4dYtWLo b2GT6TNTbJKWunOvZl8dl2hKaT2Xmd4m7vvz58tCFvgEJ0RIKL+OvlMNnBNMkiKfAQwGx8EQ k4CjI8O8IR4A1rW0sE6QZkuqhjIM3wPoCXoEQ0wB/u53suG+ghyDgZwSJhxYKF8QsGa6lwkH Fsjx6JgKzTInv4yhphAfZrP8Flb3nuWNTy3FivOXZhtFyOuxu65HDLMiL8Hek5OzTVHukrDh 4RHOKIhH11jOHC/AYb9XNPgFDBTmckbBQcCjvirREPmA3x8fncvagN57HWJ4OFZ+FSvrVxv2 O5hX1MEZM0fizdH5YZudwQJf0dwqzJjjUIxsC1661j1nIz75Z56BKnZWxBn7aQJ0ZXex+bC0 +P+nSgHKYbGWoduSNX1dmpa5Srfa9Iy05FXbd9suwsypBv71T9ZC/fTnzSBLYJlnLg0mJii8 da++39YMKLGWheZ32wPbFHOSdf9Xmn13gj0jVdObIVriLIvNr7nvblXkZOse7QtNS9fs/0UZ KSJq5gwS721Z2/TBMlswMupXLd6RtXF9fyNfvqLj/JdvVIycXLbpYXbZ9vd3KCsqW4s++Sb2 h5Xm6Lbo9FFvzI/uiIbGrhNxL17pn0p5z+MqPD24OQEy/0o6V/vd4ZHAol37+vSDu3LU2Ocj N77y3Lpvr279qL346/zNyqfbPrzNtXvcOz6OGXJvsXB6inXtctauW58BiO4VEKYDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSaUwTYRCG/Xa3uy1as1TETzSIjSQeoVoOOyWIhqhZ/5kY/ygKG1wBpVS7 LajRBIkBLVDkkASPiuJFIRwih0ZUiIFqQQVFJBwSQBGvyqHxwKOF+O/JvDPvvMmMlFRMUj7S +ESjYEjkE5S0B+X409IfwHjyUWvMdX5Q0WpFMNhfTMJAfh8NGV9OEPDKth7u1p2XQO7rFAIs uWME1N0w0/BxIJWCz+N1BPQ2OBg425HKwHjTCANZT88hGJl6T0Jh0QSCp9YaCfxovEODc+oy BZafnQiyb9kRtGSOUZB/ux5BmpmFLyXXGSju9YXxATsFju5qBsq+tpNQ0/obQU5LBYK2tL+S DUu5n0VXJVzx3VGCy7vUTnLN3QUMl/nISnBVn+sJznmvk+Yst2yIezyYQXKlw9/prR47VGEG vcko+MXpReM65U41BKrUWlAFBmtV6iDNrtDAEOXq8LA9QkJ8kmBYHR6tirOXJx94zBwautJI p6Ba2oykUswG4+phkxl5SBXsVYS/V5aRM3WMPwy7UObCeXjqpZme6ZlAuNhezrgFml2OHSet hFvwYnto/Dz9OOUW5rEbcdpXJ+FmivXHzganxM1yVotrukokM65LcGnlg+kNMjYUd9zunDZV sPH4YvpzeoZ9cdfFSeI0mluEZtmQl2ASdbE6Ua0SeZ1oSoxVxeh1N5Hr4rXNP6rrUUfVtibE SpFyjryoJzpKIeGTxMO6JoSlpNJLHtHm2K2Q7+EPHxEM+iiDKUEQm1CIK2AO6TM/Ru/6n0Rj lDpErQGtWhOkCVoLygXyk2xjpIKN5Y3CfkE4IBj+zxFSmU8KCpzbEiZbvKZbl111JgvTsmh/ Y2z7m4jgoyHezftsDX39AYWWLU/G1u4Nr5ko4Sf9s1b6fdt0M9X0Imu/49iy2Unei96u2G79 pR+Ny3/y0HKhZ4f/knezAzzzwi/bcomFfYLQf//Zp4Ob21cln6rIuPZ7SNEgFtgPpT2MlGSM avNGNEpKjOPVK0mDyP8DYqiR8QcDAAA= X-CMS-MailID: 20200915190751eucas1p20c71494682efc4dbcda7836db5af1558 X-Msg-Generator: CA X-RootMTR: 20200915190751eucas1p20c71494682efc4dbcda7836db5af1558 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200915190751eucas1p20c71494682efc4dbcda7836db5af1558 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200915190728.18143-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v11 04/24] net/ixgbe: return unknown speed in status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rte_ethdev has declared new NUM_UNKNOWN speed which could be used in case when no speed information is available Signed-off-by: Ivan Dyukov Reviewed-by: Wei Zhao --- drivers/net/ixgbe/ixgbe_ethdev.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 248f21d14..34a171116 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -4300,11 +4300,7 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev, switch (link_speed) { default: case IXGBE_LINK_SPEED_UNKNOWN: - if (hw->device_id == IXGBE_DEV_ID_X550EM_A_1G_T || - hw->device_id == IXGBE_DEV_ID_X550EM_A_1G_T_L) - link.link_speed = ETH_SPEED_NUM_10M; - else - link.link_speed = ETH_SPEED_NUM_100M; + link.link_speed = ETH_SPEED_NUM_UNKNOWN; break; case IXGBE_LINK_SPEED_100_FULL: From patchwork Tue Sep 15 19:07:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77790 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6A2ADA04C7; Tue, 15 Sep 2020 21:08:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E672E1C132; Tue, 15 Sep 2020 21:07:57 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id D52161C131 for ; Tue, 15 Sep 2020 21:07:55 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200915190755euoutp02ceeefb6694e594e0209416008de4bc78~1CpSF0trR0661006610euoutp02f; Tue, 15 Sep 2020 19:07:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200915190755euoutp02ceeefb6694e594e0209416008de4bc78~1CpSF0trR0661006610euoutp02f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1600196875; bh=zbg2xoSaiDgck4H57R7Z3rwqX+vJJlCAoA2nccHDMek=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=UiGV6y0ov1bxN0JHO4CZqYv710TXGbal4u9kLYvi2jQQxv1XrzNBxdVfEFW9Bk+pa vgPjGRYXmA/kAcxlKwq0DDFF17QPePfW+8KGnPS+/k2ZoFi6OuW3fs2YI2S6pVpe/v hVsAXTlN3q5oCdIRKSt0IVncFtn5y2ESqbgnSRGw= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200915190755eucas1p2b53b734765929a92c1e2b93e4b90cedf~1CpRnOnYJ2574925749eucas1p2t; Tue, 15 Sep 2020 19:07:55 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 60.DF.05997.A01116F5; Tue, 15 Sep 2020 20:07:54 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200915190754eucas1p110b35ee7bbb1143e153f8f1469528fdb~1CpRJPEeP3097130971eucas1p1X; Tue, 15 Sep 2020 19:07:54 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200915190754eusmtrp176df0165baccf37aac8080bcd14f5b1c~1CpRIcO3Q2872428724eusmtrp1M; Tue, 15 Sep 2020 19:07:54 +0000 (GMT) X-AuditID: cbfec7f4-65dff7000000176d-3d-5f61110a908d Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 4D.DB.06314.A01116F5; Tue, 15 Sep 2020 20:07:54 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200915190752eusmtip26af1b68f95cd8ccdca741e4b02da7641~1CpPYBum-1712017120eusmtip2H; Tue, 15 Sep 2020 19:07:52 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 15 Sep 2020 22:07:00 +0300 Message-Id: <20200915190728.18143-6-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200915190728.18143-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0VSa0xTZxj2O+f0nENHyWeR+Vqnbo3GzUTQOfXVOO/Zjj80y2KiMdmw0xM0 QiEtOMVMCSprSkUBdSudXQXlUowM6QUaMcoPLhblonhFx4yXiEIFMVGst3Iw+/e8z+V73rz5 RFZbyOvErcZ02WQ0JOt5NedrfNU2Uz3WkDjrYe4irGp1Erx3t4TFnsN3eMx9to/BG+4leNb/ lwoL/s1iMK9ggEF/uZXHpz3ZHPYP+hnsrg8KWNSZLeBgwyMBD7Q5CD4K97Jodz0n2Ob0qvDV hQCPoXAxh3nDXQQPepoJNtkGODxcV0swx0rxWUWZgCXdk3Gwp5nD4M0aAU+96GDR2/qGYH5T FcFLOe9US7+Qhl0nVVLJ2ceMVHi8g5Uabx4VJFuLk5Gq+2sZKXSui5fyPG4iXbyXy0qV91/y P6g3qBdtlpO3bpdNCYs3qrdYOm4Jae0xO3wBF5NFjkVbSZQI9BvoDN/irUQtamk5gYrQaT4i aOkQgcDBiYrwnMBdl539mCi/X80pQhkBe0sfqwwvCNh8QVXExdMvIWhxMhFhHK3mwR++zkSE WLoCLp5wjGCOTgOLzS9YiShq6ALot1OlYQpU/nN+pC2KLoTOui5BWWkyXP97aORNoK0iWP87 pVICK6H5gXcUx0Jvk0dQ8GcQLLRxSuB3Avm+GkEZDhHY6+gbdS0Bz5PLI1uw9CuoCiQo9DIY eNCiitBAY+BG39gIzX6ABb4/WIXWgCVHq7j1cL6lc5QGePM6WoESVDamKuepJ1DaXcMcIlOK /q9yEeIm4+UMc0qSbP7aKP8abzakmDOMSfGbUlPOkA9fNfi2aaiWBMK/NBAqEn20xnV7Y6JW Zdhu3pnSQEBk9eM0yy8Ff9ZqNht2Zsqm1ERTRrJsbiATRU4/XjOn+PFPWppkSJe3yXKabPqo MmKULousMn5fl0DjTJb9V3LHFC+7o4s76v588LVnfuYF19r6mPTdU9enx6+2tHuzD3z6ict5 st3x3Zji0pml87y3V9P80PG0Pevcw3Om02vzCwbWnK4I7XUv6NHNrTU6uv7UJr71Tei1x//2 9OriyyZd5pqy7Gtru8/s+vbEj5V2OXbSriNFcaV6zrzFMHsGazIb3gNKmobxpgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSfUgTcRjH+93d7k5xcc1Jl5HZRVGBs/nSnkVWWMFVUJF/9aLz0EMtt9lu RvVHWETZMk17f7OVmWWC+ToVixyk5lymYvneUEGt0JwFJZZtSf994fN9vs8D34fGFT+IQDrF YBZNBiGVI30Jx5+mwRDfRYJufXnhcihtzUcwNFiAg+vaAAmXvp3DoLt4C9Tb7skg71MGBtl5 UxjYnlpI+Oo6S8CE24ZB/0sHBXc6zlLgto9ScLntLoLR2c843LZOI2jLr5LBr4Y6EiZnHxGQ PdOFIKeyGUFT1hQB12prEJy3MPDtWREFBf1B4HY1E+DoqaCg5Ec7DlWtvxHkNpUicJ6fk21d wc9YC2V8Qf04xl992I7zjT03KD7rbT7Gl03UYPzkqy6Sz64sRnzL0CWcfz7yk9zne1C1yWRM N4vByUbJHMUdUkOYSq0FVViEVqUO18RuDIvkQjdvShRTU46LptDN8arkzPZeKu39whPVdVYs A933syAfmmUi2KcjZYQF+dIKphCxT95MYhZEewDLfhnB5z3+7OwHCznvmfZ4xm5SXkAya1hH Zj7mBUqmj2Q7L5whvMCf2ca2PL6LeTXBrGIzs2yUN1TOaNmJ28x86HL2+YvX/xb4MBvZjtqu f5kKJoV9cKGTnNdB7McH37EraKEVLShGSjFd0ifpJbVKEvRSuiFJlWDUlyNP5dWNvypqUEdZ jB0xNOL85Na+eJ1CJhyXTurtiKVxTimPdjriFPJE4eQp0WTUmdJTRcmOIj335eKBAQlGzwMZ zDp1pFoDWrUmXBO+AbjF8kym4bCCSRLM4lFRTBNN/+cw2icwAy1RSDmR5hSf5j1Te+jYhDN+ wZyuMODIyvHOXe6Zjy5jb9jXG934vv0ut/NYsubAxUBl9QBmCFENXw+xc7Grmg0KW/DqEkfD 6E5t5dxpYVmUJePW9bXfd+9w5u2KLhhzRmeXDsfkBFUM9OD+1Tmn42KKRqP3BtG6iETl0qnc 7e84QkoW1OtwkyT8BR1fDi4IAwAA X-CMS-MailID: 20200915190754eucas1p110b35ee7bbb1143e153f8f1469528fdb X-Msg-Generator: CA X-RootMTR: 20200915190754eucas1p110b35ee7bbb1143e153f8f1469528fdb X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200915190754eucas1p110b35ee7bbb1143e153f8f1469528fdb References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200915190728.18143-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v11 05/24] net/i40e: return unknown speed in status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rte_ethdev has declared new NUM_UNKNOWN speed which could be used in case when no speed information is available and link is up. NUM_NONE should be returned, if link is down. Signed-off-by: Ivan Dyukov Acked-by: Jeff Guo --- drivers/net/i40e/i40e_ethdev.c | 5 ++++- drivers/net/i40e/i40e_ethdev_vf.c | 10 +++++----- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 472ce2a9e..f718356b5 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -2891,7 +2891,10 @@ update_link_aq(struct i40e_hw *hw, struct rte_eth_link *link, link->link_speed = ETH_SPEED_NUM_40G; break; default: - link->link_speed = ETH_SPEED_NUM_NONE; + if (link->link_status) + link->link_speed = ETH_SPEED_NUM_UNKNOWN; + else + link->link_speed = ETH_SPEED_NUM_NONE; break; } } diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index eca716a6a..cf931bf9c 100644 --- a/drivers/net/i40e/i40e_ethdev_vf.c +++ b/drivers/net/i40e/i40e_ethdev_vf.c @@ -2163,15 +2163,15 @@ i40evf_dev_link_update(struct rte_eth_dev *dev, new_link.link_speed = ETH_SPEED_NUM_40G; break; default: - new_link.link_speed = ETH_SPEED_NUM_NONE; + if (vf->link_up) + new_link.link_speed = ETH_SPEED_NUM_UNKNOWN; + else + new_link.link_speed = ETH_SPEED_NUM_NONE; break; } /* full duplex only */ new_link.link_duplex = ETH_LINK_FULL_DUPLEX; - new_link.link_status = vf->link_up && - new_link.link_speed != ETH_SPEED_NUM_NONE - ? ETH_LINK_UP - : ETH_LINK_DOWN; + new_link.link_status = vf->link_up ? ETH_LINK_UP : ETH_LINK_DOWN; new_link.link_autoneg = !(dev->data->dev_conf.link_speeds & ETH_LINK_SPEED_FIXED); From patchwork Tue Sep 15 19:07:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77791 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7ACD7A04C7; Tue, 15 Sep 2020 21:08:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8D6CB1C134; Tue, 15 Sep 2020 21:08:00 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id B07311C133 for ; Tue, 15 Sep 2020 21:07:59 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200915190759euoutp01a470613c7955872eeb2eb6b0e959fb48~1CpVeWoPB0530105301euoutp01U; Tue, 15 Sep 2020 19:07:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200915190759euoutp01a470613c7955872eeb2eb6b0e959fb48~1CpVeWoPB0530105301euoutp01U DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1600196879; bh=8FgdUe6Aml3rB/AWNSgZoZqeJOx9OS3/lqpbs6iX2+c=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=bcf1VNozd4j7MpzElbynEExXQ4AteXFiAP9sbsAFGFc7tFxJhxJIBNRgp5UVjSoZa e6uEvARLdZr7imaRYSulo8oJ6h6LqHWapN2DBnWbrfIlUEo/Hg21YzA3eTMjw2CeyQ dF311Xa4tCJin7oV6NCmToPqNIHesvyfIH/D93mI= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200915190758eucas1p1288bef07c8a4f1c2d25e9d1849823948~1CpUmKkAP3097130971eucas1p1Z; Tue, 15 Sep 2020 19:07:58 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id C2.DF.05997.E01116F5; Tue, 15 Sep 2020 20:07:58 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200915190757eucas1p2f4d9f5f1beff09e8102311dde7569271~1CpTr8wck2574925749eucas1p2x; Tue, 15 Sep 2020 19:07:57 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200915190757eusmtrp14b824e7c54c9c376e95bad694ac9126a~1CpTrInAx2872428724eusmtrp1P; Tue, 15 Sep 2020 19:07:57 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-44-5f61110ec7a6 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 93.EB.06017.D01116F5; Tue, 15 Sep 2020 20:07:57 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200915190755eusmtip2940c249698504d1b1b7f8bf10da155a7~1CpR7nW5L0503105031eusmtip2L; Tue, 15 Sep 2020 19:07:55 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 15 Sep 2020 22:07:01 +0300 Message-Id: <20200915190728.18143-7-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200915190728.18143-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSa0xTZxjH95xzes6hoeZYXXiixEujyVjijfnh0bjhdIlnWbLLh33Ykomd nCCTi2kBh8aMykRSEQRxTmRQJRNEI6gItQJhNVqgCEIk6qhSCJEgUuUWLRQn5dTs2+9/ed8n z5tXZPVF/BIxITlVMSUbEw28lqu76+9Ys2ChMXb9g2kdVbeXAg08LWfJW/SEp2OvfmfoUVUM NdSXaKiwL5OhvMIxhuorrTy98B7myDdez5Cn0S1QcfdhgcadQwId7zwLNBR4ztIZ2wRQZ+kN Dfn/cfD0MnCeo7zpHqD82hYgV+4YR0U37UDZVoleXawQqNyzjMa9LRy5H18X6PJUF0s32meB ClzVQPey/9NsXSlP2/7WyOUNw4x88lwXK999/Icg57aWMvJVn52RXzb18HJebRXIbQPHWPnS 4Bv+W+2P2i1xSmJCumJa99ku7Z6Gp4Pcvg7h19ddDyATrvBWCBNR2oh3Zos1VtCKeqkS0O97 wqliEnAs+21ITADaKjo1749csJfwalABWNL2TFDFFGD+cBMEW7z0EbpzSplgsFi6ymN94CET DBZJ2/C+xzFf4qTVWDfz7zzrpE0Y8Pax6ojleKmmeZ7DpM3YfbNHCLJeWoYPyyYZtdMuomMk 1P8C/Vn+kL8In7tqBZUj0X0yd34HlI4CFtRdF1RxAjDr7GioFYO1Ix1zLIqsFIXVjnVBROlz POqLVnEBPhpdGCyzc1hYd5pVbR3mZOvVOwzY3NodshFnZ8JVW0aLd4ZVn6cR8LbrFn8Clhf/ P8oGUAURSpo5KV4xRycr+9eajUnmtOT4tbtTkq7B3F91v3VN2sER+NkJkgiGcJ2td1esXmNM N2ckOQFF1rBYt+2ee6deF2fMOKCYUmJNaYmK2QlLRc4Qofvk/PBPeinemKrsVZR9iul9yohh SzLBFtn/HRflPZITF7nqTtuHStapnZbwhNEVsvLX9/1lr7X2rR7XbwdTdw+eKYiIOZXyTdOO 8P7WhisHJvZvuq31/CL1ftk38kFrdfTp/kOskG+NsjdHHK9pWZlh2T5U2BtFS3/4Kv3T1SO+ mlXlZXsHnH9+XXluqvHFhbjOayZLy2DiFouBM+8xbviYNZmN7wCA3UPLpwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSa1BMYRjHveecPXuK5djWeCemWJnBTJst6elCTR84vmAkH9zqjI422pY9 u418IMZUs5FKMUjFymVdQtFKRGMKG0lFKdWsncklXd1iXbbi22/m93/+88w8D0PKv1KeTEKS QdAn8YlK2p2y/a7r9JVN5WMWOnqnQGl9IQJ7p5mE7rw3NGQOHCCg1RIOVRUFEsjtSiUgK3eQ gIoLJhp6u/dT0DdUQUDHXZsUTrzYL4Whmh4pHGo4iaDH+YGE48XDCBoKb0pg5EElDf3OMxRk /WhBcLj8EYK6g4MU5N22IkgzsTBw8bwUzB1eMNT9iAJbW5kULn9pJOFm/S8EOXWlCJ6m/ZFE zOZ+FJdIOHPVe4I7crqR5Grbjkq5g48LCe56n5Xg+u+10FxWuQVxT+yZJHfJ8Z1e7b5eFabX GQ3CLI1ONCxRblCDv0odDCr/RcEqdUDQphD/QKXf0rA4ITEhWdD7LY1Vaao6HdSOZ9Jd3xqb USq6SpuQG4PZRfictcDF7oycLUE4575dYkKMS2D80UGOZzyw86XpX2YY4Zb8x9JRQbPzsC2j kBgVCradxk3p+6hR4cFG4ucdlWiUKXYuvvXz9RjL2GDs7O761+qNL127P8ZubAh+cbtlrFTO JuCi9CZ6nL3wq6LPRDaaXIwmWJBCMIraeK3orxJ5rWhMildt0WlvINfNb9WOlFuRqS+qBrEM Uk6SFbfHxsglfLKYoq1BmCGVClnkU9tmuSyOT9kt6HUxemOiINagQNeCOaTntC061wclGWLU geogCFYHBQQFLAbldFkG+2CjnI3nDcJ2Qdgh6P/PEYybZyqaEb0tekXyFUXImpk0c1ZYvrJ9 Z4Z1G+9dWq1YW9d15051xKbYVT6tb7NrR2jzlEkR2fmne47Z132Sm32eaDStyx7iULpxa688 sk+y91TUwIKyssAGc/PUG/auJRGmNeSetKHEMxPLLe/K+M9qmz4zVIt954Sjzhma0vrh+eGh oKREDa9eQOpF/i/MCTnaCQMAAA== X-CMS-MailID: 20200915190757eucas1p2f4d9f5f1beff09e8102311dde7569271 X-Msg-Generator: CA X-RootMTR: 20200915190757eucas1p2f4d9f5f1beff09e8102311dde7569271 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200915190757eucas1p2f4d9f5f1beff09e8102311dde7569271 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200915190728.18143-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v11 06/24] net/ice: return unknown speed in status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rte_ethdev has declared new NUM_UNKNOWN speed which could be used in case when no speed information is available and link is up. NUM_NONE should be returned, if link is down. Signed-off-by: Ivan Dyukov Reviewed-by: Ferruh Yigit --- drivers/net/ice/ice_ethdev.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index b51fa2f17..76f797de0 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -3135,8 +3135,11 @@ ice_link_update(struct rte_eth_dev *dev, int wait_to_complete) link.link_speed = ETH_SPEED_NUM_100G; break; case ICE_AQ_LINK_SPEED_UNKNOWN: - default: PMD_DRV_LOG(ERR, "Unknown link speed"); + link.link_speed = ETH_SPEED_NUM_UNKNOWN; + break; + default: + PMD_DRV_LOG(ERR, "None link speed"); link.link_speed = ETH_SPEED_NUM_NONE; break; } From patchwork Tue Sep 15 19:07:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77792 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4D221A04C7; Tue, 15 Sep 2020 21:08:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8489B1C13A; Tue, 15 Sep 2020 21:08:03 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 589291C139 for ; Tue, 15 Sep 2020 21:08:02 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200915190802euoutp025f90da159a7a19f1433e1f28eb4bad1b~1CpYKVyim0661006610euoutp02g; Tue, 15 Sep 2020 19:08:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200915190802euoutp025f90da159a7a19f1433e1f28eb4bad1b~1CpYKVyim0661006610euoutp02g DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1600196882; bh=70Bc5Qf+Pjp25n3sxWMGseS0dIRRQUC1Jc8dQTJLpmQ=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=TeJ+uce1Yn+IYHM5UIWuUH7jds/W23pPwuaYyRJEPHZ0fWHa/rKHZwH+91PPzX3PY qdJJ/MG0MXQigwLa4NEvpbY1V0z12/vt9Nc4PpQX6H+6AmXFdDSVb5s0Mk0OgsaNkM Pl9p4W8I7qWj8chFWiUkiqGcg5jaoXlL6ER3BUfI= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200915190801eucas1p1696ae567f943347db8f50c3547dea35e~1CpXIyBbr3106731067eucas1p1d; Tue, 15 Sep 2020 19:08:01 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 3D.46.06318.011116F5; Tue, 15 Sep 2020 20:08:00 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200915190800eucas1p16c5aa3b72311b2aae8b4085732b35384~1CpWNe9kO3106731067eucas1p1c; Tue, 15 Sep 2020 19:08:00 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200915190800eusmtrp11e11f818536f83182d6650cb49ba084b~1CpWMplrF3148631486eusmtrp1K; Tue, 15 Sep 2020 19:08:00 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-6b-5f6111101e72 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 80.EB.06314.F01116F5; Tue, 15 Sep 2020 20:07:59 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200915190758eusmtip2b0d44c018082c978ca5ecfe65962718f~1CpUaB9FT0503405034eusmtip2h; Tue, 15 Sep 2020 19:07:58 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 15 Sep 2020 22:07:02 +0300 Message-Id: <20200915190728.18143-8-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200915190728.18143-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSbUxTZxTHd+47DTXXyuKJM5g12ZuZisEPZwYHOD/cZH6YS0wWE4Fu3qAR qukV35IpdgRNQYbYzKhLZXSmgE4EC6VYjGsCFAoyiY0QUJlbfGEi71OgoJbrsm//5/c//+ec 8+SRWJNTWCbtsu5TbVZLjlkwcA2t07dWyYstmUnDkfVU0+kCenjfzdKg855ARaMFDPVWp1LA 9zNPZQ/yGSopG2PIV+kQ6NmgnaPn4z6GBprDIp3rsYs0Hnws0snu80CPo0MsnS2fAOp21fM0 /XuTQCPRCo5KZiJAP3pDQG3FYxw5/Y1AhQ6ZRqs8IrkHEml8MMRRuO+aSJenbrNU3zkHdKqt Bqir8BWf9r4yU36RV9yBp4xy+pfbrNLa95OoFLe7GKX2eSOjjNyICEqJtxqUjodFrHLp75fC V4ZthpQdas6u/aptzedZhp11s5PMXvuGg4GoA/LhZJID4iSU12G48hHnAINkkisBz7hG+Jhh kicB+90rdWMC0DfvBwdIC4n20Nc69wDa2+tF/TAFGOn2c7G0IH+M4RMuJmYkyLUC+qJ3mZix RE7HWa8dYpqTP8B7kd8W2hnlz/C+q5fRZ1qBl67eZGM6Tl6PPf6IqI+UiHcvTC5cinKnhGPz 9bwe2ISlF4+DrpfgUJtX1PVyDJ8u5vTAccBTDddE/VAK+MP54bdVqej955YYW46VP8GapjU6 Tsfr7iZO33kR9g4vjmH2jSxrOMPq2IgnCk16tRlvtve8xYhzs/E6VvDKEw+vP1AzYMd0H1cK K87936scoBqWqnlabraqJVvVA6s1S66WZ81e/d2e3Dp481fD821TjXAj+m0QZAnM8cby/qxM E2/Zrx3KDQJKrDnBuLErnGEy7rAcOqza9mTa8nJULQjvSZx5qTG54ul2k5xt2afuVtW9qu0/ l5HiluXDO1ktVVsHavrPelKaE4+kBfna9C+LxS3fe/u1oowLr9TQi5a0MmvTZs+cIa2kuzX8 xHF47eiveaZU5+6OqatbHx0tuNJ1vW500WXnu5vvKGLSiy8yWjbNfFMw5H456At5P5qo+PTD VX5v1baND5Ih5d8jW/x/zf8ZCPwRf8ycMJ5656CZ03Za1q5kbZrlNZsS/sGnAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzVSe0hTcRjtd+/d3VWcXafRjwmWg+iBTTczv4WZGcT9MwyKsrKl11fOye6s 7C8dYjZ1pVmgyXwh1UzM1NSy0glqrRKtlZKaiGUP8R2VrodT+u9wzvm+78D5GFK6SMmYpFQD r0/VpMhpd8r+p2d053ovTUxQ7nU11L+wIBgfrSZhrHiEhrzZbAIGrfugvaVMBEUfMgkwF80R 0HLbRMPUmJGC6fkWAoYf28VQOmAUw7xtUgwFfTcRTDq/klBSsYCgz9Isgl+dD2mYcVZRYF5y ILjS1IugJ3+OguK2VgQ5JhZm79wSQ/WwH8yP9VJgH2oUw93v/SQ0v/iNoLCnHsHLnL+iCH9u qaJGxFW3fyG4a5X9JNc9dEPM5T+zEFzDdCvBzTxx0Jy5yYq45+N5JFc78ZM+5H5cEabXpRv4 zYk6wbBXHq0ElUKpBoVql1qhDA49uUcVIg8MD4vjU5LO8frA8NOKxPvLi0Sace+FdqcJZaKC IBNiGMzuws96o0zIjZGyNQh3Ws6s0Rh/myBdNGa9sfOtiTYh9xXLAsJZOcvIJdDsNmzPtRAu wYd9T+PXl7Iol+DN7sfLTcZVE8VuwSOOOpELS1g1HrUMEmtbN+Haex2rF9zYPXigzSFeC5GE yy+9ptewH35XvkhcRZ4VaJ0V+fDpgjZBKygVgkYrpKcmKGJ12vtopfEH3b8aW9FAw2EbYhkk 95BUvD8dIxVpzgkZWhvCDCn3kUS+tJ+SSuI0GRd5vS5Gn57CCzYUshKwkJRtiNWt/E+qIUYZ ogwFtTI0ODR4N8g3SnLZzhNSNkFj4M/yfBqv/z9HMG6yTHS050dNhyzXK2Ik8vKOIevzbK8j 399FNcZHeyf/+DKSnTUXURK0vba+tNzonyYLq/RRzak8Z6cjZsk/TxtER7riM7aer1QffJVf 5WvzZOq8e2Fya1jQx2OysibfT7eOdQR0eZqHByPb7gZ8dvT/fGM9M8WXOvV+G83J7QcKH33z iJRTQqJGuYPUC5p/ZJi8IQcDAAA= X-CMS-MailID: 20200915190800eucas1p16c5aa3b72311b2aae8b4085732b35384 X-Msg-Generator: CA X-RootMTR: 20200915190800eucas1p16c5aa3b72311b2aae8b4085732b35384 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200915190800eucas1p16c5aa3b72311b2aae8b4085732b35384 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200915190728.18143-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v11 07/24] examples: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications: * ipv4_multicast * l2fwd-jobstats * l2fwd-keepalive * l3fwd * link_status_interrupt Signed-off-by: Ivan Dyukov --- examples/ipv4_multicast/main.c | 14 ++++++------- examples/l2fwd-jobstats/main.c | 13 +++++------- examples/l2fwd-keepalive/main.c | 13 +++++------- examples/l3fwd/main.c | 13 +++++------- examples/link_status_interrupt/main.c | 30 +++++++++++---------------- 5 files changed, 33 insertions(+), 50 deletions(-) diff --git a/examples/ipv4_multicast/main.c b/examples/ipv4_multicast/main.c index 7e255c35a..a51b58412 100644 --- a/examples/ipv4_multicast/main.c +++ b/examples/ipv4_multicast/main.c @@ -572,6 +572,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -591,14 +592,11 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), + &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/l2fwd-jobstats/main.c b/examples/l2fwd-jobstats/main.c index 47a3b0976..6e01b2e66 100644 --- a/examples/l2fwd-jobstats/main.c +++ b/examples/l2fwd-jobstats/main.c @@ -689,6 +689,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -708,14 +709,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/l2fwd-keepalive/main.c b/examples/l2fwd-keepalive/main.c index b2742633b..e2236a87b 100644 --- a/examples/l2fwd-keepalive/main.c +++ b/examples/l2fwd-keepalive/main.c @@ -453,6 +453,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -472,14 +473,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c index 24ede4290..0aeae216a 100644 --- a/examples/l3fwd/main.c +++ b/examples/l3fwd/main.c @@ -810,6 +810,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -833,14 +834,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps -%s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/link_status_interrupt/main.c b/examples/link_status_interrupt/main.c index 9bbcadfcf..a06398eff 100644 --- a/examples/link_status_interrupt/main.c +++ b/examples/link_status_interrupt/main.c @@ -133,7 +133,7 @@ print_stats(void) link_get_err = rte_eth_link_get_nowait(portid, &link); printf("\nStatistics for port %u ------------------------------" "\nLink status: %25s" - "\nLink speed: %26u" + "\nLink speed: %26s" "\nLink duplex: %25s" "\nPackets sent: %24"PRIu64 "\nPackets received: %20"PRIu64 @@ -141,8 +141,8 @@ print_stats(void) portid, link_get_err < 0 ? "Link get failed" : (link.link_status ? "Link up" : "Link down"), - link_get_err < 0 ? 0 : - (unsigned int)link.link_speed, + link_get_err < 0 ? "0" : + rte_eth_link_speed_to_str(link.link_speed), link_get_err < 0 ? "Link get failed" : (link.link_duplex == ETH_LINK_FULL_DUPLEX ? \ "full-duplex" : "half-duplex"), @@ -445,6 +445,7 @@ lsi_event_callback(uint16_t port_id, enum rte_eth_event_type type, void *param, { struct rte_eth_link link; int ret; + char link_status_text[ETH_LINK_MAX_STR_LEN]; RTE_SET_USED(param); RTE_SET_USED(ret_param); @@ -457,13 +458,9 @@ lsi_event_callback(uint16_t port_id, enum rte_eth_event_type type, void *param, port_id, rte_strerror(-ret)); return ret; } - if (link.link_status) { - printf("Port %d Link Up - speed %u Mbps - %s\n\n", - port_id, (unsigned)link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - } else - printf("Port %d Link Down\n\n", port_id); + rte_eth_link_to_str(link_status_text, sizeof(link_status_text), + NULL, &link); + printf("Port %d %s\n\n", port_id, link_status_text); return 0; } @@ -478,6 +475,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) uint16_t portid; struct rte_eth_link link; int ret; + char link_status_text[ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -497,14 +495,10 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), NULL, &link); + printf("Port %d %s", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Tue Sep 15 19:07:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77793 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 035FAA04C7; Tue, 15 Sep 2020 21:09:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1B1BA1C197; Tue, 15 Sep 2020 21:08:06 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 1F5E31C139 for ; Tue, 15 Sep 2020 21:08:04 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200915190803euoutp016def2f38ad0ab057b1a8bb1653aec3df~1CpZy5JiZ0517005170euoutp01a; Tue, 15 Sep 2020 19:08:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200915190803euoutp016def2f38ad0ab057b1a8bb1653aec3df~1CpZy5JiZ0517005170euoutp01a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1600196883; bh=rtlr8T5Fy0EDTqnsAnewtW3pEkKYnBnvexBXMUYSoLI=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=OVingUGL8r2SUEzpwp3u8eU6gfwsGjH4PoGAE7UdXryqQwDSM7T5KEAMjey6knT/X J86w2/L+cMY9vfGPg8jwXLYWNys3sRUdzUVPuGgD5tbu8FlAzSn6a20SHj+P+jhn7K o2rSbI9IYELaBJA4L66pqU+Jk0+FE7oWFMX23F/0= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200915190803eucas1p2ecdd509582f5b5ad7b27550719e52ae4~1CpZFuSZk2574925749eucas1p25; Tue, 15 Sep 2020 19:08:03 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 45.53.06456.311116F5; Tue, 15 Sep 2020 20:08:03 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200915190802eucas1p25937243b85d9a7064895f1d46d3a3829~1CpYuhmOA2574925749eucas1p23; Tue, 15 Sep 2020 19:08:02 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200915190802eusmtrp161598a7e88ada3869eead2ccfc4185b3~1CpYtlIoO3148631486eusmtrp1M; Tue, 15 Sep 2020 19:08:02 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-5c-5f6111139322 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id C2.EB.06314.211116F5; Tue, 15 Sep 2020 20:08:02 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200915190800eusmtip23507c8fd9c2c0ed5e3a0652b71998255~1CpW7Dun11161311613eusmtip21; Tue, 15 Sep 2020 19:08:00 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 15 Sep 2020 22:07:03 +0300 Message-Id: <20200915190728.18143-9-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200915190728.18143-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSe0yTZxTG8353Guo+i9EjLpp10ahRkWjkOInOxSxfXLJs0Wg0UfzUL3gB JK14+8Mhm0AKY9CyTYVhoaJQNFhLAU29sWmrBZUmBBWFelkYoHKpTcSVKfWr2X/P+Z3nOefk zSvQOgsXL+zM2KsYMuQ0PadhGm+O3pkfN1FOWViUz2J9awXBp902GgOljzksGPqJwvv2Fehu KmfR3JNNYZF5mMKmGhOHLwI5DL4aaaLw0WUfjyf8OTyOtPTy+PPdMoK94X4aj1uDBO9WuFgc vX6Jw8FwFYNFbzsI/tLgJegpHGaw9GIzwVyTiEO1Z3i0PZqOIwEvg74HTh7PhtppdLWOESzx 1BNsy33HfvmZ9NZazUo2dx8lWSrbaenmg994qfBWBSU5XjVT0uCVDk4qarAT6fbTAlqqe/6G +06zUZO8XUnbuU8xJCzfotlhed7PZt7gDpR2QTapZE0kRgBxMRS0H2NMRCPoxBoCtrw/ebV4 TWDYejpaBAnYHeepj5GyoZPRyBkCx071cJGGTgwRqHGsjGhOnA2+/AoqYpokOjhoCnd+SMeJ 38CpWut4QBAYcSaEB5IiWCsuhTJXd/SmGVB3/hod0THiF+C/2MGr86dD58nXH2aCeE+AYJ6f UwOrwFcwxqg6Dvo9DbyqPwWfpZBRA3kEShqdvFoUE/ix7GXUtQIaBu7wkYtocQ7UX0pQ8Uro yv2VimAQJ8D9lxMjmB6X5sbfaRVrIT9Xp7r1cO2WP4oBxv6NVbEEV4+YOPWtLhMItvayxWTG if93WQmxkylKljE9VTEmZij7FxjldGNWRuqCbXvSL5Dxr+r7zzPSTEL+rS1EFIg+Vmvt2pKi Y+V9xoPpLQQEWj9J+1Wbb7NOu10+eEgx7EkxZKUpxhYyTWD0U7SLqvo26cRUea+yW1EyFcPH LiXExGcT9z9/J6+uiXEmbbz+bLP5cM7RqXlLqlZtevjiSa1dyLa0ff1DUrX3j0Dd5KV+b/Gu yr7e2WvOHfccmfdurWPUmZjp7Pk+NGgq18x6uCzEhz+vdn/SWbpuNxefeWhgw/pK5a+Aubsk KWGX7duexwF9TlA+HFv8Jtl92rXOu2b0gGvx6md6xrhDTpxLG4zyezKrvnemAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917dzel1W0q/RKyGr0oml0f7UzKIiIuFaTZX2muUTe13Ka7 UzSKTEJtPsrUoDQ3Nd+Cms+epphaK0LFVDSTIdqLfGUPs4fT+u9wPt/z/R44R0LKvlCukjCd kTfoNOFy2pGy/m4f2iZboVFvTy3aCJUvchHYhgpIGM58Q0PyxGUC+sp2w8OGHBFcfxtHQNr1 SQIaSkw0fBqOp+DzVAMBg4+sYrjVFS+GqZYxMaS+ykYwNveBhJuWaQSvcutE8KP5Pg3jc/kU pM32ILha24GgPWWSgsx7jQgSTAxMlBaLoWDQDaaGOyiw9teIoWKmk4S6F78QpLdXIniZ8Ee0 Zx03aykUcQUP3xNcRl4nybX13xBzKc9yCa76cyPBjT/uobm02jLEPbclk1z5yHfaz/GYYqdB H2Xk14bqBeMueSALHgpWBQoPL5WC9VQe9/Hwlrv77jzFh4dF8wZ33xOK0IyRD6KIp3RM5gCO Q3kiE3KQYMYLZ0+YKRNylMiYQoSbkq+QJiSZBxh/HCEXNU547rWJXtRMI2zO7hPbAc1sxtak XMIOnJkBGncnXqLswIk5iO+UWmi7EcVswHMflfa2lFHh7Lqhf8FrcHnVk4UAB8YHd93rWfCU MWHYnNhNL9ZuuNf8hbiGllnQkjLkzEcJ2hCtwCoEjVaI0oUoTuq1d9H8xevbftQ0oq7qgBbE SJB8qdQycEItE2mihVhtC8ISUu4s3fvSGiyTntLEnuMNerUhKpwXWpD3/H7ppKvLSf38/+iM atabVYKKVXoqPXeAfKU0iWkOkjEhGiN/lucjeMP/OULi4BqHPDJ+Ht6S+ujng5msANvq1Hpj /OS6poaYcZV77FAirTr67eysZ8aA+8X88xe8R7OCZpYXmHUliqJN3965ocBCm39MdUlC5K5D j7Nc5PuKS/1PBxWPj7aei8z3OXO7ev2N1iMPoq15bN/XsuD2A04Vtv1u/X5bq1apIyJJ3967 nYE503JKCNWwW0iDoPkL3ojA8QcDAAA= X-CMS-MailID: 20200915190802eucas1p25937243b85d9a7064895f1d46d3a3829 X-Msg-Generator: CA X-RootMTR: 20200915190802eucas1p25937243b85d9a7064895f1d46d3a3829 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200915190802eucas1p25937243b85d9a7064895f1d46d3a3829 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200915190728.18143-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v11 08/24] examples/bbdev_app: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/bbdev_app/main.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/examples/bbdev_app/main.c b/examples/bbdev_app/main.c index 68a46050c..fe9d8e0a5 100644 --- a/examples/bbdev_app/main.c +++ b/examples/bbdev_app/main.c @@ -326,8 +326,10 @@ check_port_link_status(uint16_t port_id) const char *dp = (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? "full-duplex" : "half-duplex"; - printf("\nPort %u Link Up - speed %u Mbps - %s\n", - port_id, link.link_speed, dp); + printf("\nPort %u Link Up - speed %s Mbps - %s\n", + port_id, + rte_eth_link_speed_to_str(link.link_speed), + dp); return 0; } printf("."); From patchwork Tue Sep 15 19:07:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77794 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8460A04C7; Tue, 15 Sep 2020 21:09:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E3CA61C19E; Tue, 15 Sep 2020 21:08:08 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 87A4A1C19B for ; Tue, 15 Sep 2020 21:08:07 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200915190807euoutp01e01958228e6d725f31174246c1ba345c~1Cpc69SD00516505165euoutp01b; Tue, 15 Sep 2020 19:08:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200915190807euoutp01e01958228e6d725f31174246c1ba345c~1Cpc69SD00516505165euoutp01b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1600196887; bh=zr14D0fDL7SjhFN+jVIm/DVAQiqOuCvoeH8ErtcPSmA=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=bMi/TFyznoACbsCjGg9J/xYD3inq4pbt1OZkZ9VUHFLE1zzV+JRiTgSfa1Xu7mdRC p0fpocLoZV7s2zkavOfZizqXBpQ9IY6HQ6ZwURhFba1HP2+qAPe26GzTTtF2c2umT8 QV/v9qdBYGlVx6AkZ/fT/zWJJbCOYF0h82p/6HJw= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200915190806eucas1p2f1cbc506f1ba1e3722302332b8f3ef42~1Cpca-Kg71274112741eucas1p2t; Tue, 15 Sep 2020 19:08:06 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 06.DF.05997.611116F5; Tue, 15 Sep 2020 20:08:06 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200915190805eucas1p17a324ccd4d81cd51dc855b6be17d13a5~1CpbOtKEU3097030970eucas1p1m; Tue, 15 Sep 2020 19:08:05 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200915190805eusmtrp184b14ef36ca36ef34c80b1c1545a6dbe~1CpbN57ri3148631486eusmtrp1O; Tue, 15 Sep 2020 19:08:05 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-52-5f6111168d30 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 36.EB.06017.511116F5; Tue, 15 Sep 2020 20:08:05 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200915190803eusmtip2feec93f6aebf3035eb6924ec0a851e3c~1CpZfGEeg1712017120eusmtip2K; Tue, 15 Sep 2020 19:08:03 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 15 Sep 2020 22:07:04 +0300 Message-Id: <20200915190728.18143-10-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200915190728.18143-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0VSa0yTZxjN893pqH5UM54psbGJCerEbRrzZNM5t8V8f0ww6pYscVDHJxIp mBZ07hcTRQRELnVOMOUWI5eNghao3AJIBCyukYQgGQohGoNyv2QgxY3yYfbvnPOc8z7nffNK rOG6sEGKiUtQrXHmWJOg42ofLnh3fBhkjvgkeSyUnN0OoOHnJSwN2Z8JlD55kaGn5fupse4W TzmDSQxl5kwxVFeaJtDo0AWOxqfrGBpo8oiU13NBpOm2VyJd9eYDvfK9Zulm4QyQ11HD00Jr vUATvmKOMt/2Al1zdQJ1ZExxZL/vBkpJk2my7I5IJQObaHqokyNP/z2R/ph7wlJN9xJQdocT 6HHKv/xXm5W3hbd5paRxhFFyi56wysP+30Qlo8vBKNXjbkaZaO4VlExXOSiPhtNZpeLFvBCu +0G3N0qNjTmrWnd+Gak7NfBgkDkzGPCzq+G2mARzYhoESCjvRrtzXkgDnWSQSwHtjS9ZjcwC pncOMxqZARxZymLeR/5sdvPa4A6gez4XNDIH6C1r5v0uQQ5FT6pjJb5erhawzte3TCRpnXwQ L70L9Xs4eQu2t/SzfqyXP8eu4hustsGIFVUtKzhgWe+537tS1iBvwr6C2ZUzUe6W8J+8xdXA t5gz/Lug4XX4usO1ersQ9ORmcFrgMmB27T1RI1mAyfljq6796Hrzl+hvx8pb0Vm/U5MP4NXs ds4vo7wGn44F+WV2GebU+ov6ZT2mphg0twlbunpWZcSlxUBNVvBSZSenvU8T4FBfEZ8Fxrz/ dxUClEOwmmizRKu2z+LUc2E2s8WWGBcd9lO85S4sf1bPu45ZN9T7TrSBLIEpUF/4d2SEgTef tZ23tAFKrGm9/uvHnh8N+ijz+V9Ua3yENTFWtbXBRokzBet3FY8cN8jR5gT1tKqeUa3vp4wU sCEJQhZTtz/bsvaY42hB+ILjZnFQ6XfhVxqa56sb1u5tmjx5BGuCkkJ/XeKNl6dbD7VPtOwp 8ByeO+yCLwrkitGPdeN2lzJuLEv4oJ29ERK/NTfykLhrpjfTeJ2/ErPx+UeBoxXfVx04HuNN nsqv3PeIyrwJBh9jcQY7wPXNsahr5ayJs50yf7qNtdrM/wFKh8khqAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzVSbUgTcRzuf3e73aTFuRQPI8tBIVGzzWy/WVkU1EVfDKnISpt6qOmc7Ka9 fWhZqc0yXW9YMZci2Uwsm6mlost8mxIqq8ylEoK9oaYNUkybWt8efs8LDzw/Cpe4CX8qKVXP 6VLVKVLSi3DMtQ1u8vVWx2zuMvlBZZcZwefBEhyGb30iIXfiMgYfrDuhvuaBAExDBgzyTD8x qCkzkvBjOJOAsckaDFwNDiHc680UwqR9VAjX395HMDr7DYdCyxSCt+ZqAUw3vyRhfLaYgLwZ J4IbtnYEbdd+EnCrrhZBlpGGicePhFDiCoDJ4XYCHP3PhfDE3YNDddcfBAVtlQi6s+YFuwLZ GUupgC2p/4qxNx/24Gxr/x0he63DjLHPxmoxdrzRSbJ5NitiOz/n4mz5yG8ywitKtl2nTddz axO1vH6H9JgcFDK5CmSKLSqZPER5IkwRKg0O3x7PpSRlcLrg8JOyRNfrISxtSHTG9qpUaEBu oRGJKIbewlQ01gqMyIuS0KWImcyxISOiPATDfB/BlzQrmdl3RnJJM4WY+c6rggWCpIMYR44Z WyB86AGS6cu+SCyYV9J7mStzQQsagl7HtDT1LwaJ6TCmo/juv9A1TPnTpkUs8tx765yLhSR0 ElOU3Ucu4QDmfdEvLB+tsKBlVuTDpfOaBA2vkPFqDZ+emiCL02qqkGfyF63TtlpkHIu0I5pC 0uViy8DJGIlAncGf1dgRQ+FSH/Hubke0RByvPnuO02ljdOkpHG9HoZ6CBbi/b5zW80Cp+hh5 qFwJKrkyRBmyFaR+4hy6+biETlDruWSOS+N0/30YJfI3IBPf8Kun6/wEZTi8hy9ze0Xg2owG 83dX5vx6g/JQxOkLDZHJeWfW5xdF7TraGd/+psw2OuPt44oeb729bb8999CRME3gOrcYfXGo BtNU2cWBFw4c3dPu/pjsVxilKHw0t/zg6tiN70QF1oBTppSKsJGiy1XOloH8S07rKjO5TxIr JfhEtXwDruPVfwE8kvWYCAMAAA== X-CMS-MailID: 20200915190805eucas1p17a324ccd4d81cd51dc855b6be17d13a5 X-Msg-Generator: CA X-RootMTR: 20200915190805eucas1p17a324ccd4d81cd51dc855b6be17d13a5 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200915190805eucas1p17a324ccd4d81cd51dc855b6be17d13a5 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200915190728.18143-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v11 09/24] examples/ioat: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/ioat/ioatfwd.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/examples/ioat/ioatfwd.c b/examples/ioat/ioatfwd.c index b66ee73bc..f77012eb9 100644 --- a/examples/ioat/ioatfwd.c +++ b/examples/ioat/ioatfwd.c @@ -700,6 +700,7 @@ check_link_status(uint32_t port_mask) uint16_t portid; struct rte_eth_link link; int ret, link_status = 0; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status\n"); RTE_ETH_FOREACH_DEV(portid) { @@ -715,15 +716,12 @@ check_link_status(uint32_t port_mask) } /* Print link status */ - if (link.link_status) { - printf( - "Port %d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", portid, link_status_text); + + if (link.link_status) link_status = 1; - } else - printf("Port %d Link Down\n", portid); } return link_status; } From patchwork Tue Sep 15 19:07:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77795 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E415FA04C7; Tue, 15 Sep 2020 21:09:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1061D1C190; Tue, 15 Sep 2020 21:08:12 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 78A021C1A3 for ; Tue, 15 Sep 2020 21:08:09 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200915190809euoutp01927a5833fab9550cfc9451c1fc53519b~1Cpey8PM80517005170euoutp01b; Tue, 15 Sep 2020 19:08:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200915190809euoutp01927a5833fab9550cfc9451c1fc53519b~1Cpey8PM80517005170euoutp01b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1600196889; bh=0UwttxWlMNSO6zvpNf9yvDxpqBtUhn2OurscN38uKVo=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=dUVGj5UEDWwqGDRmAWUj0Ptdzr0LGKg6Jvl3EeRuMkiN7M0ZuD+Ay2T4uSL0GjPEA 2nQ9Ae4o7dfxI50DCRxPSp7pJboRFN/HjY2dysqRK5RYqlg7haoQVfBLsHVZcLJqWg cxs35HVSvSLl7StVihLbLDYv9fd7J4mFkS18pFgs= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200915190808eucas1p1a76ebf1cc30ecaf9a612843d841f0037~1Cpeg7I-c0047600476eucas1p1J; Tue, 15 Sep 2020 19:08:08 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id B7.53.06456.811116F5; Tue, 15 Sep 2020 20:08:08 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200915190808eucas1p239c33a16b012897614a124dff919d3be~1CpdqYpQA1274112741eucas1p2v; Tue, 15 Sep 2020 19:08:08 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200915190808eusmtrp16aa34d52d60e65663095963cb21cc29d~1Cpdpn6Op2872428724eusmtrp1W; Tue, 15 Sep 2020 19:08:08 +0000 (GMT) X-AuditID: cbfec7f2-809ff70000001938-65-5f611118a086 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 25.EB.06314.711116F5; Tue, 15 Sep 2020 20:08:07 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200915190806eusmtip2a8d82595770806de288a87dfe975ddae~1Cpb5JZF91161311613eusmtip22; Tue, 15 Sep 2020 19:08:06 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 15 Sep 2020 22:07:05 +0300 Message-Id: <20200915190728.18143-11-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200915190728.18143-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSbUxTZxTHc+69vffS0HmtL5w4hlkXie9INPFkMTo33e6+7YsfJFG4whWN gKa1vswPMlDGKmNYdQaqbYFMBE0QBQqIgqgULUhoJEq0SIwZiKJQwMibjHo1+/Y7v/85z0lO HpE1nuEXiLvT9qvmNCXFxOu56uaxBytwthK/6re8WCpvdQI97y5mqed0gKcTg8cYely2geo9 53Rkf5bOUK59iCHPRRtPr3syOHoT9DD09IZPoAJ/hkDBpl6B/mx3APVO9rOU7x4GandW6Wjs Vh1PbyeLOMod7wT6q7IFyJszxNHp2hqgLJtEg6UlAhU/jaJgTwtHvq5rAl0e7WCpqnUK6KS3 HKgta1r33dfyuPsfnVxc/5KRTxV2sHJz19+CnHPPycgVb2oY+e3NTl7OrSwD+f7zE6x86cV7 /hd9nH5dkpqy+4BqjlmfoN9VVNzN77N9dejd2B0uHXIibBAmorQGL5zt422gF43SRcDAXRun FSOA+fYAqxXDgK+93dznkSeOej7ERqkEsNQbpTWNAnpdE0Io4KXF6Mt2MqFgrlTBo2fyERMK 5kg/YtV0AELMSYuwJ3CBDbFB+hbPO6dYbcNCvHSl8SOHzXh/baegbYvCR66Rj4+i1Cpiv9PG aAOb0HP9GK/xHOz3VgoaR6LvVA6nDfwOeLL6mqAVeYCZjoFPXRuw8tWDGRZFVlqC5XUxmt6I DvsZLqRR+gIfD8wOaXYG7dVnWU0bMDvLqHWbsPGe/5NGnJoI17SMgw4/ox3oBqC7sI7Ng4UF /+9yA5RBhGq1pCarltg09eBKi5JqsaYlr0zcm3oVZj6r74M3WAOj/h1NIIlgCje4nyTEG3XK Acvh1CZAkTXNNXzf5ttuNCQph39VzXvjzdYU1dIEX4qcKcKwuujlNqOUrOxX96jqPtX8OWXE sAXpILf9K/f2TbauuRnXnXF1c+Tdoa6dyAyHdyTeXht9PHvWyMGfdR/mh7ck5S8r+Mm/LMYV XRXXuGV8u+dc1I4t1Q/vr/9DuJXd70t0lYjWHxRX+/KttedrNkXP2xobOT3Q0Fe/rWsx7Omo mNX8rPNI8Bs+IbOhwR1ROu47at2Y6ZzI3GziLLuU2KWs2aL8B1qI/16oAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSbUhTcRTG/d97dzdni+s0vBhZDaKSunV9yeMqzQi59SEE6Utm66YXFd0W u5tk9MEitKZZmhlmzemwTAVdZmpYpohaU0rNSnzJZCRlmGlvmmZT69tzzu85DwfOkeHKH4Sv LElnFAw6PkVFygnHn46R7T6evGZn4Us1VHdZEIyN2HAYzR8mIWvqAgZvK8Khqf6WBPLepWOQ k/cVg/pyMwmfR88TMDldj8HQY4cUbvael8J067gULr8oQjA+/wmHQusMgheWOgnMtjwi4ct8 KQE5c/0IrjzoRNCR/ZWA/MYGBBlmCqbu3ZWCbcgPpkc7CXAM1Eqh6nsPDnVdCwhyO6oRdGcs SvZt5OasZRLO1vQR466V9OBc+0CBlMt+ZsE4+2QDxn150k9yOQ8qEPd8LAvnKp2/yCj5UWaP QW8yChsS9aJxryqGhQCGDQUmICiUYQNDYtUBwaodYXvihZSkVMGwI+wEk1hqGyFPmded/jHb RqSjbB8zcpfRVBA9WNREmpFcpqTKEP1oYMpVyFyApiec+IrHi55/bf7nmUG083qNdAmQ1Bba cdGCLQFvapCk+zLPEUvAi4qk6xaH0ZImqE306PCd5SQFpaZvWxb+pa6nK2ueLmt3V7+3sX85 VEkl0cWZfeSK9qPfFH/DrqLVVuRWgbwFk6hN0IosI/Ja0aRLYOL02vvIdfOH7bO1DajXHt2K KBlSrVJYB09olBI+VUzTtiJahqu8Ffu7HceVing+7Yxg0GsMphRBbEXBrgVzcd81cXrXB+mM GjaYDYFQNiQwJHAXqHwUF6mWY0oqgTcKyYJwSjD8n8Nk7r7pKPd9LP+hzYMtyIhjFOVFFpO/ e9TpzfYJ7adDRyKKpc1WiT4s33/bq6r47pKfEf5DPdUNtktztuQDB+WE21aW8F39NtxeedcZ oZtoVnt2nfWcKeZZ9FtzuPuNaiH6hrMqbDMTvjs9Orxp7cnamLRLM1F2PFJORRR6YBfuk5/P qAgxkWf9cYPI/wU2bxSyCQMAAA== X-CMS-MailID: 20200915190808eucas1p239c33a16b012897614a124dff919d3be X-Msg-Generator: CA X-RootMTR: 20200915190808eucas1p239c33a16b012897614a124dff919d3be X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200915190808eucas1p239c33a16b012897614a124dff919d3be References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200915190728.18143-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v11 10/24] examples/ip_*: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications: * ip_fragmentation * ip_reassembly * l3fwd-acl Signed-off-by: Ivan Dyukov --- examples/ip_fragmentation/main.c | 13 +++++-------- examples/ip_reassembly/main.c | 13 +++++-------- examples/l3fwd-acl/main.c | 13 +++++-------- 3 files changed, 15 insertions(+), 24 deletions(-) diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c index 4afb97109..c7348bee5 100644 --- a/examples/ip_fragmentation/main.c +++ b/examples/ip_fragmentation/main.c @@ -593,6 +593,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -612,14 +613,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up .Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/ip_reassembly/main.c b/examples/ip_reassembly/main.c index 494d7ee77..6241c9824 100644 --- a/examples/ip_reassembly/main.c +++ b/examples/ip_reassembly/main.c @@ -712,6 +712,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -731,14 +732,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/l3fwd-acl/main.c b/examples/l3fwd-acl/main.c index f22fca732..e773d3586 100644 --- a/examples/l3fwd-acl/main.c +++ b/examples/l3fwd-acl/main.c @@ -1815,6 +1815,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -1834,14 +1835,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Tue Sep 15 19:07:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77796 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D047AA04C7; Tue, 15 Sep 2020 21:09:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DD38E1C1A8; Tue, 15 Sep 2020 21:08:13 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id A1B6B1C1A6 for ; Tue, 15 Sep 2020 21:08:12 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200915190812euoutp0154beed8213d2c5ee8810ca0a4fb21ee9~1CphvzBF90530105301euoutp01W; Tue, 15 Sep 2020 19:08:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200915190812euoutp0154beed8213d2c5ee8810ca0a4fb21ee9~1CphvzBF90530105301euoutp01W DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1600196892; bh=FVrECeLodo2mEpIyUJqIc0xB0igSGcYvhVqWSW4kZ3c=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=iOx752bQM+RMEKicaf/2RVizdrDAe50vPN658WLlDTsG777sjrcazl1Q4afoYcTnj oVPp3YUm2pKh1UiAd778TbTS0w1z9GFgfv5jh7RNZBi5q80s75X3WH0H7r7Zr0Vu9/ rPvSQfc3zbbedud3QDseCZqvNUbr+BUeXjAysH8U= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200915190811eucas1p13c4668dddf28d796dffc5d60d55bdb32~1CphLatBL0048000480eucas1p1X; Tue, 15 Sep 2020 19:08:11 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id D9.53.06456.B11116F5; Tue, 15 Sep 2020 20:08:11 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200915190810eucas1p2a781b5404bdbd5b3a94b7c57f429a39d~1CpgFdRIE1274112741eucas1p2x; Tue, 15 Sep 2020 19:08:10 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200915190810eusmtrp18258076458f313e5f6c085add4b1e139~1CpgEt3wz2872428724eusmtrp1X; Tue, 15 Sep 2020 19:08:10 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-68-5f61111b3efa Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 47.EB.06314.A11116F5; Tue, 15 Sep 2020 20:08:10 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200915190808eusmtip2b576af5cf356d77e36d1200b9689817d~1CpeTJRi11755217552eusmtip2K; Tue, 15 Sep 2020 19:08:08 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 15 Sep 2020 22:07:06 +0300 Message-Id: <20200915190728.18143-12-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200915190728.18143-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0VSe0xTVxjPuW+qNddqwhecoE1c1GwKcSafuvja/rhGdCZOtywq3s0bYKOo LSguGhs1KC0WBMUMtVSRgYA8FCgiqDQO1FJQEhQFkTASolt5CWY4GGu5Nf73/Z7fOSdHoHWZ XIgQG5+gGOPlOD2nYaoaxpo/nzNTjgqvsX6GpU12gj1duTR2n33JoXXwBIXthWuw1nmRxYxX ZgptGUMUOgssHP7dfYzB/mEnhZ11bh6zW4/xOOzq4/F0ywWCfeNvaPzN8ZZgi72SxbH6Gg4H xq8waHvfRjCt4gHBxtQhBs/eqiaYbBFx8Fo+j7mdoTjc/YBB9/ObPBaPPqGxsmmC4JnGUoKe 5El27XzpvSOPlXJrX1NS5uUntNTwPIuXUh/aKam8v5qSBu60cZKtopBIj3qstFTU+w+3RfOD 5ss9SlzsAcW4dPVuTUxfR9i+diHpXEomayZpvIUECSB+ARM9g75ZI+jEAgKurPsBMELg5ash SgVvCdSVFHMfIllPPUQV8gmkWW0BMEqg2GNj/C5OXAjuU/ap+GyxnAPn+DPKL8wSv4FLl7pp /8yIC+Bux31fQBC04kq45likbgiDorJ7U5YgH916q23qsDoxFJ7ljEx1gvhYgPZHbtafBfFr qLRsUrOz4E1jReByn4A7M5VR/ScJnKm6yasgncDxC96Aaw1U/NXM+4tocRGU1ixV6XXgue0l av8MaPfO9NO0b8yoOk+rtBZOJetUtx7uPWwN0AAT/05XaQkGzWWB56kj4M3w0ukkLPvjLgch hSRYSTQZohVTRLxycIlJNpgS46OX/LTXcIP4vqr7v8bhajLa+qOLiALRT9c6OnZH6Vj5gOmQ wUVAoPWztes97l067R750K+KcW+UMTFOMbnIHIHRB2uXXXm9UydGywnKL4qyTzF+UCkhKMRM om9sLYn4fm7MtquRk71/1CcFr6hdYLz4LnJzVcJIyIvzR5q+Wp3N3kluDt9oDcvpGpLmde6Q IvuptXm525w/z9BsGBCy7NtT9h8N3bzh05Ml2/9c9XvamLzuW7Yr8d2yoNP1hi2Pr1NJFktR +MFd3y039+QYYj0p6YfZyeO9VxtaYqbl6RlTjByxmDaa5P8BPOdz3qYDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSWUwTcRDG+e9utwuhuhTUTYmINSZoQrVcHQgqmmj2BYPxweCFFVYOKYVu a4T4gAZRK4IiGq+UKhi0kNQKyiEiNEYq5QinEBAIwYAXtyAEj1bi22R+33zzJTMULp4jJFRi ipbTpCiTpaQbYf/dOOgv8VDGbDct+IK52YBgZLAIh+GCjyRcncrCoNe0C2orHwggfygTg9z8 aQwqn+hJ+DZ8gYCJmUoMBl7bhXCv44IQZqxjQrjWdh/B2PIXHO4aZxG0GV4IYLGhhoTJ5UcE 5C51I8irsCFozJkmoKC6CkG2noappyVCKBrwgZlhGwH2vnIhlP1ox+FF8y8ENxrNCFqy/wgi NrJLxscCtqj2M8befNiOs+/6bgvZnPcGjLVMVGHsZF03yeZWmBDbNHIVZ0tHf5JRbodl4Rq1 Tsv5Jqh57Q7pETkEyOShIAsICpXJAxXHwgKCpdt2hsdxyYlnOM22nSdkCWP9G1J7qbO3rtwU ZKI8oR65UgwdxNzuaUF65EaJ6ceIeXI9T6BHlAMwzNdRfEXjySz36MkVzSxiLF8/CZyApP0Y +2UD5gRedD/JdF46TziBJx3JdNa/Qs6aoDczb/rfEk5TER3GPDVuWTHdwJQ+q/+3wNXR7qju /hdITCcyhZc6yZXah/lQOIddR6uMyMWEvDgdr4pX8XIZr1TxupR4Waxa9Rw5Lv7y3WJ5Feqw HLQimkJSd5Gx/0SMWKA8w6errIihcKmXaE+L/bhYFKdMz+A06hiNLpnjrSjYke8GLlkTq3b8 T4o2Rh4sV0CoXBGoCAwB6TrRZbrhqJiOV2q50xyXymn+z2GUqyQTnd30PcycNK9KMIlNlisZ ESGprasXOg91RYuSxgM8/PeX6cYV9NCmqq4hl6Qvddm7l9JKRBXFvSfz97Hn1u+NitffOR6x 2RM15BzQuri2zmtGhOYhY3TW3cXitbJqb0tierP3HV2bz8VTfoebMiKpLTW7OK/I8ntp7gU2 m8q3CJMSfIJSvhXX8Mq/RIeVEQcDAAA= X-CMS-MailID: 20200915190810eucas1p2a781b5404bdbd5b3a94b7c57f429a39d X-Msg-Generator: CA X-RootMTR: 20200915190810eucas1p2a781b5404bdbd5b3a94b7c57f429a39d X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200915190810eucas1p2a781b5404bdbd5b3a94b7c57f429a39d References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200915190728.18143-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v11 11/24] examples/ip_pipeline: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_speed_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/ip_pipeline/cli.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c index d79699e2e..cf3d7d462 100644 --- a/examples/ip_pipeline/cli.c +++ b/examples/ip_pipeline/cli.c @@ -273,7 +273,7 @@ print_link_info(struct link *link, char *out, size_t out_size) "\n" "%s: flags=<%s> mtu %u\n" "\tether %02X:%02X:%02X:%02X:%02X:%02X rxqueues %u txqueues %u\n" - "\tport# %u speed %u Mbps\n" + "\tport# %u speed %s Mbps\n" "\tRX packets %" PRIu64" bytes %" PRIu64"\n" "\tRX errors %" PRIu64" missed %" PRIu64" no-mbuf %" PRIu64"\n" "\tTX packets %" PRIu64" bytes %" PRIu64"\n" @@ -287,7 +287,7 @@ print_link_info(struct link *link, char *out, size_t out_size) link->n_rxq, link->n_txq, link->port_id, - eth_link.link_speed, + rte_eth_link_speed_to_str(eth_link.link_speed), stats.ipackets, stats.ibytes, stats.ierrors, From patchwork Tue Sep 15 19:07:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77797 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4235A04C7; Tue, 15 Sep 2020 21:09:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0ED1D1C1B4; Tue, 15 Sep 2020 21:08:17 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id BF7A41C1AD for ; Tue, 15 Sep 2020 21:08:14 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200915190814euoutp01ae6919d3242b2bc6cb749002a0db2338~1Cpjpr0M30552405524euoutp01R; Tue, 15 Sep 2020 19:08:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200915190814euoutp01ae6919d3242b2bc6cb749002a0db2338~1Cpjpr0M30552405524euoutp01R DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1600196894; bh=2wNIFYHcmh4yCYEREX5OuVKRLboLxAKCyymFOQAhjOI=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=J4C+c3zh9EiLAMxta1qSXqEyyAlGiXuLFm383DFj+Bb5XI2CEidXAyeW5oFvPPOQo vmdiRD5alxedZXp+1BNwZY0Hfpk4eVKy1bCNvifkMkSUDJtKel+xqh1pLWcfgmgjc6 aHv1nDe685pgP27PesiTJLD6gb3hJvawBQmpFQyM= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200915190813eucas1p135079ff10232320bd2189a4912e401e7~1Cpiz1EKX0047600476eucas1p1P; Tue, 15 Sep 2020 19:08:13 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 1C.53.06456.D11116F5; Tue, 15 Sep 2020 20:08:13 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200915190813eucas1p2ead5e8c99461c1253b7407f1d0ef3c1e~1CpihQU1H1703717037eucas1p2J; Tue, 15 Sep 2020 19:08:13 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200915190813eusmtrp1593108c17526e16d170f253e117706c4~1CpigZPdQ3148631486eusmtrp1T; Tue, 15 Sep 2020 19:08:13 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-6c-5f61111d93b2 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id E9.EB.06017.D11116F5; Tue, 15 Sep 2020 20:08:13 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200915190811eusmtip2bc5b3d59e9d6c8dc02aa3a9d76a02bcb~1CpgwgKp70503405034eusmtip2k; Tue, 15 Sep 2020 19:08:11 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 15 Sep 2020 22:07:07 +0300 Message-Id: <20200915190728.18143-13-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200915190728.18143-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSbUwUdxDGO7t7u3sXz6yHxlEqpGcaWo1SW5NOaqu1Nc0m/VASXxKbWtzK iigcege24BeiFOiJvB3VVBSpBEGkPdCDA3xHwwmHWi8SJB4WpQnFKiJCfOGovXUx/fbMb555 Zv7JX2QtxfxcMcmWptptSrKVN3FN7c+vLZo3Q4l/r35kHrm7yoHu3alkqb+0j6e9I9kM3apd QWe8hwxU8mcWQwUljxny1jh5etC/m6PhUS9DwbN+gQ4Gdgs02jYo0L7rZUCDofss/VLxBOh6 eaOBnl9s5elR6ChHBS+6gQo9V4B8+Y85Km1pBspxSjRyvFqgymAUjfZf4cjfe0qguvEbLDV2 TQIV+9xAV3NeGj59S35RUWWQK88MMbLr1xus3N67X5DzO8oZuWG4mZEfnevm5QJPLcid9/ay 8om/nvFxpq9NHyeoyUk7VXvs8o2mLXmlQWH7XdMPewab2Cz4Q3SCUURpKXqHJg1OMIkWqQZw uLOD14sxwPM3g6zmskhPAIsPf/N64nC3E3RTNWBrbpmgm8YBR4ZJ07z0DvrzyhnNNFNq4NEb 6gkXohghfYU9nQs1Dye9jRNdfZyGzdJHeP7yGj0/Gk/UX3i11xjGgZbuqfgo7Dky9ioSpZsi Vr108vrAKjw0EGB1HYH3fR5B12+i35XP6QO54Qc0nRL0oghwT9nDKdcK9PxzTdCuYKV30d0a q+OVWOPbBxpGaTreejhDw2xYljQdYHVsxrwci+624oWOwBRGnJyYpmMZfzughWjnnwVsH9pR BNEH/19VAVALs9V0R0qi6lhiU79f7FBSHOm2xMWbUlNOQvij+v/1jTbDeOC7NpBEsE4zV9ze GG8xKDsdGSltgCJrnWn+7Kr/W4s5QcnIVO2p8fb0ZNXRBpEiZ51t/uDo0AaLlKikqdtUdbtq f91lROPcLCgTl3+SOdjgijm9uu5c4emLP9UaVycZQxNpvoQPl8UouZc/X7s0KTC9KLaq8Pe4 xjH3QHP2GzCgHlvJf7HOtllKjeo9+XcE+/6qDnfUj66fs6Mje+ovub7s6gu15K31LFAaMCjF VBuexm3bsH58VlpG3a7Mkq37N0XOUR/cWWidNd9k5RxblCULWLtD+Q8oJtf6pAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrKIsWRmVeSWpSXmKPExsVy+t/xe7qygonxBtO/cFmsPzOP0eLRvcXM Fg+m3GWz6P7QwmRxY5W9xZ7tc1gtJt1vYLLom/SRyWL7ii42izcPmlgs3n3azmRxZ+9pdotZ l5rYLT4des5u0Xt+NqPF8z+vmC1mLvjMaHF+3lZWi58Hd7FZvP+ziMWi79dVRov+LScYLY73 fGSxmLJzB6NFW5eAxYeVy9ktFt+Rs/j04ASLxembm9kt1ny9yGyx9cxfRouJx9czWpxt+8/q oOjxa8FSVo/Fe14yeUxeeJHZ49jNaewePSfnMXlsfLeDyeP9vqtsHn1bVjF6nHrUzeyx+skP tgCuKD2bovzSklSFjPziElulaEMLIz1DSws9IxNLPUNj81grI1MlfTublNSczLLUIn27BL2M jil32AseclU0P9/G3MB4gaOLkZNDQsBEYu7VLsYuRi4OIYGljBLfe5vZuhg5gBISEq+fMEPU CEv8udbFBlHzmVFi9cEGNpAEm4CGxOmOeUwgCRGB22wSl9sbWUASwgK+EjdXXWIFsVkEVCV+ n7nLAjKUV8BKYv+REIih8hKrNxwAW8AJFL608yo7iC0kkCkxv/0yG4QtJ3F9/hemCYx8CxgZ VjGKpJYW56bnFhvpFSfmFpfmpesl5+duYgRG+bZjP7fsYOx6F3yIUYCDUYmHd8HthHgh1sSy 4srcQ4wSHMxKIrxOZ0/HCfGmJFZWpRblxxeV5qQWH2I0BbpvIrOUaHI+MAHllcQbmhqaW1ga mhubG5tZKInzdggcjBESSE8sSc1OTS1ILYLpY+LglGpg1BEzK01Ke92U21LrtFvW+XRV18eU Cr5OOaHViTW/uJQFNk0xnp3o2XZ1Q/b5Z2/Pf8zzfFOfyF2t0sVuzRq0km9eCMOdv2Gnpz1r D5pzY/tsmxdtYpMXSrVxpppY6+7VTnkXeDCTz9Oq/82J86wX+P82zFnmx7j5QOQM2d+3X1y/ ckpdZ8kKJZbijERDLeai4kQAOyqYcwgDAAA= X-CMS-MailID: 20200915190813eucas1p2ead5e8c99461c1253b7407f1d0ef3c1e X-Msg-Generator: CA X-RootMTR: 20200915190813eucas1p2ead5e8c99461c1253b7407f1d0ef3c1e X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200915190813eucas1p2ead5e8c99461c1253b7407f1d0ef3c1e References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200915190728.18143-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v11 12/24] examples/ipsec-secgw: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/ipsec-secgw/ipsec-secgw.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c index f777ce2af..e478fe359 100644 --- a/examples/ipsec-secgw/ipsec-secgw.c +++ b/examples/ipsec-secgw/ipsec-secgw.c @@ -1775,6 +1775,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -1794,14 +1795,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up - speed %u Mbps -%s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Tue Sep 15 19:07:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77798 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96342A04C7; Tue, 15 Sep 2020 21:09:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9AD7E1C1BA; Tue, 15 Sep 2020 21:08:19 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 1CF901C1B8 for ; Tue, 15 Sep 2020 21:08:17 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200915190816euoutp0296aa8abcdf0b1855cf5ef190a28afb6e~1Cpl6KJce0661006610euoutp02k; Tue, 15 Sep 2020 19:08:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200915190816euoutp0296aa8abcdf0b1855cf5ef190a28afb6e~1Cpl6KJce0661006610euoutp02k DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1600196896; bh=V+UhUmI0wX9EPRjnOZ4RF5aTByD1DePKpjF9zRdOzyY=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=Nofk31wuw2ORZVac2G2xITm3gIO/57UT/NVXe2/JwMjTCeGCyoJOuQyTiVBvubLdK dCit5GhnVgTchlJ1e5q9VTkzLdKiL+qekt23WXtO3KF38RDBKkyVc9Sor/4m62mJEP 7Io+W3f6uY2ByCYddvon/LIOuTRJMtb64L2UIRtM= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200915190816eucas1p2e5f9915b5e961c37a4b852febf798b23~1Cplci9r11274512745eucas1p21; Tue, 15 Sep 2020 19:08:16 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 52.56.06318.021116F5; Tue, 15 Sep 2020 20:08:16 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200915190815eucas1p1c027e0f5e4f5b2cb5c179ccad5cd4456~1CplBN_Cc0048000480eucas1p1c; Tue, 15 Sep 2020 19:08:15 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200915190815eusmtrp1dfc783da02ced0b719e236b11ffecb14~1CplAcEJj2872428724eusmtrp1c; Tue, 15 Sep 2020 19:08:15 +0000 (GMT) X-AuditID: cbfec7f5-371ff700000018ae-82-5f6111208328 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id F9.EB.06314.F11116F5; Tue, 15 Sep 2020 20:08:15 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200915190814eusmtip2745c272ab7b74b1058e5483587fe796b~1CpjOVtFK1759817598eusmtip2O; Tue, 15 Sep 2020 19:08:13 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 15 Sep 2020 22:07:08 +0300 Message-Id: <20200915190728.18143-14-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200915190728.18143-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSa0wTaRSG881MZ6bVmnEw8URX1BqT1Si6cX+cuLrezSRqYmKMkUSx6oi6 UE0Lrhg328hFrVgF8QamgiiyYKwKFIqXQBNFLJRIlijhsg1rgqhFWmDXQgtSBuO/5zznvOck Xz6eFnPYGfwhQ5JsNOgTdKyGcbwIehbPmaqPW1rkFtHeYCPY1VlIozeng8VzfWkUvi1ZhU8q b6gw+x8zhdZsP4WVxRYWP3lPMdgbqKSw/ambw9zmUxwGXN0cnm/KI9gd+kDj9fx+gk22ChUG a6tZ/By6xaB1qIXghfKXBOsy/QzmOKsIZlgE7PvrLoeF7dEY8L5k0N1axuG9wdc0VjSECWbV 2Qk2ZoyqVs+VhvLvqKTCJz2UdKngNS29aL3CSZn1Nkp62FtFSZ+ftbCStbyESK+6ztFS6bsv 7FZNrGbFfjnh0DHZuOTXPZqD4bJfjv4vHPfer2DNxKW1EDUPws/QZG5mLETDi0IxgfpwPasU AwTK+tI5pegn0NXuJ98ivf4RLsKicJfAFS+vDA0SCHZEdql5VvgR3GdsVKQxTXjIQmXoDRVp RAkbwJ8aGmdGmA/pdud4QCsshwaHmVUuzIbSBzV0hNVjvtnZMnEtGt7cHBhfCkIDDy2+B5QS WA83Si2MwlHwoa6cU/gHcF/KZJTAaQJZjjJOKS4SSM3zTUytgvKPnjHmeVpYAPbqJYpeAxfS Wsc1CFPgrW9qRNNjmO24SitaC2cyRGVaBzX1zRMaIDw8WdESdI5YJ973KYGOHit9kczO/X4r n5ASMl1ONiXGy6ZlBvn3GJM+0ZRsiI/ZdyTxERn7q+6RusEq8iy010UEnugma/Pb9sSJKv0x U0qiiwBP66Zp1za6d4va/fqUE7LxSJwxOUE2uchMntFN1y671bNLFOL1SfJvsnxUNn7rUrx6 hpmkxp6/husvj0ZVPA9q//xvy67Gvx+1pS+/k7W7c1t/kbyyzzM3bOscfZ8ypO43BNNDg8/T thecrQ6mHB+Ieb8p4PPkHnDWlg7XvGry1Q7dXjc8J6/1cfHhLSMb7X8k/btZur11Um20PDNn luhp6140PE+9jvdUnXTsCAhOsyuqeifoGNNB/U8LaaNJ/xWc6K+ppwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSbUhTYRTHfe69u5vW8raMnvxQNglMcrU581imJSSXJBCDPtiLDr2p5Tbb 3Uzti1mmzFpZIfSCrkQrjUynTsWkVqS1iaksDc0sROkFc5pk5ktT6dv//H/nDc4RkZJpyleU ptFzOo0qXUp7UfaF9qGgzWtVCTu7OxRQ4yhF8GWonIThmx9pKJq4SEB/VSS0Wu8K4PqnXAJM 110EWB8aafgxnEfB+KSVgMFndiHc7skTwqRtTAhXuu4gGJv7RsIt8xSCrtIGAfx50ULDz7n7 FJhmnQiu1ncgaL/souBmcxOCS0YGJh49EEL54CaYHO6gwP7BIoTH090kNDjmERS31yDovLQo 2LeFnTVXCNjy1q8Ee+NeN8m+/lAiZC+/KSXY2vEmgv3Z5qRZU30VYt9+KSLZ6pEZOtYrXhau 0xr0nF+qltfvlR6Vg0ImDwOZQhkmkweHHt+tCJHuiAhP5tLTMjndjohEWeq8ZU/GbyZr+EkD nYtsYiPyFGFGicddC0Ij8hJJmAqEX31ucwciN8D4+wi5krMOz7030is5Uwgb++5SS4BmArC9 sJRYAj7MAI17C84vg3XMAey6MEcsaYrZivNrmpd9MbMbOxpz6ZWum3H10+fLEzzdfk+zU7ik JUwaLivopVf0JtxX9ou4htaYkUcV8uEMvDpFzctlvErNGzQpsiStug65T974+o+lCfXUHrYh RoSkq8XmgcQEiUCVyWerbQiLSKmPOKrTfkIiTlZl53A6bYLOkM7xNhTiXrCY9F2fpHU/kEaf IA+Rh0KYPDQ4NHgXSDeIC5kXxyRMikrPnea4DE73v44Qefrmoug2U6xGceqqcs9xj94Rq7pT WTmaGZIfk4ZLtiduXK1I9ous39Xw1/Y7cMSb9/bITOyXRFXG5x2KWzuTZX/5Y2Z8dj764Mlz 4sres++2WMyumZbTQZ/qTVYU/a3ubeGoMeBIew/y63I5Vzk9tsWULPr7B5+DK2rHGYNyf3Jc To6U4lNV8kBSx6v+AVQSCvUIAwAA X-CMS-MailID: 20200915190815eucas1p1c027e0f5e4f5b2cb5c179ccad5cd4456 X-Msg-Generator: CA X-RootMTR: 20200915190815eucas1p1c027e0f5e4f5b2cb5c179ccad5cd4456 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200915190815eucas1p1c027e0f5e4f5b2cb5c179ccad5cd4456 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200915190728.18143-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v11 13/24] examples/kni: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/kni/main.c | 27 ++++++++++----------------- 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/examples/kni/main.c b/examples/kni/main.c index f5d12a5b8..49d888064 100644 --- a/examples/kni/main.c +++ b/examples/kni/main.c @@ -661,6 +661,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status\n"); fflush(stdout); @@ -680,14 +681,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up - speed %uMbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ @@ -717,19 +714,15 @@ check_all_ports_link_status(uint32_t port_mask) static void log_link_state(struct rte_kni *kni, int prev, struct rte_eth_link *link) { + char link_status_text[60]; if (kni == NULL || link == NULL) return; - if (prev == ETH_LINK_DOWN && link->link_status == ETH_LINK_UP) { - RTE_LOG(INFO, APP, "%s NIC Link is Up %d Mbps %s %s.\n", + rte_eth_link_to_str(link_status_text, 60, NULL, link); + if (prev != link->link_status) + RTE_LOG(INFO, APP, "%s NIC %s", rte_kni_get_name(kni), - link->link_speed, - link->link_autoneg ? "(AutoNeg)" : "(Fixed)", - link->link_duplex ? "Full Duplex" : "Half Duplex"); - } else if (prev == ETH_LINK_UP && link->link_status == ETH_LINK_DOWN) { - RTE_LOG(INFO, APP, "%s NIC Link is Down.\n", - rte_kni_get_name(kni)); - } + link_status_text); } /* From patchwork Tue Sep 15 19:07:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77799 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6F9F9A04C7; Tue, 15 Sep 2020 21:10:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D56301C1BE; Tue, 15 Sep 2020 21:08:21 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id B77301C1BC for ; Tue, 15 Sep 2020 21:08:19 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200915190819euoutp0100c900ddae00f4925c2f1be3018fb818~1CpoWBK5S0530105301euoutp01Z; Tue, 15 Sep 2020 19:08:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200915190819euoutp0100c900ddae00f4925c2f1be3018fb818~1CpoWBK5S0530105301euoutp01Z DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1600196899; bh=O0RMdSfG+AOCpq5MldeMzJL75/V6GLjvklL2HbHCXdQ=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=Ey3mN+dEY/cDDPK/1DmnJZ38WvHwZX4tzSsTs3Le3G9pzNNfc8BHXa5fMdeqPn900 sariUILOKEb7rEQpna1o2eYihGjSMFyCu/P2RoRbLFnQV5tjcK2JAke3PKzUnRzoD4 5aimaECPOPlwyN1VbImm7qlw7pUI43QEeKt/IvWQ= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200915190819eucas1p288779dbce6b9119226db49762dd17d29~1CpoBzGT01703717037eucas1p2O; Tue, 15 Sep 2020 19:08:19 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id EE.53.06456.321116F5; Tue, 15 Sep 2020 20:08:19 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200915190818eucas1p2ce297ae5bed8ea506af740a738f411f8~1Cpnoc4Yh2576625766eucas1p2o; Tue, 15 Sep 2020 19:08:18 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200915190818eusmtrp15d283be3c82945c1ba30a736dd6f0237~1CpnntkSd3148631486eusmtrp1X; Tue, 15 Sep 2020 19:08:18 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-76-5f611123dc2d Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 4C.EB.06314.221116F5; Tue, 15 Sep 2020 20:08:18 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200915190816eusmtip29bc84787e7d94202ebdb4e2b41cc0999~1Cpl2Kj6U0503105031eusmtip2N; Tue, 15 Sep 2020 19:08:16 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 15 Sep 2020 22:07:09 +0300 Message-Id: <20200915190728.18143-15-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200915190728.18143-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSa0wUZxSGc2ZmZ4aNa4ZVy4k2GNeYiMZb9cdJNdJaEyehKTYxaWq1OOqI F26dAaz9RdRSs6xbWa9gu1I2KqINdxYJq7hRVrorhDVbNPWyNSZeEJRVGrGo3XUw/fee5z3v +c735RNZq4ufKm7LK1S1PCXHxpu51q7R3nkzk5WshdcreaoLuYHu3fGwFD10m6eyZ3sZulGb Th3eX0zkulvCkNM1zJC3xs7Tk+hujoZiXoZu+YICVYZ3CxTzPxBof+9xoAdjj1mqqHoO1Otu MdHopXaeno5Vc+R8FQH6ufkqUMAxzNGh821ApXaJnp05LZDnVirFolc5Ct5sEujcSB9LLaHX QOWBOqBrpW9Nn8yQX1WdNMmejkeMfPC3PlbuunlEkB3dbkZuGGpj5KcXIrzsbK4F+Y97Zax8 9v5LfrV5rXnZZjVnW7GqLVi+wbz11J7LbIHP/H3vkRBfAo2iHUQRpSX4z93FdjCLVqkGMOi7 yBjFC8Afz1WAHZLixXNA59HZ7wOB/gyj5zRg97E/xwMjgAPxLRIBXpqNwX3ud8ZkqYFH71g/ kzAmSZno8A0xiUmcNAtbYt8lsEX6GOtrHnIJjdJ0PFvfySZ0UpyHz0cEY4lU7D/x4t1MlEIi 3nHs5Y3ASry9/8J4eBI+DjQLhv4QgwcdnBH4CbC8tUkwigOAe44PjnelY/NAj5DYiJXSsK59 gYE/xYuHY5xx5Yl4YzA5gdm4dLUeZQ1swX2lVqPbhp3d4XGM+PrfCQaW8UT1FcF4Hx9gKNbI HYDplf+fVQVQCylqkZ6breqL8tSd83UlVy/Ky56/KT+3EeI/NfgmEGuDkfBGP0gi2CZYqv7a kGU1KcX6rlw/oMjaJltWXAt+a7VsVnb9oGr5WVpRjqr7YZrI2VIsi6sfrbdK2UqhukNVC1Tt vcuISVNLYEta/hfbGwKXi+pcX20v/eBL+zwFvlnTtnLT6lUDaZ5pM57097TXr/01P0mLVahd lcPR5TNP7fA7lwobP8q4Hx71Rd6cTNm5rDhDq9fTOzyDa47NjZq09t//nnX968/LCuyjS/S3 L6e4ew6PcJmRgcIt3s4VnxW4yvuS5zatu5R5JTVi4/StyqI5rKYr/wE5WkdEpQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzVSe0hTcRjtd+/d3XU5uU2jm4TVSIzI2Xy0z0cW9c+lKIRe9NSLXR/pNtvd IoVqmlQsW2kiPURNMc0CH2nO0h4j1Jo2Wk0zH4kF9sLH1Miwx5b03+Gc853vwPdRuGya8KdS NXpep+HS5aSEsP3uGAqWL+Li15mmgqC2qwTByFAFDsOFgyRcmMjF4G3NRmhtLhZBwXsjBuaC SQyaq00kfBvOIWDM1YzBQJtNDNcdOWJwWUfFcNF+A8Ho3BccrpVNIbCXNIlg9ukDEsbnygkw /3QiuNTYiaAjb5KAwhYLgrMmGiZuV4mhYiAAXMOdBNj67onh7swrHJq6fiHI76hF0H32j2jT SvZnWaWIrWj9jLFXbr7C2fa+IjGb97wEY+vHLBg7/shJsubGGsS+GLmAs3c+/iDjJPsVMTqt Qc+vSNEK+g3yA0oIVSgjQREaHqlQhqkORYVGyENiY47w6anHeV1IbIIi5daZZ3hGm+SEvaiL NKIGyoQoiqHDmY7ebSYkoWR0JWJ6Hr1B8zzDfP2Im5CXG/oycz0mct4z5fZU/iE8AkmvZmzn SzCP4Ef3k8zrc9n/BF96OzP7wYh5ggg6kGlyHfPQUjqKqav+RMyHLmfu1D35t8DLzTtanGIP ltGpTOm51+Q8DmB6S6exy8inDC2oQX68QVAnqwWlQuDUgkGTrEjUqhuQ++L322fvWZCjfqcV 0RSSe0vL+hPiZSLuuJCptiKGwuV+0s3dtsMy6REuM4vXaeN1hnResKIId7983H9xotb9Pxp9 vDJCqYJIpSpMFbYe5Euk5+mnB2V0Mqfn03g+g9f9n8MoL38j4haIg3q7ncX5xuxTMyfZ7LVG NOpf8DAsqLHc8f2lLjjB3B+YvjTLslEabd8KjXYnm5O2Sh1TWJcUTXUvkrhOtWouJwZtHxtM StjnWJu20Lbj8ZYK09wuQ17G7S2fZ67uWdZrqTrq7EyK+v0wOmuTz+7T5riGpd65hr1tlmv7 3vnKCSGFU67BdQL3F48/lPgHAwAA X-CMS-MailID: 20200915190818eucas1p2ce297ae5bed8ea506af740a738f411f8 X-Msg-Generator: CA X-RootMTR: 20200915190818eucas1p2ce297ae5bed8ea506af740a738f411f8 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200915190818eucas1p2ce297ae5bed8ea506af740a738f411f8 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200915190728.18143-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v11 14/24] examples/l2fwd-crypt: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/l2fwd-crypto/main.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c index 827da9b3e..820470db5 100644 --- a/examples/l2fwd-crypto/main.c +++ b/examples/l2fwd-crypto/main.c @@ -1734,6 +1734,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -1753,14 +1754,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Tue Sep 15 19:07:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77800 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 46148A04C7; Tue, 15 Sep 2020 21:10:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F24801C1C1; Tue, 15 Sep 2020 21:08:23 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 66B821C0C6 for ; Tue, 15 Sep 2020 21:08:23 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200915190823euoutp01b7cdf53cdf7f8a4c5d4ee82944ef3fec~1CprzHQK80552405524euoutp01V; Tue, 15 Sep 2020 19:08:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200915190823euoutp01b7cdf53cdf7f8a4c5d4ee82944ef3fec~1CprzHQK80552405524euoutp01V DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1600196903; bh=PBAyJH+AMK1xxIDr0X+5LdKR/8t0CIeYr6u1GtWAoJE=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=CttNugaIpzzl9OSd2ntPIWedD7tEZkBu8nhjewXPkYZ1L/l6QI3yZEymzoxnXmG7X FX/Fq828kycKf2XCoQ5gyEV5nqr6bUuS9/COzcQv2QKe6WrmUkNcbuo8UzSSIsA63c GL0S8q/KvaGfgbxaxawKE1OZh0K06KcZfhVsFD5c= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200915190822eucas1p1ad4bed353aa8d51e7745473a9af00e75~1CprI55123106731067eucas1p1y; Tue, 15 Sep 2020 19:08:22 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 4A.DF.05997.621116F5; Tue, 15 Sep 2020 20:08:22 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200915190821eucas1p101ad6e551219cd63fbf784ef8ea366d0~1CpqnVAC50047600476eucas1p1X; Tue, 15 Sep 2020 19:08:21 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200915190821eusmtrp168ac4be8c3afdc3e5e576aa5a058ce16~1CpqmkiH33148631486eusmtrp1Y; Tue, 15 Sep 2020 19:08:21 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-6a-5f6111264900 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 8E.EB.06314.521116F5; Tue, 15 Sep 2020 20:08:21 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200915190819eusmtip237d79ce81efb6d9ac52ed57b520635d7~1CpovOlzE0744507445eusmtip29; Tue, 15 Sep 2020 19:08:19 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 15 Sep 2020 22:07:10 +0300 Message-Id: <20200915190728.18143-16-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200915190728.18143-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSfUxTZxTGc+69vfe2ocu1uHgCE7MmWwaLwtRsJ+6DbXHmLvzhYpYsMVGs coNGitgr+JEsEnS1IlYFsgmYymiYrhiRgRSIKBZCkRYRJsEvPqIjRB2oWJ0wlLXemv33nN/z vO85580rsqZiPk7ckr1DsWVbssy8gWvsnO5d/P48S3rKyFA81QZdQHeH3SyNlg7xdOjxfoZu eFLpgveEjopH8hlyFj9hyHu6kKe/Rws4mpzyMnSnNSBQeX+BQFO+cYEO91YAjc8+YKms8ilQ r+u8jqYvt/D0aLaKI+fMANCRhi4gf9ETjkqbm4DshRI9/v2UQO47CTQ12sVR4Ga9QGee9bF0 PvgS6Ji/FqjHPqf78l15prJaJ7sv3Gfkkl/7WLnz5s+CXHTFxch1k02M/OjiAC87Gzwgd989 xMo1f73gvzOsNXyWoWRtyVNsyV9sMGx2tNdBznXDrp8e5uXDZbEQ9CJKy7GofJgrBINokk4D HpvpjBYhwOE/y1iteApYWm0X3hzZH5jTacYpwFDzNYgYJukZYEHtqojmpQ8w4HAxkdB8qY5H 7+wgEzFipdXoPnDv9U2c9B7aj2vaKK3AsesjjNZhEdaca2MjWh/m/c0DgtYgAQdPhqKZoIjB wz9qeiU+72iP8lh84G+ITvoOBkqKXu+D0oHwco31glYcBdxXMRFNpWLDw6thLYqslIi1Lcka /gqrPKNsBKP0Ft6YmBfBbFgWN/4SxUZ02E1a2oxtV/qjGPHlvzGalNE1/b32VK2ALfvGhaOw qPz/VpUAHlig5KrWTEVdmq3sXKJarGpuduaSTdusf0D4pwZe+UNN0DK70QeSCOYYY+XtDekm nSVP3W31AYqseb7x657AepMxw7J7j2Lblm7LzVJUH8SLnHmBcVnV/XUmKdOyQ9mqKDmK7Y3L iPq4fEj1Tpxck5+YtHdvz9zCLOfVWzuF4D+DCXH6nKF24ZPuDx2JJSmx3rTjP7wd05s8vL5a zfB9usK9qku4131C39o2tnB5Rd/HmzrHUy7Fn/VvxUtDYxNn0tJWd0yu6fgtrT+mZrEjqarM W/88ZD3i/Hw7tE3PhPTKi5JvAwf3fOPZtZIzc+pmy0dJrE21/AeEGMHzpQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrKIsWRmVeSWpSXmKPExsVy+t/xe7qqgonxBs3fjC3Wn5nHaPHo3mJm iwdT7rJZdH9oYbK4screYs/2OawWk+43MFn0TfrIZLF9RRebxZsHTSwW7z5tZ7K4s/c0u8Ws S03sFp8OPWe36D0/m9Hi+Z9XzBYzF3xmtDg/byurxc+Du9gs3v9ZxGLR9+sqo0X/lhOMFsd7 PrJYTNm5g9GirUvA4sPK5ewWi+/IWXx6cILF4vTNzewWa75eZLbYeuYvo8XE4+sZLc62/Wd1 UPT4tWApq8fiPS+ZPCYvvMjscezmNHaPnpPzmDw2vtvB5PF+31U2j74tqxg9Tj3qZvZY/eQH WwBXlJ5NUX5pSapCRn5xia1StKGFkZ6hpYWekYmlnqGxeayVkamSvp1NSmpOZllqkb5dgl5G x+GNjAVXuCpaX5c1MB7k6GLk5JAQMJFoOf2ftYuRi0NIYCmjRNPsN0AOB1BCQuL1E2aIGmGJ P9e62CBqPjNKTH7Yxg6SYBPQkDjdMY8JJCEicJtN4nJ7IwtIQljAV2Le1htgRSwCqhJtMx6D 2bwCVhJPr9xngpgqL7F6wwGwDZxA8Us7r4LVCAlkSsxvv8wGYctJXJ//hWkCI98CRoZVjCKp pcW56bnFhnrFibnFpXnpesn5uZsYgVG+7djPzTsYL20MPsQowMGoxMO74HZCvBBrYllxZe4h RgkOZiURXqezp+OEeFMSK6tSi/Lji0pzUosPMZoCHTiRWUo0OR+YgPJK4g1NDc0tLA3Njc2N zSyUxHk7BA7GCAmkJ5akZqemFqQWwfQxcXBKNTA2LTXQa/6v9+4U17M7PMkZ7x61efmpBVi5 eW/lLtoikWyzbkr2RVdei/j5gvtqlRNSf5+ZeDjD4Zd+NXv9x6S/cWzPGaKu5ahL2om1H37N OY2hKM0v/vCyBMePNtLafLsymG1rJFXXblt5qGz+J7Np155kLXx8fa2FsnVel0lx2a59VXku wkosxRmJhlrMRcWJAKe02egIAwAA X-CMS-MailID: 20200915190821eucas1p101ad6e551219cd63fbf784ef8ea366d0 X-Msg-Generator: CA X-RootMTR: 20200915190821eucas1p101ad6e551219cd63fbf784ef8ea366d0 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200915190821eucas1p101ad6e551219cd63fbf784ef8ea366d0 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200915190728.18143-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v11 15/24] examples/l2fwd-event: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/l2fwd-event/main.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/examples/l2fwd-event/main.c b/examples/l2fwd-event/main.c index 4fe500333..d90c71698 100644 --- a/examples/l2fwd-event/main.c +++ b/examples/l2fwd-event/main.c @@ -366,6 +366,7 @@ check_all_ports_link_status(struct l2fwd_resources *rsrc, uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status..."); fflush(stdout); @@ -389,14 +390,10 @@ check_all_ports_link_status(struct l2fwd_resources *rsrc, } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - port_id, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", port_id); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", port_id, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Tue Sep 15 19:07:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77801 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D9420A04C7; Tue, 15 Sep 2020 21:10:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 90E0D1C1D5; Tue, 15 Sep 2020 21:08:27 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 5DD711C1D7 for ; Tue, 15 Sep 2020 21:08:26 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200915190826euoutp0287a24a7511b428f22d5787a590eba734~1CpujK46p1840518405euoutp02E; Tue, 15 Sep 2020 19:08:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200915190826euoutp0287a24a7511b428f22d5787a590eba734~1CpujK46p1840518405euoutp02E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1600196906; bh=zmZz7YLNZwsZfzlBrodbxoobMXy1KSIqos1a6ezRVA4=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=sklUWwvasDtjhrNzx9TlzKz5DzYlfJNSLOuGvIOrUcQccJfcPLpuGAAQXY9IZTAlb ipCaOsfMgV1rbEMuK/RScLlhUIk/YdAYHSSXc/VQkaj/SbmEwZB7RG9HZ6KRo1bxgy rH7YinSKcHsRMtOxA+vJZSbYvWMRyJWuIWkbq9Oo= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200915190825eucas1p2de13a036dede87968de7285a38a3e05a~1CptvzgpB2576625766eucas1p2t; Tue, 15 Sep 2020 19:08:25 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id FC.DF.05997.921116F5; Tue, 15 Sep 2020 20:08:25 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200915190824eucas1p2244766de5d98225fea4c2c3e074f99d5~1CptUSOS41703717037eucas1p2V; Tue, 15 Sep 2020 19:08:24 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200915190824eusmtrp16d742e08ad4e38e0460068beb367b72d~1CptTjCTJ2872428724eusmtrp1i; Tue, 15 Sep 2020 19:08:24 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-72-5f611129f999 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 11.FB.06314.821116F5; Tue, 15 Sep 2020 20:08:24 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200915190822eusmtip24c397f1b11da6852e90cab54f03953bb~1Cprh-n891759817598eusmtip2P; Tue, 15 Sep 2020 19:08:22 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 15 Sep 2020 22:07:11 +0300 Message-Id: <20200915190728.18143-17-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200915190728.18143-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSe0xTdxTHPffe3nupVq/F6c8HEJsZxWUqm5oTXOY7Xl+JWUJ8RIXruEED VNMCPhJNA465FhEK6kYREeZ4KMFHeQYXqZmlVHxAGoThRpwRBRXBQiajOsrtsv++38/3/M75 nV9+PK3NYWfxB/RJskEvJehYNVN99/39z8OnStFL8p9PxMp7BYBP/yimsTv3CYuWtycpfFy+ Ehtq8lVo/dNEYaZ1gMKaUjOLr7pTGXwzWENh1y03h3mtqRwOOno4PP3ABtgz2kvjT4XvAB8U VKnwfWM9i/2jRQxmjngAz9ibAJ0ZAwzm1tUCppsFfFtWwmFxVygOdjcx6O64yeHVoUc0Vt3z AWY7KwFb0j+qVs0VRwovq8TihpeUmHPpES3e7TjHiRmuAkq8/qaWEvt/9bBipr0cxOanFlq8 8uxvdpt6l/qrWDnhQIpsWPx1jHr/d9mVcChffSS1zEKZwMKbIYgnwlJiP/szYwY1rxVKgRSV nqUV4wXSNdIZMO+ANLaZODPw40fufFym8BIg58r6VYoZAtLy0EP5+7LCAuI+VUD5g2nCdZbU jLaPB8HCBtL5Sz3l78QI84jvxm4/1giRpKnTQil3CiNXrt2m/TpojLfWeTi/1gqhpP2iN1Dz kCe9v61T9DoyZG0HRQeTXqedU/Qc4s7JGN+NCN8Dya6+ySkmC0ia7XWgaiWx990fX40Wwkll /WIFryaunGegbDyZPH491Y/pMWmtPk8rWENOpWuVah257WoNYEJ8/0xSsEhc9o7A694C8sRd osqCsLz/ZxUClMMMOdmYGCcbv9DLhxcZpURjsj5u0bcHE2/A2Fd1f3B6a6F+dJ8DBB50kzSF v8dEa1VSivFoogMIT+umada0uPdqNbHS0WOy4WC0ITlBNjpgNs/oZmi+LHq5RyvESUlyvCwf kg3/pRQfNMsEc9Zr+7Z8sFT0RYSa+nZszI2zfrp91aZr8sC+CcXPo1K3fhMRaWuM7ZlywRMS knZnjzVteqTrcoz+s00nfPPkCl/K2pZPXgyfiPLajreVTK9qWyYmDTfNb65Y/sPVsnAMlpq3 /TX7cM/JiTMdm4Pif4x36has3bzCusS2whu1c3B4TVaIjjHulyIW0gaj9C8vUKXhpgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH/d17d3cdLa7T6GJgNQiiaDZt7RhmEkT3D/9I+iMoaw69qLk5 252lUrSkVDYztbDyObWXGpivfGSRFk2dJZuYrx6mUvRA3VJQcdaW9N+H7/ec7zlwDoVLFohA KinFwOlT1BopKSJsa9ZPe3b6qVV7zc5gaBioQDD1qQaHyVsfSTDPX8VgtO4QdLWVCaDosxGD /CInBm2PTCT8mswiYNbVhsGH5zYhlDiyhODq+SaE64OlCL6t/sDhruU3gsGKVgEsd3eSMLda TUD+yjCCGy29CKx5TgJudbQjyDbRMF/7UAg1H4LANdlLgG2sWQiPF+04tA64ERRaGxC8zf4j iNzOrljuC9iaru8Ye7PKjrNvxoqFbF5fBcY2zrZj7NyLYZLNb6lDbP+UGWfrZ5bIY6KTsnC9 Ls3AbUvU8YaD0lNyCJHJw0AWsi9MJg9Vnj4QopAGR4THc5qk85w+OCJWlnitsAGllonSs2rN mBGZKROiKIbex7z6ozAhESWh7yNmrXoRX9cZ5ueMB3096M+svjeR6zW/EXPzdRHmNUh6J2PL rcC8RgA9QTJDOVcIr+FPH2XGH3Ri3iCC3sG4m2K8spg+wPSOm7H10K1M/ZOX/wb4enRHx7DQ yxI6ianMGSLXOYgZqVzACtBGC/KpQwFcGq9N0PJyGa/W8mkpCbI4nbYJeS7+9M1ycztyNB7v QTSFpBvElolYlUSgPs9naHsQQ+HSAPHht7YzEnG8OiOT0+tU+jQNx/cghWe/QjxwU5zO8z8p BpVcIVdCmFwZqgzdD9LN4ly6O0ZCJ6gNXDLHpXL6/30Y5RtoRCei+b6v1Zkior9DsWA/e2ag IMi/fvWifTb9Z+WWqGLNOY3P0xK/8e7d3cVzuTkfb+9qnanqXFoYSx6t7o2qNUWJk2sfxg4Y Lk+VO9dUZY6qe+53Ur+M5mnBnRbj2cRI2103GTl9waIqKCl/dmQlL7rUNdJ/cF7/ZSL8Utfr X2arlOAT1fJduJ5X/wX/pJNyBwMAAA== X-CMS-MailID: 20200915190824eucas1p2244766de5d98225fea4c2c3e074f99d5 X-Msg-Generator: CA X-RootMTR: 20200915190824eucas1p2244766de5d98225fea4c2c3e074f99d5 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200915190824eucas1p2244766de5d98225fea4c2c3e074f99d5 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200915190728.18143-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v11 16/24] examples/l2fwd: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/l2fwd/main.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index e04c601b5..28bede684 100644 --- a/examples/l2fwd/main.c +++ b/examples/l2fwd/main.c @@ -571,6 +571,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -594,14 +595,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Tue Sep 15 19:07:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77802 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0641FA04C7; Tue, 15 Sep 2020 21:10:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B040C1C1CB; Tue, 15 Sep 2020 21:08:30 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id CDCAD1C1DC for ; Tue, 15 Sep 2020 21:08:28 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200915190828euoutp0191bb06b8fd8d4a7909f10655ec8ee84d~1Cpw2WuU80517005170euoutp01i; Tue, 15 Sep 2020 19:08:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200915190828euoutp0191bb06b8fd8d4a7909f10655ec8ee84d~1Cpw2WuU80517005170euoutp01i DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1600196908; bh=hWLcmMyVuKFoVFPzJm+8zZ/bn73NfLWC3PPR6DROxJc=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=MnoUalswLfq+Y1KLlP/c8a34w+2ho+DxREQih09ho3w3YRi7ydkejSfzWtc6MXC6n xFvRPqpQvpQMM4aW/XVx2Ry0OyAUJh8Gla6MOnHMc0C83UBuzpUQbElecdW27MYKLC YD+RMrYVRCOnwgicigbojIshZrM+9tlk5hd2YJCs= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200915190828eucas1p11fde35c31e8a60028bd254d8a6358669~1CpwoHyfU3106731067eucas1p13; Tue, 15 Sep 2020 19:08:28 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id F5.56.06318.C21116F5; Tue, 15 Sep 2020 20:08:28 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200915190827eucas1p227a32a8f74b364decb7ebbc096172949~1CpwHV-7Z1703717037eucas1p2Y; Tue, 15 Sep 2020 19:08:27 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200915190827eusmtrp1be8e9c8f5f241c4c7faf8e48f83910a5~1CpwGjV433148631486eusmtrp1e; Tue, 15 Sep 2020 19:08:27 +0000 (GMT) X-AuditID: cbfec7f5-371ff700000018ae-94-5f61112c6599 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 44.FB.06314.B21116F5; Tue, 15 Sep 2020 20:08:27 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200915190825eusmtip2ac3ea44f225555eb233fb9fc09b4da59~1CpuWToXp1712317123eusmtip2N; Tue, 15 Sep 2020 19:08:25 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 15 Sep 2020 22:07:12 +0300 Message-Id: <20200915190728.18143-18-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200915190728.18143-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSe0wTWRTGc2amM0OXmqGQcNVVtInGXQXXoNkTs1kfMTpqjK+gCckKVSbI SqvpiIDZBKIGpCIiRQ1oKkgMD4nAUigQQERjwaKsrOUhKKxrYkBFBGp81AftYPzvO7/vO+fe c3N5WnuOncXHGQ9LJqM+Xseqmdo77ztDlwToo35pnwjCig4r4NMnRTQO5T5m8dTYCQp7y1Zh o/2SCnMGUynMynlDob3EzOLLoWMMjo7bKRxocnKY33WMw/HW5xye7rwI+NwzQmNewQRgp7VG he9vNrD42nOFwawPLsAztjZAR+YbBnPr6wDTzAKOlRZzWDQwF8eH2hh09lVzWO5+QGNNxyfA s44KwHtpX1Sr54sfCq6qxKLGYUq0FD6gxTt95zkxs91KiVWjdZT4utnFilm2MhDvPj1Fi9ee vWO3qSPVv8VI8XFHJNPS36PV+4v7zeyhXnXSoKWGSoV83gx+PBGWk4rqbjCDmtcKJUAqm8po pZgE0pBxg1GKCSBV2Q7ODLyvpbpcrfBiIB21b6dDbiDDnnTOO5cVFhHnSSvlNYKEKpbYPT2U 1wgUtpLLpTdpr2aEBcRpHld5tUZYSQr7XKBcKoRcq2zxZfymeFe9yzdUK8wlPZcnfUOJ0MGT QfewSmlYRzLKH9KKDiQjDhun6B+J05LJKA3pQM7WVnNKkQ3k+MVX06lVxPbivm85WviJVDQs VfAact7yjlZ2nkF6XwV4MT0lc2ovTGMNOZmmVdI60tLeNY0J+fTRX8EiseQ+VCkP1ASk/ZGd zYaQ/O9nFQCUQbCUIBtiJTncKCWGyXqDnGCMDdt30PA3TH1W52eHuw6aPXtbQeBB568p6I+O 0qr0R+RkQysQntYFadbec+7RamL0yUcl08EoU0K8JLfCbJ7RBWvCrwz/oRVi9YelA5J0SDJ9 cyneb1Yq/OBZOdv915ONYyVbena1pXSv60+67pDqDTGNK1L+/ccWdmtHZKK1ND/dqO49vj4v MCJ4t7y4byJl28Lbo39ycZUtNaHOSboxI+FzQJ0wMidigOOSDf9vSMyL2MynrWdvDyY5toe3 7XSFbk0P+W+gvzs58tfH/ss3FS7b7Zi5ccujOfN0jLxfv+xn2iTrvwKT8FtvqAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSa0gUYRSG+2ZmZ8etrWk1/JAwW4iiaHW0zaOUZRFMP7oRdLdtskmXXNd2 VulCZBFq46W80M3QNQlrNe+mlaXuD61WsbQtxUqJsrIwtYIMy3aV/j2873nPOXAOQ2p+Un6M Md4qWuKFOC2topx/294uXzZXMAQ9qwyEivYCBO/eFpMwkPeGhvSRcwT02NdAY/11BeT0JxOQ lTNKQP0tmYavA2cpGB6rJ+D1Q6cSrnWdVcKY46MSMjvzEXycGCLhqu07gs6COgWMt9yn4dvE DQqyfrsQXKh9jKAtY5SCvHsNCFJkFkZulyih+LU/jA08psDZW6OEsp/PSahr/4Mgu60CQUfK pGLtQv637aaCL278TPC5Rc9JvrX3kpLPeFJA8FXDDQT/7ZGL5rNq7Yh/+i6d5Evf/6K3qvbo VlnMiVYxINYsWVdr93IQrOPCQBe8IkzHhYRGhQfrtYERqw6JccYk0RIYcUAXW9In0wk9qmP9 uXVEMrrGyIhhMLsC15SpZKRiNOxNhEda26hpHeMv70kZebnRG0+8lOnpmu8ID10pV3gMml2C nWkFhMfwYfto3J16hvIY3uwmLDseEB6m2EXYKY9NBdRsOC7qdaHprgtwaWXz1AQvt951z6X0 sIY14sLUbnqa/fGrwh/ERTTbhmbYkY+YKJliTBKnkwSTlBgfo4s2m6qR++R3W8drGlBX1XYH YhmknaW29R0waBRCknTc5ECYIbU+6nUdzv0a9SHh+AnRYjZYEuNEyYH07gWzSb950Wb3A8Vb DZyeC4UwLjQkNGQlaH3VaWzLPg0bI1jFI6KYIFr+5wjGyy8ZcYvHXYMHw/Sm6g3OXU9L9Y3E nfWfRs4fDPgwdLK8245P+0b9aE8KpI8Y5m9cMDm483DHjOatEby3ZPdN2ZZvtCRkztxfst2B /Y+GCIWROinapo5Y1xOU3qSP3Fy084kxeemxF/Vep1rA//PugMuKyeBB0ylTaf6c/tEtTVED QTu0lBQrcEtJiyT8A0kO6GcIAwAA X-CMS-MailID: 20200915190827eucas1p227a32a8f74b364decb7ebbc096172949 X-Msg-Generator: CA X-RootMTR: 20200915190827eucas1p227a32a8f74b364decb7ebbc096172949 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200915190827eucas1p227a32a8f74b364decb7ebbc096172949 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200915190728.18143-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v11 17/24] examples/l3fwd-graph: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/l3fwd-graph/main.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/examples/l3fwd-graph/main.c b/examples/l3fwd-graph/main.c index c70270c4d..0f3f4088c 100644 --- a/examples/l3fwd-graph/main.c +++ b/examples/l3fwd-graph/main.c @@ -599,6 +599,7 @@ check_all_ports_link_status(uint32_t port_mask) struct rte_eth_link link; uint16_t portid; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -623,16 +624,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* Print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf("Port%d Link Up. Speed %u Mbps " - "-%s\n", - portid, link.link_speed, - (link.link_duplex == - ETH_LINK_FULL_DUPLEX) - ? ("full-duplex") - : ("half-duplex\n")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* Clear all_ports_up flag if any link down */ From patchwork Tue Sep 15 19:07:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77803 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC7F8A04C7; Tue, 15 Sep 2020 21:10:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CF4661C0D9; Tue, 15 Sep 2020 21:08:32 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 855A21C114 for ; Tue, 15 Sep 2020 21:08:31 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200915190831euoutp017ec18fe1b4ae8f4d825d9697b083f080~1CpzVQ3wL0530105301euoutp01c; Tue, 15 Sep 2020 19:08:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200915190831euoutp017ec18fe1b4ae8f4d825d9697b083f080~1CpzVQ3wL0530105301euoutp01c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1600196911; bh=kjiDZOgx4RVk31QgFA7JiC93FXZ7jB4R8xwyUSv77Cc=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=fmgJszBBpbULEQGzimK7N6yN4d79mP2Zbwqpe/8ExvQGXb2qxdfxLRWXI1oJX4aqe ZIIjsantQJzughSPALje8y1ZZs30kZLhrtPQMO7zbmHbAh4/pdnrILLLUA9tcga+xR EtwxllEVbuq3AJtf2sVh6u7y81R9UDf+Ue9E9ax0= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200915190831eucas1p2cf119cd441308f15775e1689722398a4~1CpzJgzX-2576625766eucas1p2z; Tue, 15 Sep 2020 19:08:31 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 70.EF.05997.E21116F5; Tue, 15 Sep 2020 20:08:30 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200915190830eucas1p1104f3abf3de5ca32e43f8efc0e53a524~1CpyvqE1T0047600476eucas1p1d; Tue, 15 Sep 2020 19:08:30 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200915190830eusmtrp1bf34d66cded3524c22fd07468cf5cc02~1Cpyu05c83148631486eusmtrp1h; Tue, 15 Sep 2020 19:08:30 +0000 (GMT) X-AuditID: cbfec7f4-677ff7000000176d-7c-5f61112eb7e4 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id BE.EB.06017.E21116F5; Tue, 15 Sep 2020 20:08:30 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200915190828eusmtip2b17a41cc3f77cb0cd8e0dd9f2023ccdf~1Cpw_k84J1712017120eusmtip2M; Tue, 15 Sep 2020 19:08:28 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 15 Sep 2020 22:07:13 +0300 Message-Id: <20200915190728.18143-19-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200915190728.18143-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSa0wUZxSGPTOzM8PGbcfFlKNVjJs00VbBVk1Oqqml9cf8qtSYJmoUR52C gV3pLqi0fwgiEkDutimYBUUDLkRUlosEDIvRRRak0CyKRSHiJVoRwfUCLFKWwfTfe573Pd/7 5csnssaT/GLxgCVBtVqUOBOv5+pujHetDlugRK0517mRqjvsQA/ul7E0WHiPp8yXqQzdcWyi pvpTOsofSGYoO3+UofqKDJ6eD6Zw9GKsnqH+Zo9ART0pAo21PhHoRFcx0BP/M5b+LH0F1GWv 1dG4q5GnEf8ZjrInvEA5zjYgd9YoR4VXGoDSMiR6eb5coLL+UBobbOPI01cjUNXrbpZqO6aA 8tzVQJ1p07pvl8sTped0clnTU0YuON3Nyjf6fhfkrJt2Rr70ooGRR656eTnb6QC5/UEmK1c+ fMdH6nfoN+5X4w4cUq3h3+zRx7yxX+TiO/RHUl0PhWSoFTMgSERpHaa/aYMM0ItGqQIwp9fN Bwyj5AO8cDlWM14BjhYN6j5s5DgGWM0oB/QPlQva8Bqw33uBCaR4aQV60u1MwFgoXeKx3n97 1giWtuDJRy4hoDnpMyxw5s72GaSvsXKojNEqlmHlxRY2oINmeM8Vr6DdKRRvl/hmD0WpTcSR pkzQFjbjcEo+q+lgfOZ2Cppegp6CLE5bOA6YV1cjaEMu4NHi4bnUJnT+e2tGiyIrrcTqxnAN R+D79hI2gFH6CO8MLwhgdkbm1/0xhw2YnmbU0iZsudkzhxGnJudrWMbrJZNzD9QM2Dt+nMuF ZUX/d5UCOCBETbSZo1XbVxb1cJhNMdsSLdFh+w6aL8PMZ/W8d/saoNG/txUkEUzzDaX/7Iky 6pRDtiRzK6DImhYavuv07DYa9itJv6rWg1HWxDjV1gqfipwpxLD2zNNdRilaSVBjVTVetX5w GTFocTKEZkYW3x1IUKa6U8anypvTqyZSm4yhfZFVP38cs+H+5NUtNRE700zH8tpzVy7yufI6 dx22OHzXR+f9WPicrm0+cXfVXm7bX0UbQFzzwy8rVm+fDp6Ir5vXcuvUT70FxwYef8KFh0et X7p8ydnfvDlJb7//YmvEPZe1whxybem2v7f7pmOHTJwtRvnyc9ZqU/4DqLLVkagDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH/d17d+9VWt2m0g+JHosshK5Osx2lLHpegkiKIHrpxW46clvs Tiv/iBWitZlmiVTatIZYWlim+SgjR2Q2K1O0pFIzw17OfPTQ7DG1/vvwPd9zvgfOYUnVCBXA 6gxmyWQQE9W0D+X63dC5hJ8pxoQMtgdCWZMdQU+ng4TunNc02L6kEvCiZCXcqcpXwOkuCwGZ pwcJqLpspeFz9zEK3ENVBLyqczFwvuUYA0POPgZOPs1D0Df+kYRzhcMIntorFTBaX0vDwPgl CjLH2hBkVTxE0JAxSEFOTTWCNCsHX64UM+B4NQeGuh9S4Oq4ycDVr89IqGz6hSC7oQzB47Q/ ilXzhbHCIoXguPOBEM5cfEYKDzpyGSGj0U4IN9zVhDBwt40WMitKkPCox0YKpb0/6GifHfxy kzHJLM1LMMrmFeqdGgjlNRHAhy6N4DVh2t2RoeHq4Kjle6VEXbJkCo6K5RO+2a9TB5p8DqXW 9zIWVMlakTeLuaU4q6SLnGAVV4Rw0TXeiliPjvGnXnLK4ovH2630lGUY4fd1xATT3GLsOm73 sA/rx72kcWv6UWqi4Mttwqm3HJNMcQvxmYpTk81KLhKXvnUQU0Pn4tLr9yYDvD16S00bMxWg wwXprf/C5uDnBSPEKTS9EHmVID8pSdbH6+VQXhb1cpIhno8z6suR5+K3HoxWVCOre6sTcSxS T1MWvoyNUSnEZPmw3okwS6r9lKsfu/aolHvFwymSyRhjSkqUZCcK9yyYTQb4xxk9/2Mwx2jC NVqI0GjDtGHLQD1LeZyr36Xi4kWztF+SDkim/30E6x1gQaK2eV9/+aJ9u3+XRTB9YqAuQxGo exeuvG8pXtMfPbfsyJag744Zfb41L7ZvjNrl/rzxhFj35mBe847+9BRdSJotaFb2k3iCsdgS 16abGOf61ixpmwG6/Bvx3XWK27PPNoYU5O9XbejsXHBh5XfbYE+uXlnlVecu7v+p7/Cq3fxB TckJoiaINMniX+VGxtoHAwAA X-CMS-MailID: 20200915190830eucas1p1104f3abf3de5ca32e43f8efc0e53a524 X-Msg-Generator: CA X-RootMTR: 20200915190830eucas1p1104f3abf3de5ca32e43f8efc0e53a524 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200915190830eucas1p1104f3abf3de5ca32e43f8efc0e53a524 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200915190728.18143-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v11 18/24] examples/l3fwd-power: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/l3fwd-power/main.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index 9db94ce04..bcd737994 100644 --- a/examples/l3fwd-power/main.c +++ b/examples/l3fwd-power/main.c @@ -1945,6 +1945,7 @@ check_all_ports_link_status(uint32_t port_mask) uint16_t portid; struct rte_eth_link link; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -1964,15 +1965,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf("Port %d Link Up - speed %u " - "Mbps - %s\n", (uint8_t)portid, - (unsigned)link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", - (uint8_t)portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Tue Sep 15 19:07:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77804 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D3D79A04C7; Tue, 15 Sep 2020 21:10:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D7FFD1C1E1; Tue, 15 Sep 2020 21:08:36 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 37C041C1DF for ; Tue, 15 Sep 2020 21:08:35 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200915190834euoutp01cc340afeac3909f7319de03aee2005d5~1Cp2wqbOz0552405524euoutp01X; Tue, 15 Sep 2020 19:08:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200915190834euoutp01cc340afeac3909f7319de03aee2005d5~1Cp2wqbOz0552405524euoutp01X DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1600196915; bh=6p7H3O/p30P7+DqRWD5odx/9ARdFqIE8TJnlYcrXyzc=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=tyCZBrAU48Zt4z6RHpTFRLi1RWMo7czZDEEgkgGKuZuq6CixMUtBJt9NfkspNiTyQ EgUgucheYu7FObMWZ7OEnLT686kLx66lMePrhDxUPPdRKOvDArVvzdwURMMvHiAtjZ aQm6qi6KJKzQN1KAQ6r3kb++j85QnW1J5C/ESneU= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200915190834eucas1p1f29fb0a714487fee04b9df0526cd027a~1Cp12GONm0047600476eucas1p1f; Tue, 15 Sep 2020 19:08:34 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 98.56.06318.131116F5; Tue, 15 Sep 2020 20:08:33 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200915190833eucas1p2708ab17017315c193173b423c9fa1d0e~1Cp1VSUMa2576625766eucas1p23; Tue, 15 Sep 2020 19:08:33 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200915190833eusmtrp183ae6948f188600fb06cf1c3d2ce591f~1Cp1UeztW3148631486eusmtrp1k; Tue, 15 Sep 2020 19:08:33 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-9d-5f6111314829 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id A6.FB.06314.131116F5; Tue, 15 Sep 2020 20:08:33 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200915190831eusmtip2bdb03e323bb79a8440858b7d1d94f244~1CpzjEwj50503105031eusmtip2P; Tue, 15 Sep 2020 19:08:31 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 15 Sep 2020 22:07:14 +0300 Message-Id: <20200915190728.18143-20-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200915190728.18143-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSa0hTYRjHec85O+c4WpyW2IuF0qDoQutKPUX3gk4QFPTBClKPelgXN2VL u3yokWE2zbxRamXqykzLS85tho1akdbcREHUrmJGlOl0ZWStbPMYffs9/+f/f56Xh5cllbl0 OHtYd0zU64REFS2nrM/GPUuWzxBilhWa10BtWwmC/rdmEvoK3tCQOXKOgJ6qTdBsuyaDvHdG ArLzRgmwVZpo+NJ3loJhn42A1w9dDBR3nmXA5/zIwMX2qwg++j+TUFT6FUF7SaMMxh8/oMHr L6cg+2cXgkuWVgQtWaMUFDTZEaSbOBi5c5sB8+sI8PW1UuDqbWDg7lgHCY1tvxHkttQicKdP yDbP5X+W3pLx5uZPBJ9f1kHyz3ovM3zW8xKCrx+2E7zX0UXz2ZYqxL/ozyT56oEf9B75Afn6 BDHxcKqoX7oxVn4o0xiWbAs7kXapgDKiC0oTCmExtwpn2H2yICu5SoRrvq81IXmAvyHc+XIY ScVXhIvq+4l/icfnLkwlbiNcVxMlmcYQ/mBPo4MNmluAXRklRLARytXT2ObvnkzP5HbjgR+O yTTFzcN9gw4qyApuHR5qvSyTNkTi6rpHZJBDAnpnUxcjbYvA3Te+TQ7FXBuL3WV3Au9jA8V2 fNcbLWVn4s8tFkbiOdiVn0VJ/vMI51obGKnIQTjt6tCUaxO2DHqY4CCSW4hrHyyVZm7BhZ7V Ek7HPUMzgmYygHnWK6QkK3BG+tQVVfjR884pGePfv6ZJMo+Lr1wjpPM8RLg86zuZgyKL/68q RagKzRJTDFqNaFipE4+rDYLWkKLTqOOTtPdR4KO6/rSM2ZHDH+dEHItU0xSlr2JjlDIh1XBS 60SYJVWhiq1uV7RSkSCcPCXqk2L0KYmiwYlms5RqlmJl+aeDSk4jHBOPimKyqP/XJdiQcCNq vegIpSsL1amWiqQjFSb3vobs3WTj8HT1rw3nrYNzhs44HUcnTtuEmKLmJXP3q3Pk1vs5p8J1 qdaevYKxYoE3as0TT7x/wLqN9S6umb8ibCxusWY0PjpSEz6+002/UzXdjPJHTORrPcvujVT7 tmkrmO73m6Pd5l3j15/ucLUlqijDIWH5IlJvEP4C6Fn+16QDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917d7dZi+tSuyywumX0oNX1eYw0e0CX6AXRP73WaBeV3Ca7 0zQI1EptmuUSy4o5FXtoYA9rZmY6olkzfGEqWq0YmJma2ihFran035fz+Z7vOXCOBJd7CIUk XmfkDTp1AkP6EM4Zx6eNrK9atbnHHABVzRYEXz+V4eAq+EhCzs8LGHRXbIM6220RmD+nYZBn HsXAds9Ewg9XBgHDYzYM+l46xXCzPUMMY/Z+MVxuuYWgf+o7DkXWcQQtlqcimGisJWFkqpSA vMlOBFeqmxA4ckcJKHhegyDTRMHP+3fFUNYXCGOuJgKcPU/E8MDThsPT5mkE+Y4qBO8z/4pi VnKT1nIRV1Y3gHHXStpw7k1PoZjLfWvBuEfDNRg3Ut9JcnnVFYh79zUH5yrdf8iDPkeUWw36 JCO/Ik4vGKOYoywEK9lIUAaHRirZkIjjW4LDmE3RWzV8Qnwyb9gUfVIZl5MWkGgLSDl/pYBI Q5fkJiSV0FQo3XjhksiEfCRyqhzRrW0tyIQkXkDTg2583rOEnvpgIuc944huuPFKPAtIai3t zLZgs8CP6iXpjqx0YhYsofbRo3Xdc5qggmjXYP2cllFb6KGmQtF86nK68mHD3ASpt97+vHMu VE7F08VZHeS8DqS7in9hV9FiK1pQgfz4JEEbqxVYpaDWCkm6WOUpvfYx8p782ZuJJzWo/dEh O6IkiFkks/aeVMlF6mQhVWtHtARn/GQ73jtPyGUadepZ3qBXGZISeMGOwrwL5uMK/1N67wPp jCo2jI2ASDYiJCIkHJilsmyq8ZicilUb+dM8n8gb/vdhEqkiDV1fk/J7l79H4SiptZ5fJ4VU jWZ4taX897LK5ZWtvq93Fu1tdtm+FM7E+H47rFfIo6SBiVVua62jK7L+kObtuRRV+ICPbBzs 7oYd/aXTLZ4p1my+OHPkTHXmVbc7aPedhX+3vzDvxx6ICxnHdMWqmPTPe/IPbEhMONs7FFqc 0xzCEEKcml2PGwT1P5hB/FAIAwAA X-CMS-MailID: 20200915190833eucas1p2708ab17017315c193173b423c9fa1d0e X-Msg-Generator: CA X-RootMTR: 20200915190833eucas1p2708ab17017315c193173b423c9fa1d0e X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200915190833eucas1p2708ab17017315c193173b423c9fa1d0e References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200915190728.18143-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v11 19/24] examples/multi_proc*: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- .../client_server_mp/mp_server/init.c | 15 ++++++--------- examples/multi_process/symmetric_mp/main.c | 13 +++++-------- 2 files changed, 11 insertions(+), 17 deletions(-) diff --git a/examples/multi_process/client_server_mp/mp_server/init.c b/examples/multi_process/client_server_mp/mp_server/init.c index c2ec07ac6..a7f5207c3 100644 --- a/examples/multi_process/client_server_mp/mp_server/init.c +++ b/examples/multi_process/client_server_mp/mp_server/init.c @@ -185,6 +185,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -204,15 +205,11 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf("Port %d Link Up - speed %u " - "Mbps - %s\n", ports->id[portid], - (unsigned)link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", - (uint8_t)ports->id[portid]); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", + (uint8_t)ports->id[portid], + link_status_text); continue; } /* clear all_ports_up flag if any link down */ diff --git a/examples/multi_process/symmetric_mp/main.c b/examples/multi_process/symmetric_mp/main.c index 9a16e198c..33643d354 100644 --- a/examples/multi_process/symmetric_mp/main.c +++ b/examples/multi_process/symmetric_mp/main.c @@ -365,6 +365,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -384,14 +385,10 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Tue Sep 15 19:07:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77805 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C65D4A04C7; Tue, 15 Sep 2020 21:10:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 546A01C1F4; Tue, 15 Sep 2020 21:08:38 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 6470C1C1E5 for ; Tue, 15 Sep 2020 21:08:37 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200915190837euoutp026fc2a42ecc11a8b218ecf1f7d8caa200~1Cp4vDSyT1840518405euoutp02H; Tue, 15 Sep 2020 19:08:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200915190837euoutp026fc2a42ecc11a8b218ecf1f7d8caa200~1Cp4vDSyT1840518405euoutp02H DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1600196917; bh=2gXLZvWQss8NYG1Gu+w8A/KveRxMhRUfcMEnas9Mi8U=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=A21DQxpoK8gonV1zMw9w/qStU4SLiU/asJD2gx0w199bxJOe0AmA5lokGARBJevoZ RvCNK6DlvQMpHOjp1Wlq0WTmILN6jFqmXqim0KqyhPIqO8P239FeGt/9aWz49bS/a8 TiMWqULjKxSaGEmenUH0pyFFnY7/qsmR5MFe6RQE= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200915190836eucas1p161949d83fe2f2fe131799b3d6a367148~1Cp4dJG640198001980eucas1p1E; Tue, 15 Sep 2020 19:08:36 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 0B.56.06318.431116F5; Tue, 15 Sep 2020 20:08:36 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200915190836eucas1p2d2806d0372be5ef08085ab7c5f4585d2~1Cp33i8021274112741eucas1p2C; Tue, 15 Sep 2020 19:08:36 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200915190836eusmtrp1e1fa255456b06fb91ee4e4359a11995f~1Cp32yzmF3148631486eusmtrp1n; Tue, 15 Sep 2020 19:08:36 +0000 (GMT) X-AuditID: cbfec7f5-371ff700000018ae-a2-5f6111348110 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id A1.FB.06017.431116F5; Tue, 15 Sep 2020 20:08:36 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200915190834eusmtip244af2434f7d98144415c0875698ae9b6~1Cp2FPEu91712317123eusmtip2O; Tue, 15 Sep 2020 19:08:34 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 15 Sep 2020 22:07:15 +0300 Message-Id: <20200915190728.18143-21-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200915190728.18143-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0VSa0xTdxTPuf/bey+NNddC5B9cUJtNcUN8sXhCjG4+b9SYxW/bnNjpFYyA phec7lNFgsijFKiY0QWKdRGBBIVKq0KH/QBIRYWEIPFF3BICW7VWUFFQKbfGb7/nOcnJEYje xsUJh7KyZVOWMcPAadnWzsk7y5PnGVNX2mxJ2HS7GvDpYyfBYdsjDouCeQzer9+Abe4/NVj+ xMygpfwFg+66Qg7/H85l8VnIzeDDdj+PVf25PIZ8IzyW3LUDjkyNEfzD8RLwbvVVDU7evM7h 86nzLFreDgCWuroBu4pfsGi75gHMLxQxeOkij86H8Rga7mbRP9TCY+NEH8Grt6cBy7qaAHvz P2i+Wyy9dfylkZxto4xUUdtHpM6hSl4qvlXNSFeeeRjpuXeAkyyuepB6nhYRqeHfN9wP2p+0 6w7IGYeOyaYV6/dp088M2uFoj3D8RtW3ZnjCFYIgUDGZPq6JLgStoBfrgDpCr4lKxoGe7J/g VfIS6D8XgjONqNmGz/0oYlwEWnQvBCqZAPqgbRjCKU5MoP6CaiZsxIhXOOqeGmTCRrS4hZZ6 X82GWPEr2ny2kw1jnZhCnd1uXl2xkDZc7iBhHDWj918bmNX1YjwdrBmfHUrFboEOnZwkamEz Ha0viuBoOtbligz6gvorilm1cBpoWWsLrxIr0FP2QCS1gbr+u8OH70HEZbTp+gpV/p6Wlgc0 6pnm0vuBeWGZzMDy1nNElXW0IF+vpg2041Z/RKZ0+t0cVZaopeZS5EDtQC+fs7BWWFj1eZcD oB5i5RwlM01W1mTJvyUpxkwlJystaf+RzGaY+VX/+64JD3infvWBKIBhjs7xYF+qXmM8ppzI 9AEViCFGt7HXv1evO2A88btsOpJqysmQFR8sEFhDrG7N+dFf9GKaMVs+LMtHZdMnlxGi4sxQ lbDUam7cNX9r5dDuv1PiYu41xVaMd1T2bLW/WbaDz3u9rdadkmfFlg/JuTZnxuqDO8subJ/2 6ckIuaGYzSWJP3pfrZ1sjvf8/GW69+x60uoK7EnYlGpPLNDm7qk7vDoxjwT2lmxf9M2S9rkh w4IcORjss3rObMtmx+ZH9SYuX2lglXTjqq+JSTF+BCA1Pg2nAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917d+/VXFyX0cWix1SQqFubWx6tLIro/hkEklrNS15U3Jzu bqL+k0pYLbWHFWWylmYPiyyzZqZS+0Nn03xhKj4TQezhM6XErKn03+H7+Z5zvnAOjSvmCH86 MdksmpIFvZL0JtxLjYO7NL6Cbk9dMQUVzTYEI4OlOAzfGCDh8tR5DHrKD0Kto1gG14eyMCi4 Po2B47GVhO/DOQRMzDgw6K9zU1DUkUPBjHOMgvzWuwjGFr/icMc+i6DV9loGvz/UkDC5WEJA wUIXgitVLgSNedME3HhbjSDXysDUk0cUlPZvgZlhFwHu3lcUPJtrx+F18x8E1xorELTk/pUd 2s4v2MtkfGntOMYX3m/H+YbeWxSf12TD+JcT1Rg/Wd9F8gVV5Yj/OHIZ55+O/iKPe0dz+01G i1nclmCUzAeUMSpQc6ow4NSaME4VEno6XK1V7o7YHyfqE9NE0+6IWC7hUvddlPKRTn9XpM1C Q6QVedEso2GdjgHKirxpBVOG2L7eEtyKaA9g2W+j+KpnPbv42UquemYRm/NgCC0Dkglm3Rdt 2DLwY/pItvNCNrEM1jNH2Sv18ysmggliK282rOhyJpwtdTmo1alb2acv3q9s8PLoHW+7VnQF k8jeu9BJrtZb2O57P7GraJ0drSlHfqJFMsQbJDUnCQbJkhzPnTUaKpHn5G8afldVI+vECSdi aKT0kdv7YnUKmZAmZRiciKVxpZ/8cIv7jEIeJ2RkiiajzmTRi5ITaT0Br+H+G84aPQ+UbNap tKpQCFOFhoSG7AXlRvlF5sMpBRMvmMUkUUwRTf/7MNrLPwtlND3vOZceU6S55MusTcq9vW0p 1uJVOZ7NVUdyQovGW3/Mrk89VKzTuw64KhcUDsvBzTX0QFcZjWyBT5LUflE7AzrmlhaUmVd3 fgr4cTIyd995cTEoJrww9W9N4ExwRTYV0Dy/KS9Qe8Qnqq3QkvIl/2FEU9u8IzppuvlXxKRD SUgJgmoHbpKEf7E0YcAIAwAA X-CMS-MailID: 20200915190836eucas1p2d2806d0372be5ef08085ab7c5f4585d2 X-Msg-Generator: CA X-RootMTR: 20200915190836eucas1p2d2806d0372be5ef08085ab7c5f4585d2 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200915190836eucas1p2d2806d0372be5ef08085ab7c5f4585d2 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200915190728.18143-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v11 20/24] examples/ntb: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_strf function to example applications Signed-off-by: Ivan Dyukov --- examples/ntb/ntb_fwd.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/examples/ntb/ntb_fwd.c b/examples/ntb/ntb_fwd.c index eba8ebf9f..6d9b3b45c 100644 --- a/examples/ntb/ntb_fwd.c +++ b/examples/ntb/ntb_fwd.c @@ -729,6 +729,7 @@ start_pkt_fwd(void) struct rte_eth_link eth_link; uint32_t lcore_id; int ret, i; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; ret = ntb_fwd_config_setup(); if (ret < 0) { @@ -747,11 +748,11 @@ start_pkt_fwd(void) return; } if (eth_link.link_status) { - printf("Eth%u Link Up. Speed %u Mbps - %s\n", - eth_port_id, eth_link.link_speed, - (eth_link.link_duplex == - ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), + ð_link); + printf("Eth%u %s\n", eth_port_id, + link_status_text); break; } } From patchwork Tue Sep 15 19:07:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77806 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C8EAA04C7; Tue, 15 Sep 2020 21:11:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 801861C11C; Tue, 15 Sep 2020 21:08:41 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 525E11C0DB for ; Tue, 15 Sep 2020 21:08:40 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200915190840euoutp0115cf836c07170f83070f71647c0a23b1~1Cp7j_CJu0530105301euoutp01e; Tue, 15 Sep 2020 19:08:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200915190840euoutp0115cf836c07170f83070f71647c0a23b1~1Cp7j_CJu0530105301euoutp01e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1600196920; bh=6qXnbzIjmvFRgAFmouzzB/qKJMLERwKTl8zUKg8Pv5k=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=eT7gGvZPoCyaWX/Ma8LW7h/3JpXz+tCOZrcdnsj6EOmo68h55qglwDIChu025vuuQ tsIMWvhNfYP4f/SMZtuGOCiZgAIzEfPjRFinkShd+1iKXBnXydmAY9Vxkr3NlEUqzi 2dDRuHawYIychsLp/j6CrvKiiHK23yCGD3Ppmi/w= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200915190839eucas1p2b54b2475087d6270e4217facc63b5210~1Cp6yOkSp1703717037eucas1p2i; Tue, 15 Sep 2020 19:08:39 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 2D.56.06318.731116F5; Tue, 15 Sep 2020 20:08:39 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200915190838eucas1p1adaabef8ead06d5220e3091a94dedf37~1Cp6dWV4S0047600476eucas1p1k; Tue, 15 Sep 2020 19:08:38 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200915190838eusmtrp1e937cb75fcfd1cf08e6d9116d7096398~1Cp6chCq43148631486eusmtrp1s; Tue, 15 Sep 2020 19:08:38 +0000 (GMT) X-AuditID: cbfec7f5-371ff700000018ae-a6-5f6111379c03 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 99.FB.06314.631116F5; Tue, 15 Sep 2020 20:08:38 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200915190837eusmtip21af50c51d2a69bdc42b661dcb70d0264~1Cp4ueyHl1759817598eusmtip2R; Tue, 15 Sep 2020 19:08:37 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 15 Sep 2020 22:07:16 +0300 Message-Id: <20200915190728.18143-22-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200915190728.18143-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSa0hTcRjG+Z9zds7ZanVahi8VVoOgguwKvXQvIk596PJFLCpbdbKL09jS bgR2M1mmuUQrxzIlZrow23Rq2kVqm25mSaOsLLtAZVmpGWnTch6jb8/ze5/nfeHPn6c1ZnYs vzt+v2SI18VpWRVT7u5pnD5vlC5m5on+kVjitxJ8+6qAxtasFhbPfD9J4bOiJVjtsijQ/DqZ wnRzB4WuQhOLX1qPM/i100Xhyxofh5eajnPYWfuBw7ONuQQ/BNtovJjXRbDRWqbAnntVLH4L 5jOY3hsgmOH0EvSkdTCYVVlBMMUk4PdrNg4LXkZgZ6uXQV+zg0N792May/x9BDM9JQQbUv4o lk4Se/OuKsSC6k+UeP7KY1p0N2dzYlqdlRJLv1ZQ4rfbAVZMdxYRsf7tGVosfv+LXafaqFq4 Q4rbnSQZZizeqtplsa3ZZxl28EbqimSSqTQRJQ/CXMjOzmFMRMVrhEICGR3JlGx+EGi4cozI pouAN7+A+lfxZJTR8sBGoKOxZch0E/BlWRWhFCtMAV+qdXBXmFDKgiv4dLA+WlgLp7zX2JBm hMkQqPQPcJ5XC/Mh/+cY+cIEKL5xlw5p5QBuqgxwIa0RIuDp5R+DO0Hw81DpLmZDXRBWgNe8 SO6OhjaPk5P1ePCdT2Pk/GkCmeUOTjbnCJzIbR9KLQHn54dcaBEtTIWSqhkyXgZvqp5z8v4R 8Kx9VAjTA9JcnkPLWA2pKRo5rYW7dU1DGKDv93AZi/C5zTH0iDUEbvW6FefIhEv/b+URUkTC pUSjPlYyzomXDkQadXpjYnxs5PYE/U0y8FN9/Z7uCnI7uK2WCDzRDlfnvdgao1HokoyH9LUE eFobpl7e4NuiUe/QHTosGRJiDIlxkrGWjOMZbbh6Tv6nzRohVrdf2itJ+yTDvynFK8cmkzEW u8mXEnVh4j3H0dzZfWH36Ucb7CM3KtSRRTa0Wxy2arP62Kr0tFUfc5o9d/ae3WOP7gkq9S2a 9p0PC6O3DOu9/qTufk1ggZAaff3Anuev3lUk1azv6m+Kkuo3hbPOqW7r6veu7X9KnPYjjLve X7pOux4i3j0IS8CVv5YnuadpGeMu3axptMGo+wscgz3GpQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917d3c1F9epeDHQWikSNLvq3DFMI3pcegpSf1Smwy4qOSe7 m/QirCxlmu+CfKyliKmRmo9pVOr+aOoU0bASzYZI9kLNF2n22JL++3I+3/M9B86hcOkC4UMl p+p4baoqRUa6Erbf1omdYe6quF23lpTQ0G9EMDlRhYO95D0JOXOZGLyri4Ln5nIRFH3IwCCv 6DsG5kcGEr7ZbxAwM2/GYPyFTQylwzfEMG+ZFsOdwTIE02tfcLhvWkAwaGwVwUr3MxJm1yoJ yFsdQZDf0oPAmvudgJKOdgS3DTTM1daIoWrcF+btPQTYRpvF8HhpCIfW/l8ICq0NCAZu/xHt 3cqtmqpFXNXzzxhX/HAI516N3hNzub1GjGuaace42ZcjJJfXUoe4vskcnKuf+kFGu56WR2g1 eh2/JUkj6PbIzrAQLGfDQR4cGi5nQ5Sxu4MVsqDIiPN8SnI6rw2KjJcnldccTyvfeLExe38G KnQxIBeKoUMZa34rbkCulJSuRkxuQR9hQJQDMMzXKXzd48GsvTGQ654FxFhnH5JOQNKBjC3b iDmBJz1GMq+zrhNO4EEfY1p6S0VOTdD+zEhHP+YMldC7mcplr/VQP6a+sevfABdHebhjROzU UjqZeZD1mlzXvszbB4tYAdpkQhvqkCevF9SJaoGVCyq1oE9NlCdo1E+R4+Btr1aa29FwU4wF 0RSSuUlMY/FxUpEqXbiktiCGwmWekn0DtnNSyXnVpcu8VhOn1afwggUpHPsV4j5eCRrH+6Tq 4lgFq4RwVhmiDAkDmbckm+4+K6UTVTr+As+n8dr/fRjl4pOBRIPPNjRXdPmfKIsqsmeVGgeW E/ya9UcLZkwB8Ts7S6MzYyTkgeOKvD+z3sWH6SiF67XYtpVFuzb7bJfp1tHlg+mdN4tDsJgc +5O76dsDS158OnXI8vPpyVHRpLt7pjGgPSpyDTU2QM2VzbXR22aOuJnNmW+8PlJXzewP+3zZ rwoZISSp2B24VlD9BUKydEYGAwAA X-CMS-MailID: 20200915190838eucas1p1adaabef8ead06d5220e3091a94dedf37 X-Msg-Generator: CA X-RootMTR: 20200915190838eucas1p1adaabef8ead06d5220e3091a94dedf37 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200915190838eucas1p1adaabef8ead06d5220e3091a94dedf37 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200915190728.18143-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v11 21/24] example/performance*: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/performance-thread/l3fwd-thread/main.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/examples/performance-thread/l3fwd-thread/main.c b/examples/performance-thread/l3fwd-thread/main.c index 84c1d7b3a..956a1f48d 100644 --- a/examples/performance-thread/l3fwd-thread/main.c +++ b/examples/performance-thread/l3fwd-thread/main.c @@ -3433,6 +3433,7 @@ check_all_ports_link_status(uint32_t port_mask) uint8_t count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -3452,14 +3453,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - portid, link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Tue Sep 15 19:07:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77807 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BDCCAA04C7; Tue, 15 Sep 2020 21:11:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 084041C1EB; Tue, 15 Sep 2020 21:08:44 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 7E0611C1EB for ; Tue, 15 Sep 2020 21:08:42 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200915190842euoutp01227f17729b5ba1e81c5c75336a5c9b4b~1Cp9lYPT40516505165euoutp01n; Tue, 15 Sep 2020 19:08:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200915190842euoutp01227f17729b5ba1e81c5c75336a5c9b4b~1Cp9lYPT40516505165euoutp01n DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1600196922; bh=qVSmYkun2k36EKGsPQLrlSwrALp4hWMj7WN7omI+2SA=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=keX3Kc1QUvxiyw2T6vPE/SwNFwo1VsNcfa6dvL3/eWHfzkZ0AdEZ0SHs2xXl5+VK1 EvATQ2773ypKZrMyYpZi+MYr8XAiw81Axs1z1RXi7qYR6XJzE81R1UACHgoDeBiVM8 Bmw7r3+3ln1cV6RTiGJzJw5oD7l0LEEuXvc5hi18= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200915190842eucas1p172f9261cd09cc1f06745cea8ec256611~1Cp9aknRC0047600476eucas1p1l; Tue, 15 Sep 2020 19:08:42 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id F5.63.06456.A31116F5; Tue, 15 Sep 2020 20:08:42 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200915190841eucas1p20ca62d955effb1ca2b22aea6b7170e2e~1Cp85i86V1274512745eucas1p2K; Tue, 15 Sep 2020 19:08:41 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200915190841eusmtrp1bb09a4b737b7a123df05f6633cde5af4~1Cp84xd7J3148631486eusmtrp1u; Tue, 15 Sep 2020 19:08:41 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-96-5f61113a5ef3 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 04.FB.06017.931116F5; Tue, 15 Sep 2020 20:08:41 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200915190839eusmtip2681b181fa67182b4b4f79058faef9c07~1Cp7KbkBn1712317123eusmtip2P; Tue, 15 Sep 2020 19:08:39 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 15 Sep 2020 22:07:17 +0300 Message-Id: <20200915190728.18143-23-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200915190728.18143-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSb0xTZxTGc+69vffS0OVSSDxxRLJmWzaNqBnJTro5558sd9uXfTMxGVDH HSAUTStumJggOmRYGCDTrCzIIEgtWzqlpUBkYahFrMBgMnAiIgwJCIJAI2gda7mYfXue33me 97x584qsvpxfL6ZnHVYsWaZMA6/lGn3LPZuNUaakrSVDHLluVQKNDtewNFJ+j6fTcycZGnTu oCveHzVUdj+XoeKyJwx5HYU8TY/kcfR43svQUKtfIHtfnkDz7RMCFfVUAE0Ep1j6oWoBqKfS o6Hl31t4mg1Wc1T8rB/oO/cNoA7bE47Km5uA8gslmrtYJ1DN0AaaH7nBkf9Og0A/B3pZ8tx6 AVTa4QLqyl/RfPia/KyqViPXXJlk5DM/9bKy785ZQbZ1VjLypcdNjDz7Wz8vF7udIN8cPc3K 9f8s8Z9p92nfT1Ey048oli0fJGvT6gIeOPSn9mu37yGTC3NiIUSIKCVgwcIYXwhaUS85ALuv rTCqWQS8PTAoqGYB8NunA/Cy0vp0HNRBHWBgeHqtEgiZldtMOMVLb6G/oHJ1ECNd4tEbHAgZ UYyWPsWxUmM4w0lv4Nlg3irWSUbs7E5XF8Rh/a9tbFhHhHBfc78Q1nppAw6cX1w9EqU/RLQ7 znNqYQ/WOpvWbheNUx1uQdWx6D9j49TCKcDSxgZBNSWAJypm1lI70P2oWwjfgpXeRlfLFhXv xFNLC3wYo/QKDs5EhTEbkmWN51gV67AgX6+mDdjW2beGEV88j1SxjL0NLlZ9nlbAtvrLTAnE 2f/fVQXghHVKttWcqli3ZSlfxVtNZmt2Vmr8FwfNlyH0V/3/dsw3QaBvfztIIhgidVV3k5P0 GtMRa465HVBkDTG6XV3+RL0uxZRzVLEcTLJkZyrWdnhV5AzrdO9UT36ul1JNh5UMRTmkWF5O GTFifS5ELv2d5nHwFUdzKj62j3vSPFvfu9tcO7fXaC+6frWs9Pv+8a7RxHdtcrAxft9IAs4c my16c/haxs2JyQN/OZITH+z6ZpPvl41fihkHbOZqs+tC1B5nWwQ9nEqI2b24/FGcUbOJiXbH rhhiT3ilvdO+45+k7h57PWP/ueYLm6dbUmK2GzhrmmnbRtZiNf0HqMsySqcDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAAzWSa0hTcRjG+59zdnbUFqdp+VfCcpLdV5uZr6ImBnGiL4YRXbWhB7XcZjtb ZBGYhNUsUxPTtLUSsTQwS3PdddJmTZMSLclM1MxKvBbd1mVL+vbw/p7n4YX3ZUjpZ8qfSdPo eZ1GlS6jPSnHb3vfqvC5qsQ1efcWQW2bCcFAXwUJ/UVvaMidOE7Aq+r1cL+xXASFb7MIyCuc JKDxqpGG0f5sCsamGgnofeAQw4UX2WKYsr4Xw5mOMgTvnR9JKDVPI+gwNYjge/NdGsadVyjI +9GF4Gx9KwL76UkKiu5YEOQYWZi4ViWGit4AmOpvpcDRc0sM1788J6Gh7ReCAnstgvacP6KY QO6HuVLEVdz/QHDnLj8nOVtPsZg7/cREcHVjFoIbf9hFc3n11Yh7OpBLcjVD3+g4z53ySJ3W oOcXpWoFfZRslwKUckU4yJVrw+WKkLA9EcpQ2eroyGQ+Pe0gr1sdvVeeWvWlAWV0eh6qtw0T WWiCMSIPBrNr8YOv75AReTJSthLh3J4awogYF8D40xA54/HGzm4jPeOZRnhkZIR2A5pdih0n TYQb+LCvadx54hjlDnuzm/FgQYTbQ7GLcbEz+1+nhI3AT56lzXQuxDU3mv71e7jGL+50id1a yqbhSyc66RkdgF9e+kzkozlmNKsa+fAGQZ2iFpRyQaUWDJoUeZJWfRO5Ln7b9r3egoxj8VbE Mkg2W2J+vTdRKlIdFDLVVoQZUuYjiW13JEglyarMw7xOm6gzpPOCFYW69isg/eclaV3/o9En KkIVYRCuCAsJC1kHMl/JSbZ5t5RNUen5/Tyfwev+5wjGwz8L5fwa2mR91RtAP7pYE7XnyCn/ uHN4QfcOFPQyamfZ8FgGv+Ty0e0mp0Wzcdmo4GXpjluxondb6fwNvn6Pvf2S95X4dgYesG3F P+Nl5uUfWlqC7dPnUeZK+5LBhNbHQZGnHk0MeBzJ/51gp9tsMcElW8q9YpVmr5W1zp7Ypqr0 um91MkpIVSmWkzpB9RfiVBHbBwMAAA== X-CMS-MailID: 20200915190841eucas1p20ca62d955effb1ca2b22aea6b7170e2e X-Msg-Generator: CA X-RootMTR: 20200915190841eucas1p20ca62d955effb1ca2b22aea6b7170e2e X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200915190841eucas1p20ca62d955effb1ca2b22aea6b7170e2e References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200915190728.18143-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v11 22/24] examples/qos_sched: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/qos_sched/init.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/examples/qos_sched/init.c b/examples/qos_sched/init.c index 9626c15b8..06328ddb2 100644 --- a/examples/qos_sched/init.c +++ b/examples/qos_sched/init.c @@ -76,6 +76,7 @@ app_init_port(uint16_t portid, struct rte_mempool *mp) uint16_t rx_size; uint16_t tx_size; struct rte_eth_conf local_port_conf = port_conf; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; /* check if port already initialized (multistream configuration) */ if (app_inited_port_mask & (1u << portid)) @@ -160,14 +161,9 @@ app_init_port(uint16_t portid, struct rte_mempool *mp) "rte_eth_link_get: err=%d, port=%u: %s\n", ret, portid, rte_strerror(-ret)); - if (link.link_status) { - printf(" Link Up - speed %u Mbps - %s\n", - (uint32_t) link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - } else { - printf(" Link Down\n"); - } + rte_eth_link_to_str(link_status_text, sizeof(link_status_text), &link); + printf("%s\n", link_status_text); + ret = rte_eth_promiscuous_enable(portid); if (ret != 0) rte_exit(EXIT_FAILURE, From patchwork Tue Sep 15 19:07:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77808 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C32BA04C7; Tue, 15 Sep 2020 21:11:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 910CC1C201; Tue, 15 Sep 2020 21:08:46 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id D74D21C1FE for ; Tue, 15 Sep 2020 21:08:45 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200915190845euoutp020cef812fd625a46e73565b8de2bf629a~1CqAsjI4j1839718397euoutp02L; Tue, 15 Sep 2020 19:08:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200915190845euoutp020cef812fd625a46e73565b8de2bf629a~1CqAsjI4j1839718397euoutp02L DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1600196925; bh=j+whVyosWgx3tIoE9UeDWIlBQDtqfd9P5No4AWJHtMw=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=I0nRPvLbQwycBfct5TRJx4ScnhpbWrNZTkGYPOQKimVBwhZLZFsheHnBbxjApiob9 4JvdLUVk2ppO7fQ1UQc4A4Gx7+Jp+c+DdDv811o+srqDq/ddvWrntPngOHciQlXnzi ggJSkrJadwQZsVKWcO+ePIrIWLmTRVbcDxRs7gZ0= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200915190845eucas1p2faa012bbb1613cc09beca63cce8a0456~1CqAP40tC1703717037eucas1p2m; Tue, 15 Sep 2020 19:08:45 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 18.63.06456.D31116F5; Tue, 15 Sep 2020 20:08:45 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200915190844eucas1p15a2a2b9f2226d5fd315c7c8e0a484e5f~1Cp-TW4lp3106731067eucas1p1B; Tue, 15 Sep 2020 19:08:44 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200915190844eusmtrp1ad8f660b2b57f3cadbcd0149a21e90ba~1Cp-ScUax3148631486eusmtrp1y; Tue, 15 Sep 2020 19:08:44 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-9a-5f61113d7c27 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 4C.FB.06314.C31116F5; Tue, 15 Sep 2020 20:08:44 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200915190842eusmtip29babc8b6cb17e4a47d72ae90f6a38798~1Cp9ihaAe1759817598eusmtip2S; Tue, 15 Sep 2020 19:08:42 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 15 Sep 2020 22:07:18 +0300 Message-Id: <20200915190728.18143-24-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200915190728.18143-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSfUzMcRzH9/k9dzr7dVhfz5x5nuThj8/M82x+ZsNm/smok58yXcedIhvy FE5Pl7CKE8eQh1C6zip1m4q7tKIVQpoxpSIXSqKfX+a/z+f1fn8e9tlHoHWp3Ahha/RO2Rxt iNJzGqagvPvJjAUBhtBgRz2HuV47YPNrB41N6a84PPH5MIUNOYuwyHmWxbQ38RQmp32h0HnV yuGnpoMMtnc6KWws9vCYWXuQx073Bx6TqrMAP/S20JiR/RWw2n6Pxe6y+xx29F5kMLmnDjAl vxKwIvELg+muQsAEq4ifr13h0dE4BjubKhn0PM/j8UZXDY33vL8AbRW5gFUJv9nF46We7Mus 5Cj6SEknL9TQUvnz07yU+MhOSXfaCympo6SOk5Lzc0B63HyClq6/+8Gt0YRo5m+Wo7bGyuaZ C8M0kTn2jdtvDNpdXdzLx0OSnxUEgYhzSWOeZAWNoBOvAsl84WKs4Nef+IB0tG1Qha9AWlJ8 vCIoBa7vd0E1XQHyNl2jmrqAlDTbWEXgxCnEc8xOKcJQ8Q5HnL31lDJuiLiaHMnYongYcSKp q0xjFKwV55HXRbPV/mPJ9dultBL79eNaVx2vzhpD6s/7/rYk4jOB+I4eYdWCZaT4XTmtxkNI S0X+wKKjiOdkIqMWHAViK8jj1SQVyKGstgHXIpLf+oRXtqDFqST3/kwVLyFdPzJY9USDSUNb gILp/jCt4AytYi05lqBT3XpS+qh2ABPy66e/iiXS7XKx6nmKgVRdOkSnwtjM/7OyAXIgUI6x GCNky6xoeVeQxWC0xERHBIWbjHeh/089fRWdhdBVu8kNogB6f232y7BQHWuItcQZ3UAEWj9U u7TKs1Gn3WyI2yObTaHmmCjZ4oaRAqMP1M65+HGDToww7JS3yfJ22fxPpQS/EfFg2jO1vccU fKlPs37Gcfe66d4tw3ymfe8fWvW2FS9rIvpst2LTncGnWyfH8TveNEauXnW+tLSMerp8nMka 8CosfHnIGff85kHawoYdw/2Xndo7O8Y46eb+cylFt2s0834nOcIvPMsLWZo53Lp2berIawe+ jX5wNmOBt2XKhJXGlV73tlZBz1giDbOm0WaL4Q+DM1eVowMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAAzWSe0hTcRTH+917d++mLa7T6CJkNoikx+qq06PZgx5wI4qggrLHuuj1gW6T 3Rk9ICzKYpqmlpnVXIqUMzKdpoaWj1Jz2sowNc1UCsnKTHuaZVvSf1/O53u+58A5UlzxhfCW xuqMgkHHxytJN8L+p7l/eZgHr1k5Mk1ASZsZwVB/AQ4DF16RkDJ2CoNu61qoqbwqgczXSRik ZX7GoPKmiYQPAycJGB2vxKCv1k5BbsdJCsYbhik457iCYHhqBIfLlgkEDnOFBH7W3yPh01Q+ AWmTnQjSy1sQNKd+JuBCdRWCZBMNY0U3KCjo84HxgRYC7D02Cm59fYZDRdtvBBnNJQjak6cl 6xZyk5ZCCVdQ8w7jsq4/w7mmnmyKS31sxrjS0SqM+3S/k+TSyq2Iax1KwbniNz/I7W7hqjCD PtEo+MboReNq5V4W/FVsCKj8A0NUbEDw/lB/tXLFmrBIIT72kGBYseagKsZqPpBwy/2wo3aK SkLnZCYkkzJ0IFP9vQyZkJtUQRci5uWTQcqEpE7AMO/f4DMeT2bqhYmc8UwgZqj9LekCJO3H 2M+aMRfwontJ5vmZE4QLeNJbmacPrBKXJuhFTGdLJuEKldOhTH+N/0zoAqb4Tt2/ATJnuaO6 k3JpBR3L5J15Ts5oH6Yr7wt2Hs2xoFlW5CUkitporciqRF4rJuqiVRF6bRlyXvxu009bFeoo 3dGAaClSzpZbeg9qFBL+kHhE24AYKa70kq9vtx9QyCP5I0cFg15jSIwXxAakdu6XgXvPjdA7 /0dn1LBqNhhC2OCA4IAgUM6Tn6Xr9ynoaN4oxAlCgmD434dJZd5JiMwJ8KZzInLj6Mm2uoyo 6TofNtUiDs037lkfntX658HHt7ZlaK/60qZVI/z2a3R0+ovGpflLMsuKkm1B23avyi1SuD9C Xe7DjV2nbYXJpaQlKmz6dM63X4MDY70pjs07Nsw+vrG1b5/D66K1e9eWh77Z7Lzbxzw8fP0i fRbvLM5uVxJiDM8uwQ0i/xdc4GerBwMAAA== X-CMS-MailID: 20200915190844eucas1p15a2a2b9f2226d5fd315c7c8e0a484e5f X-Msg-Generator: CA X-RootMTR: 20200915190844eucas1p15a2a2b9f2226d5fd315c7c8e0a484e5f X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200915190844eucas1p15a2a2b9f2226d5fd315c7c8e0a484e5f References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200915190728.18143-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v11 23/24] examples/server_nod*: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/server_node_efd/server/init.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/examples/server_node_efd/server/init.c b/examples/server_node_efd/server/init.c index 378a74fa5..347737cb9 100644 --- a/examples/server_node_efd/server/init.c +++ b/examples/server_node_efd/server/init.c @@ -247,6 +247,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) uint16_t portid; struct rte_eth_link link; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -266,16 +267,10 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf( - "Port%d Link Up. Speed %u Mbps - %s\n", - info->id[portid], - link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", - info->id[portid]); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", info->id[portid], + link_status_text); continue; } /* clear all_ports_up flag if any link down */ From patchwork Tue Sep 15 19:07:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Dyukov X-Patchwork-Id: 77809 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA58BA04C7; Tue, 15 Sep 2020 21:11:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A5D031C210; Tue, 15 Sep 2020 21:08:50 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id A10A91C204 for ; Tue, 15 Sep 2020 21:08:48 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200915190848euoutp01fc7b5706b2d667d39ae83405b43ddf5b~1CqDTI5Ws0516505165euoutp01o; Tue, 15 Sep 2020 19:08:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200915190848euoutp01fc7b5706b2d667d39ae83405b43ddf5b~1CqDTI5Ws0516505165euoutp01o DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1600196928; bh=jaolOMwppEWttOA38f35lGVL8aPkv9Cah3B7/iAVP9g=; h=From:To:Subject:Date:In-Reply-To:Reply-To:References:From; b=iIL9mrR1PkimvxaDPdAL0o894q4W6KYttnz8NKwisCrQx5xO47aHKPhY6q7G0BWqF fbC1h7UtRONKPGy3q/KjrdIgV7489CIQISaIZPYc12lpq613uMMEat3TA7NFILYw0l hrDEkh3pYanUUCICv9SdBqWYe/l7bWzdfhcU7ySo= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200915190848eucas1p1d4a389bbe7d37dd00288fb92ab86e4a4~1CqC83o8Q0048000480eucas1p11; Tue, 15 Sep 2020 19:08:48 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 3A.63.06456.F31116F5; Tue, 15 Sep 2020 20:08:47 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200915190847eucas1p28539b8571d5060f354c0263b96358ce2~1CqCCDxEd1274512745eucas1p2P; Tue, 15 Sep 2020 19:08:47 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200915190847eusmtrp1213c658c3a252d07f31dcbe5312d8bf2~1CqCAvuJb3148631486eusmtrp11; Tue, 15 Sep 2020 19:08:47 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-9e-5f61113f139f Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 56.FB.06017.E31116F5; Tue, 15 Sep 2020 20:08:46 +0100 (BST) Received: from idyukov.rnd.samsung.ru (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200915190845eusmtip249048eff4a43c639cebf755579ed606e~1CqAPI-qa1755217552eusmtip2N; Tue, 15 Sep 2020 19:08:45 +0000 (GMT) From: Ivan Dyukov To: dev@dpdk.org, i.dyukov@samsung.com, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, stephen@networkplumber.org, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com Date: Tue, 15 Sep 2020 22:07:19 +0300 Message-Id: <20200915190728.18143-25-i.dyukov@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200915190728.18143-1-i.dyukov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA0WSeUwTeRTH85uZzgxda8Zq5AVXjY0moiuo6+rTdcUrOmaNx8aYeGKREc1y aEe8FhPiQQlWrhKIsGIFCS4Qu2g5Ix78YcHComSJqCgVDwIeSKFRkaqtU+N/n/d53/d7v/zy 42ltFhvE74ndLxli9dE6Vs1U3vrQMiNslD585qOCX9HalE+w63Ehjc6sRyyeenuCwvaSMLxa 9bcKMzsTKUzN7Kew6mIKi6+cxxh846qisKPOwWFu6zEOXfXdHJ5uySPYPdxL4xnLAMGW/AoV frhZy2LfcAGDqUNtBNNsDQTtpn4Gs2qqCSalCPj2n2IOCzsmoMvZwKDj/hUOy9x3aaxo8hDM sFsJNid9Vi2eJA5ZilRi4dUeSjSfv0uLt+5nc6KpMZ8Sy99UU2LftTZWTLWVEPF21ylaLH32 nl2n3qxeGClF7zkgGUIX7VDvtqbnMHszfziU2l9OJ5I+PoUE8CDMAbf5HedjrXCRwECt16u9 PEigM8VGlGKAgKUoj/028aQxl1YaxQTaPdf8KTeBy9d7v6ZYYSo4kvMpX2OMUM5C1fA9b8Hz o4XVYHct8WUYYQr0dKSpfKwRFsDTTrtK2TARSv+9Qfs4wOtba9r895sA984Nfj0ThCYeStuN /oHlUO6uYxQeDb12G6fwj+AwmxhlwEggo/IKpxTpBI7nvfanwsD28j/OdztaCAZrbaiil4Dz 3DOVT4MwEtpfj/Jp2ouZlTm0ojWQnKRV0jq40djq1wCejyMULcKrF5/9j1VHoKyomUsnE3O/ 77IQUkICpXg5JkqSZ8VKB0NkfYwcHxsVsjMu5jLx/lXHJ7urmrhbI+qJwBPdCI3l4Y5wrUp/ QD4cU0+Ap3VjNEubHdu1mkj94SOSIS7cEB8tyfVkHM/oAjU/F/Rs0wpR+v3Sn5K0VzJ861J8 QFAiMVnnh2xcX7Fq7FzXUf6dva6Bf7ll9i/TV8Sf6d8QWmn0rP3Ls/P4b43FF+KCAp/e/n+c advm7AfPIxPSntTAsq2aO13m6caWuee7P4YeGvtYflCTMf6P7qSIlcEHf0rety7CnHDp7OSh hoSEDuPMTZPWOE9G25If/q4LHjy9y5I9ryx4Ma1j5N36WdNog6z/AmwLTvunAwAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWSfUzMcRzHfX9P9+vh7OeE70Jy5nmO60GfksTYfn9kZfwlOke/VdN17X5X Q5tVrLi4krCwijQ9cdJRmaf6w8XVbpXESiWZJZUuLO2KO/Hfe++93u/PZ/t8WFI2QXmzCUl6 QZekTpQz7pR1xtK7IWyeWrXJlhUKppYiBAO9pST0F7xnIOfbaQLeVm6Dx3XXacjvSyfAmD9O QF25gYGv/ZkUjNrrCOh5YpXA1fZMCdibPkvgvO0ags+OLyQUlkwgsBU9oOFX4yMGxhw3KTBO dSLINTcjsJwbp6CgoR5BloGDbxW3JVDa4wP2/mYKrO9qJVD9o42EBy3TCC5YTAhas37T4cv5 qZIymi99PETwF2+0kfyLd5cl/LmXRQRfM1pP8GNPOxneaK5E/KuBHJKvGpxkotz3K0J12hS9 4BuvFfVb5dFK8FMog0HhFxCsUPoHHQzxC5RvDAuNFRITUgXdxrBDinhT3hUqOd/jmHG8hkxH Y6wBubGYC8AfXl4lXVrGlSFszOQNiHX6GA8PkrPIfOx4Y2BmkQmEpw0LXZrh1mDrmSLCgNxZ L66bwR3ZGZQrO5+LwBb7dhdDcSvxUE8u7dJSLgR/7LPQs53LcNW953/73Zx+e0OnZLY/ARdn d/yb5YO7ir8TeWhuCZpTibyEFFETpxH9FKJaI6YkxSmOaDX3kfPgD1/8Mtcjw+jeJsSxSO4p Lek+pJLR6lTxuKYJYZaUe0l3tFpjZNJY9fETgk6r0qUkCmITCnQueIH0XnBE63yfJL1KGagM gmBlkH+Q/2aQL5Ke4RoPyLg4tV44KgjJgu5/jmDdvNOR9v5SW/aStJndjRXmRZ70+js/H474 FHrtC8l5tafPcXJtlHZkyeGOZxnhkevLHFd2rvPdcL4mr3a1Pa19avJudXSMhb60QtBbfcuT PXMXX9zJdbm3PT1timQGlt9KGzIvOGW0RayqPZuX3xa1mR88yXW1bPmUM3Hq9a4Ij7Rrw7h1 r5wS49XKdaROVP8BxUaebwYDAAA= X-CMS-MailID: 20200915190847eucas1p28539b8571d5060f354c0263b96358ce2 X-Msg-Generator: CA X-RootMTR: 20200915190847eucas1p28539b8571d5060f354c0263b96358ce2 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200915190847eucas1p28539b8571d5060f354c0263b96358ce2 References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200915190728.18143-1-i.dyukov@samsung.com> Subject: [dpdk-dev] [PATCH v11 24/24] examples/vm_power_*: new link status print format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: i.dyukov@samsung.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add usage of rte_eth_link_to_str function to example applications Signed-off-by: Ivan Dyukov --- examples/vm_power_manager/main.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/examples/vm_power_manager/main.c b/examples/vm_power_manager/main.c index 273bfec29..37c4a9c50 100644 --- a/examples/vm_power_manager/main.c +++ b/examples/vm_power_manager/main.c @@ -244,6 +244,7 @@ check_all_ports_link_status(uint32_t port_mask) uint16_t portid, count, all_ports_up, print_flag = 0; struct rte_eth_link link; int ret; + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN]; printf("\nChecking link status"); fflush(stdout); @@ -267,15 +268,10 @@ check_all_ports_link_status(uint32_t port_mask) } /* print link status if flag set */ if (print_flag == 1) { - if (link.link_status) - printf("Port %d Link Up - speed %u " - "Mbps - %s\n", (uint16_t)portid, - (unsigned int)link.link_speed, - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ? - ("full-duplex") : ("half-duplex")); - else - printf("Port %d Link Down\n", - (uint16_t)portid); + rte_eth_link_to_str(link_status_text, + sizeof(link_status_text), &link); + printf("Port %d %s\n", portid, + link_status_text); continue; } /* clear all_ports_up flag if any link down */