From patchwork Thu Nov 5 15:33:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dharmik Thakkar X-Patchwork-Id: 83752 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5FFF7A04E7; Thu, 5 Nov 2020 16:33:44 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5D558C866; Thu, 5 Nov 2020 16:33:42 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by dpdk.org (Postfix) with ESMTP id C3637C858 for ; Thu, 5 Nov 2020 16:33:40 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1DCF814BF; Thu, 5 Nov 2020 07:33:39 -0800 (PST) Received: from localhost.localdomain (2p2660v4-1.austin.arm.com [10.118.13.220]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 167573F718; Thu, 5 Nov 2020 07:33:39 -0800 (PST) From: Dharmik Thakkar To: Ruifeng Wang , Bruce Richardson Cc: dev@dpdk.org, nd@arm.com, Dharmik Thakkar Date: Thu, 5 Nov 2020 09:33:15 -0600 Message-Id: <20201105153316.27918-1-dharmik.thakkar@arm.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH 1/2] crypto/armv8: update meson build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" With pkg-config support available within AArch64crypto library, meson option 'armv8_crypto_dir' can be removed. PKG_CONFIG_PATH environment variable should be set appropriately to use the crypto library. Refer [1] for build instructions. [1] https://doc.dpdk.org/guides/cryptodevs/armv8.html Suggested-by: Thomas Monjalon Signed-off-by: Dharmik Thakkar Reviewed-by: Ruifeng Wang Acked-by: Bruce Richardson Acked-by: Ruifeng Wang --- drivers/crypto/armv8/meson.build | 19 ++++--------------- meson_options.txt | 2 -- 2 files changed, 4 insertions(+), 17 deletions(-) diff --git a/drivers/crypto/armv8/meson.build b/drivers/crypto/armv8/meson.build index c445c5bd3dfd..3289a2adcac5 100644 --- a/drivers/crypto/armv8/meson.build +++ b/drivers/crypto/armv8/meson.build @@ -1,24 +1,13 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2019 Arm Limited -path = get_option('armv8_crypto_dir') -if path == '' +dep = dependency('libAArch64crypto', required: false) +if not dep.found() build = false - reason = 'missing dependency, "armv8_crypto"' + reason = 'missing dependency, "libAArch64crypto"' subdir_done() endif -inc_dir = path - -lib = cc.find_library('libAArch64crypto', dirs: [path], required: false) -if not lib.found() - build = false - reason = 'missing dependency, "AArch64crypto"' - subdir_done() -else - ext_deps += lib - includes += include_directories(inc_dir) -endif - +ext_deps += dep deps += ['bus_vdev'] sources = files('rte_armv8_pmd.c', 'rte_armv8_pmd_ops.c') diff --git a/meson_options.txt b/meson_options.txt index 9bf18ab6b1c9..e384e6dbb29e 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -1,7 +1,5 @@ # Please keep these options sorted alphabetically. -option('armv8_crypto_dir', type: 'string', value: '', - description: 'path to the armv8_crypto library installation directory') option('disable_drivers', type: 'string', value: '', description: 'Comma-separated list of drivers to explicitly disable.') option('drivers_install_subdir', type: 'string', value: 'dpdk/pmds-', From patchwork Thu Nov 5 15:33:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dharmik Thakkar X-Patchwork-Id: 83753 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B0B17A04E7; Thu, 5 Nov 2020 16:34:01 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F02E1C8E2; Thu, 5 Nov 2020 16:33:43 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by dpdk.org (Postfix) with ESMTP id CE772C866 for ; Thu, 5 Nov 2020 16:33:40 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 31A171509; Thu, 5 Nov 2020 07:33:39 -0800 (PST) Received: from localhost.localdomain (2p2660v4-1.austin.arm.com [10.118.13.220]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2C7A33F718; Thu, 5 Nov 2020 07:33:39 -0800 (PST) From: Dharmik Thakkar To: Ruifeng Wang Cc: dev@dpdk.org, nd@arm.com, Dharmik Thakkar Date: Thu, 5 Nov 2020 09:33:16 -0600 Message-Id: <20201105153316.27918-2-dharmik.thakkar@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201105153316.27918-1-dharmik.thakkar@arm.com> References: <20201105153316.27918-1-dharmik.thakkar@arm.com> Subject: [dpdk-dev] [PATCH 2/2] doc: update build guide for armv8 crypto PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Remove build steps about using meson option armv8_crypto_dir. Add build steps about using pkg-config. Suggested-by: Thomas Monjalon Signed-off-by: Dharmik Thakkar Reviewed-by: Ruifeng Wang Acked-by: Ruifeng Wang --- doc/guides/cryptodevs/armv8.rst | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/doc/guides/cryptodevs/armv8.rst b/doc/guides/cryptodevs/armv8.rst index f0f30fe0003a..8963f66a206c 100644 --- a/doc/guides/cryptodevs/armv8.rst +++ b/doc/guides/cryptodevs/armv8.rst @@ -37,11 +37,17 @@ To build DPDK with this virtual crypto PMD, the user is required to: make -* Build DPDK with meson option ``-Darmv8_crypto_dir=``: +* Add path to `libAArch64crypto.pc` in `PKG_CONFIG_PATH` environment variable: .. code-block:: console - meson -Darmv8_crypto_dir= build + export PKG_CONFIG_PATH=/pkgconfig/:$PKG_CONFIG_PATH + +* Build DPDK: + +.. code-block:: console + + meson build ninja -C build The corresponding device can be created only if the following features