From patchwork Sat Nov 21 22:54:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Connolly X-Patchwork-Id: 84446 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07AEDA04B5; Sat, 21 Nov 2020 23:54:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 44BD73B5; Sat, 21 Nov 2020 23:54:38 +0100 (CET) Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by dpdk.org (Postfix) with ESMTP id 6E4BC23D for ; Sat, 21 Nov 2020 23:54:36 +0100 (CET) Received: by mail-wm1-f54.google.com with SMTP id x13so5251129wmj.1 for ; Sat, 21 Nov 2020 14:54:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mayadata-io.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=a8y7qw/H1vn2cHLbHaPpnw3ZTH9d2O0WlyBGispIvdI=; b=I0G6Bk+Efmh5mvtigiom9NQA2h3ELfT6HGWVsXilmJjuT2DNt5Q1cTMyeyBiZewbTa UwLyga4n+XgvFohP9yY3K0vBdFzxSFMlwJZVldTrHwaN96Vu1GXfC5d3MfRJbjeqd1/0 qkq5G2xxYdFo0dyqb8vwWnlVxfYCoEjY6YARb+Ec5x/pRryxpS1/dWPD3kN3Ab3NXpw9 tycOw0ZTUOQ48Ly+wmQn63WnU/bXc9nhmHu0Q+03zj/gqMWNcCT3+PdhrjPgCVbj5mrD W5cb1hogFOgYPThojRWEv7UCTLK404jGvrT6hjBBaaAKkCBxlouWbBdhcB0prL+LKFjE Omfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=a8y7qw/H1vn2cHLbHaPpnw3ZTH9d2O0WlyBGispIvdI=; b=Dx1NjjZZwhi8mTGbH22/F6+r+7ds372zh/BA6Z3wk4+HWmfPcIFeaqD2HCSrbc2Pck jNCfku3T39SkVYil642kY0CmGzLJJwbAyX/Domiu0V1u9ctFSayjzw4Q6pbBkwWEJyv8 Lg8iK+cttsC9WdKSybeW+JchGN4HcUg6DCKteqphTdVGgJFxxVom/crPJ0E2tNfUeYdh dsLrQJE20dgkW+WB+lTaeo6mtVY9APbXy/wIkzVKjYujunPULPexAkfh2s0H5ewDJbxL ppZIJhC9aqpMfpbGdyN69AfSxvP3m1k8q2ZwFr6PDDCCsCVcIB1P3NaFgOiTI2sFzBim GLvw== X-Gm-Message-State: AOAM5308kzKYIFjvv3c9T5fS3Bvn1hNiY8Gq4IDnEzg0uCejCZi5I4lA xySrvok3nmozeEj+X/jPBa4oBQ== X-Google-Smtp-Source: ABdhPJz2711ALcGExe8/nhVw3tCxpPWMuu7biLjyhT4I+gDUCxN9/grB9DUOqH0s5SOdRIGB7zLRYw== X-Received: by 2002:a1c:4856:: with SMTP id v83mr16231250wma.88.1605999275066; Sat, 21 Nov 2020 14:54:35 -0800 (PST) Received: from FENIX.localdomain (cpc98320-croy25-2-0-cust77.19-2.cable.virginm.net. [80.235.134.78]) by smtp.gmail.com with ESMTPSA id s25sm8508085wmh.16.2020.11.21.14.54.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Nov 2020 14:54:34 -0800 (PST) From: Nick Connolly To: Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Tal Shnaiderman Cc: dev@dpdk.org, Nick Connolly Date: Sat, 21 Nov 2020 22:54:15 +0000 Message-Id: <20201121225415.25609-1-nick.connolly@mayadata.io> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201120211255.24803-1-nick.connolly@mayadata.io> References: <20201120211255.24803-1-nick.connolly@mayadata.io> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2] eal/windows: fix link error with MinGW X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Linking with the 'pci' driver when building with MinGW on Windows fails with undefined symbol 'GUID_DEVCLASS_NET'. This occurs because devguid.h is included in rte_windows.h before INITGUID is defined. Move the include of devguid.h after the definition of INITGUID. Fixes: b762221ac24f ("bus/pci: support Windows with bifurcated drivers") Cc: talshn@mellanox.com Signed-off-by: Nick Connolly --- v2 * Fix commit message - add blank line, use present tense lib/librte_eal/windows/include/rte_windows.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/windows/include/rte_windows.h b/lib/librte_eal/windows/include/rte_windows.h index 0a5e71a05..b82af34f6 100644 --- a/lib/librte_eal/windows/include/rte_windows.h +++ b/lib/librte_eal/windows/include/rte_windows.h @@ -25,13 +25,13 @@ #include #include #include -#include /* Have GUIDs defined. */ #ifndef INITGUID #define INITGUID #endif #include +#include #include /**