From patchwork Sun Jul 18 05:30:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kalesh A P X-Patchwork-Id: 96010 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5344BA0C43; Sun, 18 Jul 2021 07:10:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CB70240683; Sun, 18 Jul 2021 07:10:03 +0200 (CEST) Received: from relay.smtp-ext.broadcom.com (lpdvsmtp10.broadcom.com [192.19.11.229]) by mails.dpdk.org (Postfix) with ESMTP id 7596D4067B for ; Sun, 18 Jul 2021 07:10:02 +0200 (CEST) Received: from dhcp-10-123-153-22.dhcp.broadcom.net (bgccx-dev-host-lnx2.bec.broadcom.net [10.123.153.22]) by relay.smtp-ext.broadcom.com (Postfix) with ESMTP id C8B4A2E22E; Sat, 17 Jul 2021 22:10:00 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com C8B4A2E22E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1626585001; bh=iDFefAnxn9GE9r4cMFmJUeD5+xim9fAbFnxDeiPJ/I0=; h=From:To:Cc:Subject:Date:From; b=Z/K/3R+nEI5OexpGZkTBsYSvEILrPqndkeEKaPtv8RZOQe+QdQpKIpgrRKSWLxk3F 7kOilM0uQjshU23hb2dzRJdJz7jgQVJoFTUdx2//bYRxZbpts9rty2cH9UTSj6jh28 kZYv56ftUeDGR5sD07BblWr5OaX/ufJ/7R4F2+3U= From: Kalesh A P To: dev@dpdk.org Cc: ajit.khaparde@broadcom.com Date: Sun, 18 Jul 2021 11:00:59 +0530 Message-Id: <20210718053059.16194-1-kalesh-anakkur.purayil@broadcom.com> X-Mailer: git-send-email 2.10.1 Subject: [dpdk-dev] [PATCH] net/bnxt: remove workaround for default VNIC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Kalesh AP On older Wh+ firmware versions, HWRM_FUNC_QCFG returns zero for the parent default vnic. Commit "3fb93bc7c349" added a temporary Wh+-specific workaround in the PMD. This has been fixed in latest firmware and hence removing the workaround. Fixes: 3fb93bc7c349 ("net/bnxt: initialize parent PF information") Cc: stable@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde Reviewed-by: Lance Richardson --- drivers/net/bnxt/bnxt_hwrm.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index e6c46d4..73deb41 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -3390,16 +3390,6 @@ int bnxt_hwrm_parent_pf_qcfg(struct bnxt *bp) bp->parent->fid = rte_le_to_cpu_16(resp->fid); bp->parent->port_id = rte_le_to_cpu_16(resp->port_id); - /* FIXME: Temporary workaround - remove when firmware issue is fixed. */ - if (bp->parent->vnic == 0) { - PMD_DRV_LOG(DEBUG, "parent VNIC unavailable.\n"); - /* Use hard-coded values appropriate for current Wh+ fw. */ - if (bp->parent->fid == 2) - bp->parent->vnic = 0x100; - else - bp->parent->vnic = 1; - } - HWRM_UNLOCK(); return 0;