From patchwork Sun Aug 8 12:51:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 96712 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2AB76A0A0C; Sun, 8 Aug 2021 14:51:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A34404116A; Sun, 8 Aug 2021 14:51:46 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 20E4841168 for ; Sun, 8 Aug 2021 14:51:46 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id C16745C004A; Sun, 8 Aug 2021 08:51:45 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 08 Aug 2021 08:51:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=fm1; bh= 2Yn3H9Qttt1QSyyCn5RkED9/NjlZLf2kK4zUrnmXLHs=; b=s9YoOFNmi7p7+/hE R7dzIr1void+frE91xWnWlJEdu3OqFvGBJD1sVpCXAT7UJ2YI1DzD29+4cOqZQeQ QsUtJjiXJY86KEGfZLgCLjzIdTrkfwb/I9JgXTwVfA4JTfnyRJg2/XiirYoWp7w6 uaTMHjgAOdCKsyPuT35FgEQxhLD+HodoWmhE+wnNvj27q1nOa5TsvYhE1OHH0FTA nv7e4kGUqC9Ios59VWnPEOog3Ns4Jeueh9XiHKfPE0+hM5Eo+dM14ec4G+oKDFdt nwLQEo1PpMWKQBBKpL/2IKMAdmtRxCZrBd5FrcNYBI3K3LXAV/ZZL26Vofbi76Nf RhmJwA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=2Yn3H9Qttt1QSyyCn5RkED9/NjlZLf2kK4zUrnmXL Hs=; b=tv4NEzPBkEmTM28lcbk3jirkA4rT15dGT/Xzqg6i1qH+xmyF/bEd/qDYx k9O595plL0c/rxAy4jDVoBeMXGHJLQdzLIshR/umqFoy5vKDxaE9arUwJnhZ9UN7 rNzfN3FTd09HES1zG2Y5dJxkOdW5MmJ8/McC4k1p4KIQlV0CQ2DnLFXdmcXIDLM8 NsjDgu+dichRe0cA37DqKIx4fgDvjBQ8b2/I9ybmv6KryOmzbwnaS47bQPxLcc2I 8ZK5RF9kBPHk52JiS1VnFW0leIElzRer3Fpym9iyJEeB19INEI1G77nzuu/6kIvl +f5QRM+egQ7JQMI610nm9neuRVB4Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrjeehgdehjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepvedutdevueevjeekveehheevffeugeejudekffeltdelkeeifeeg udehvdegjefhnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 8 Aug 2021 08:51:44 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: bruce.richardson@intel.com, david.marchand@redhat.com, Rasesh Mody , Devendra Singh Rawat Date: Sun, 8 Aug 2021 14:51:34 +0200 Message-Id: <20210808125139.3573701-2-thomas@monjalon.net> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210808125139.3573701-1-thomas@monjalon.net> References: <20210412215339.2439530-1-thomas@monjalon.net> <20210808125139.3573701-1-thomas@monjalon.net> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v3 1/5] net/qede: fix minsize build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Error occurs when configuring meson with --buildtype=minsize with GCC 11.1.0: In function ‘__internal_ram_wr_relaxed’, inlined from ‘internal_ram_wr’ at ecore_int_api.h:166:2, inlined from ‘qede_update_rx_prod.constprop’ at qede_rxtx.c:736:2: drivers/net/qede/base/bcm_osal.h:136:9: error: ‘rx_prods’ is used uninitialized [-Werror=uninitialized] | rte_write32_relaxed((_val), (_reg_addr)) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ecore_int_api.h:151:17: note: in expansion of macro ‘DIRECT_REG_WR_RELAXED’ | DIRECT_REG_WR_RELAXED(p_hwfn, &((u32 OSAL_IOMEM *)addr)[i], | ^~~~~~~~~~~~~~~~~~~~~ drivers/net/qede/qede_rxtx.c: In function ‘qede_update_rx_prod.constprop’: drivers/net/qede/qede_rxtx.c:724:33: note: ‘rx_prods’ declared here | struct eth_rx_prod_data rx_prods = { 0 }; | ^~~~~~~~ Signed-off-by: Thomas Monjalon Signed-off-by: Thomas Monjalon Acked-by: Rasesh Mody --- drivers/net/qede/qede_rxtx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c index 298f4e3e42..35cde561ba 100644 --- a/drivers/net/qede/qede_rxtx.c +++ b/drivers/net/qede/qede_rxtx.c @@ -721,9 +721,10 @@ qede_update_rx_prod(__rte_unused struct qede_dev *edev, { uint16_t bd_prod = ecore_chain_get_prod_idx(&rxq->rx_bd_ring); uint16_t cqe_prod = ecore_chain_get_prod_idx(&rxq->rx_comp_ring); - struct eth_rx_prod_data rx_prods = { 0 }; + struct eth_rx_prod_data rx_prods; /* Update producers */ + memset(&rx_prods, 0, sizeof(rx_prods)); rx_prods.bd_prod = rte_cpu_to_le_16(bd_prod); rx_prods.cqe_prod = rte_cpu_to_le_16(cqe_prod); From patchwork Sun Aug 8 12:51:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 96713 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 12EB4A0A0C; Sun, 8 Aug 2021 14:51:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DEA334116F; Sun, 8 Aug 2021 14:51:49 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 206664067E for ; Sun, 8 Aug 2021 14:51:49 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CA8AD5C004A; Sun, 8 Aug 2021 08:51:47 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 08 Aug 2021 08:51:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=fm1; bh= YAt5pKCMnXFMVMreTHNVztqZCXO5YFVjv8L5Dc78+x4=; b=tMBa2CoX8hkfI0+f wK7BsW91qcANjQMbhDKfYhRXVQiWrrgwHENSZvL7iOMQTvNyesfK30Yad1KHbU2k 94ko+m4TTOAgC8QXqeTSWISznNSIKkaw1KwFaRB8rKCVX1CZ98OZPSYB2e6NeNV4 wGPtQ3i+dh+gBMZQPVB22teD5r1/uyyQpKT/aa2U4FSypNoG4zVURXJZ/PvZiWcT aP2Ik+gXA7Xho+NzJzWucO+iE2q7SooIJLHsOXMCKwqac4EtdRkXZL//ghYlda4D wUx3q9qeur5Z+wPw2up9UcEHzTWRJIe0xDBay33FcYocM5ivV82UMu4WmagF48DL 6KKxdQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=YAt5pKCMnXFMVMreTHNVztqZCXO5YFVjv8L5Dc78+ x4=; b=etkGL5yGEZbU0F+6EXHkVxA15MXvMa/wbEi5xZ+PfblKlRS275j470n21 TMZWFFz06r5MzVXKBDRBoVJaaoa6Ifv5XSGInMqhAC7PRkhnLukRyjhZVhKQfX8f p2+1Ko66UHexnpBt/Zs5ajuDe+srBHQSxLRSVJ3wnhpxucTx4L/sncV4cFD1QcRc zZeRkS4MhuuLtSYw34XPH88fUIFUjTUbeZ3f5r727jv4l8wnMwJrgiPzWnh1T0K+ rQg2K+KKk7AXMkN0LDN1HSRw95Q3iyo6vVUxKGwYSY3sm48IpYkzpWwP2j5sAU4M gSdUEmS+UTacbn3/xZ/g1jar7THog== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrjeehgdehjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepvedutdevueevjeekveehheevffeugeejudekffeltdelkeeifeeg udehvdegjefhnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 8 Aug 2021 08:51:46 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: bruce.richardson@intel.com, david.marchand@redhat.com, Ori Kam Date: Sun, 8 Aug 2021 14:51:35 +0200 Message-Id: <20210808125139.3573701-3-thomas@monjalon.net> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210808125139.3573701-1-thomas@monjalon.net> References: <20210412215339.2439530-1-thomas@monjalon.net> <20210808125139.3573701-1-thomas@monjalon.net> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v3 2/5] regex/mlx5: fix minsize build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Error occurs when configuring meson with --buildtype=minsize with GCC 11.1.0: drivers/regex/mlx5/mlx5_regex_fastpath.c:398:17: error: ‘len’ may be used uninitialized in this function [-Werror=maybe-uninitialized] | complete_umr_wqe(qp, sq, &qp->jobs[mkey_job_id], sq->pi, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | klm_num, len); | ~~~~~~~~~~~~~ drivers/regex/mlx5/mlx5_regex_fastpath.c:315:31: note: ‘len’ was declared here | uint32_t klm_num = 0, len; | ^~~ Signed-off-by: Thomas Monjalon Reviewed-by: Ruifeng Wang --- drivers/regex/mlx5/mlx5_regex_fastpath.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/regex/mlx5/mlx5_regex_fastpath.c b/drivers/regex/mlx5/mlx5_regex_fastpath.c index 786718af53..c79445ce7d 100644 --- a/drivers/regex/mlx5/mlx5_regex_fastpath.c +++ b/drivers/regex/mlx5/mlx5_regex_fastpath.c @@ -312,7 +312,8 @@ prep_regex_umr_wqe_set(struct mlx5_regex_priv *priv, struct mlx5_regex_qp *qp, struct mlx5_regex_job *job = NULL; size_t sqid = sq->sqn, mkey_job_id = 0; size_t left_ops = nb_ops; - uint32_t klm_num = 0, len; + uint32_t klm_num = 0; + uint32_t len = 0; struct mlx5_klm *mkey_klm = NULL; struct mlx5_klm klm; From patchwork Sun Aug 8 12:51:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 96714 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 41F04A0A0C; Sun, 8 Aug 2021 14:52:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A30A41175; Sun, 8 Aug 2021 14:51:51 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id E416641170 for ; Sun, 8 Aug 2021 14:51:49 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 9B86D5C004A; Sun, 8 Aug 2021 08:51:49 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sun, 08 Aug 2021 08:51:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=fm1; bh= w/mDflN0hFOkF3KD+46orSbnww8mwnH0sYjCrO9rMaY=; b=wB9mmbDKRtdUgW/D iYby7TTp17ul02b73FhXIw/wtnfT3mLXGzdSwYrXxJCo7uC/dSun8xl4AuzeszWP mhO7khIHHkh3Ug51TR0O1w5BLFcHgh4gcFWaWVXIWEJ/nD4FGQPo3VhHnmdiEUrk q0Juag3yZJSuuv0hFw8gFWJdAh5HpXwbog8viEgoRFkAyqRkgIUvYjoqgGZ5kkbU MATm0a/f+Smf1yOmdf+EVC4ZvrwE9BtoPWFiPFUlD4ZfOW7jbStCQqZeXxK1aD6w YBuu1V3cUr3jMcLS66h+vVLFbaAs/rVzQ53NYd9yQVHkiQjMs7slYLhPntAxWIyC VEv5tw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=w/mDflN0hFOkF3KD+46orSbnww8mwnH0sYjCrO9rM aY=; b=WOgRDPN2SCFntEx+7uk05TRma+2s/MHipi38wMVJw4HHjKfzE0Xl0riiO uu52Rwz9GfsfWO4Cu293zmnmAXZEXdy1Fo3f+k9xkAOruLGaj0gy006rPS+uvJoi FpSboBRJJgXQxFaL6fQEQIQ9koqtyn76BFCO6h4Xo/6Ns9LnTEVWhhG+3aEtNiBh 43sdXh3rV3d1qUPOgO/B4X6r091DIDTOlsYdRRFgzUSNXTvjPWGaC1bpRYzxoYG2 f2cOE/FkYjFUxu80uonJQHYpH43NtGT92AYivaTDLh178c18A+/RclRc+2Qytk2z Nec4EcephFxaThZlTBugdvFbducyQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrjeehgdehjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepvedutdevueevjeekveehheevffeugeejudekffeltdelkeeifeeg udehvdegjefhnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 8 Aug 2021 08:51:48 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: bruce.richardson@intel.com, david.marchand@redhat.com, Matan Azrad , Viacheslav Ovsiienko Date: Sun, 8 Aug 2021 14:51:36 +0200 Message-Id: <20210808125139.3573701-4-thomas@monjalon.net> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210808125139.3573701-1-thomas@monjalon.net> References: <20210412215339.2439530-1-thomas@monjalon.net> <20210808125139.3573701-1-thomas@monjalon.net> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v3 3/5] vdpa/mlx5: fix minsize build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Error occurs when configuring meson with --buildtype=minsize with GCC 11.1.0: drivers/vdpa/mlx5/mlx5_vdpa_mem.c: In function ‘mlx5_vdpa_mem_register’: drivers/vdpa/mlx5/mlx5_vdpa_mem.c:183:24: error: initialization of ‘uint64_t’ {aka ‘long unsigned int’} from ‘void *’ makes integer from pointer without a cast [-Werror=int-conversion] | uint64_t gcd = NULL; | ^~~~ drivers/vdpa/mlx5/mlx5_vdpa_mem.c:244:75: error: ‘mode’ may be used uninitialized in this function [-Werror=maybe-uninitialized] | klm_size = mode == MLX5_MKC_ACCESS_MODE_KLM ? | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | KLM_SIZE_MAX_ALIGN(empty_region_sz) : gcd; | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~ Signed-off-by: Thomas Monjalon Acked-by: Matan Azrad Reviewed-by: Ruifeng Wang --- drivers/vdpa/mlx5/mlx5_vdpa_mem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_mem.c b/drivers/vdpa/mlx5/mlx5_vdpa_mem.c index a13bde5a0b..59ce4e891c 100644 --- a/drivers/vdpa/mlx5/mlx5_vdpa_mem.c +++ b/drivers/vdpa/mlx5/mlx5_vdpa_mem.c @@ -177,10 +177,10 @@ mlx5_vdpa_mem_register(struct mlx5_vdpa_priv *priv) struct mlx5_devx_mkey_attr mkey_attr; struct mlx5_vdpa_query_mr *entry = NULL; struct rte_vhost_mem_region *reg = NULL; - uint8_t mode; + uint8_t mode = 0; uint32_t entries_num = 0; uint32_t i; - uint64_t gcd; + uint64_t gcd = 0; uint64_t klm_size; uint64_t mem_size; uint64_t k; From patchwork Sun Aug 8 12:51:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 96715 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1ACDAA0A0C; Sun, 8 Aug 2021 14:52:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 21E744117B; Sun, 8 Aug 2021 14:51:53 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 0343E4117A for ; Sun, 8 Aug 2021 14:51:52 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id AF8695C00D8; Sun, 8 Aug 2021 08:51:51 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 08 Aug 2021 08:51:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=fm1; bh= 9Dw8fWRfdmYpJhyWrXjYgr1ARm/vXEYqcLVXe1hCqp0=; b=6B4Rtpp+Mai7Mfyv GMDCVHdmIaJZZtcUd0MOJFuHryrGcAmuXCNEpzCBasEPVPbM4alt5bRm5ReY0R2X d7Pvq2u1Nk/JLm9CvSLii/hLl87k/OsOH8MJhGOiERFzWNr6f1pjnC3sQ+MmsbIH FMTUVSz0D+P1P2n9Os8gaU3S1I9DkgpaY6SFFtudT5UA7GOg4TMNyAQCtDD/eUvn RlQVjOW03KbGgLplgfVFEmLX7x23/mW8eR7Ul9yureToIp9bAKHtuMSdu+2EKCif qhGQMRaoo0hrx9tXuIpXQOv6LVnSDJXEqPdCHxR+m07wP1HU3B2jUjd+WLHpmPvV lvGB0A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=9Dw8fWRfdmYpJhyWrXjYgr1ARm/vXEYqcLVXe1hCq p0=; b=IsQsLsFlInDQyKTlnuVVkw3P79wCl1EvnHe1ngfphYaxFeiPWanduwFzV AYTrO8i7ZDg0jbFOeUli9SoKH3HOAGYt2P3VXqMjSYuPszj+w6s448qm4DEoqxOI TaRpDQTVdnSScFenw7O6ZbUFnA/cXKzjgebOO45cDMLjE8iOQJseRv5Xt4JF5JgL g1jEA+cnKvFspdN5/57wHUqkSCthLCQEuwsuT/1M1PkLGmeyL3l2RMW/XTvoFELN PWVROxPImwLZVenO7DceagLgyZu8Bx4K4EUqmiC5F4xW82fC0Icx4aVRwydJMBTa iTDI65AmHvI9UBwYVsDXhu7WmLpLQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrjeehgdehjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepvedutdevueevjeekveehheevffeugeejudekffeltdelkeeifeeg udehvdegjefhnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 8 Aug 2021 08:51:50 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: bruce.richardson@intel.com, david.marchand@redhat.com, Akhil Goyal , Declan Doherty Date: Sun, 8 Aug 2021 14:51:37 +0200 Message-Id: <20210808125139.3573701-5-thomas@monjalon.net> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210808125139.3573701-1-thomas@monjalon.net> References: <20210412215339.2439530-1-thomas@monjalon.net> <20210808125139.3573701-1-thomas@monjalon.net> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v3 4/5] test/crypto: fix minsize build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Error occurs when configuring meson with --buildtype=minsize with GCC 11.1.0: app/test/test_cryptodev_blockcipher.c:1133:45: error: ‘blk_tcs’ may be used uninitialized in this function [-Werror=maybe-uninitialized] | const struct blockcipher_test_case *blk_tcs; | ^~~~~~~ Signed-off-by: Thomas Monjalon Reviewed-by: Ruifeng Wang --- app/test/test_cryptodev_blockcipher.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_cryptodev_blockcipher.c b/app/test/test_cryptodev_blockcipher.c index 53fd4718af..0d5082887e 100644 --- a/app/test/test_cryptodev_blockcipher.c +++ b/app/test/test_cryptodev_blockcipher.c @@ -1184,7 +1184,7 @@ build_blockcipher_test_suite(enum blockcipher_test_type test_type) ts_setup = authonly_setup; break; default: - break; + return NULL; } ts = calloc(1, sizeof(struct unit_test_suite) + From patchwork Sun Aug 8 12:51:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 96716 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 705C9A0A0C; Sun, 8 Aug 2021 14:52:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4761941174; Sun, 8 Aug 2021 14:51:55 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id C6C774117E for ; Sun, 8 Aug 2021 14:51:53 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 7E7405C00D8; Sun, 8 Aug 2021 08:51:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sun, 08 Aug 2021 08:51:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm1; bh=oMpwMIIkQeAkX oQGL2zpp6Ef+GLmB1ae5ewAamYSTJo=; b=IxcLpO0LqX8mZ86q+etjLQwcB2fzO 7/HFKHbT6rZd1is9kKLDG1+58Rp6RIDywb2Lsq9V3eoG8ga6GRuiMZA27O3tMzms 9+p+B9CMzcPCZxoTCuDvYDvDcTGN9HdI9oNuRMiy0/UXEmWisRQfHNDaX+7cANpV p81n2LbMnAxTRCEsJDwqHJYdQE3zGFS6kl5vYSmCdDRr8b4aZpje/XlX7/o6kaGV IjCC+bMAlEmEx52ZQLanrZTH4shquYaQfA18yQaUGgXsId7NtPS0v89eGAylDcCD fskqE76cWiziypjCl9jomY3uuBQk9IIc+ZVB53lTPbvirDrp2BZnpfCKw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=oMpwMIIkQeAkXoQGL2zpp6Ef+GLmB1ae5ewAamYSTJo=; b=qwDQ8leM lrhc5SinqxjI3+6pk+o0RBwI8aYKfnCOWj+qWDGgPEVsGUJkfKyHAZ/7DeBMyRVe N7fD71tBu2x+vCU1hJeDFCdahEk6bhsEhFdFTLK+ClViSF55bY0DOwVjo7zB6Bjq fs9eof86/AWCMZWeQVTBE0sUtfxb/dBGDSmIr1vQgl83Qpoy2GJN8rQxvUELC2fe q3VJ0y2dxMTxXr4K2zd3k7ZryvaPZBtqg9Onvtb/VatR7IvoMRjfsQL1mompCL7x BeBYl1bGY8YWvyRSMKFCQTcwtuh+OM78ei1goLishvzGQaNfFRCgdPqwOe6yfKYF chOpk9A1RXkZmA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrjeehgdehjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedvhefgiedvjeegtdevheefhfetleefgfeivefgffevfeejgedtgfeu tdehtdegveenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 8 Aug 2021 08:51:52 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: bruce.richardson@intel.com, david.marchand@redhat.com, Andrew Rybchenko Date: Sun, 8 Aug 2021 14:51:38 +0200 Message-Id: <20210808125139.3573701-6-thomas@monjalon.net> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210808125139.3573701-1-thomas@monjalon.net> References: <20210412215339.2439530-1-thomas@monjalon.net> <20210808125139.3573701-1-thomas@monjalon.net> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v3 5/5] devtools: test different build types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" All builds were of type debugoptimized. It is kept only for builds having an ABI check. Others will have the default build type (release), except if specified differently as in the x86 generic build which will be a test of the non-optimized debug build type. Some static builds will test the minsize build type. Signed-off-by: Thomas Monjalon Acked-by: Andrew Rybchenko --- This patch cannot be merged now because it makes clang 11.1.0 crashing. --- devtools/test-meson-builds.sh | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh index 9ec8e2bc7e..7bd305a669 100755 --- a/devtools/test-meson-builds.sh +++ b/devtools/test-meson-builds.sh @@ -92,13 +92,16 @@ load_env () # command -v $targetcc >/dev/null 2>&1 || return 1 } -config () # +config () # { dir=$1 shift builddir=$1 shift + abicheck=$1 + shift if [ -f "$builddir/build.ninja" ] ; then + [ $abicheck = ABI ] || return 0 # for existing environments, switch to debugoptimized if unset # so that ABI checks can run if ! $MESON configure $builddir | @@ -114,7 +117,9 @@ config () # else options="$options -Dexamples=l3fwd" # save disk space fi - options="$options --buildtype=debugoptimized" + if [ $abicheck = ABI ] ; then + options="$options --buildtype=debugoptimized" + fi for option in $DPDK_MESON_OPTIONS ; do options="$options -D$option" done @@ -165,7 +170,7 @@ build () # [meson options] cross= fi load_env $targetcc || return 0 - config $srcdir $builds_dir/$targetdir $cross --werror $* + config $srcdir $builds_dir/$targetdir $abicheck $cross --werror $* compile $builds_dir/$targetdir if [ -n "$DPDK_ABI_REF_VERSION" -a "$abicheck" = ABI ] ; then abirefdir=${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION @@ -179,7 +184,7 @@ build () # [meson options] fi rm -rf $abirefdir/build - config $abirefdir/src $abirefdir/build $cross \ + config $abirefdir/src $abirefdir/build $abicheck $cross \ -Dexamples= $* compile $abirefdir/build install_target $abirefdir/build $abirefdir/$targetdir @@ -211,11 +216,13 @@ for c in gcc clang ; do for s in static shared ; do if [ $s = shared ] ; then abicheck=ABI + buildtype= else abicheck=skipABI # save time and disk space + buildtype='--buildtype=minsize' fi export CC="$CCACHE $c" - build build-$c-$s $c $abicheck --default-library=$s + build build-$c-$s $c $abicheck $buildtype --default-library=$s unset CC done done @@ -227,7 +234,7 @@ generic_isa='nehalem' if ! check_cc_flags "-march=$generic_isa" ; then generic_isa='corei7' fi -build build-x86-generic cc skipABI -Dcheck_includes=true \ +build build-x86-generic cc skipABI --buildtype=debug -Dcheck_includes=true \ -Dlibdir=lib -Dcpu_instruction_set=$generic_isa $use_shared # 32-bit with default compiler