From patchwork Tue Oct 16 13:16:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerin Jacob X-Patchwork-Id: 46894 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 197CC7CB0; Tue, 16 Oct 2018 15:16:48 +0200 (CEST) Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0056.outbound.protection.outlook.com [104.47.33.56]) by dpdk.org (Postfix) with ESMTP id E39175F72; Tue, 16 Oct 2018 15:16:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2rx9tYlnbbtYbz5Dq4+0Qkvch3tFy6rWG7cP842Tc0Y=; b=Kq80kGfuJmkkZJmjJICHamfybygKcxrGQOfTmMSmrmHUqY78oQeFzIhXXN95RVQxpuua5ipLdPrXMbqLmrsYy3Qx7LSpzKYj4uiNDg8SSoLMYfZz6Ky2qFQsZhvMbvc7BQRYB7V5UhEowbqvC7dNEtg1XLhDqVi/0ztUro6Z9i4= Received: from BYAPR07MB4997.namprd07.prod.outlook.com (52.135.238.214) by BYAPR07MB4949.namprd07.prod.outlook.com (52.135.238.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1228.24; Tue, 16 Oct 2018 13:16:43 +0000 Received: from BYAPR07MB4997.namprd07.prod.outlook.com ([fe80::c5c:4d86:b353:175a]) by BYAPR07MB4997.namprd07.prod.outlook.com ([fe80::c5c:4d86:b353:175a%4]) with mapi id 15.20.1228.027; Tue, 16 Oct 2018 13:16:43 +0000 From: Jerin Jacob To: John McNamara , Marko Kovacevic CC: "dev@dpdk.org" , "thomas@monjalon.net" , "ferruh.yigit@intel.com" , "arybchenko@solarflare.com" , "olivier.matz@6wind.com" , "Jacob, Jerin" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] doc: clarify VLAN and QinQ Tx offload prerequisite Thread-Index: AQHUZVJ7KhmFTFcPYE6OxrJm6WtcXA== Date: Tue, 16 Oct 2018 13:16:43 +0000 Message-ID: <20181016131548.13733-1-jerin.jacob@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [202.83.56.73] x-clientproxiedby: MAXPR01CA0076.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:49::18) To BYAPR07MB4997.namprd07.prod.outlook.com (2603:10b6:a03:5b::22) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BYAPR07MB4949; 6:lh82fBTY1R0zjUpswGDUeJxma+6+9BQUdSyUjJswT0WeQRBajm5One7eSkLVE2bj8ycf44AbnegCjEuW9ib8c8W6URGwRrUlSxKx8jA+6GnGYHvqCJq1xWWNblEm1GvWCha0tAvW2AEzjHfFcgG4hIBB3zSDOtqqtkRBLYBJVQycN0r/9nxGu2fUEJG5KEpp8Shjfec5syw8KLvthne+iAijgeyW512dcsIUldfC/wSHnGOjV0ye16F3SpA1qodu2nzLDaY0jCOdbOVphXZKzzBqhEcfWY+SWZmc5nnrdLWWmzGBZUm2M/YBGZdgctW9YkT9T0sqeWIxZsIuJR1h+DTyT1koIChtgEFqfbX/Z7lS/XbHs04mzfRc1yRDRm3+Aq1o28ZDbmbBB8IuL39v+SMsqS22FtIOQnM1j0CyI8furxODECo896pRm31bzk9l/7e77xu9g+fRxToHTvLSww==; 5:nONdNIvCsrnfo15VYs16ai3XwxNGmLP2lFCeUu02xWmdcC9qCI6UMlbM08BCjN6etRP9j5asofkXeyitoiq7adPCqofjV1WPjmot213iMv9A7QM83lyyNmRfOwfKuIxlYl/3FnTUtpzAASF2uMCj3f0+PWSiHLk3z+I3xrVP/d0=; 7:goYXs7kDTlFiPJT1oO2b0TUub7NDaXngohN2tzAPR686mA1KUiePQwVIIYSnsHPMMnYOuJ5Sx+C4/n7QMiv61PJJqTdSrhcV6A2GWcu7z6pm9KY3Z9XMOH4owd+HM5igjqK2EMIsbpfEyihF7UCc1S+t6wKHgI91GYX3lIzonTVDECJzzgJNVxeamS6o2lkKfi65bP9xULMzm6MkfNYq+zwZSM4x2oNTBfaDTciBRHNJT2NJzdwXNP2JXP6Bx/vG x-ms-office365-filtering-correlation-id: 23da79c6-825d-4574-b14b-08d633699db0 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BYAPR07MB4949; x-ms-traffictypediagnostic: BYAPR07MB4949: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(10201501046)(3231355)(944501410)(52105095)(3002001)(149066)(150057)(6041310)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991067); SRVR:BYAPR07MB4949; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB4949; x-forefront-prvs: 0827D7ACB9 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(136003)(39860400002)(346002)(396003)(366004)(189003)(199004)(6512007)(97736004)(53936002)(52116002)(6486002)(72206003)(5250100002)(54906003)(316002)(14454004)(2906002)(110136005)(6436002)(99286004)(8936002)(8676002)(66066001)(81166006)(81156014)(1076002)(256004)(105586002)(14444005)(68736007)(36756003)(3846002)(5660300001)(106356001)(2616005)(476003)(25786009)(42882007)(486006)(6116002)(6506007)(71190400001)(102836004)(71200400001)(2900100001)(4326008)(386003)(186003)(26005)(7736002)(478600001)(1857600001)(305945005); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB4949; H:BYAPR07MB4997.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: HjRuPpQfiLiL5Fa9r0ReWG9TEQ7Enze7ai9tcKF/OmatNrAgFUOtGyv3yybn+njaf9G10ghYSLK1W6IjMIIp8GFLjjCFOe9UTj4oT9scz8DH+pgv1BPhi7jF16vc4k/5ii0JgGSCRl12Cr//Wg7qd1Jbxp3XOmw99ZX1nrsZ7ljxNKRNFTLeGngwJyiSzC2Sf1YGlhoR2tQZCtgqZmlLjwIAzi5QznOSs7vrthOkHnvDYQheuFYtABX8YAXkWwcI+HozOkN1qyHQ8vtTCMYvtnwSxTLo6DFt0qBRJ94urOtpEpJV1jQIrHw6N7vb5pMbBFfw73VgazXX4AprJz114IjfjkDTe2fGH4Z6eFGrFmY= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23da79c6-825d-4574-b14b-08d633699db0 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Oct 2018 13:16:43.5723 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB4949 Subject: [dpdk-dev] [PATCH] doc: clarify VLAN and QinQ Tx offload prerequisite X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" - Fix missing PKT_TX_VLAN mbuf.ol_flag and mbuf.vlan_tci fields for Tx VLAN INSERT offload. - Fix missing mbuf.vlan_tci_outer field for Tx QINQ INSERT offload. - Rename deprecated PKT_TX_QINQ_PKT to PKT_TX_QINQ Fixes: cba7f53b717d ("ethdev: introduce Tx queue offloads API") Cc: stable@dpdk.org Signed-off-by: Jerin Jacob Reviewed-by: Ferruh Yigit --- doc/guides/nics/features.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst index a9604c1e1..3fa5cb745 100644 --- a/doc/guides/nics/features.rst +++ b/doc/guides/nics/features.rst @@ -527,6 +527,7 @@ Supports VLAN offload to hardware. * **[uses] rte_eth_rxconf,rte_eth_rxmode**: ``offloads:DEV_RX_OFFLOAD_VLAN_STRIP,DEV_RX_OFFLOAD_VLAN_FILTER,DEV_RX_OFFLOAD_VLAN_EXTEND``. * **[uses] rte_eth_txconf,rte_eth_txmode**: ``offloads:DEV_TX_OFFLOAD_VLAN_INSERT``. +* **[uses] mbuf**: ``mbuf.ol_flags:PKT_TX_VLAN``, ``mbuf.vlan_tci``. * **[implements] eth_dev_ops**: ``vlan_offload_set``. * **[provides] mbuf**: ``mbuf.ol_flags:PKT_RX_VLAN_STRIPPED``, ``mbuf.ol_flags:PKT_RX_VLAN`` ``mbuf.vlan_tci``. * **[provides] rte_eth_dev_info**: ``rx_offload_capa,rx_queue_offload_capa:DEV_RX_OFFLOAD_VLAN_STRIP``, @@ -544,7 +545,7 @@ Supports QinQ (queue in queue) offload. * **[uses] rte_eth_rxconf,rte_eth_rxmode**: ``offloads:DEV_RX_OFFLOAD_QINQ_STRIP``. * **[uses] rte_eth_txconf,rte_eth_txmode**: ``offloads:DEV_TX_OFFLOAD_QINQ_INSERT``. -* **[uses] mbuf**: ``mbuf.ol_flags:PKT_TX_QINQ_PKT``. +* **[uses] mbuf**: ``mbuf.ol_flags:PKT_TX_QINQ``, ``mbuf.vlan_tci_outer``. * **[provides] mbuf**: ``mbuf.ol_flags:PKT_RX_QINQ_STRIPPED``, ``mbuf.ol_flags:PKT_RX_QINQ``, ``mbuf.ol_flags:PKT_RX_VLAN_STRIPPED``, ``mbuf.ol_flags:PKT_RX_VLAN`` ``mbuf.vlan_tci``, ``mbuf.vlan_tci_outer``.