From patchwork Wed Oct 17 05:30:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerin Jacob X-Patchwork-Id: 46941 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 156F75A44; Wed, 17 Oct 2018 07:30:32 +0200 (CEST) Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0047.outbound.protection.outlook.com [104.47.34.47]) by dpdk.org (Postfix) with ESMTP id A7D675587 for ; Wed, 17 Oct 2018 07:30:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1sT+JowvHf5kmyY9wSKMhwL04HZjW5a8ZNIZ1cKK92w=; b=WROPYfXijT7z75xWIZ5hedMt3G5zeuIDsYZCG48qSoqmJDK5gWrnH1uFns7l2d/jkdAfPlVnIKiFKJVa4yWIUg3OJ7Mxy+V15s8InBOQGOk4HAGd0Kc6kjsOkjeAipOVFxxBntWqM9vCWUTtl9y/pzuhomIMy6Qp0LLXlTIDTsk= Received: from BYAPR07MB4997.namprd07.prod.outlook.com (52.135.238.214) by BYAPR07MB4326.namprd07.prod.outlook.com (52.135.223.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1250.20; Wed, 17 Oct 2018 05:30:29 +0000 Received: from BYAPR07MB4997.namprd07.prod.outlook.com ([fe80::c5c:4d86:b353:175a]) by BYAPR07MB4997.namprd07.prod.outlook.com ([fe80::c5c:4d86:b353:175a%4]) with mapi id 15.20.1228.027; Wed, 17 Oct 2018 05:30:29 +0000 From: Jerin Jacob To: "dev@dpdk.org" CC: "thomas@monjalon.net" , "ferruh.yigit@intel.com" , "jia.guo@intel.com" , "Jacob, Jerin" , "Bhagavatula, Pavan" Thread-Topic: [dpdk-dev] [PATCH] vfio: fix missing header inclusion Thread-Index: AQHUZdqDEpeVKQ1QgEO0upjUnqmwYw== Date: Wed, 17 Oct 2018 05:30:28 +0000 Message-ID: <20181017052950.29078-1-jerin.jacob@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.3] x-clientproxiedby: BM1PR0101CA0018.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:18::28) To BYAPR07MB4997.namprd07.prod.outlook.com (2603:10b6:a03:5b::22) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BYAPR07MB4326; 6:rTQ+C+XSyUi2Vvmoz+Go6crNf131xmWIW9rY2cqNMqwI+s2f6OVx5wja60NHu+DZyFy92PsmZzKb8sW+mMkSYIgBRlwKrEr31/uvF8qRiBn3EuxPWOqcqaho4s0CH5aa9/zJmu2tseGpKNzZKK8n7q+G/6WrcRr8aXq/cYnuTh/Z8hKzFHqIijOPCepLg/wyUsPnEKmNTruYNnhTHNApmWdPMY56OtCYanNgqKH8INdgyYdtKnvjarbO42FlFOgvsy/NK9msNSXtYGCxkyxr2i85pswCjbjNK7D9123Ft/Lvj8L+Chu9r3GtW9tECN1Ln60/16InU/qZAghcpeJKjLUOYZOUjmmVuZvlrwe7FxdKJ12MsjmN6RgA7F9FGIOP/bSl4RAlktXnX6Pap1R9Um2KykVXCIvT8hU8lGRNrCRpcVGe0hYxVvw3NIZod8rIdOxy/nGwCZzHk9IlbRHWNQ==; 5:BT7xtUVhuXATwhZkUz2PbmXqNcd8Q1nlxWlPAY/pAnQs7wZNWYc7e4mCd0DzeIHBkAGRz/JyV/ZIwdRFr77lUevS5pRQsNl+bkqOkz6vX8uS/rnT1Qzc0haHBDW3YH/hbMJnRE89/DS08uZgG4LetJFbLdwb+aub8KsBPJ5jmMg=; 7:8om/9UQbcAk04U0cHP4YVF+QS5WY9qbZw5kOncaMzZPV8eg9VO526U47okl/2qI7Nxf6TvbOHiRCv3dtI4x/53rl0s/pqXmx3qb90AKFJSe3Cb++WwFjdj1y3Xyty1uVblifR+NIKXfROaY9vDSonEAn/O/Lnr8sM7H7ZOGNukLyb8lK45Y0Vwngh/xIlSK9e9sUAXvtHIUtTLqN2KZ/i9XilvzzX32Y4jMPMpk+YYneRQRLlthvYkz39Cd7/MyA x-ms-office365-filtering-correlation-id: 5aa7f8c5-9ed4-4393-452b-08d633f1a595 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:BYAPR07MB4326; x-ms-traffictypediagnostic: BYAPR07MB4326: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(10201501046)(3002001)(3231355)(944501410)(52105095)(149066)(150057)(6041310)(20161123560045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(201708071742011)(7699051)(76991091); SRVR:BYAPR07MB4326; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB4326; x-forefront-prvs: 08286A0BE2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(136003)(376002)(366004)(346002)(39860400002)(199004)(189003)(3846002)(6506007)(386003)(6116002)(1076002)(97736004)(2906002)(55236004)(102836004)(2501003)(66066001)(5250100002)(52116002)(4326008)(2900100001)(25786009)(36756003)(99286004)(14454004)(5660300001)(68736007)(54906003)(316002)(106356001)(71190400001)(478600001)(486006)(1857600001)(72206003)(71200400001)(105586002)(6486002)(186003)(256004)(6916009)(26005)(5640700003)(476003)(53936002)(42882007)(81156014)(7736002)(81166006)(305945005)(6436002)(6512007)(8676002)(1730700003)(107886003)(2616005)(8936002)(2351001); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB4326; H:BYAPR07MB4997.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: NpuL1+arpV/WwRMbqwNAcxD5Gn3v9YgkSNnHD03rhsmDCso2PexiaCs1FdRosMGQNWAtr+OOKMNsljj3XVZSlxJMM2daMIVpBTCOGqu6Ogxlzk2BDHwK4fQS5fq2ZTRbezv5TvgnvgKR62X/XKpRN9Xxpxwe77X6Z7vf27uT5Gm/gdOsTAxMBpff+h0Gj1FmjhGvefjX0vMl87KKxCmaFgHGLU5grhANvFVei6eXNO3SLaj53W/vAf1RGculwimapAQnshOrRolDmEnelLgfN9z762SR5HzaMi32sdt65gUnP8LVOUOGkYzf4OTJrx++yMKXxUnZDR6L/CV3/a31Jw42Kfug7AMu6QpCabg7THA= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5aa7f8c5-9ed4-4393-452b-08d633f1a595 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2018 05:30:28.9671 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB4326 Subject: [dpdk-dev] [PATCH] vfio: fix missing header inclusion X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The following change set introduces HAVE_VFIO_DEV_REQ_INTERFACE and used in the below files. drivers/bus/pci/linux/pci_vfio.c drivers/bus/pci/pci_common.c lib/librte_eal/linuxapp/eal/eal_interrupts.c However, Except the first file, the change missed to include where HAVE_VFIO_DEV_REQ_INTERFACE defined. This creates runtime following error on vfio-pci mode and kernel >= 4.0.0 combination. EAL: [rte_intr_enable] Unknown handle type of fd 95 EAL: [pci_vfio_enable_notifier]Fail to enable req notifier. EAL: Fail to unregister req notifier handler. EAL: Error setting up notifier! EAL: Requested device 0000:07:00.1 cannot be used Fixes: cda94419964f ("vfio: fix build with Linux < 4.0") Signed-off-by: Jerin Jacob Signed-off-by: Pavan Nikhilesh --- drivers/bus/pci/pci_common.c | 1 + lib/librte_eal/linuxapp/eal/eal_interrupts.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c index 4b3749a9a..c0238d444 100644 --- a/drivers/bus/pci/pci_common.c +++ b/drivers/bus/pci/pci_common.c @@ -23,6 +23,7 @@ #include #include #include +#include #include "private.h" diff --git a/lib/librte_eal/linuxapp/eal/eal_interrupts.c b/lib/librte_eal/linuxapp/eal/eal_interrupts.c index 767b50880..39252a887 100644 --- a/lib/librte_eal/linuxapp/eal/eal_interrupts.c +++ b/lib/librte_eal/linuxapp/eal/eal_interrupts.c @@ -33,6 +33,7 @@ #include #include #include +#include #include "eal_private.h" #include "eal_vfio.h"