From patchwork Sat Oct 27 10:40:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiaolong Ye X-Patchwork-Id: 47522 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2106C4C8C; Sat, 27 Oct 2018 12:41:08 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 711CE10A3; Sat, 27 Oct 2018 12:41:06 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Oct 2018 03:41:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,431,1534834800"; d="scan'208";a="81343900" Received: from yexl-server.sh.intel.com ([10.67.110.207]) by fmsmga007.fm.intel.com with ESMTP; 27 Oct 2018 03:40:53 -0700 From: Xiaolong Ye To: Qi Zhang , Beilei Xing Cc: dev@dpdk.org, stable@dpdk.org, Xiaolong Ye , tomaszx.kulasek@intel.com Date: Sat, 27 Oct 2018 18:40:25 +0800 Message-Id: <20181027104032.10251-2-xiaolong.ye@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181027104032.10251-1-xiaolong.ye@intel.com> References: <20181027104032.10251-1-xiaolong.ye@intel.com> Subject: [dpdk-dev] [PATCH 1/8] net/ixgbe: correct offload not supported mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Previously IXGBE_TX_OFFLOAD_NOTSUP_MASK is obtained via xor which would lead to unexpected result, correct it by using a NOT-AND operation. Fixes: 7829b8d52be0 ("net/ixgbe: add Tx preparation") Cc: tomaszx.kulasek@intel.com Cc: stable@dpdk.org Signed-off-by: Xiaolong Ye --- drivers/net/ixgbe/ixgbe_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c index 2f0262ae1..a486ff4bd 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx.c +++ b/drivers/net/ixgbe/ixgbe_rxtx.c @@ -72,7 +72,7 @@ IXGBE_TX_IEEE1588_TMST) #define IXGBE_TX_OFFLOAD_NOTSUP_MASK \ - (PKT_TX_OFFLOAD_MASK ^ IXGBE_TX_OFFLOAD_MASK) + ~(PKT_TX_OFFLOAD_MASK & IXGBE_TX_OFFLOAD_MASK) #if 1 #define RTE_PMD_USE_PREFETCH From patchwork Sat Oct 27 10:40:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiaolong Ye X-Patchwork-Id: 47524 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DFFA9532C; Sat, 27 Oct 2018 12:41:15 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 7886E2D13; Sat, 27 Oct 2018 12:41:07 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Oct 2018 03:41:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,431,1534834800"; d="scan'208";a="81343907" Received: from yexl-server.sh.intel.com ([10.67.110.207]) by fmsmga007.fm.intel.com with ESMTP; 27 Oct 2018 03:40:56 -0700 From: Xiaolong Ye To: Qi Zhang , Beilei Xing Cc: dev@dpdk.org, stable@dpdk.org, Xiaolong Ye , wenzhuo.lu@intel.com Date: Sat, 27 Oct 2018 18:40:26 +0800 Message-Id: <20181027104032.10251-3-xiaolong.ye@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181027104032.10251-1-xiaolong.ye@intel.com> References: <20181027104032.10251-1-xiaolong.ye@intel.com> Subject: [dpdk-dev] [PATCH 2/8] net/avf: correct offload not supported mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Previously AVF_TX_OFFLOAD_NOTSUP_MASK is obtained via xor which would lead to unexpected result, correct it by using a NOT-AND operation. Fixes: a2b29a7733ef ("net/avf: enable basic Rx Tx") Cc: wenzhuo.lu@intel.com Cc: stable@dpdk.org Signed-off-by: Xiaolong Ye --- drivers/net/avf/avf_rxtx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/avf/avf_rxtx.h b/drivers/net/avf/avf_rxtx.h index 898d2f387..5583b68be 100644 --- a/drivers/net/avf/avf_rxtx.h +++ b/drivers/net/avf/avf_rxtx.h @@ -49,7 +49,7 @@ PKT_TX_TCP_SEG) #define AVF_TX_OFFLOAD_NOTSUP_MASK \ - (PKT_TX_OFFLOAD_MASK ^ AVF_TX_OFFLOAD_MASK) + ~(PKT_TX_OFFLOAD_MASK & AVF_TX_OFFLOAD_MASK) /* HW desc structure, both 16-byte and 32-byte types are supported */ #ifdef RTE_LIBRTE_AVF_16BYTE_RX_DESC From patchwork Sat Oct 27 10:40:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiaolong Ye X-Patchwork-Id: 47525 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1775C54AE; Sat, 27 Oct 2018 12:41:18 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 302014C94; Sat, 27 Oct 2018 12:41:08 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Oct 2018 03:41:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,431,1534834800"; d="scan'208";a="81343913" Received: from yexl-server.sh.intel.com ([10.67.110.207]) by fmsmga007.fm.intel.com with ESMTP; 27 Oct 2018 03:40:58 -0700 From: Xiaolong Ye To: Qi Zhang , Beilei Xing Cc: dev@dpdk.org, stable@dpdk.org, Xiaolong Ye , konstantin.ananyev@intel.com Date: Sat, 27 Oct 2018 18:40:27 +0800 Message-Id: <20181027104032.10251-4-xiaolong.ye@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181027104032.10251-1-xiaolong.ye@intel.com> References: <20181027104032.10251-1-xiaolong.ye@intel.com> Subject: [dpdk-dev] [PATCH 3/8] net/ena: correct offload not supported mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Previously ENA_TX_OFFLOAD_NOTSUP_MASK is obtained via xor which would lead to unexpected result, correct it by using a NOT-AND operation. Fixes: b3fc5a1ae10d ("net/ena: add Tx preparation") Cc: konstantin.ananyev@intel.com Cc: stable@dpdk.org Signed-off-by: Xiaolong Ye --- drivers/net/ena/ena_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 0c0ed9302..47250b168 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -193,7 +193,7 @@ static const struct ena_stats ena_stats_ena_com_strings[] = { PKT_TX_TCP_SEG) #define ENA_TX_OFFLOAD_NOTSUP_MASK \ - (PKT_TX_OFFLOAD_MASK ^ ENA_TX_OFFLOAD_MASK) + ~(PKT_TX_OFFLOAD_MASK & ENA_TX_OFFLOAD_MASK) int ena_logtype_init; int ena_logtype_driver; From patchwork Sat Oct 27 10:40:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiaolong Ye X-Patchwork-Id: 47526 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7069C5911; Sat, 27 Oct 2018 12:41:20 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 6803110A3; Sat, 27 Oct 2018 12:41:08 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Oct 2018 03:41:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,431,1534834800"; d="scan'208";a="81343924" Received: from yexl-server.sh.intel.com ([10.67.110.207]) by fmsmga007.fm.intel.com with ESMTP; 27 Oct 2018 03:41:00 -0700 From: Xiaolong Ye To: Qi Zhang , Beilei Xing Cc: dev@dpdk.org, stable@dpdk.org, Xiaolong Ye , pavel.belous@aquantia.com Date: Sat, 27 Oct 2018 18:40:28 +0800 Message-Id: <20181027104032.10251-5-xiaolong.ye@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181027104032.10251-1-xiaolong.ye@intel.com> References: <20181027104032.10251-1-xiaolong.ye@intel.com> Subject: [dpdk-dev] [PATCH 4/8] net/atlantic: correct offload not supported mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Previously ATL_TX_OFFLOAD_NOTSUP_MASK is obtained via xor which would lead to unexpected result, correct it by using a NOT-AND operation. Fixes: 2b1472d7150c ("net/atlantic: implement Tx path") Cc: pavel.belous@aquantia.com Cc: stable@dpdk.org Signed-off-by: Xiaolong Ye --- drivers/net/atlantic/atl_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/atlantic/atl_rxtx.c b/drivers/net/atlantic/atl_rxtx.c index fd909476c..7a4eaf191 100644 --- a/drivers/net/atlantic/atl_rxtx.c +++ b/drivers/net/atlantic/atl_rxtx.c @@ -26,7 +26,7 @@ PKT_TX_TCP_SEG) #define ATL_TX_OFFLOAD_NOTSUP_MASK \ - (PKT_TX_OFFLOAD_MASK ^ ATL_TX_OFFLOAD_MASK) + ~(PKT_TX_OFFLOAD_MASK & ATL_TX_OFFLOAD_MASK) /** * Structure associated with each descriptor of the RX ring of a RX queue. From patchwork Sat Oct 27 10:40:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiaolong Ye X-Patchwork-Id: 47527 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E8FD15A4A; Sat, 27 Oct 2018 12:41:22 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id DFAFC4CA5; Sat, 27 Oct 2018 12:41:08 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Oct 2018 03:41:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,431,1534834800"; d="scan'208";a="81343936" Received: from yexl-server.sh.intel.com ([10.67.110.207]) by fmsmga007.fm.intel.com with ESMTP; 27 Oct 2018 03:41:03 -0700 From: Xiaolong Ye To: Qi Zhang , Beilei Xing Cc: dev@dpdk.org, stable@dpdk.org, Xiaolong Ye , tomaszx.kulasek@intel.com Date: Sat, 27 Oct 2018 18:40:29 +0800 Message-Id: <20181027104032.10251-6-xiaolong.ye@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181027104032.10251-1-xiaolong.ye@intel.com> References: <20181027104032.10251-1-xiaolong.ye@intel.com> Subject: [dpdk-dev] [PATCH 5/8] net/fm10k: correct offload not supported mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Previously XXX_TX_OFFLOAD_NOTSUP_MASK is obtained via xor which would lead to unexpected result, correct it by using a NOT-AND operation. Fixes: 9b134aa39716 ("net/fm10k: add Tx preparation") Cc: tomaszx.kulasek@intel.com Cc: stable@dpdk.org Signed-off-by: Xiaolong Ye --- drivers/net/fm10k/fm10k_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/fm10k/fm10k_rxtx.c b/drivers/net/fm10k/fm10k_rxtx.c index 4a5b46ec8..5c648eea7 100644 --- a/drivers/net/fm10k/fm10k_rxtx.c +++ b/drivers/net/fm10k/fm10k_rxtx.c @@ -44,7 +44,7 @@ static inline void dump_rxd(union fm10k_rx_desc *rxd) PKT_TX_TCP_SEG) #define FM10K_TX_OFFLOAD_NOTSUP_MASK \ - (PKT_TX_OFFLOAD_MASK ^ FM10K_TX_OFFLOAD_MASK) + ~(PKT_TX_OFFLOAD_MASK & FM10K_TX_OFFLOAD_MASK) /* @note: When this function is changed, make corresponding change to * fm10k_dev_supported_ptypes_get() From patchwork Sat Oct 27 10:40:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiaolong Ye X-Patchwork-Id: 47528 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 416D956A3; Sat, 27 Oct 2018 12:41:25 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id E51604CA7; Sat, 27 Oct 2018 12:41:08 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Oct 2018 03:41:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,431,1534834800"; d="scan'208";a="81343943" Received: from yexl-server.sh.intel.com ([10.67.110.207]) by fmsmga007.fm.intel.com with ESMTP; 27 Oct 2018 03:41:05 -0700 From: Xiaolong Ye To: Qi Zhang , Beilei Xing Cc: dev@dpdk.org, stable@dpdk.org, Xiaolong Ye , harish.patil@qlogic.com Date: Sat, 27 Oct 2018 18:40:30 +0800 Message-Id: <20181027104032.10251-7-xiaolong.ye@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181027104032.10251-1-xiaolong.ye@intel.com> References: <20181027104032.10251-1-xiaolong.ye@intel.com> Subject: [dpdk-dev] [PATCH 6/8] net/qede: correct offload not supported mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Previously XXX_TX_OFFLOAD_NOTSUP_MASK is obtained via xor which would lead to unexpected result, correct it by using a NOT-AND operation. Fixes: 29540be7efce ("net/qede: support LRO/TSO offloads") Cc: harish.patil@qlogic.com Cc: stable@dpdk.org Signed-off-by: Xiaolong Ye --- drivers/net/qede/qede_rxtx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/qede/qede_rxtx.h b/drivers/net/qede/qede_rxtx.h index d3a41e92e..9da059564 100644 --- a/drivers/net/qede/qede_rxtx.h +++ b/drivers/net/qede/qede_rxtx.h @@ -159,7 +159,7 @@ PKT_TX_TUNNEL_GRE) #define QEDE_TX_OFFLOAD_NOTSUP_MASK \ - (PKT_TX_OFFLOAD_MASK ^ QEDE_TX_OFFLOAD_MASK) + ~(PKT_TX_OFFLOAD_MASK & QEDE_TX_OFFLOAD_MASK) /* * RX BD descriptor ring From patchwork Sat Oct 27 10:40:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiaolong Ye X-Patchwork-Id: 47529 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A459F5B3E; Sat, 27 Oct 2018 12:41:27 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 5544110A3; Sat, 27 Oct 2018 12:41:09 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Oct 2018 03:41:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,431,1534834800"; d="scan'208";a="81343952" Received: from yexl-server.sh.intel.com ([10.67.110.207]) by fmsmga007.fm.intel.com with ESMTP; 27 Oct 2018 03:41:07 -0700 From: Xiaolong Ye To: Qi Zhang , Beilei Xing Cc: dev@dpdk.org, stable@dpdk.org, Xiaolong Ye , konstantin.ananyev@intel.com Date: Sat, 27 Oct 2018 18:40:31 +0800 Message-Id: <20181027104032.10251-8-xiaolong.ye@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181027104032.10251-1-xiaolong.ye@intel.com> References: <20181027104032.10251-1-xiaolong.ye@intel.com> Subject: [dpdk-dev] [PATCH 7/8] net/vmxnet3: correct offload not supported mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Previously XXX_TX_OFFLOAD_NOTSUP_MASK is obtained via xor which would lead to unexpected result, correct it by using a NOT-AND operation. Fixes: baf3bbae5556 ("net/vmxnet3: add Tx preparation") Cc: konstantin.ananyev@intel.com Cc: stable@dpdk.org Signed-off-by: Xiaolong Ye --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c index cf85f3d61..ab3505886 100644 --- a/drivers/net/vmxnet3/vmxnet3_rxtx.c +++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c @@ -54,7 +54,7 @@ PKT_TX_TCP_SEG) #define VMXNET3_TX_OFFLOAD_NOTSUP_MASK \ - (PKT_TX_OFFLOAD_MASK ^ VMXNET3_TX_OFFLOAD_MASK) + ~(PKT_TX_OFFLOAD_MASK & VMXNET3_TX_OFFLOAD_MASK) static const uint32_t rxprod_reg[2] = {VMXNET3_REG_RXPROD, VMXNET3_REG_RXPROD2}; From patchwork Sat Oct 27 10:40:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiaolong Ye X-Patchwork-Id: 47530 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 12E785F12; Sat, 27 Oct 2018 12:41:30 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 66D424CA5; Sat, 27 Oct 2018 12:41:11 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Oct 2018 03:41:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,431,1534834800"; d="scan'208";a="81343962" Received: from yexl-server.sh.intel.com ([10.67.110.207]) by fmsmga007.fm.intel.com with ESMTP; 27 Oct 2018 03:41:09 -0700 From: Xiaolong Ye To: Qi Zhang , Beilei Xing Cc: dev@dpdk.org, stable@dpdk.org, Xiaolong Ye , tomaszx.kulasek@intel.com Date: Sat, 27 Oct 2018 18:40:32 +0800 Message-Id: <20181027104032.10251-9-xiaolong.ye@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181027104032.10251-1-xiaolong.ye@intel.com> References: <20181027104032.10251-1-xiaolong.ye@intel.com> Subject: [dpdk-dev] [PATCH 8/8] net/e1000: correct offload not supported mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Previously XXX_TX_OFFLOAD_NOTSUP_MASK is obtained via xor which would lead to unexpected result, correct it by using a NOT-AND operation. Fixes: 2b76648872c9 ("net/e1000: add Tx preparation") Cc: tomaszx.kulasek@intel.com Cc: stable@dpdk.org Signed-off-by: Xiaolong Ye --- drivers/net/e1000/em_rxtx.c | 2 +- drivers/net/e1000/igb_rxtx.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/e1000/em_rxtx.c b/drivers/net/e1000/em_rxtx.c index a9cd76518..c3fd2cd6e 100644 --- a/drivers/net/e1000/em_rxtx.c +++ b/drivers/net/e1000/em_rxtx.c @@ -55,7 +55,7 @@ PKT_TX_VLAN_PKT) #define E1000_TX_OFFLOAD_NOTSUP_MASK \ - (PKT_TX_OFFLOAD_MASK ^ E1000_TX_OFFLOAD_MASK) + ~(PKT_TX_OFFLOAD_MASK & E1000_TX_OFFLOAD_MASK) /** * Structure associated with each descriptor of the RX ring of a RX queue. diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c index 25ff5f68f..055dff102 100644 --- a/drivers/net/e1000/igb_rxtx.c +++ b/drivers/net/e1000/igb_rxtx.c @@ -57,7 +57,7 @@ IGB_TX_IEEE1588_TMST) #define IGB_TX_OFFLOAD_NOTSUP_MASK \ - (PKT_TX_OFFLOAD_MASK ^ IGB_TX_OFFLOAD_MASK) + ~(PKT_TX_OFFLOAD_MASK & IGB_TX_OFFLOAD_MASK) /** * Structure associated with each descriptor of the RX ring of a RX queue.